linux-next: build warning after merge of the devicetree tree

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

Hi Rob,

After merging the devicetree tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@3/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb90000/ports/port@0/endpoint' is not bidirectional
drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@1/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb90000/ports/port@0/endpoint' is not bidirectional
drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@2/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb94000/ports/port@0/endpoint' is not bidirectional

and over 2000 more :-(

Presumably introduced by commit

  0698fc8b542f ("scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc")

but not suppressed by commit

  b63caea4b5b5 ("kbuild: disable new dtc graph and unit-address warnings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Rob Herring]

On Wed, May 9, 2018 at 1:04 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rob,
>
> After merging the devicetree tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@3/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb90000/ports/port@0/endpoint' is not bidirectional
> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@1/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb90000/ports/port@0/endpoint' is not bidirectional
> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb: Warning (graph_endpoint): /fragment@1/__overlay__/port@2/endpoint: graph connection to node '/fragment@0/__overlay__/lvds@feb94000/ports/port@0/endpoint' is not bidirectional

I forgot about this one hiding in the tree.

> and over 2000 more :-(

I assume you mean on other files. I've already sent out patches for
arm and arm64 dts files.

Rob

Re: linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

Hi Rob,

On Wed, 9 May 2018 07:17:06 -0500 Rob Herring <robherring2@gmail.com> wrote:
>
> > and over 2000 more :-(  
> 
> I assume you mean on other files. I've already sent out patches for
> arm and arm64 dts files.

Yeah, we appear to be just down to this now:

arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dtb: Warning (graph_endpoint): /soc/mdp@5100000/ports/port@3/endpoint: graph connection to node '/soc/hdmi-tx@4a00000/ports/port@0/endpoint' is not bidirectional
arch/arm/boot/dts/rk3288-evb-act8846.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-evb-rk808.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-veyron-jaq.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-veyron-jerry.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-veyron-minnie.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-veyron-pinky.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"
arch/arm/boot/dts/rk3288-veyron-speedy.dtb: Warning (graph_endpoint): /dp@ff970000/ports/port@1/endpoint: graph node unit address error, expected "0"

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

After merging the devicetree tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '

Introduced by commit

  39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

Hi all,

After merging the devicetree tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/of/unittest-data/tests-phandle.dtsi:11.18-22: Warning (node_name_vs_property_name): /testcase-data/duplicate-name: node name and property name conflict
drivers/of/unittest-data/tests-phandle.dtsi:11.18-22: Warning (node_name_vs_property_name): /testcase-data/duplicate-name: node name and property name conflict

Presumably exposed by commit

  e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Rob Herring]

On Thu, Sep 2, 2021 at 5:34 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Rob,
>
> On Tue, 24 Aug 2021 07:35:37 -0500 Rob Herring <robherring2@gmail.com> wrote:
> >
> > On Mon, Aug 23, 2021 at 10:18 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the devicetree tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
> > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
> > >
> > > Presumably exposed by commit
> > >
> > >   1ee7943c3343 ("kbuild: Enable dtc 'pci_device_reg' warning by default")
> >
> > Yep, that's expected. There's a couple on arm64 builds too.
>
> These warnings are now in Linus' tree :-(

There's some pending patches for them now[1]. The SoC tree needs to
pick them up.

Rob

[1] https://lore.kernel.org/all/20210831125843.1233488-1-nsaenzju@redhat.com/

Re: linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

Hi Rob,

On Tue, 24 Aug 2021 07:35:37 -0500 Rob Herring <robherring2@gmail.com> wrote:
>
> On Mon, Aug 23, 2021 at 10:18 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the devicetree tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
> > arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
> >
> > Presumably exposed by commit
> >
> >   1ee7943c3343 ("kbuild: Enable dtc 'pci_device_reg' warning by default")  
> 
> Yep, that's expected. There's a couple on arm64 builds too.

These warnings are now in Linus' tree :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Rob Herring]

On Mon, Aug 23, 2021 at 10:18 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the devicetree tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
>
> Presumably exposed by commit
>
>   1ee7943c3343 ("kbuild: Enable dtc 'pci_device_reg' warning by default")

Yep, that's expected. There's a couple on arm64 builds too.

Rob

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi all,

After merging the devicetree tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"
arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format error, expected "0,0"

Presumably exposed by commit

  1ee7943c3343 ("kbuild: Enable dtc 'pci_device_reg' warning by default")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

Hi Rob,

On Mon, 5 Mar 2018 20:34:46 -0600 Rob Herring <robherring2@gmail.com> wrote:
>
> Yes. I've sent out patches for all these. Waiting for various
> maintainers to pick them up.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Rob Herring]

On Mon, Mar 5, 2018 at 7:05 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rob,
>
> After merging the devicetree tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/imx51-digi-connectcore-jsk.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6dl-phytec-pbab01.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/vf610m4-colibri.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi@ff980000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih418-b2199.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
>
> Presumably introduced by commit
>
>   c0e8e5234671 ("scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987")

Yes. I've sent out patches for all these. Waiting for various
maintainers to pick them up.

Rob

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3454 bytes --]

Hi Rob,

After merging the devicetree tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

arch/arm/boot/dts/imx51-digi-connectcore-jsk.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6dl-phytec-pbab01.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/vf610m4-colibri.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi@ff980000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/stih410-b2120.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/stih410-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/stih407-b2120.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/stih407-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/stih410-b2260.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead
arch/arm/boot/dts/stih410-b2260.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/stih418-b2199.dtb: Warning (chosen_node_stdout_path): /chosen:linux,stdout-path: Use 'stdout-path' instead

Presumably introduced by commit

  c0e8e5234671 ("scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987")

or

  f26e93812a4f ("scripts: re-enable some now fixed dtc warnings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Hi Rob,

After merging the devicetree tree, today's linux-next build
(powerpc_ppc64_defconfig) produced this warning:

arch/powerpc/boot/fdt_ro.c: In function 'fdt_get_name':
arch/powerpc/boot/fdt_ro.c:253:10: warning: implicit declaration of function 'strrchr'; did you mean 'strchr'? [-Wimplicit-function-declaration]
   leaf = strrchr(nameptr, '/');
          ^~~~~~~
          strchr
arch/powerpc/boot/fdt_ro.c:253:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
   leaf = strrchr(nameptr, '/');
        ^

Introduced by commit

  c0e8e5234671 ("scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987")

I presume that commit

  d308701979aa ("powerpc: boot: add strrchr function")

was meant to address this, but it seems that it has no completely.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

Hi Rob,

On Wed, 3 May 2017 07:12:27 -0500 Rob Herring <robherring2@gmail.com> wrote:
>
> Sorry, forgot to push out the fix. Now done.

Thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the devicetree tree

[Rob Herring]

On Wed, May 3, 2017 at 12:44 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rob,
>
> On Fri, 28 Apr 2017 12:45:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the devicetree tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/of/unittest.c: In function 'of_unittest':
>> drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    last_sibling->sibling = overlay_base_root->child;
>>                          ^
>> drivers/of/unittest.c:2122:22: note: 'last_sibling' was declared here
>>   struct device_node *last_sibling;
>>                       ^
>>
>> Introduced by commit
>>
>>   81d0848fc8d2 ("of: Add unit tests for applying overlays")
>
> Ping?

Sorry, forgot to push out the fix. Now done.

Rob

Re: linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

Hi Rob,

On Fri, 28 Apr 2017 12:45:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the devicetree tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/of/unittest.c: In function 'of_unittest':
> drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    last_sibling->sibling = overlay_base_root->child;
>                          ^
> drivers/of/unittest.c:2122:22: note: 'last_sibling' was declared here
>   struct device_node *last_sibling;
>                       ^
> 
> Introduced by commit
> 
>   81d0848fc8d2 ("of: Add unit tests for applying overlays")

Ping?
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

Hi Rob,

After merging the devicetree tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/of/unittest.c: In function 'of_unittest':
drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used uninitialized in this function [-Wmaybe-uninitialized]
   last_sibling->sibling = overlay_base_root->child;
                         ^
drivers/of/unittest.c:2122:22: note: 'last_sibling' was declared here
  struct device_node *last_sibling;
                      ^

Introduced by commit

  81d0848fc8d2 ("of: Add unit tests for applying overlays")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the devicetree tree

[Grant Likely]

On Thu, Oct 21, 2010 at 10:05:26AM +0200, Ingo Molnar wrote:
> > On Thu, Oct 21, 2010 at 01:37:26PM +1100, Stephen Rothwell wrote:
> > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> > index 4417f49..23216f7 100644
> > --- a/arch/x86/kernel/irq.c
> > +++ b/arch/x86/kernel/irq.c
> > @@ -276,12 +276,14 @@ void smp_x86_platform_ipi(struct pt_regs *regs)
> >  
> >  EXPORT_SYMBOL_GPL(vector_used_by_percpu_irq);
> >  
> > +#ifdef CONFIG_OF
> >  unsigned int irq_create_of_mapping(struct device_node *controller,
> >                 const u32 *intspec, unsigned int intsize)
> >  {
> >         return intspec[0];
> >  }
> >  EXPORT_SYMBOL_GPL(irq_create_of_mapping);
> > +#endif
> 
> Sigh, 'of' is the most misnamed Linux subsystem in history! 'CONFIG_OF_' always 
> makes me ask 'config of what?' irq_create_of_mapping ditto.
> 
> Why not OFW or OPENFIRMWARE?

That's not the half of it.  Most of the new platforms using this code
don't have openfirmware either.  This subsystem merely supports the
device tree data structure which originated with OpenFirmware, but has
been used heavily in non-ofw systems for many years now.  Something
like dt_* would be more accurate.

The of_ prefixes are entirely historical.  Off and on I consider doing
a mass rename, but I shy away from the scope of the work (plus nobody
has complained loud enough to make it a priority).  If I were to do
such a thing it would probably be best to use a script to handle all
the renames, and I'd want to organize with Linus to get it committed
when it will have the least impact on everyone.  Probably
immediately after a merge window closes.

BTW, I'm actually dropping the patch that added this function to x86
for this merge window since the patch that uses it isn't quite ready
yet.  It will sit in my test tree for another cycle.

g.

Re: linux-next: build warning after merge of the devicetree tree

[Ingo Molnar]

* Grant Likely <grant.likely@secretlab.ca> wrote:

> On Thu, Oct 21, 2010 at 01:37:26PM +1100, Stephen Rothwell wrote:
> > Hi Grant,
> > 
> > After merging the devicetree tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > arch/x86/kernel/irq.c:280: warning: 'struct device_node' declared inside parameter list
> > 
> > Introduced by commit 27f4e2b1060be8bc38146fd30986e7c2858e2a5f ("x86/of:
> > define irq functions to allow drivers/of/* to build on x86").  This build
> > has CONFIG_OF not set.
> 
> Thanks Stephen.  Does the following patch fix things?
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 4417f49..23216f7 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -276,12 +276,14 @@ void smp_x86_platform_ipi(struct pt_regs *regs)
>  
>  EXPORT_SYMBOL_GPL(vector_used_by_percpu_irq);
>  
> +#ifdef CONFIG_OF
>  unsigned int irq_create_of_mapping(struct device_node *controller,
>                 const u32 *intspec, unsigned int intsize)
>  {
>         return intspec[0];
>  }
>  EXPORT_SYMBOL_GPL(irq_create_of_mapping);
> +#endif

Sigh, 'of' is the most misnamed Linux subsystem in history! 'CONFIG_OF_' always 
makes me ask 'config of what?' irq_create_of_mapping ditto.

Why not OFW or OPENFIRMWARE?

Thanks,

	Ingo

Re: linux-next: build warning after merge of the devicetree tree

[Grant Likely]

On Thu, Oct 21, 2010 at 01:37:26PM +1100, Stephen Rothwell wrote:
> Hi Grant,
> 
> After merging the devicetree tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> arch/x86/kernel/irq.c:280: warning: 'struct device_node' declared inside parameter list
> 
> Introduced by commit 27f4e2b1060be8bc38146fd30986e7c2858e2a5f ("x86/of:
> define irq functions to allow drivers/of/* to build on x86").  This build
> has CONFIG_OF not set.

Thanks Stephen.  Does the following patch fix things?

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 4417f49..23216f7 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -276,12 +276,14 @@ void smp_x86_platform_ipi(struct pt_regs *regs)
 
 EXPORT_SYMBOL_GPL(vector_used_by_percpu_irq);
 
+#ifdef CONFIG_OF
 unsigned int irq_create_of_mapping(struct device_node *controller,
                const u32 *intspec, unsigned int intsize)
 {
        return intspec[0];
 }
 EXPORT_SYMBOL_GPL(irq_create_of_mapping);
+#endif
 
 #ifdef CONFIG_HOTPLUG_CPU
 /* A cpu has been removed from cpu_online_mask.  Reset irq affinities. */

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi Grant,

After merging the devicetree tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

arch/x86/kernel/irq.c:280: warning: 'struct device_node' declared inside parameter list

Introduced by commit 27f4e2b1060be8bc38146fd30986e7c2858e2a5f ("x86/of:
define irq functions to allow drivers/of/* to build on x86").  This build
has CONFIG_OF not set.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the devicetree tree

[Grant Likely]

On Thu, Jul 29, 2010 at 10:54 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Grant,
>
> After merging the devicetree tree, today's linux-next build (powerpc64
> allnoconfig) produced this warning:
>
> drivers/of/irq.c: In function 'of_irq_map_raw':
> drivers/of/irq.c:102: warning: cast from pointer to integer of different size
>
> Introduced by commit 7d12c3ee9e1843b1d19d9c308988bb163fb9aa0b ("of/irq:
> Fix endian issues in parsing interrupt specifiers").

Thanks.  fixed now and pushed out.  Silly typo.

g.

linux-next: build warning after merge of the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi Grant,

After merging the devicetree tree, today's linux-next build (powerpc64
allnoconfig) produced this warning:

drivers/of/irq.c: In function 'of_irq_map_raw':
drivers/of/irq.c:102: warning: cast from pointer to integer of different size

Introduced by commit 7d12c3ee9e1843b1d19d9c308988bb163fb9aa0b ("of/irq:
Fix endian issues in parsing interrupt specifiers").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]