linux-next: build warnings after merge of the gpio tree

linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

Hi Linus,

After merging the gpio tree, yesterday's linux-next build (arm
multi_v7_defconfig) produced these warnings:

arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000

and many, many more.

I have no idea what caused this.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

Hi Linus,

On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the gpio tree, yesterday's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
> 
> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
> 
> and many, many more.
> 
> I have no idea what caused this.

I am still getting lots of these ...
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the gpio tree

[Linus Walleij]

On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the gpio tree, yesterday's linux-next build (arm
>> multi_v7_defconfig) produced these warnings:
>>
>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
>>
>> and many, many more.
>>
>> I have no idea what caused this.
>
> I am still getting lots of these ...

I have absolutely no clue either.

What I know is that there is a device tree compiler warning that can
be turned on, and
it generates these warnings a lot. The actual problems have been in
the DTS files
forever. They just recently started to look into them.

It has nothing to do with the GPIO tree whatsoever, so I wonder if it
is a side effect of
something else?

Yours,
Linus Walleij

Re: linux-next: build warnings after merge of the gpio tree

[Rob Herring]

On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> After merging the gpio tree, yesterday's linux-next build (arm
>>> multi_v7_defconfig) produced these warnings:
>>>
>>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
>>>
>>> and many, many more.
>>>
>>> I have no idea what caused this.
>>
>> I am still getting lots of these ...
>
> I have absolutely no clue either.
>
> What I know is that there is a device tree compiler warning that can
> be turned on, and
> it generates these warnings a lot. The actual problems have been in
> the DTS files
> forever. They just recently started to look into them.
>
> It has nothing to do with the GPIO tree whatsoever, so I wonder if it
> is a side effect of
> something else?

There's a dtc update in -next which adds these new checks. It's been
there for over a month now. Unlike other dtc checks, these are
generally actual errors, so they are not off by default (enabled with
W=1,2).

In reality, there's only about 50-100 warnings. The way dts includes
are structured and because the dtc checks don't have the original
source file lines, it just multiplies the warnings.

Rob

Re: linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

Hi all,

On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> >> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> >>>
> >>> After merging the gpio tree, yesterday's linux-next build (arm
> >>> multi_v7_defconfig) produced these warnings:
> >>>
> >>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
> >>>
> >>> and many, many more.
> >>>
> >>> I have no idea what caused this.  
> >>
> >> I am still getting lots of these ...  
> >
> > I have absolutely no clue either.
> >
> > What I know is that there is a device tree compiler warning that can
> > be turned on, and
> > it generates these warnings a lot. The actual problems have been in
> > the DTS files
> > forever. They just recently started to look into them.
> >
> > It has nothing to do with the GPIO tree whatsoever, so I wonder if it
> > is a side effect of
> > something else?  

Probably just the first tree to cause a rebuild of the dtb files after
the change below.

> There's a dtc update in -next which adds these new checks. It's been
> there for over a month now. Unlike other dtc checks, these are
> generally actual errors, so they are not off by default (enabled with
> W=1,2).
> 
> In reality, there's only about 50-100 warnings. The way dts includes
> are structured and because the dtc checks don't have the original
> source file lines, it just multiplies the warnings.

So these (many) warnings are now in Linus' tree :-(

Please do something about them.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the gpio tree

[Rob Herring]

On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring <robh@kernel.org> wrote:
>>
>> On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> > On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> >> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> >>>
>> >>> After merging the gpio tree, yesterday's linux-next build (arm
>> >>> multi_v7_defconfig) produced these warnings:
>> >>>
>> >>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
>> >>>
>> >>> and many, many more.
>> >>>
>> >>> I have no idea what caused this.
>> >>
>> >> I am still getting lots of these ...
>> >
>> > I have absolutely no clue either.
>> >
>> > What I know is that there is a device tree compiler warning that can
>> > be turned on, and
>> > it generates these warnings a lot. The actual problems have been in
>> > the DTS files
>> > forever. They just recently started to look into them.
>> >
>> > It has nothing to do with the GPIO tree whatsoever, so I wonder if it
>> > is a side effect of
>> > something else?
>
> Probably just the first tree to cause a rebuild of the dtb files after
> the change below.
>
>> There's a dtc update in -next which adds these new checks. It's been
>> there for over a month now. Unlike other dtc checks, these are
>> generally actual errors, so they are not off by default (enabled with
>> W=1,2).
>>
>> In reality, there's only about 50-100 warnings. The way dts includes
>> are structured and because the dtc checks don't have the original
>> source file lines, it just multiplies the warnings.
>
> So these (many) warnings are now in Linus' tree :-(
>
> Please do something about them.

Patches are in flight. I got all the low hanging fruit that are the
most duplicated[1]. There's other patches in flight too.

Rob

[1] https://www.spinics.net/lists/arm-kernel/msg616518.html

Re: linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

Hi Rob,

On Wed, 15 Nov 2017 17:12:00 -0600 Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > So these (many) warnings are now in Linus' tree :-(
> >
> > Please do something about them.  
> 
> Patches are in flight. I got all the low hanging fruit that are the
> most duplicated[1]. There's other patches in flight too.
> 
> Rob
> 
> [1] https://www.spinics.net/lists/arm-kernel/msg616518.html

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

Hi Rob,

On Wed, 15 Nov 2017 17:12:00 -0600 Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring <robh@kernel.org> wrote:  
> >>
> >> On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij <linus.walleij@linaro.org> wrote:  
> >> > On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> >> >> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> >> >>>
> >> >>> After merging the gpio tree, yesterday's linux-next build (arm
> >> >>> multi_v7_defconfig) produced these warnings:
> >> >>>
> >> >>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
> >> >>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
> >> >>>
> >> >>> and many, many more.
> >> >>>
> >> >>> I have no idea what caused this.  
> >> >>
> >> >> I am still getting lots of these ...  
> >> >
> >> > I have absolutely no clue either.
> >> >
> >> > What I know is that there is a device tree compiler warning that can
> >> > be turned on, and
> >> > it generates these warnings a lot. The actual problems have been in
> >> > the DTS files
> >> > forever. They just recently started to look into them.
> >> >
> >> > It has nothing to do with the GPIO tree whatsoever, so I wonder if it
> >> > is a side effect of
> >> > something else?  
> >
> > Probably just the first tree to cause a rebuild of the dtb files after
> > the change below.
> >  
> >> There's a dtc update in -next which adds these new checks. It's been
> >> there for over a month now. Unlike other dtc checks, these are
> >> generally actual errors, so they are not off by default (enabled with
> >> W=1,2).
> >>
> >> In reality, there's only about 50-100 warnings. The way dts includes
> >> are structured and because the dtc checks don't have the original
> >> source file lines, it just multiplies the warnings.  
> >
> > So these (many) warnings are now in Linus' tree :-(
> >
> > Please do something about them.  
> 
> Patches are in flight. I got all the low hanging fruit that are the
> most duplicated[1]. There's other patches in flight too.
> 
> Rob
> 
> [1] https://www.spinics.net/lists/arm-kernel/msg616518.html

How are these going?  I am still getting over 500 lines of output in my
arm multi_v7_defconfig builds of Linus' tree :-(

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the gpio tree

[Rob Herring]

On Tue, Dec 5, 2017 at 4:48 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rob,
>
> On Wed, 15 Nov 2017 17:12:00 -0600 Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, Nov 15, 2017 at 4:42 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > Hi all,
>> >
>> > On Thu, 9 Nov 2017 08:37:00 -0600 Rob Herring <robh@kernel.org> wrote:
>> >>
>> >> On Thu, Nov 9, 2017 at 1:42 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> >> > On Thu, Nov 9, 2017 at 4:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> >> >> On Fri, 3 Nov 2017 16:37:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> >> >>>
>> >> >>> After merging the gpio tree, yesterday's linux-next build (arm
>> >> >>> multi_v7_defconfig) produced these warnings:
>> >> >>>
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-a.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-b-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-a-plus.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2836-rpi-2-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2837-rpi-3-b.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-zero.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/bcm2835-rpi-zero-w.dtb: Warning (phys_property): Missing property '#phy-cells' in node /phy or bad phandle (referred from /soc/usb@7e980000:phys[0])
>> >> >>> arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/system-controller@10040000
>> >> >>>
>> >> >>> and many, many more.
>> >> >>>
>> >> >>> I have no idea what caused this.
>> >> >>
>> >> >> I am still getting lots of these ...
>> >> >
>> >> > I have absolutely no clue either.
>> >> >
>> >> > What I know is that there is a device tree compiler warning that can
>> >> > be turned on, and
>> >> > it generates these warnings a lot. The actual problems have been in
>> >> > the DTS files
>> >> > forever. They just recently started to look into them.
>> >> >
>> >> > It has nothing to do with the GPIO tree whatsoever, so I wonder if it
>> >> > is a side effect of
>> >> > something else?
>> >
>> > Probably just the first tree to cause a rebuild of the dtb files after
>> > the change below.
>> >
>> >> There's a dtc update in -next which adds these new checks. It's been
>> >> there for over a month now. Unlike other dtc checks, these are
>> >> generally actual errors, so they are not off by default (enabled with
>> >> W=1,2).
>> >>
>> >> In reality, there's only about 50-100 warnings. The way dts includes
>> >> are structured and because the dtc checks don't have the original
>> >> source file lines, it just multiplies the warnings.
>> >
>> > So these (many) warnings are now in Linus' tree :-(
>> >
>> > Please do something about them.
>>
>> Patches are in flight. I got all the low hanging fruit that are the
>> most duplicated[1]. There's other patches in flight too.
>>
>> Rob
>>
>> [1] https://www.spinics.net/lists/arm-kernel/msg616518.html
>
> How are these going?  I am still getting over 500 lines of output in my
> arm multi_v7_defconfig builds of Linus' tree :-(

Well, there's these five in -next that I guess haven't been sent to Linus yet:

912d7985f3ce ARM: dts: rockchip: fix rk3288 iep-IOMMU interrupts property cells
44e5dced2ef6 arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv
d53418dfe997 ARM: dts: imx: Add missing #phy-cells to usb-nop-xceiv
f0e11ff8ff65 ARM: dts: am33xx: Add missing #phy-cells to ti,am335x-usb-phy
f568f6f554b8 ARM: dts: omap: Add missing #phy-cells to usb-nop-xceiv

These 2 aren't in -next and seem to have been missed:

arm: dts: qcom: fix missing #phy-cells for apq8064
arm: dts: nspire: Add missing #phy-cells to usb-nop-xceiv

Arnd, Olof, can you pick these up?

Rob

Re: linux-next: build warnings after merge of the gpio tree

[Arnd Bergmann]

On Wed, Dec 6, 2017 at 9:51 PM, Rob Herring <robh@kernel.org> wrote:
> On Tue, Dec 5, 2017 at 4:48 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> These 2 aren't in -next and seem to have been missed:
>
> arm: dts: qcom: fix missing #phy-cells for apq8064

Apparently this is a subsect of 3191b5b332f8 ("ARM: dts: qcom-apq8064: Fix dsi
and hdmi phy cells"), which we already have

> arm: dts: nspire: Add missing #phy-cells to usb-nop-xceiv

Picked this one up now.

       Arnd

Re: linux-next: build warnings after merge of the gpio tree

[Linus Walleij]

On Wed, Jul 23, 2014 at 10:45 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (powerpc
> allyesconfig) produced these warnings:
>
> drivers/gpio/gpio-ucb1400.c: In function 'ucb1400_gpio_remove':
> drivers/gpio/gpio-ucb1400.c:92:2: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result [-Wunused-result]
>   gpiochip_remove(&ucb->gc);
>   ^
>
> And lots of similar ones.
>
> Introduced by commit 9f5132ae82fd ("gpio: remove all usage of
> gpio_remove retval in driver/gpio").

Yes we're planning to get rid of the retval in the next merge window after first
purging all drivers.

> Maybe the __must_check attribute should be removed from the declaration
> of the function before removing the retval checking ...

Hey, good idea. I'll do this.

Yours,
Linus Walleij

linux-next: build warnings after merge of the gpio tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
allyesconfig) produced these warnings:

drivers/gpio/gpio-ucb1400.c: In function 'ucb1400_gpio_remove':
drivers/gpio/gpio-ucb1400.c:92:2: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result [-Wunused-result]
  gpiochip_remove(&ucb->gc);
  ^

And lots of similar ones.

Introduced by commit 9f5132ae82fd ("gpio: remove all usage of
gpio_remove retval in driver/gpio").

Maybe the __must_check attribute should be removed from the declaration
of the function before removing the retval checking ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]