Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the devicetree-fixes tree
@ 2021-04-07 11:28 Stephen Rothwell
  2021-04-07 23:24 ` Frank.Rowand
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-04-07 11:28 UTC (permalink / raw)
  To: Rob Herring
  Cc: Frank Rowand, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi all,

In commit

  f2ce9e97cf07 ("of: properly check for error returned by fdt_get_name()")

Fixes tag

  Fixes: commit 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: linux-next: Fixes tag needs some work in the devicetree-fixes tree
  2021-04-07 11:28 linux-next: Fixes tag needs some work in the devicetree-fixes tree Stephen Rothwell
@ 2021-04-07 23:24 ` Frank.Rowand
  2021-04-08  1:50   ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Frank.Rowand @ 2021-04-07 23:24 UTC (permalink / raw)
  To: sfr, robherring2; +Cc: linux-kernel, linux-next, frowand.list

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Wednesday, April 7, 2021 6:28 AM
> 
> Hi all,
> 
> In commit
> 
>   f2ce9e97cf07 ("of: properly check for error returned by fdt_get_name()")
> 
> Fixes tag
> 
>   Fixes: commit 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Sorry about that, checkpatch wanted "commit" in some other context and
I got carried away and also added it to the Fixes tag.

-Frank

> 
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the devicetree-fixes tree
  2021-04-07 23:24 ` Frank.Rowand
@ 2021-04-08  1:50   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-04-08  1:50 UTC (permalink / raw)
  To: Frank Rowand, Stephen Rothwell; +Cc: linux-kernel, linux-next, Frank Rowand

On Wed, Apr 7, 2021 at 6:24 PM <Frank.Rowand@sony.com> wrote:
>
> > -----Original Message-----
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Sent: Wednesday, April 7, 2021 6:28 AM
> >
> > Hi all,
> >
> > In commit
> >
> >   f2ce9e97cf07 ("of: properly check for error returned by fdt_get_name()")
> >
> > Fixes tag
> >
> >   Fixes: commit 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
> >
> > has these problem(s):
> >
> >   - leading word 'commit' unexpected
>
> Sorry about that, checkpatch wanted "commit" in some other context and
> I got carried away and also added it to the Fixes tag.

I've fixed it up.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: Fixes tag needs some work in the devicetree-fixes tree
  2020-04-16 22:11 Stephen Rothwell
@ 2020-04-17 13:33 ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-04-17 13:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Alexandru Tachici

On Thu, Apr 16, 2020 at 5:11 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   acca9cd4a084 ("dt-bindings: iio: dac: AD5570R fix bindings errors")
>
> Fixes tag
>
>   Fixes: ea52c21268e6 ("iio: dac: ad5770r: Add AD5770R support")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> Did you mean
>
> Fixes: ea52c21268e6 ("dt-bindings: iio: dac: Add docs for AD5770R DAC")

Sigh, yes. Now fixed.

Thanks,
Rob

>
> or
>
> Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 5+ messages in thread

* linux-next: Fixes tag needs some work in the devicetree-fixes tree
@ 2020-04-16 22:11 Stephen Rothwell
  2020-04-17 13:33 ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-04-16 22:11 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Alexandru Tachici


[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi all,

In commit

  acca9cd4a084 ("dt-bindings: iio: dac: AD5570R fix bindings errors")

Fixes tag

  Fixes: ea52c21268e6 ("iio: dac: ad5770r: Add AD5770R support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: ea52c21268e6 ("dt-bindings: iio: dac: Add docs for AD5770R DAC")

or

Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 11:28 linux-next: Fixes tag needs some work in the devicetree-fixes tree Stephen Rothwell
2021-04-07 23:24 ` Frank.Rowand
2021-04-08  1:50   ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2020-04-16 22:11 Stephen Rothwell
2020-04-17 13:33 ` Rob Herring

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git