linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Tree for Mar 29
@ 2021-03-29  9:52 Stephen Rothwell
  2021-03-30 11:32 ` kernel warning percpu ref in obj_cgroup_release (was: Re: linux-next: Tree for Mar 29) Christian Borntraeger
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2021-03-29  9:52 UTC (permalink / raw)
  To: Linux Next Mailing List; +Cc: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 37354 bytes --]

Hi all,

News: there will be no linux-next release on Friday or the following
Monday.

Changes since 20210326:

The arm64 tree gained a conflict against Linus' tree.

I applied a supplied patch for clang brakage in the kbuild tree.

The net-next tree gained a conflict against the bpf tree.

The drm tree gained a conflict against Linus' tree.

The staging tree gained a conflict against the scmi tree and a semantic
conflict against the spi tree.

The rust tree gained a conflict against the kbuild tree.

The akpm-current tree lost its its build failure and gained a conflict
against the gpio-brgl tree.

Non-merge commits (relative to Linus' tree): 7289
 7213 files changed, 432170 insertions(+), 147471 deletions(-)

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" and checkout or reset to the new
master.

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log
files in the Next directory.  Between each merge, the tree was built
with a ppc64_defconfig for powerpc, an allmodconfig for x86_64, a
multi_v7_defconfig for arm and a native build of tools/perf. After
the final fixups (if any), I do an x86_64 modules_install followed by
builds for x86_64 allnoconfig, powerpc allnoconfig (32 and 64 bit),
ppc44x_defconfig, allyesconfig and pseries_le_defconfig and i386, sparc
and sparc64 defconfig and htmldocs. And finally, a simple boot test
of the powerpc pseries_le_defconfig kernel in qemu (with and without
kvm enabled).

Below is a summary of the state of the merge.

I am currently merging 335 trees (counting Linus' and 87 trees of bug
fix patches pending for the current merge release).

Stats about the size of the tree over time can be seen at
http://neuling.org/linux-next-size.html .

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Randy Dunlap for doing many randconfig builds.  And to Paul
Gortmaker for triage and bug fixes.

-- 
Cheers,
Stephen Rothwell

$ git checkout master
$ git reset --hard stable
Merging origin/master (f9e2bb42cf0d Merge tag 'perf-tools-fixes-for-v5.12-2020-03-28' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux)
Merging fixes/fixes (e71ba9452f0b Linux 5.11-rc2)
Merging kbuild-current/fixes (bcbcf50f5218 kbuild: fix ld-version.sh to not be affected by locale)
Merging arc-current/for-curr (83520d62cc5a ARC: treewide: avoid the pointer addition with NULL pointer)
Merging arm-current/fixes (30e3b4f256b4 ARM: footbridge: fix PCI interrupt mapping)
Merging arm64-fixes/for-next/fixes (20109a859a9b arm64: kernel: disable CNP on Carmel)
Merging arm-soc-fixes/arm/fixes (67335b8d28cd Merge tag 'imx-fixes-5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes)
Merging drivers-memory-fixes/fixes (a38fd8748464 Linux 5.12-rc2)
Merging m68k-current/for-linus (a65a802aadba m68k: Fix virt_addr_valid() W=1 compiler warnings)
Merging powerpc-fixes/fixes (274cb1ca2e7c powerpc/pseries/mobility: handle premature return from H_JOIN)
Merging s390-fixes/fixes (84d572e634e2 MAINTAINERS: add backups for s390 vfio drivers)
Merging sparc/master (05a59d79793d Merge git://git.kernel.org:/pub/scm/linux/kernel/git/netdev/net)
Merging fscrypt-current/for-stable (d19d8d345eec fscrypt: fix inline encryption not used on new files)
Merging net/master (75887e881b19 Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue)
Merging bpf/master (861de02e5f3f bpf: Take module reference for trampoline in module)
Merging ipsec/master (b1e3a5607034 xfrm: Fix NULL pointer dereference on policy lookup)
CONFLICT (content): Merge conflict in net/ipv6/ip6_vti.c
CONFLICT (content): Merge conflict in net/ipv4/ip_vti.c
Merging netfilter/master (75887e881b19 Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue)
Merging ipvs/master (b58f33d49e42 netfilter: ctnetlink: fix dump of the expect mask attribute)
Merging wireless-drivers/master (bd83a2fc05ed brcmfmac: p2p: Fix recently introduced deadlock issue)
Merging mac80211/master (6f235a69e594 ch_ktls: fix enum-conversion warning)
Merging rdma-fixes/for-rc (3408be145a5d RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server)
Merging sound-current/for-linus (e54f30befa79 ALSA: hda/realtek: call alc_update_headset_mode() in hp_automute_hook)
Merging sound-asoc-fixes/for-linus (983b899a1f62 Merge remote-tracking branch 'asoc/for-5.12' into asoc-linus)
Merging regmap-fixes/for-linus (f29fd6d5a08d Merge remote-tracking branch 'regmap/for-5.12' into regmap-linus)
Merging regulator-fixes/for-linus (1676953644ed Merge remote-tracking branch 'regulator/for-5.12' into regulator-linus)
Merging spi-fixes/for-linus (b4ee593e2331 Merge remote-tracking branch 'spi/for-5.12' into spi-linus)
Merging pci-current/for-linus (cf673bd0cc97 PCI: switchtec: Fix Spectre v1 vulnerability)
Merging driver-core.current/driver-core-linus (f0acf637d60f driver core: clear deferred probe reason on probe retry)
Merging tty.current/tty-linus (29d96eb26134 soc: qcom-geni-se: Cleanup the code to remove proxy votes)
Merging usb.current/usb-linus (93f672804bf2 usb: dwc2: Prevent core suspend when port connection flag is 0)
Merging usb-gadget-fixes/fixes (a38fd8748464 Linux 5.12-rc2)
Merging usb-serial-fixes/usb-linus (1e28eed17697 Linux 5.12-rc3)
Merging usb-chipidea-fixes/for-usb-fixes (cf97d7af2468 usb: cdnsp: Fixes issue with dequeuing requests after disabling endpoint)
Merging phy/fixes (da848f9a0e13 phy: qcom-qmp: add hbr3_hbr2 voltage and premphasis swing table)
Merging staging.current/staging-linus (e78836ae76d2 staging: rtl8192e: Change state information from u16 to u8)
Merging char-misc.current/char-misc-linus (3756b6578709 Merge tag 'icc-5.12-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc into char-misc-linus)
Merging soundwire-fixes/fixes (fde5d7f27108 soundwire: bus: Fix device found flag correctly)
Merging thunderbolt-fixes/fixes (0d02ec6b3136 Linux 5.12-rc4)
Merging input-current/for-linus (781bab3238c2 Input: elants_i2c - fix division by zero if firmware reports zero phys size)
Merging crypto-current/master (0de9dc80625b hwrng: timeriomem - Use device-managed registration API)
Merging ide/master (6800cd8cbc6e ide-acpi: use %*ph to print small buffer)
Merging vfio-fixes/for-linus (60c988bc1541 vfio/type1: Empty batch for pfnmap pages)
Merging kselftest-fixes/fixes (a38fd8748464 Linux 5.12-rc2)
Merging modules-fixes/modules-linus (57baec7b1b04 scripts/nsdeps: make sure to pass all module source files to spatch)
Merging dmaengine-fixes/fixes (868833fbffbe dmaengine: xilinx: dpdma: Fix race condition in done IRQ)
Merging backlight-fixes/for-backlight-fixes (a38fd8748464 Linux 5.12-rc2)
Merging mtd-fixes/mtd/fixes (2fb164f0ce95 mtd: rawnand: mtk: Fix WAITRDY break condition and timeout)
Merging mfd-fixes/for-mfd-fixes (a61f4661fba4 mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources")
Merging v4l-dvb-fixes/fixes (0e37b4fa67f5 media: coda: fix macroblocks count control usage)
Merging reset-fixes/reset/fixes (b460e0a9e240 reset: intel: add unspecified HAS_IOMEM dependency)
Merging mips-fixes/mips-fixes (3f6c515d7234 MIPS: vmlinux.lds.S: Fix appended dtb not properly aligned)
Merging at91-fixes/at91-fixes (2c69c8a1736e ARM: dts: at91: sam9x60: fix mux-mask to match product's datasheet)
Merging omap-fixes/fixes (a3efe3f6d0eb ARM: OMAP2+: Fix warning for omap_init_time_of())
Merging kvm-fixes/master (9ce3746d6413 documentation/kvm: additional explanations on KVM_SET_BOOT_CPU_ID)
Merging kvms390-fixes/master (735931f9a51a MAINTAINERS: add uv.c also to KVM/s390)
Merging hwmon-fixes/hwmon (a38fd8748464 Linux 5.12-rc2)
Merging nvdimm-fixes/libnvdimm-fixes (7018c897c2f2 libnvdimm/dimm: Avoid race between probe and available_slots_show())
Merging btrfs-fixes/next-fixes (3b7ec4d1b5cb Merge branch 'misc-5.12' into next-fixes)
Merging vfs-fixes/fixes (7f6c411c9b50 hostfs: fix memory handling in follow_link())
Merging dma-mapping-fixes/for-linus (d17405d52bac dma-mapping: benchmark: fix kernel crash when dma_map_single fails)
Merging i3c-fixes/i3c/fixes (fe07bfda2fb9 Linux 5.12-rc1)
Merging drivers-x86-fixes/fixes (d1635448f110 platform/x86: intel_pmc_core: Ignore GBE LTR on Tiger Lake platforms)
Merging samsung-krzk-fixes/fixes (a38fd8748464 Linux 5.12-rc2)
Merging pinctrl-samsung-fixes/fixes (a38fd8748464 Linux 5.12-rc2)
Merging devicetree-fixes/dt/linus (8242ff9ea9f0 dt-bindings: display: mediatek,dpi: Convert to use graph schema)
Merging scsi-fixes/fixes (36fa766faa0c scsi: target: pscsi: Clean up after failure in pscsi_map_sg())
Merging drm-fixes/drm-fixes (09d78dde88ef Merge tag 'drm-msm-fixes-2021-02-25' of https://gitlab.freedesktop.org/drm/msm into drm-fixes)
Merging amdgpu-fixes/drm-fixes (2c409ba81be2 drm/radeon: fix si_enable_smc_cac() failed issue)
Merging drm-intel-fixes/for-linux-next-fixes (8840e3bd981f drm/i915: Fix the GT fence revocation runtime PM logic)
Merging mmc-fixes/fixes (f06391c45e83 mmc: cqhci: Fix random crash when remove mmc module/card)
Merging rtc-fixes/rtc-fixes (bd33335aa93d rtc: cmos: Disable irq around direct invocation of cmos_interrupt())
Merging gnss-fixes/gnss-linus (a38fd8748464 Linux 5.12-rc2)
Merging hyperv-fixes/hyperv-fixes (37df9f3fedb6 video: hyperv_fb: Fix a double free in hvfb_probe)
Merging soc-fsl-fixes/fix (2663b3388551 soc: fsl: dpio: Get the cpumask through cpumask_of(cpu))
Merging risc-v-fixes/fixes (a5406a7ff56e riscv: Correct SPARSEMEM configuration)
Merging pidfd-fixes/fixes (d3fed0da34e9 file: fix close_range() for unshare+cloexec)
Merging fpga-fixes/fixes (2e8496f31d0b firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0)
Merging spdx/spdx-linus (88fe49249c99 Merge tag 'char-misc-5.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc)
Merging gpio-brgl-fixes/gpio/for-current (6cb59afe9e5b gpiolib: Assign fwnode to parent's if no primary one provided)
Merging gpio-intel-fixes/fixes (b41ba2ec54a7 gpiolib: Read "gpio-line-names" from a firmware node)
Merging pinctrl-intel-fixes/fixes (39c1f1bd8adf pinctrl: intel: check REVID register value for device presence)
Merging erofs-fixes/fixes (9f377622a484 erofs: fix bio->bi_max_vecs behavior change)
Merging integrity-fixes/fixes (843385694721 evm: Fix a small race in init_desc())
Merging kunit-fixes/kunit-fixes (7fd53f41f771 kunit: tool: Disable PAGE_POISONING under --alltests)
Merging ubifs-fixes/fixes (78c7d49f55d8 ubifs: journal: Make sure to not dirty twice for auth nodes)
Merging memblock-fixes/fixes (17cbe03872be mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid())
Merging cel-fixes/for-rc (0d02ec6b3136 Linux 5.12-rc4)
Merging drm-misc-fixes/for-linux-next-fixes (014305d00198 drivers: gpu: drm: xen_drm_front_drm_info is declared twice)
Merging kspp-gustavo/for-next/kspp (36f9ff9e03de lib: Fix fall-through warnings for Clang)
Merging kbuild/for-next (dc4acf529044 Merge branch 'kconfig' into for-next)
Merging compiler-attributes/compiler-attributes (19c329f68089 Linux 5.11-rc4)
Merging dma-mapping/for-next (84fcfbdadbfd dma-mapping: remove a pointless empty line in dma_alloc_coherent)
Merging asm-generic/master (38489db09b10 Merge branch 'asm-generic-fixes' into asm-generic)
Merging arc/for-next (def9d2780727 Linux 5.5-rc7)
Merging arm/for-next (0ae6d1f52670 Merge branches 'fixes' and 'misc' into for-next)
Merging arm64/for-next/core (69d8d41bdb8a Merge branch 'for-next/misc' into for-next/core)
CONFLICT (content): Merge conflict in arch/arm64/include/asm/cpucaps.h
Merging arm-perf/for-next/perf (9b86b1b41e0f docs: perf: Add new description on HiSilicon uncore PMU v2)
Merging arm-soc/for-next (a57e29abb79d soc: document merges)
Merging actions/for-next (006828d706fd Merge branch 'v5.12/defconfig' into for-next)
Merging amlogic/for-next (cf4b8849e4c2 Merge branch 'v5.13/dt64' into tmp/aml-rebuild)
Merging aspeed/for-next (697dabd5d370 Merge branches 'soc-for-v5.12' and 'dt-for-v5.12' into for-next)
Merging at91/at91-next (b95bbae19954 Merge branch 'at91-fixes' into at91-next)
Merging drivers-memory/for-next (923f1fc28897 memory: tegra20: Protect debug code with a lock)
Merging imx-mxs/for-next (58b195fac435 Merge branch 'imx/defconfig' into for-next)
Merging keystone/next (9d2e21ed98a2 Merge branch 'for_5.12/drivers-soc' into next)
Merging mediatek/for-next (e6468af3b590 Merge branch 'v5.11-next/soc' into for-next)
Merging mvebu/for-next (8e03d45cb7de Merge branch 'mvebu/dt64' into mvebu/for-next)
Merging omap/for-next (159a17f5b3a9 Merge branch 'omap-for-v5.13/dt-v2' into for-next)
Merging qcom/for-next (c465fc2707c6 Merge branches 'arm64-defconfig-for-5.13', 'arm64-for-5.13' and 'drivers-for-5.13' into for-next)
Merging raspberrypi/for-next (fbdcf1d20126 ARM: dts: bcm2711: Add the CEC interrupt controller)
Merging realtek/for-next (486f29df6941 Merge branch 'v5.8/dt' into next)
Merging renesas/next (32b5d4bd9e51 Merge branch 'renesas-arm-dt-for-v5.13' into renesas-next)
Merging reset/reset/next (d4e4dffec50b reset: oxnas: replace file name with short description)
Merging rockchip/for-next (3b6c3c12b77c Merge branch 'v5.13-armsoc/dts64' into for-next)
Merging samsung-krzk/for-next (67518feb5fda Merge branch 'next/dt' into for-next)
Merging scmi/for-linux-next (17d69bed53b4 Merge branch 'for-next/scmi' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into for-linux-next)
Merging stm32/stm32-next (adc0496104b6 ARM: dts: stm32: Add Engicam i.Core STM32MP1 EDIMM2.2 Starter Kit)
Merging sunxi/sunxi/for-next (582cfdb9d206 Merge branch 'sunxi/clk-for-5.13' into sunxi/for-next)
Merging tegra/for-next (c064a4031d7f Merge branch for-5.13/arm64/dt into for-next)
Merging ti-k3/ti-k3-next (1e3d655fe7b4 Merge branch 'ti-k3-config-next' into ti-k3-next)
Merging ti-k3-new/ti-k3-next (9437499086c2 arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems)
Merging clk/clk-next (9575aeae2cd1 Merge branch 'clk-cleanup' into clk-next)
Merging clk-imx/for-next (d60fe8fa6c01 clk: imx: Fix reparenting of UARTs not associated with stdout)
Merging clk-renesas/renesas-clk (dbb397ccc6bb clk: renesas: Couple of spelling fixes)
Merging clk-samsung/for-next (44a9e78f9242 clk: samsung: Prevent potential endless loop in the PLL ops)
Merging csky/linux-next (74cdb2664477 csky: Fixup typos)
Merging h8300/h8300-next (6e5e55227c95 Merge tag 'v5.11' into h8300-next)
Merging m68k/for-next (f2e7e4bf38fd m68k: syscalls: switch to generic syscallhdr.sh)
Merging m68knommu/for-next (06c5fa9b2168 m68k: fix flatmem memory model setup)
Merging microblaze/next (bbcee72c2f7a microblaze: Fix a typo)
Merging mips/mips-next (509d36a941a3 MIPS: loongson64: fix bug when PAGE_SIZE > 16KB)
Merging nds32/next (40e0dd851e7b nds32: Fix bogus reference to <asm/procinfo.h>)
Merging nios2/for-next (7f7bc20bc41a nios2: Don't use _end for calculating min_low_pfn)
Merging openrisc/for-next (8f722f67452f openrisc: Use devicetree to determine present cpus)
Merging parisc-hd/for-next (711d090f0e02 parisc: syscalls: switch to generic syscallhdr.sh)
Merging powerpc/next (fbda79043024 Merge tag 'powerpc-5.12-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux)
Merging fsl/next (a76bea0287ce powerpc/kmcent2: add ranges to the pci bridges)
Merging soc-fsl/next (e95f287deed2 soc: fsl: handle RCPM errata A-008646 on SoC LS1021A)
Merging risc-v/for-next (06c7c914de26 RISC-V: enable XIP)
Merging s390/for-next (e10e71c5f1e3 Merge branch 'features' into for-next)
Merging sh/for-next (2882b7626f49 sh: kernel: traps: remove unused variable)
Merging sparc-next/master (dd0d718152e4 Merge tag 'spi-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi)
Merging uml/linux-next (ddad5187fc2a um: irq.h: include <asm-generic/irq.h>)
Merging xtensa/xtensa-for-next (ea7737109dfe xtensa: fix uaccess-related livelock in do_page_fault)
Merging pidfd/for-next (8fac44cbbaa2 Merge branch 'fs/idmapped_mounts/helpers' into for-next)
Merging fscrypt/master (a14d0b676491 fscrypt: allow deleting files with unsupported encryption policy)
Merging fscache/fscache-next (42587ccf2ed5 afs: Use the fscache_write_begin() helper)
CONFLICT (content): Merge conflict in fs/afs/write.c
Merging afs/afs-next (8409f67b6437 afs: Adjust the fileserver rotation algorithm to reprobe/retry more quickly)
Merging btrfs/for-next (c7f98650557a Merge branch 'for-next-next-v5.12-20210322' into for-next-20210322)
Merging ceph/master (558b4510f622 ceph: defer flushing the capsnap if the Fb is used)
Merging cifs/for-next (f9e2bb42cf0d Merge tag 'perf-tools-fixes-for-v5.12-2020-03-28' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux)
Merging cifsd/cifsd-for-next (91208e87d526 Merge pull request #34 from namjaejeon/cifsd-for-next)
Merging configfs/for-next (14fbbc829772 configfs: fix a use-after-free in __configfs_open_file)
Merging ecryptfs/next (902af369942f ecryptfs: use DEFINE_MUTEX() for mutex lock)
Merging erofs/dev (f3382f3159d7 erofs: complete a missing case for inplace I/O)
Merging exfat/dev (f9b23f1f6ca0 exfat: speed up iterate/lookup by fixing start point of traversing cluster chain)
Merging ext3/for_next (4a140c918e21 Pull fanotify cleanup from Christian)
Merging ext4/dev (64395d950bc4 ext4: initialize ret to suppress smatch warning)
Merging f2fs/dev (823d13e12b6c f2fs: fix to cover __allocate_new_section() with curseg_lock)
Merging fsverity/fsverity (07c99001312c fs-verity: support reading signature with ioctl)
Merging fuse/for-next (0d02ec6b3136 Linux 5.12-rc4)
Merging jfs/jfs-next (b462cecfa323 fs: Fix typo issue)
Merging nfs/linux-next (0d02ec6b3136 Linux 5.12-rc4)
Merging nfs-anna/linux-next (4f8be1f53bf6 nfs: we don't support removing system.nfs4_acl)
Merging nfsd/nfsd-next (c3213d260a23 SUNRPC: Fix oops in the rpc_xdr_buf event class)
Merging cel/for-next (29a4e914914a svcrdma: Clean up dto_q critical section in svc_rdma_recvfrom())
Merging orangefs/for-next (c1048828c3db orangefs: add splice file operations)
Merging overlayfs/overlayfs-next (d46b7cd68336 ovl: plumb through flush method)
Merging ubifs/next (42119dbe571e ubifs: Fix error return code in alloc_wbufs())
Merging v9fs/9p-next (324a158fe535 fs: 9p: add generic splice_write file operation)
Merging xfs/for-next (25dfa65f8149 xfs: fix xfs_trans slab cache name)
Merging zonefs/for-next (6980d29ce4da zonefs: fix to update .i_wr_refcnt correctly in zonefs_open_zone())
Merging iomap/iomap-for-next (ad89b66cbad1 iomap: improve the warnings from iomap_swapfile_activate)
Merging djw-vfs/vfs-for-next (9b8523423b23 vfs: move __sb_{start,end}_write* to fs.h)
Merging file-locks/locks-next (b8da9b10e26c fs/locks: print full locks information)
Merging vfs/for-next (f85ebc25fa88 Merge branch 'work.misc' into for-next)
CONFLICT (content): Merge conflict in fs/cifs/file.c
Merging printk/for-next (de9a2d6a2625 Merge branch 'for-5.13-vsprintf-pgp' into for-next)
Merging pci/next (55bddc9ae5fb Merge branch 'remotes/lorenzo/pci/misc')
Merging pstore/for-next/pstore (7db688e99c0f pstore/ram: Rate-limit "uncorrectable error in header" message)
Merging hid/for-next (30541b02f591 Merge branch 'for-5.13/thrustmaster' into for-next)
Merging i2c/i2c/for-next (2acaad748aa8 Merge branch 'i2c/for-current' into i2c/for-next)
Merging i3c/i3c/next (e43d5c7c3c34 dt-bindings: i3c: Fix silvaco,i3c-master-v1 compatible string)
Merging dmi/dmi-for-next (3cb4d29a2633 MAINTAINERS: The DMI/SMBIOS tree has moved)
Merging hwmon-staging/hwmon-next (644b9af5c605 hwmon: replace snprintf in show functions with sysfs_emit)
Merging jc_docs/docs-next (212209cff89f docs: kernel-doc: properly recognize parameter lines with colons)
Merging v4l-dvb/master (97b34809ec24 media: staging: atomisp: reduce kernel stack usage)
CONFLICT (content): Merge conflict in MAINTAINERS
Merging v4l-dvb-next/master (1e28eed17697 Linux 5.12-rc3)
Merging fbdev/fbdev-for-next (732146a3f1dc video: fbdev: imxfb: fix a typo in imxfb_probe())
Merging pm/linux-next (a78dc08f3919 Merge branch 'pm-pci' into linux-next)
Merging cpufreq-arm/cpufreq/arm/linux-next (c3135d28a1e0 cpufreq: dt: dev_pm_opp_of_cpumask_add_table() may return -EPROBE_DEFER)
Merging cpupower/cpupower (a38fd8748464 Linux 5.12-rc2)
Merging devfreq/devfreq-next (cc0a62bc9731 PM / devfreq: imx8m-ddrc: Remove imx8m_ddrc_get_dev_status)
Merging opp/opp/linux-next (a8bb0e872bfb memory: samsung: exynos5422-dmc: Convert to use resource-managed OPP API)
Merging thermal/thermal/linux-next (6e3e14c9385c thermal/core/power_allocator: Using round the division when re-divvying up power)
Merging thermal-rzhang/next (54ecb8f7028c Linux 5.4-rc1)
Merging thermal-soc/next (6c375eccded4 thermal: db8500: Rewrite to be a pure OF sensor)
Merging ieee1394/for-next (67f8e65e4fc1 firewire: net: remove set but not used variable 'guid')
Merging dlm/next (9d232469bcd7 fs: dlm: add shutdown hook)
Merging swiotlb/linux-next (2cbc2776efe4 swiotlb: remove swiotlb_nr_tbl)
Merging rdma/for-next (783cf673b05e RDMA/hns: Fix memory corruption when allocating XRCDN)
Merging net-next/master (9d0365448b5b net: moxa: remove redundant dev_err call in moxart_mac_probe())
CONFLICT (content): Merge conflict in include/linux/bpf.h
Merging bpf-next/for-next (21cfd2db9f51 bpf: tcp: Fix an error in the bpf_tcp_ca_kfunc_ids list)
Merging ipsec-next/master (6ad2dd6c14d3 ipv6: fix clang Wformat warning)
Merging mlx5-next/mlx5-next (26bf30902c10 net/mlx5: Use order-0 allocations for EQs)
Merging netfilter-next/master (a1281601f88e farsync: use DEFINE_SPINLOCK() for spinlock)
Merging ipvs-next/master (d4a96be65423 netfilter: conntrack: Remove unused variable declaration)
Merging wireless-drivers-next/master (13ce240a932f rtw88: 8822c: support FW crash dump when FW crash)
Merging bluetooth/master (d58cf00dcedb Bluetooth: Increment management interface revision)
Merging mac80211-next/master (4b837ad53be2 Merge branch 'netfilter-flowtable')
Merging gfs2/for-next (b67e76f22acf gfs2: don't create empty buffers for NO_CREATE)
Merging mtd/mtd/next (28f0be44b263 include: linux: mtd: Remove duplicate include of nand.h)
Merging nand/nand/next (bd9c9fe2ad04 mtd: rawnand: bbt: Skip bad blocks when searching for the BBT in NAND)
Merging spi-nor/spi-nor/next (79321e752aff mtd: spi-nor: core: Update comment about the default flash parameters)
Merging crypto/master (10cb823bbacd crypto: nx - fix incorrect kernel-doc comment syntax in files)
Merging drm/drm-next (2cbcb78c9ee5 Merge tag 'amd-drm-next-5.13-2021-03-23' of https://gitlab.freedesktop.org/agd5f/linux into drm-next)
CONFLICT (content): Merge conflict in drivers/gpu/drm/omapdrm/dss/dsi.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Applying: merge fix for "drm: Switch to %p4cc format modifier"
Merging drm-misc/for-linux-next (e55f2ffc4dc1 drm/mst: Enhance MST topology logging)
Merging amdgpu/drm-next (d6d0e2649dca drm/amdgpu/swsmu: don't bail early on hw_setup on resume)
Merging drm-intel/for-linux-next (93fe86281259 drm/i915: Fix transposed arguments to skl_plane_wm_level())
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/display/intel_dp_link_training.c
Merging drm-tegra/drm/tegra/for-next (09f5220aa699 drm/tegra: dc: Don't set PLL clock to 0Hz)
Merging drm-msm/msm-next (627dc55c273d drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume)
Merging imx-drm/imx-drm/next (82581fcf070b drm/modes: add non-OF stub for of_get_drm_display_mode)
Merging etnaviv/etnaviv/next (7d614ab2f205 drm/etnaviv: fix NULL check before some freeing functions is not needed)
Merging regmap/for-next (5af7bd5b148a Merge remote-tracking branch 'regmap/for-5.13' into regmap-next)
Merging sound/for-next (583770e84a44 ALSA: pcm: Fix couple of typos)
Merging sound-asoc/for-next (3cac585bcd41 Merge remote-tracking branch 'asoc/for-5.13' into asoc-next)
Merging modules/modules-next (1e80d9cb579e module: potential uninitialized return in module_kallsyms_on_each_symbol())
Merging input/next (73e7f1732e80 Input: imx_keypad - convert to a DT-only driver)
Merging block/for-next (13c8804ec329 Merge branch 'for-5.13/libata' into for-next)
CONFLICT (content): Merge conflict in fs/io-wq.c
Merging device-mapper/for-next (db7b93e38106 dm integrity: add the "reset_recalculate" feature flag)
Merging pcmcia/pcmcia-next (e9d503fef7da pcmcia: rsrc_nonstatic: Fix call-back function as reference formatting)
Merging mmc/next (b7b2feb44c61 mmc: sdhci: replace mmc->parent with mmc_dev() for consistency)
Merging mfd/for-mfd-next (43e72121b5f6 mfd: intel_quark_i2c_gpio: Don't play dirty trick with const)
Merging backlight/for-backlight-next (225be60f3853 dt-bindings: backlight: qcom-wled: Add PMI8994 compatible)
Merging battery/for-next (3aeaf5093809 power: reset: replace curly brackets in Makefile)
Merging regulator/for-next (1baf2b66e886 Merge remote-tracking branch 'regulator/for-5.13' into regulator-next)
Merging security/next-testing (215042ece980 Merge branch 'landlock_lsm' into next-testing)
CONFLICT (content): Merge conflict in include/uapi/asm-generic/unistd.h
CONFLICT (content): Merge conflict in arch/xtensa/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/x86/entry/syscalls/syscall_64.tbl
CONFLICT (content): Merge conflict in arch/x86/entry/syscalls/syscall_32.tbl
CONFLICT (content): Merge conflict in arch/sparc/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/sh/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/s390/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/powerpc/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/parisc/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/mips/kernel/syscalls/syscall_o32.tbl
CONFLICT (content): Merge conflict in arch/mips/kernel/syscalls/syscall_n64.tbl
CONFLICT (content): Merge conflict in arch/mips/kernel/syscalls/syscall_n32.tbl
CONFLICT (content): Merge conflict in arch/microblaze/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/m68k/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/ia64/kernel/syscalls/syscall.tbl
CONFLICT (content): Merge conflict in arch/arm64/include/asm/unistd32.h
CONFLICT (content): Merge conflict in arch/arm64/include/asm/unistd.h
CONFLICT (content): Merge conflict in arch/arm/tools/syscall.tbl
CONFLICT (content): Merge conflict in arch/alpha/kernel/syscalls/syscall.tbl
Merging apparmor/apparmor-next (d108370c644b apparmor: fix error check)
Merging integrity/next-integrity (92063f3ca73a integrity: double check iint_cache was initialized)
Merging keys/keys-next (e377c31f788f integrity: Load mokx variables into the blacklist keyring)
Merging safesetid/safesetid-next (03ca0ec13892 LSM: SafeSetID: Fix warnings reported by test bot)
Merging selinux/next (1fb057dcde11 smack: differentiate between subjective and objective task credentials)
Merging smack/next (7ef4c19d245f smackfs: restrict bytes count in smackfs write functions)
Merging tomoyo/master (4e53d1701b57 tomoyo: don't special case PF_IO_WORKER for PF_KTHREAD)
Merging tpmdd/next (8b12a62a4e3e Merge tag 'drm-fixes-2021-03-19' of git://anongit.freedesktop.org/drm/drm)
Merging watchdog/master (1e28eed17697 Linux 5.12-rc3)
Merging iommu/next (7851dfc68810 Merge branches 'iommu/fixes', 'unisoc', 'x86/vt-d' and 'core' into next)
Merging audit/next (d4ceb1d6e732 audit: avoid -Wempty-body warning)
Merging devicetree/for-next (aa89ee98b8b4 docs: dt: Add DT API documentation)
Merging mailbox/mailbox-for-next (6b50df2b8c20 mailbox: arm_mhuv2: Skip calling kfree() with invalid pointer)
Merging spi/for-next (811ba6ea42f6 Merge remote-tracking branch 'spi/for-5.13' into spi-next)
Merging tip/auto-latest (4b3ff7dd4b69 Merge branch 'core/entry')
Applying: x86: fix up for "bpf: Use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG"
Merging clockevents/timers/drivers/next (323397ef4d00 clocksource/drivers/dw_apb_timer_of: Add handling for potential memory leak)
Merging edac/edac-for-next (faf042d15093 Merge branch 'edac-amd64' into edac-for-next)
Merging irqchip/irq/irqchip-next (5fbecd2389f4 irqchip/ingenic: Add support for the JZ4760)
Merging ftrace/for-next (9a6944fee68e tracing: Add a verifier to check string pointers for trace events)
CONFLICT (content): Merge conflict in arch/x86/kernel/kprobes/ftrace.c
Merging rcu/rcu/next (1a0dfc099c1e rcu-tasks: Make ksoftirqd provide RCU Tasks quiescent states)
Merging kvm/next (4a98623d5d90 KVM: x86/mmu: Mark the PAE roots as decrypted for shadow paging)
Merging kvm-arm/next (40acb795bffd Merge branch 'kvm-arm64/host-stage2' into kvmarm-master/next)
Merging kvm-ppc/kvm-ppc-next (72476aaa4691 KVM: PPC: Book3S HV: Fix host radix SLB optimisation with hash guests)
Merging kvms390/next (c3171e94cc1c KVM: s390: VSIE: fix MVPG handling for prefixing and MSO)
Merging xen-tip/linux-next (af44a387e743 Revert "xen: fix p2m size in dom0 for disabled memory hotplug case")
Merging percpu/for-next (df1c002198a8 Merge branch 'for-5.12' into for-next)
Merging workqueues/for-next (a7347aa8e061 workqueue: Move the position of debug_work_activate() in __queue_work())
Merging drivers-x86/for-next (36974daf5388 platform/x86: intel_pmc_core: Ignore GBE LTR on Tiger Lake platforms)
CONFLICT (content): Merge conflict in drivers/platform/x86/thinkpad_acpi.c
Merging chrome-platform/for-next (a38fd8748464 Linux 5.12-rc2)
Merging hsi/for-next (aa57e77b3d28 HSI: Fix PM usage counter unbalance in ssi_hw_init)
Merging leds/for-next (d9dfac5419d0 leds: rt4505: Add support for Richtek RT4505 flash LED controller)
Merging ipmi/for-next (c053c4eb5a0f ipmi: Handle device properties with software node API)
Merging driver-core/driver-core-next (ecdc996baf29 power: supply: axp20x_usb_power: fix work-queue init)
Merging usb/usb-next (24327c478b2f usb: mtu3: drop CONFIG_OF)
Merging usb-gadget/next (a38fd8748464 Linux 5.12-rc2)
Merging usb-serial/usb-next (764de1059b97 USB: serial: pl2303: TA & TB alternate divider with non-standard baud rates)
Merging usb-chipidea-next/for-usb-next (0534e39c95a0 usb: cdns3: Optimize DMA request buffer allocation)
CONFLICT (content): Merge conflict in drivers/usb/typec/tipd/core.c
Merging tty/tty-next (41a469482de2 serial: 8250: Add new 8250-core based Broadcom STB driver)
Merging char-misc/char-misc-next (d72260cc7879 Documentation: fpga: dfl: Add description for DFL UIO support)
Merging extcon/extcon-next (cf947ad92675 extcon: qcom-spmi: Add support for VBUS detection)
Merging phy-next/next (0d811cda22ab phy: qualcomm: remove duplicate argument)
Merging soundwire/next (e6cb15b50065 soundwire: qcom: add missing \n in dev_err())
Merging thunderbolt/next (2e7a5b3e2236 thunderbolt: Unlock on error path in tb_domain_add())
Merging vfio/next (4d83de6da265 vfio/type1: Batch page pinning)
Merging staging/staging-next (305271ab4f54 staging: rtl8723bs: remove unused macros in include/drv_types.c)
CONFLICT (content): Merge conflict in drivers/iio/common/scmi_sensors/scmi_iio.c
Applying: iio: adc: merge fix for "spi: core: remove 'delay_usecs' field from spi_transfer"
Merging mux/for-next (3516bd729358 Merge tag 's390-5.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux)
Merging icc/icc-next (9f772b9e2aea Merge branch 'icc-sm8350' into icc-next)
Merging dmaengine/next (84b0aa2e0d91 dmaengine: dw-edma: Add pcim_iomap_table return check)
Merging cgroup/for-next (00bfa16052cd Merge branch 'for-5.11-fixes' into for-next)
Merging scsi/for-next (213ce3262eda Merge branch 'misc' into for-next)
Merging scsi-mkp/for-next (c2255ece2be2 scsi: pm8001: Avoid -Wrestrict warning)
Merging vhost/linux-next (723c7003c1ab vdpa: introduce virtio pci driver)
Merging rpmsg/for-next (2c2564b9d64d Merge branches 'hwspinlock-next', 'rpmsg-next' and 'rproc-next' into for-next)
Merging gpio/for-next (7ac554888233 MAINTAINERS: Remove reference to non-existing file)
Merging gpio-brgl/gpio/for-next (9d940ab72645 selftests: gpio: add test cases for gpio-sim)
Merging gpio-intel/for-next (6c46215d6b62 gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events)
Merging pinctrl/for-next (b9fd814e2c5d Merge branch 'devel' into for-next)
Merging pinctrl-intel/for-next (5b613df3f499 pinctrl: intel: No need to disable IRQs in the handler)
Merging pinctrl-renesas/renesas-pinctrl (61232cd6efca pinctrl: renesas: r8a7791: Add bias pinconf support)
Merging pinctrl-samsung/for-next (a38fd8748464 Linux 5.12-rc2)
Merging pwm/for-next (9666cec380d6 pwm: Drop function pwmchip_add_with_polarity())
Merging userns/for-next (95ebabde382c capabilities: Don't allow writing ambiguous v3 file capabilities)
Merging ktest/for-next (170f4869e662 ktest.pl: Fix the logic for truncating the size of the log file for email)
Merging random/dev (ab9a7e27044b random: avoid warnings for !CONFIG_NUMA builds)
Merging kselftest/next (ea2c679edc41 selftests/timers: Fix spelling mistake "clocksourc" -> "clocksource")
Merging y2038/y2038 (c4e71212a245 Revert "drm/etnaviv: reject timeouts with tv_nsec >= NSEC_PER_SEC")
Merging livepatching/for-next (81840f21d416 Merge branch 'for-5.12/doc' into for-next)
Merging coresight/next (1efbcec2ef8c coresight: cti: Reduce scope for the variable “cs_fwnode” in cti_plat_create_connection())
Merging rtc/rtc-next (8d69f62fddf6 rtc: rx6110: add ACPI bindings to I2C)
Merging nvdimm/libnvdimm-for-next (30c10d32152d Merge branch 'for-5.12/cxl' into libnvdimm-for-next)
Merging at24/at24/for-next (fe07bfda2fb9 Linux 5.12-rc1)
Merging ntb/ntb-next (5c8fe583cce5 Linux 5.11-rc1)
Merging seccomp/for-next/seccomp (15a2fd51384a seccomp: fix the cond to report loaded filters)
Merging kspp/for-next/kspp (414eece95b98 Merge tag 'clang-lto-v5.12-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux)
Merging gnss/gnss-next (994adcbd3714 gnss: drop stray semicolons)
Merging fsi/next (4a851d714ead fsi: aspeed: Support CFAM reset GPIO)
Merging slimbus/for-next (0320ed0a8236 drivers: slimbus: Fix word resposible -> responsible in slimbus.h)
CONFLICT (content): Merge conflict in drivers/nvmem/Kconfig
Merging nvmem/for-next (5350a8500263 nvmem: rmem: fix undefined reference to memremap)
Merging xarray/main (80c1dbebf308 XArray: Fix splitting to non-zero orders)
Merging hyperv/hyperv-next (6dc2a774cb4f x86/Hyper-V: Support for free page reporting)
CONFLICT (content): Merge conflict in arch/x86/include/asm/mshyperv.h
Applying: fix up for "x86/paravirt: Switch time pvops functions to use static_call()"
Merging auxdisplay/auxdisplay (701454bce906 auxdisplay: Remove in_interrupt() usage.)
Merging kgdb/kgdb/for-next (2bbd9b0f2b4e kernel: debug: Ordinary typo fixes in the file gdbstub.c)
Merging hmm/hmm (fe07bfda2fb9 Linux 5.12-rc1)
Merging fpga/for-next (9a8d3cda8daf fpga: dfl: afu: harden port enable logic)
Merging kunit/test (a38fd8748464 Linux 5.12-rc2)
Merging generic-ioremap/for-next (4bdc0d676a64 remove ioremap_nocache and devm_ioremap_nocache)
Merging cfi/cfi/next (a38fd8748464 Linux 5.12-rc2)
Merging kunit-next/kunit (2f9f21cdcd71 kunit: Match parenthesis alignment to improve code readability)
Merging trivial/for-next (9ff9b0d392ea Merge tag 'net-next-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next)
Merging zx2c4/for-next (16fbf79b0f83 Linux 5.6-rc7)
Merging mhi/mhi-next (9e40641f62cd bus: mhi: core: Check state before processing power_down)
Merging memblock/for-next (097d43d85704 mm: memblock: remove return value of memblock_free_all())
Merging init/init-user-pointers (38b082236e77 initramfs: use vfs_utimes in do_copy)
Merging counters/counters (e71ba9452f0b Linux 5.11-rc2)
Merging iomem-mmap-vs-gup/topic/iomem-mmap-vs-gup (5f962ee843e6 mm: unexport follow_pfn)
Merging rust/rust-next (98898dfbdf72 Rust support)
CONFLICT (content): Merge conflict in Makefile
Merging akpm-current/current (12f9533d42e5 ipc/sem.c: mundane typo fixes)
CONFLICT (content): Merge conflict in include/linux/bitmap.h
CONFLICT (content): Merge conflict in arch/x86/mm/init_64.c
CONFLICT (content): Merge conflict in Documentation/admin-guide/kernel-parameters.txt
$ git checkout -b akpm remotes/origin/akpm/master
$ git rebase --onto master remotes/origin/akpm/master-base
Merging akpm/master (d7e9d4d2fe0d secretmem: test: add basic selftest for memfd_secret(2))

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* kernel warning percpu ref in obj_cgroup_release (was: Re: linux-next: Tree for Mar 29)
  2021-03-29  9:52 linux-next: Tree for Mar 29 Stephen Rothwell
@ 2021-03-30 11:32 ` Christian Borntraeger
  2021-03-30 13:27   ` kernel warning percpu ref in obj_cgroup_release Christian Borntraeger
  0 siblings, 1 reply; 10+ messages in thread
From: Christian Borntraeger @ 2021-03-30 11:32 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Muchun Song
  Cc: Linux Kernel Mailing List, linux-s390

On 29.03.21 11:52, Stephen Rothwell wrote:
> Hi all,
> 
> News: there will be no linux-next release on Friday or the following
> Monday.
> 
> Changes since 20210326:
> 
> The arm64 tree gained a conflict against Linus' tree.
> 
> I applied a supplied patch for clang brakage in the kbuild tree.
> 
> The net-next tree gained a conflict against the bpf tree.
> 
> The drm tree gained a conflict against Linus' tree.
> 
> The staging tree gained a conflict against the scmi tree and a semantic
> conflict against the spi tree.
> 
> The rust tree gained a conflict against the kbuild tree.
> 
> The akpm-current tree lost its its build failure and gained a conflict
> against the gpio-brgl tree.
> 
> Non-merge commits (relative to Linus' tree): 7289
>   7213 files changed, 432170 insertions(+), 147471 deletions(-)
> 

This next (328 is fine) triggers several bugs during our KVM CI run:

[ 1506.494716] ------------[ cut here ]------------
[ 1506.494730] percpu ref (obj_cgroup_release) <= 0 (-1) after switching to atomic
[ 1506.494766] WARNING: CPU: 6 PID: 0 at lib/percpu-refcount.c:196 percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8
[ 1506.494774] Modules linked in: kvm vhost_vsock vmw_vsock_virtio_transport_common vsock vhost vhost_iotlb xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT xt_tcpudp nft_compat nf_nat_tftp nft_objref nf_conntrack_tftp nft_counter bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct dm_service_time nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink zfcp scsi_transport_fc rpcrdma sunrpc dm_multipath rdma_ucm scsi_dh_rdac scsi_dh_emc rdma_cm scsi_dh_alua iw_cm ib_cm mlx5_ib ib_uverbs dm_mod ib_core s390_trng vfio_ccw vfio_mdev mdev vfio_iommu_type1 zcrypt_cex4 vfio eadm_sch sch_fq_codel configfs ip_tables x_tables ghash_s390 prng aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 mlx5_core sha512_s390 sha256_s390 sha1_s390 sha_common nvme nvme_core pkey zcrypt rng_core autofs4 [last unloaded: vfio_ap]
[ 1506.494832] CPU: 6 PID: 0 Comm: swapper/6 Not tainted 5.12.0-20210330.rc4.git0.9d49ed9ca93b.300.fc33.s390x+next #1
[ 1506.494834] Hardware name: IBM 8561 T01 703 (LPAR)
[ 1506.494836] Krnl PSW : 0704c00180000000 00000002d71dd21e (percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8)
[ 1506.494840]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
[ 1506.494842] Krnl GPRS: c0000000fffeffff 00000002f7256818 0000000000000043 00000000fffeffff
[ 1506.494844]            00000000ffffffea 0000038000000001 0000000000000000 000003800000017c
[ 1506.494846]            00000002d7924988 0000000227eb97a0 000003ff5413c7e0 7fffffffffffffff
[ 1506.494848]            0000000080360000 00000002f726b570 00000002d71dd21a 00000380000bba28
[ 1506.494856] Krnl Code: 00000002d71dd20e: e3309fe8ff04        lg      %r3,-24(%r9)
                           00000002d71dd214: c0e5001eb556        brasl   %r14,00000002d75b3cc0
                          #00000002d71dd21a: af000000            mc      0,0
                          >00000002d71dd21e: a7f4ffcc            brc     15,00000002d71dd1b6
                           00000002d71dd222: 0707                bcr     0,%r7
                           00000002d71dd224: 0707                bcr     0,%r7
                           00000002d71dd226: 0707                bcr     0,%r7
                           00000002d71dd228: eb6ff0480024        stmg    %r6,%r15,72(%r15)
[ 1506.494928] Call Trace:
[ 1506.494933]  [<00000002d71dd21e>] percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8
[ 1506.494940] ([<00000002d71dd21a>] percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8)
[ 1506.494942]  [<00000002d6b8a6c6>] rcu_do_batch+0x146/0x608
[ 1506.494946]  [<00000002d6b8ec04>] rcu_core+0x124/0x1d0
[ 1506.494948]  [<00000002d75d0222>] __do_softirq+0x13a/0x3c8
[ 1506.494952]  [<00000002d6b05306>] irq_exit+0xce/0xf8
[ 1506.494955]  [<00000002d75c1eb4>] do_ext_irq+0xdc/0x170
[ 1506.494957]  [<00000002d75cdea4>] ext_int_handler+0xc4/0xf4
[ 1506.494959]  [<0000000000000000>] 0x0
[ 1506.494963]  [<00000002d75cd9c2>] default_idle_call+0x42/0x110
[ 1506.494965]  [<00000002d6b411a0>] do_idle+0xd8/0x168
[ 1506.494968]  [<00000002d6b413ee>] cpu_startup_entry+0x36/0x40
[ 1506.494971]  [<00000002d6ac730a>] smp_start_secondary+0x82/0x88
[ 1506.494974] Last Breaking-Event-Address:
[ 1506.494975]  [<00000002d6b71898>] vprintk_emit+0xa8/0x110
[ 1506.494978] Kernel panic - not syncing: panic_on_warn set ...



I will try to bisect this, but if anyone has an idea. CC some candidates.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: kernel warning percpu ref in obj_cgroup_release
  2021-03-30 11:32 ` kernel warning percpu ref in obj_cgroup_release (was: Re: linux-next: Tree for Mar 29) Christian Borntraeger
@ 2021-03-30 13:27   ` Christian Borntraeger
  2021-03-30 13:49     ` [External] " Muchun Song
  0 siblings, 1 reply; 10+ messages in thread
From: Christian Borntraeger @ 2021-03-30 13:27 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Muchun Song
  Cc: Linux Kernel Mailing List, linux-s390, Johannes Weiner,
	Michal Hocko, Roman Gushchin, Shakeel Butt, Vladimir Davydov,
	Xiongchun Duan

So bisect shows this for belows warning:

636c3ef8229ecb4e7d045e86f36505d24a8f019a is the first bad commit
commit 636c3ef8229ecb4e7d045e86f36505d24a8f019a
Author: Muchun Song <songmuchun@bytedance.com>
Date:   Mon Mar 29 11:12:06 2021 +1100

     mm: memcontrol: use obj_cgroup APIs to charge kmem pages
     
     Since Roman's series "The new cgroup slab memory controller" applied.  All
     slab objects are charged via the new APIs of obj_cgroup.  The new APIs
     introduce a struct obj_cgroup to charge slab objects.  It prevents
     long-living objects from pinning the original memory cgroup in the memory.
     But there are still some corner objects (e.g.  allocations larger than
     order-1 page on SLUB) which are not charged via the new APIs.  Those
     objects (include the pages which are allocated from buddy allocator
     directly) are charged as kmem pages which still hold a reference to the
     memory cgroup.
     
     We want to reuse the obj_cgroup APIs to charge the kmem pages.  If we do
     that, we should store an object cgroup pointer to page->memcg_data for the
     kmem pages.
     
     Finally, page->memcg_data will have 3 different meanings.
     
       1) For the slab pages, page->memcg_data points to an object cgroups
          vector.
     
       2) For the kmem pages (exclude the slab pages), page->memcg_data
          points to an object cgroup.
     
       3) For the user pages (e.g. the LRU pages), page->memcg_data points
          to a memory cgroup.
     
     We do not change the behavior of page_memcg() and page_memcg_rcu().  They
     are also suitable for LRU pages and kmem pages.  Why?
     
     Because memory allocations pinning memcgs for a long time - it exists at a
     larger scale and is causing recurring problems in the real world: page
     cache doesn't get reclaimed for a long time, or is used by the second,
     third, fourth, ...  instance of the same job that was restarted into a new
     cgroup every time.  Unreclaimable dying cgroups pile up, waste memory, and
     make page reclaim very inefficient.
     
     We can convert LRU pages and most other raw memcg pins to the objcg
     direction to fix this problem, and then the page->memcg will always point
     to an object cgroup pointer.  At that time, LRU pages and kmem pages will
     be treated the same.  The implementation of page_memcg() will remove the
     kmem page check.
     
     This patch aims to charge the kmem pages by using the new APIs of
     obj_cgroup.  Finally, the page->memcg_data of the kmem page points to an
     object cgroup.  We can use the __page_objcg() to get the object cgroup
     associated with a kmem page.  Or we can use page_memcg() to get the memory
     cgroup associated with a kmem page, but caller must ensure that the
     returned memcg won't be released (e.g.  acquire the rcu_read_lock or
     css_set_lock).
     
     Link: https://lkml.kernel.org/r/20210319163821.20704-6-songmuchun@bytedance.com
     Signed-off-by: Muchun Song <songmuchun@bytedance.com>
     Acked-by: Johannes Weiner <hannes@cmpxchg.org>
     Cc: Michal Hocko <mhocko@kernel.org>
     Cc: Roman Gushchin <guro@fb.com>
     Cc: Shakeel Butt <shakeelb@google.com>
     Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
     Cc: Xiongchun Duan <duanxiongchun@bytedance.com>
     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

  include/linux/memcontrol.h | 116 +++++++++++++++++++++++++++++++++++----------
  mm/memcontrol.c            | 110 +++++++++++++++++++++---------------------
  2 files changed, 145 insertions(+), 81 deletions(-)





On 30.03.21 13:32, Christian Borntraeger wrote:
[...]
> 
> This next (328 is fine) triggers several bugs during our KVM CI run:
> 
> [ 1506.494716] ------------[ cut here ]------------
> [ 1506.494730] percpu ref (obj_cgroup_release) <= 0 (-1) after switching to atomic
> [ 1506.494766] WARNING: CPU: 6 PID: 0 at lib/percpu-refcount.c:196 percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8
> [ 1506.494774] Modules linked in: kvm vhost_vsock vmw_vsock_virtio_transport_common vsock vhost vhost_iotlb xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT xt_tcpudp nft_compat nf_nat_tftp nft_objref nf_conntrack_tftp nft_counter bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct dm_service_time nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink zfcp scsi_transport_fc rpcrdma sunrpc dm_multipath rdma_ucm scsi_dh_rdac scsi_dh_emc rdma_cm scsi_dh_alua iw_cm ib_cm mlx5_ib ib_uverbs dm_mod ib_core s390_trng vfio_ccw vfio_mdev mdev vfio_iommu_type1 zcrypt_cex4 vfio eadm_sch sch_fq_codel configfs ip_tables x_tables ghash_s390 prng aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 mlx5_core sha512_s390 sha256_s390 sha1_s390 sha_common nvme nvme_core pkey zcrypt rng_core autofs4 [last unloaded: vfio_ap]
> [ 1506.494832] CPU: 6 PID: 0 Comm: swapper/6 Not tainted 5.12.0-20210330.rc4.git0.9d49ed9ca93b.300.fc33.s390x+next #1
> [ 1506.494834] Hardware name: IBM 8561 T01 703 (LPAR)
> [ 1506.494836] Krnl PSW : 0704c00180000000 00000002d71dd21e (percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8)
> [ 1506.494840]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
> [ 1506.494842] Krnl GPRS: c0000000fffeffff 00000002f7256818 0000000000000043 00000000fffeffff
> [ 1506.494844]            00000000ffffffea 0000038000000001 0000000000000000 000003800000017c
> [ 1506.494846]            00000002d7924988 0000000227eb97a0 000003ff5413c7e0 7fffffffffffffff
> [ 1506.494848]            0000000080360000 00000002f726b570 00000002d71dd21a 00000380000bba28
> [ 1506.494856] Krnl Code: 00000002d71dd20e: e3309fe8ff04        lg      %r3,-24(%r9)
>                            00000002d71dd214: c0e5001eb556        brasl   %r14,00000002d75b3cc0
>                           #00000002d71dd21a: af000000            mc      0,0
>                           >00000002d71dd21e: a7f4ffcc            brc     15,00000002d71dd1b6
>                            00000002d71dd222: 0707                bcr     0,%r7
>                            00000002d71dd224: 0707                bcr     0,%r7
>                            00000002d71dd226: 0707                bcr     0,%r7
>                            00000002d71dd228: eb6ff0480024        stmg    %r6,%r15,72(%r15)
> [ 1506.494928] Call Trace:
> [ 1506.494933]  [<00000002d71dd21e>] percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8
> [ 1506.494940] ([<00000002d71dd21a>] percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8)
> [ 1506.494942]  [<00000002d6b8a6c6>] rcu_do_batch+0x146/0x608
> [ 1506.494946]  [<00000002d6b8ec04>] rcu_core+0x124/0x1d0
> [ 1506.494948]  [<00000002d75d0222>] __do_softirq+0x13a/0x3c8
> [ 1506.494952]  [<00000002d6b05306>] irq_exit+0xce/0xf8
> [ 1506.494955]  [<00000002d75c1eb4>] do_ext_irq+0xdc/0x170
> [ 1506.494957]  [<00000002d75cdea4>] ext_int_handler+0xc4/0xf4
> [ 1506.494959]  [<0000000000000000>] 0x0
> [ 1506.494963]  [<00000002d75cd9c2>] default_idle_call+0x42/0x110
> [ 1506.494965]  [<00000002d6b411a0>] do_idle+0xd8/0x168
> [ 1506.494968]  [<00000002d6b413ee>] cpu_startup_entry+0x36/0x40
> [ 1506.494971]  [<00000002d6ac730a>] smp_start_secondary+0x82/0x88
> [ 1506.494974] Last Breaking-Event-Address:
> [ 1506.494975]  [<00000002d6b71898>] vprintk_emit+0xa8/0x110
> [ 1506.494978] Kernel panic - not syncing: panic_on_warn set ...
> 
> 
> 
> I will try to bisect this, but if anyone has an idea. CC some candidates.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [External] Re: kernel warning percpu ref in obj_cgroup_release
  2021-03-30 13:27   ` kernel warning percpu ref in obj_cgroup_release Christian Borntraeger
@ 2021-03-30 13:49     ` Muchun Song
  2021-03-30 15:10       ` Christian Borntraeger
  0 siblings, 1 reply; 10+ messages in thread
From: Muchun Song @ 2021-03-30 13:49 UTC (permalink / raw)
  To: Christian Borntraeger
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
> So bisect shows this for belows warning:

Thanks for your effort on this. Can you share your config?

>
> 636c3ef8229ecb4e7d045e86f36505d24a8f019a is the first bad commit
> commit 636c3ef8229ecb4e7d045e86f36505d24a8f019a
> Author: Muchun Song <songmuchun@bytedance.com>
> Date:   Mon Mar 29 11:12:06 2021 +1100
>
>      mm: memcontrol: use obj_cgroup APIs to charge kmem pages
>
>      Since Roman's series "The new cgroup slab memory controller" applied.  All
>      slab objects are charged via the new APIs of obj_cgroup.  The new APIs
>      introduce a struct obj_cgroup to charge slab objects.  It prevents
>      long-living objects from pinning the original memory cgroup in the memory.
>      But there are still some corner objects (e.g.  allocations larger than
>      order-1 page on SLUB) which are not charged via the new APIs.  Those
>      objects (include the pages which are allocated from buddy allocator
>      directly) are charged as kmem pages which still hold a reference to the
>      memory cgroup.
>
>      We want to reuse the obj_cgroup APIs to charge the kmem pages.  If we do
>      that, we should store an object cgroup pointer to page->memcg_data for the
>      kmem pages.
>
>      Finally, page->memcg_data will have 3 different meanings.
>
>        1) For the slab pages, page->memcg_data points to an object cgroups
>           vector.
>
>        2) For the kmem pages (exclude the slab pages), page->memcg_data
>           points to an object cgroup.
>
>        3) For the user pages (e.g. the LRU pages), page->memcg_data points
>           to a memory cgroup.
>
>      We do not change the behavior of page_memcg() and page_memcg_rcu().  They
>      are also suitable for LRU pages and kmem pages.  Why?
>
>      Because memory allocations pinning memcgs for a long time - it exists at a
>      larger scale and is causing recurring problems in the real world: page
>      cache doesn't get reclaimed for a long time, or is used by the second,
>      third, fourth, ...  instance of the same job that was restarted into a new
>      cgroup every time.  Unreclaimable dying cgroups pile up, waste memory, and
>      make page reclaim very inefficient.
>
>      We can convert LRU pages and most other raw memcg pins to the objcg
>      direction to fix this problem, and then the page->memcg will always point
>      to an object cgroup pointer.  At that time, LRU pages and kmem pages will
>      be treated the same.  The implementation of page_memcg() will remove the
>      kmem page check.
>
>      This patch aims to charge the kmem pages by using the new APIs of
>      obj_cgroup.  Finally, the page->memcg_data of the kmem page points to an
>      object cgroup.  We can use the __page_objcg() to get the object cgroup
>      associated with a kmem page.  Or we can use page_memcg() to get the memory
>      cgroup associated with a kmem page, but caller must ensure that the
>      returned memcg won't be released (e.g.  acquire the rcu_read_lock or
>      css_set_lock).
>
>      Link: https://lkml.kernel.org/r/20210319163821.20704-6-songmuchun@bytedance.com
>      Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>      Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>      Cc: Michal Hocko <mhocko@kernel.org>
>      Cc: Roman Gushchin <guro@fb.com>
>      Cc: Shakeel Butt <shakeelb@google.com>
>      Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
>      Cc: Xiongchun Duan <duanxiongchun@bytedance.com>
>      Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>      Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
>   include/linux/memcontrol.h | 116 +++++++++++++++++++++++++++++++++++----------
>   mm/memcontrol.c            | 110 +++++++++++++++++++++---------------------
>   2 files changed, 145 insertions(+), 81 deletions(-)
>
>
>
>
>
> On 30.03.21 13:32, Christian Borntraeger wrote:
> [...]
> >
> > This next (328 is fine) triggers several bugs during our KVM CI run:
> >
> > [ 1506.494716] ------------[ cut here ]------------
> > [ 1506.494730] percpu ref (obj_cgroup_release) <= 0 (-1) after switching to atomic
> > [ 1506.494766] WARNING: CPU: 6 PID: 0 at lib/percpu-refcount.c:196 percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8
> > [ 1506.494774] Modules linked in: kvm vhost_vsock vmw_vsock_virtio_transport_common vsock vhost vhost_iotlb xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT xt_tcpudp nft_compat nf_nat_tftp nft_objref nf_conntrack_tftp nft_counter bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct dm_service_time nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink zfcp scsi_transport_fc rpcrdma sunrpc dm_multipath rdma_ucm scsi_dh_rdac scsi_dh_emc rdma_cm scsi_dh_alua iw_cm ib_cm mlx5_ib ib_uverbs dm_mod ib_core s390_trng vfio_ccw vfio_mdev mdev vfio_iommu_type1 zcrypt_cex4 vfio eadm_sch sch_fq_codel configfs ip_tables x_tables ghash_s390 prng aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 mlx5_core sha512_s390 sha256_s390 sha1_s390 sha_common nvme nvme_core pkey zcrypt rng_core autofs4 [last unloaded: vfio_ap]
> > [ 1506.494832] CPU: 6 PID: 0 Comm: swapper/6 Not tainted 5.12.0-20210330.rc4.git0.9d49ed9ca93b.300.fc33.s390x+next #1
> > [ 1506.494834] Hardware name: IBM 8561 T01 703 (LPAR)
> > [ 1506.494836] Krnl PSW : 0704c00180000000 00000002d71dd21e (percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8)
> > [ 1506.494840]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
> > [ 1506.494842] Krnl GPRS: c0000000fffeffff 00000002f7256818 0000000000000043 00000000fffeffff
> > [ 1506.494844]            00000000ffffffea 0000038000000001 0000000000000000 000003800000017c
> > [ 1506.494846]            00000002d7924988 0000000227eb97a0 000003ff5413c7e0 7fffffffffffffff
> > [ 1506.494848]            0000000080360000 00000002f726b570 00000002d71dd21a 00000380000bba28
> > [ 1506.494856] Krnl Code: 00000002d71dd20e: e3309fe8ff04        lg      %r3,-24(%r9)
> >                            00000002d71dd214: c0e5001eb556        brasl   %r14,00000002d75b3cc0
> >                           #00000002d71dd21a: af000000            mc      0,0
> >                           >00000002d71dd21e: a7f4ffcc            brc     15,00000002d71dd1b6
> >                            00000002d71dd222: 0707                bcr     0,%r7
> >                            00000002d71dd224: 0707                bcr     0,%r7
> >                            00000002d71dd226: 0707                bcr     0,%r7
> >                            00000002d71dd228: eb6ff0480024        stmg    %r6,%r15,72(%r15)
> > [ 1506.494928] Call Trace:
> > [ 1506.494933]  [<00000002d71dd21e>] percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8
> > [ 1506.494940] ([<00000002d71dd21a>] percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8)
> > [ 1506.494942]  [<00000002d6b8a6c6>] rcu_do_batch+0x146/0x608
> > [ 1506.494946]  [<00000002d6b8ec04>] rcu_core+0x124/0x1d0
> > [ 1506.494948]  [<00000002d75d0222>] __do_softirq+0x13a/0x3c8
> > [ 1506.494952]  [<00000002d6b05306>] irq_exit+0xce/0xf8
> > [ 1506.494955]  [<00000002d75c1eb4>] do_ext_irq+0xdc/0x170
> > [ 1506.494957]  [<00000002d75cdea4>] ext_int_handler+0xc4/0xf4
> > [ 1506.494959]  [<0000000000000000>] 0x0
> > [ 1506.494963]  [<00000002d75cd9c2>] default_idle_call+0x42/0x110
> > [ 1506.494965]  [<00000002d6b411a0>] do_idle+0xd8/0x168
> > [ 1506.494968]  [<00000002d6b413ee>] cpu_startup_entry+0x36/0x40
> > [ 1506.494971]  [<00000002d6ac730a>] smp_start_secondary+0x82/0x88
> > [ 1506.494974] Last Breaking-Event-Address:
> > [ 1506.494975]  [<00000002d6b71898>] vprintk_emit+0xa8/0x110
> > [ 1506.494978] Kernel panic - not syncing: panic_on_warn set ...
> >
> >
> >
> > I will try to bisect this, but if anyone has an idea. CC some candidates.
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-30 13:49     ` [External] " Muchun Song
@ 2021-03-30 15:10       ` Christian Borntraeger
  2021-03-30 16:25         ` [External] " Muchun Song
  0 siblings, 1 reply; 10+ messages in thread
From: Christian Borntraeger @ 2021-03-30 15:10 UTC (permalink / raw)
  To: Muchun Song
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

[-- Attachment #1: Type: text/plain, Size: 8370 bytes --]


On 30.03.21 15:49, Muchun Song wrote:
> On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
> <borntraeger@de.ibm.com> wrote:
>>
>> So bisect shows this for belows warning:
> 
> Thanks for your effort on this. Can you share your config?

attached (but its s390x) for next-20210330

The problem goes away when I add
cgroup_controllers = [  ]
to /etc/libvirt/qemu.conf

The testcase that triggers the problem starts and stops multipe KVM guests with 248 CPUs.
Do we happen to have maybe only a byte of refcount space?


> 
>>
>> 636c3ef8229ecb4e7d045e86f36505d24a8f019a is the first bad commit
>> commit 636c3ef8229ecb4e7d045e86f36505d24a8f019a
>> Author: Muchun Song <songmuchun@bytedance.com>
>> Date:   Mon Mar 29 11:12:06 2021 +1100
>>
>>       mm: memcontrol: use obj_cgroup APIs to charge kmem pages
>>
>>       Since Roman's series "The new cgroup slab memory controller" applied.  All
>>       slab objects are charged via the new APIs of obj_cgroup.  The new APIs
>>       introduce a struct obj_cgroup to charge slab objects.  It prevents
>>       long-living objects from pinning the original memory cgroup in the memory.
>>       But there are still some corner objects (e.g.  allocations larger than
>>       order-1 page on SLUB) which are not charged via the new APIs.  Those
>>       objects (include the pages which are allocated from buddy allocator
>>       directly) are charged as kmem pages which still hold a reference to the
>>       memory cgroup.
>>
>>       We want to reuse the obj_cgroup APIs to charge the kmem pages.  If we do
>>       that, we should store an object cgroup pointer to page->memcg_data for the
>>       kmem pages.
>>
>>       Finally, page->memcg_data will have 3 different meanings.
>>
>>         1) For the slab pages, page->memcg_data points to an object cgroups
>>            vector.
>>
>>         2) For the kmem pages (exclude the slab pages), page->memcg_data
>>            points to an object cgroup.
>>
>>         3) For the user pages (e.g. the LRU pages), page->memcg_data points
>>            to a memory cgroup.
>>
>>       We do not change the behavior of page_memcg() and page_memcg_rcu().  They
>>       are also suitable for LRU pages and kmem pages.  Why?
>>
>>       Because memory allocations pinning memcgs for a long time - it exists at a
>>       larger scale and is causing recurring problems in the real world: page
>>       cache doesn't get reclaimed for a long time, or is used by the second,
>>       third, fourth, ...  instance of the same job that was restarted into a new
>>       cgroup every time.  Unreclaimable dying cgroups pile up, waste memory, and
>>       make page reclaim very inefficient.
>>
>>       We can convert LRU pages and most other raw memcg pins to the objcg
>>       direction to fix this problem, and then the page->memcg will always point
>>       to an object cgroup pointer.  At that time, LRU pages and kmem pages will
>>       be treated the same.  The implementation of page_memcg() will remove the
>>       kmem page check.
>>
>>       This patch aims to charge the kmem pages by using the new APIs of
>>       obj_cgroup.  Finally, the page->memcg_data of the kmem page points to an
>>       object cgroup.  We can use the __page_objcg() to get the object cgroup
>>       associated with a kmem page.  Or we can use page_memcg() to get the memory
>>       cgroup associated with a kmem page, but caller must ensure that the
>>       returned memcg won't be released (e.g.  acquire the rcu_read_lock or
>>       css_set_lock).
>>
>>       Link: https://lkml.kernel.org/r/20210319163821.20704-6-songmuchun@bytedance.com
>>       Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>>       Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>>       Cc: Michal Hocko <mhocko@kernel.org>
>>       Cc: Roman Gushchin <guro@fb.com>
>>       Cc: Shakeel Butt <shakeelb@google.com>
>>       Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
>>       Cc: Xiongchun Duan <duanxiongchun@bytedance.com>
>>       Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>       Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>
>>    include/linux/memcontrol.h | 116 +++++++++++++++++++++++++++++++++++----------
>>    mm/memcontrol.c            | 110 +++++++++++++++++++++---------------------
>>    2 files changed, 145 insertions(+), 81 deletions(-)
>>
>>
>>
>>
>>
>> On 30.03.21 13:32, Christian Borntraeger wrote:
>> [...]
>>>
>>> This next (328 is fine) triggers several bugs during our KVM CI run:
>>>
>>> [ 1506.494716] ------------[ cut here ]------------
>>> [ 1506.494730] percpu ref (obj_cgroup_release) <= 0 (-1) after switching to atomic
>>> [ 1506.494766] WARNING: CPU: 6 PID: 0 at lib/percpu-refcount.c:196 percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8
>>> [ 1506.494774] Modules linked in: kvm vhost_vsock vmw_vsock_virtio_transport_common vsock vhost vhost_iotlb xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT xt_tcpudp nft_compat nf_nat_tftp nft_objref nf_conntrack_tftp nft_counter bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct dm_service_time nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink zfcp scsi_transport_fc rpcrdma sunrpc dm_multipath rdma_ucm scsi_dh_rdac scsi_dh_emc rdma_cm scsi_dh_alua iw_cm ib_cm mlx5_ib ib_uverbs dm_mod ib_core s390_trng vfio_ccw vfio_mdev mdev vfio_iommu_type1 zcrypt_cex4 vfio eadm_sch sch_fq_codel configfs ip_tables x_tables ghash_s390 prng aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 mlx5_core sha512_s390 sha256_s390 sha1_s390 sha_common nvme nvme_core pkey zcrypt rng_core autofs4 [last unloaded: vfio_ap]
>>> [ 1506.494832] CPU: 6 PID: 0 Comm: swapper/6 Not tainted 5.12.0-20210330.rc4.git0.9d49ed9ca93b.300.fc33.s390x+next #1
>>> [ 1506.494834] Hardware name: IBM 8561 T01 703 (LPAR)
>>> [ 1506.494836] Krnl PSW : 0704c00180000000 00000002d71dd21e (percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8)
>>> [ 1506.494840]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
>>> [ 1506.494842] Krnl GPRS: c0000000fffeffff 00000002f7256818 0000000000000043 00000000fffeffff
>>> [ 1506.494844]            00000000ffffffea 0000038000000001 0000000000000000 000003800000017c
>>> [ 1506.494846]            00000002d7924988 0000000227eb97a0 000003ff5413c7e0 7fffffffffffffff
>>> [ 1506.494848]            0000000080360000 00000002f726b570 00000002d71dd21a 00000380000bba28
>>> [ 1506.494856] Krnl Code: 00000002d71dd20e: e3309fe8ff04        lg      %r3,-24(%r9)
>>>                             00000002d71dd214: c0e5001eb556        brasl   %r14,00000002d75b3cc0
>>>                            #00000002d71dd21a: af000000            mc      0,0
>>>                            >00000002d71dd21e: a7f4ffcc            brc     15,00000002d71dd1b6
>>>                             00000002d71dd222: 0707                bcr     0,%r7
>>>                             00000002d71dd224: 0707                bcr     0,%r7
>>>                             00000002d71dd226: 0707                bcr     0,%r7
>>>                             00000002d71dd228: eb6ff0480024        stmg    %r6,%r15,72(%r15)
>>> [ 1506.494928] Call Trace:
>>> [ 1506.494933]  [<00000002d71dd21e>] percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8
>>> [ 1506.494940] ([<00000002d71dd21a>] percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8)
>>> [ 1506.494942]  [<00000002d6b8a6c6>] rcu_do_batch+0x146/0x608
>>> [ 1506.494946]  [<00000002d6b8ec04>] rcu_core+0x124/0x1d0
>>> [ 1506.494948]  [<00000002d75d0222>] __do_softirq+0x13a/0x3c8
>>> [ 1506.494952]  [<00000002d6b05306>] irq_exit+0xce/0xf8
>>> [ 1506.494955]  [<00000002d75c1eb4>] do_ext_irq+0xdc/0x170
>>> [ 1506.494957]  [<00000002d75cdea4>] ext_int_handler+0xc4/0xf4
>>> [ 1506.494959]  [<0000000000000000>] 0x0
>>> [ 1506.494963]  [<00000002d75cd9c2>] default_idle_call+0x42/0x110
>>> [ 1506.494965]  [<00000002d6b411a0>] do_idle+0xd8/0x168
>>> [ 1506.494968]  [<00000002d6b413ee>] cpu_startup_entry+0x36/0x40
>>> [ 1506.494971]  [<00000002d6ac730a>] smp_start_secondary+0x82/0x88
>>> [ 1506.494974] Last Breaking-Event-Address:
>>> [ 1506.494975]  [<00000002d6b71898>] vprintk_emit+0xa8/0x110
>>> [ 1506.494978] Kernel panic - not syncing: panic_on_warn set ...
>>>
>>>
>>>
>>> I will try to bisect this, but if anyone has an idea. CC some candidates.
>>

[-- Attachment #2: config-bad.gz --]
[-- Type: application/gzip, Size: 20017 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [External] RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-30 15:10       ` Christian Borntraeger
@ 2021-03-30 16:25         ` Muchun Song
  2021-03-31  6:22           ` Christian Borntraeger
  0 siblings, 1 reply; 10+ messages in thread
From: Muchun Song @ 2021-03-30 16:25 UTC (permalink / raw)
  To: Christian Borntraeger
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

On Tue, Mar 30, 2021 at 11:10 PM Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
>
> On 30.03.21 15:49, Muchun Song wrote:
> > On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
> > <borntraeger@de.ibm.com> wrote:
> >>
> >> So bisect shows this for belows warning:
> >
> > Thanks for your effort on this. Can you share your config?
>
> attached (but its s390x) for next-20210330

Thanks. Can you apply the following patch and help me test?
Very Thanks.

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 7fdc92e1983e..579408e4d46f 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -793,6 +793,12 @@ static inline void obj_cgroup_get(struct obj_cgroup *objcg)
        percpu_ref_get(&objcg->refcnt);
 }

+static inline void obj_cgroup_get_many(struct obj_cgroup *objcg,
+                                      unsigned long nr)
+{
+       percpu_ref_get_many(&objcg->refcnt, nr);
+}
+
 static inline void obj_cgroup_put(struct obj_cgroup *objcg)
 {
        percpu_ref_put(&objcg->refcnt);
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c0b83a396299..1634dba1044c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3133,7 +3133,10 @@ void split_page_memcg(struct page *head, unsigned int nr)

        for (i = 1; i < nr; i++)
                head[i].memcg_data = head->memcg_data;
-       css_get_many(&memcg->css, nr - 1);
+       if (PageMemcgKmem(head))
+               obj_cgroup_get_many(__page_objcg(head), nr - 1);
+       else
+               css_get_many(&memcg->css, nr - 1);
 }

 #ifdef CONFIG_MEMCG_SWAP

>
> The problem goes away when I add
> cgroup_controllers = [  ]
> to /etc/libvirt/qemu.conf
>
> The testcase that triggers the problem starts and stops multipe KVM guests with 248 CPUs.
> Do we happen to have maybe only a byte of refcount space?
>
>
> >
> >>
> >> 636c3ef8229ecb4e7d045e86f36505d24a8f019a is the first bad commit
> >> commit 636c3ef8229ecb4e7d045e86f36505d24a8f019a
> >> Author: Muchun Song <songmuchun@bytedance.com>
> >> Date:   Mon Mar 29 11:12:06 2021 +1100
> >>
> >>       mm: memcontrol: use obj_cgroup APIs to charge kmem pages
> >>
> >>       Since Roman's series "The new cgroup slab memory controller" applied.  All
> >>       slab objects are charged via the new APIs of obj_cgroup.  The new APIs
> >>       introduce a struct obj_cgroup to charge slab objects.  It prevents
> >>       long-living objects from pinning the original memory cgroup in the memory.
> >>       But there are still some corner objects (e.g.  allocations larger than
> >>       order-1 page on SLUB) which are not charged via the new APIs.  Those
> >>       objects (include the pages which are allocated from buddy allocator
> >>       directly) are charged as kmem pages which still hold a reference to the
> >>       memory cgroup.
> >>
> >>       We want to reuse the obj_cgroup APIs to charge the kmem pages.  If we do
> >>       that, we should store an object cgroup pointer to page->memcg_data for the
> >>       kmem pages.
> >>
> >>       Finally, page->memcg_data will have 3 different meanings.
> >>
> >>         1) For the slab pages, page->memcg_data points to an object cgroups
> >>            vector.
> >>
> >>         2) For the kmem pages (exclude the slab pages), page->memcg_data
> >>            points to an object cgroup.
> >>
> >>         3) For the user pages (e.g. the LRU pages), page->memcg_data points
> >>            to a memory cgroup.
> >>
> >>       We do not change the behavior of page_memcg() and page_memcg_rcu().  They
> >>       are also suitable for LRU pages and kmem pages.  Why?
> >>
> >>       Because memory allocations pinning memcgs for a long time - it exists at a
> >>       larger scale and is causing recurring problems in the real world: page
> >>       cache doesn't get reclaimed for a long time, or is used by the second,
> >>       third, fourth, ...  instance of the same job that was restarted into a new
> >>       cgroup every time.  Unreclaimable dying cgroups pile up, waste memory, and
> >>       make page reclaim very inefficient.
> >>
> >>       We can convert LRU pages and most other raw memcg pins to the objcg
> >>       direction to fix this problem, and then the page->memcg will always point
> >>       to an object cgroup pointer.  At that time, LRU pages and kmem pages will
> >>       be treated the same.  The implementation of page_memcg() will remove the
> >>       kmem page check.
> >>
> >>       This patch aims to charge the kmem pages by using the new APIs of
> >>       obj_cgroup.  Finally, the page->memcg_data of the kmem page points to an
> >>       object cgroup.  We can use the __page_objcg() to get the object cgroup
> >>       associated with a kmem page.  Or we can use page_memcg() to get the memory
> >>       cgroup associated with a kmem page, but caller must ensure that the
> >>       returned memcg won't be released (e.g.  acquire the rcu_read_lock or
> >>       css_set_lock).
> >>
> >>       Link: https://lkml.kernel.org/r/20210319163821.20704-6-songmuchun@bytedance.com
> >>       Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> >>       Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >>       Cc: Michal Hocko <mhocko@kernel.org>
> >>       Cc: Roman Gushchin <guro@fb.com>
> >>       Cc: Shakeel Butt <shakeelb@google.com>
> >>       Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> >>       Cc: Xiongchun Duan <duanxiongchun@bytedance.com>
> >>       Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >>       Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >>
> >>    include/linux/memcontrol.h | 116 +++++++++++++++++++++++++++++++++++----------
> >>    mm/memcontrol.c            | 110 +++++++++++++++++++++---------------------
> >>    2 files changed, 145 insertions(+), 81 deletions(-)
> >>
> >>
> >>
> >>
> >>
> >> On 30.03.21 13:32, Christian Borntraeger wrote:
> >> [...]
> >>>
> >>> This next (328 is fine) triggers several bugs during our KVM CI run:
> >>>
> >>> [ 1506.494716] ------------[ cut here ]------------
> >>> [ 1506.494730] percpu ref (obj_cgroup_release) <= 0 (-1) after switching to atomic
> >>> [ 1506.494766] WARNING: CPU: 6 PID: 0 at lib/percpu-refcount.c:196 percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8
> >>> [ 1506.494774] Modules linked in: kvm vhost_vsock vmw_vsock_virtio_transport_common vsock vhost vhost_iotlb xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT xt_tcpudp nft_compat nf_nat_tftp nft_objref nf_conntrack_tftp nft_counter bridge stp llc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct dm_service_time nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink zfcp scsi_transport_fc rpcrdma sunrpc dm_multipath rdma_ucm scsi_dh_rdac scsi_dh_emc rdma_cm scsi_dh_alua iw_cm ib_cm mlx5_ib ib_uverbs dm_mod ib_core s390_trng vfio_ccw vfio_mdev mdev vfio_iommu_type1 zcrypt_cex4 vfio eadm_sch sch_fq_codel configfs ip_tables x_tables ghash_s390 prng aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 mlx5_core sha512_s390 sha256_s390 sha1_s390 sha_common nvme nvme_core pkey zcrypt rng_core autofs4 [last unloaded: vfio_ap]
> >>> [ 1506.494832] CPU: 6 PID: 0 Comm: swapper/6 Not tainted 5.12.0-20210330.rc4.git0.9d49ed9ca93b.300.fc33.s390x+next #1
> >>> [ 1506.494834] Hardware name: IBM 8561 T01 703 (LPAR)
> >>> [ 1506.494836] Krnl PSW : 0704c00180000000 00000002d71dd21e (percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8)
> >>> [ 1506.494840]            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
> >>> [ 1506.494842] Krnl GPRS: c0000000fffeffff 00000002f7256818 0000000000000043 00000000fffeffff
> >>> [ 1506.494844]            00000000ffffffea 0000038000000001 0000000000000000 000003800000017c
> >>> [ 1506.494846]            00000002d7924988 0000000227eb97a0 000003ff5413c7e0 7fffffffffffffff
> >>> [ 1506.494848]            0000000080360000 00000002f726b570 00000002d71dd21a 00000380000bba28
> >>> [ 1506.494856] Krnl Code: 00000002d71dd20e: e3309fe8ff04        lg      %r3,-24(%r9)
> >>>                             00000002d71dd214: c0e5001eb556        brasl   %r14,00000002d75b3cc0
> >>>                            #00000002d71dd21a: af000000            mc      0,0
> >>>                            >00000002d71dd21e: a7f4ffcc            brc     15,00000002d71dd1b6
> >>>                             00000002d71dd222: 0707                bcr     0,%r7
> >>>                             00000002d71dd224: 0707                bcr     0,%r7
> >>>                             00000002d71dd226: 0707                bcr     0,%r7
> >>>                             00000002d71dd228: eb6ff0480024        stmg    %r6,%r15,72(%r15)
> >>> [ 1506.494928] Call Trace:
> >>> [ 1506.494933]  [<00000002d71dd21e>] percpu_ref_switch_to_atomic_rcu+0x1ee/0x1f8
> >>> [ 1506.494940] ([<00000002d71dd21a>] percpu_ref_switch_to_atomic_rcu+0x1ea/0x1f8)
> >>> [ 1506.494942]  [<00000002d6b8a6c6>] rcu_do_batch+0x146/0x608
> >>> [ 1506.494946]  [<00000002d6b8ec04>] rcu_core+0x124/0x1d0
> >>> [ 1506.494948]  [<00000002d75d0222>] __do_softirq+0x13a/0x3c8
> >>> [ 1506.494952]  [<00000002d6b05306>] irq_exit+0xce/0xf8
> >>> [ 1506.494955]  [<00000002d75c1eb4>] do_ext_irq+0xdc/0x170
> >>> [ 1506.494957]  [<00000002d75cdea4>] ext_int_handler+0xc4/0xf4
> >>> [ 1506.494959]  [<0000000000000000>] 0x0
> >>> [ 1506.494963]  [<00000002d75cd9c2>] default_idle_call+0x42/0x110
> >>> [ 1506.494965]  [<00000002d6b411a0>] do_idle+0xd8/0x168
> >>> [ 1506.494968]  [<00000002d6b413ee>] cpu_startup_entry+0x36/0x40
> >>> [ 1506.494971]  [<00000002d6ac730a>] smp_start_secondary+0x82/0x88
> >>> [ 1506.494974] Last Breaking-Event-Address:
> >>> [ 1506.494975]  [<00000002d6b71898>] vprintk_emit+0xa8/0x110
> >>> [ 1506.494978] Kernel panic - not syncing: panic_on_warn set ...
> >>>
> >>>
> >>>
> >>> I will try to bisect this, but if anyone has an idea. CC some candidates.
> >>

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-30 16:25         ` [External] " Muchun Song
@ 2021-03-31  6:22           ` Christian Borntraeger
  2021-03-31 11:42             ` [External] " Muchun Song
  2021-03-31 14:45             ` Muchun Song
  0 siblings, 2 replies; 10+ messages in thread
From: Christian Borntraeger @ 2021-03-31  6:22 UTC (permalink / raw)
  To: Muchun Song
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan



On 30.03.21 18:25, Muchun Song wrote:
> On Tue, Mar 30, 2021 at 11:10 PM Christian Borntraeger
> <borntraeger@de.ibm.com> wrote:
>>
>>
>> On 30.03.21 15:49, Muchun Song wrote:
>>> On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
>>> <borntraeger@de.ibm.com> wrote:
>>>>
>>>> So bisect shows this for belows warning:
>>>
>>> Thanks for your effort on this. Can you share your config?
>>
>> attached (but its s390x) for next-20210330
> 
> Thanks. Can you apply the following patch and help me test?
> Very Thanks.
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 7fdc92e1983e..579408e4d46f 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -793,6 +793,12 @@ static inline void obj_cgroup_get(struct obj_cgroup *objcg)
>          percpu_ref_get(&objcg->refcnt);
>   }
> 
> +static inline void obj_cgroup_get_many(struct obj_cgroup *objcg,
> +                                      unsigned long nr)
> +{
> +       percpu_ref_get_many(&objcg->refcnt, nr);
> +}
> +
>   static inline void obj_cgroup_put(struct obj_cgroup *objcg)
>   {
>          percpu_ref_put(&objcg->refcnt);
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index c0b83a396299..1634dba1044c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3133,7 +3133,10 @@ void split_page_memcg(struct page *head, unsigned int nr)
> 
>          for (i = 1; i < nr; i++)
>                  head[i].memcg_data = head->memcg_data;
> -       css_get_many(&memcg->css, nr - 1);
> +       if (PageMemcgKmem(head))
> +               obj_cgroup_get_many(__page_objcg(head), nr - 1);
> +       else
> +               css_get_many(&memcg->css, nr - 1);
>   }
> 
>   #ifdef CONFIG_MEMCG_SWAP
> 

This one seems to do the trick, I can no longer see the warning.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [External] RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-31  6:22           ` Christian Borntraeger
@ 2021-03-31 11:42             ` Muchun Song
  2021-03-31 14:45             ` Muchun Song
  1 sibling, 0 replies; 10+ messages in thread
From: Muchun Song @ 2021-03-31 11:42 UTC (permalink / raw)
  To: Christian Borntraeger
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Andrew Morton, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

On Wed, Mar 31, 2021 at 2:22 PM Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
>
>
> On 30.03.21 18:25, Muchun Song wrote:
> > On Tue, Mar 30, 2021 at 11:10 PM Christian Borntraeger
> > <borntraeger@de.ibm.com> wrote:
> >>
> >>
> >> On 30.03.21 15:49, Muchun Song wrote:
> >>> On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
> >>> <borntraeger@de.ibm.com> wrote:
> >>>>
> >>>> So bisect shows this for belows warning:
> >>>
> >>> Thanks for your effort on this. Can you share your config?
> >>
> >> attached (but its s390x) for next-20210330
> >
> > Thanks. Can you apply the following patch and help me test?
> > Very Thanks.
> >
> > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> > index 7fdc92e1983e..579408e4d46f 100644
> > --- a/include/linux/memcontrol.h
> > +++ b/include/linux/memcontrol.h
> > @@ -793,6 +793,12 @@ static inline void obj_cgroup_get(struct obj_cgroup *objcg)
> >          percpu_ref_get(&objcg->refcnt);
> >   }
> >
> > +static inline void obj_cgroup_get_many(struct obj_cgroup *objcg,
> > +                                      unsigned long nr)
> > +{
> > +       percpu_ref_get_many(&objcg->refcnt, nr);
> > +}
> > +
> >   static inline void obj_cgroup_put(struct obj_cgroup *objcg)
> >   {
> >          percpu_ref_put(&objcg->refcnt);
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index c0b83a396299..1634dba1044c 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -3133,7 +3133,10 @@ void split_page_memcg(struct page *head, unsigned int nr)
> >
> >          for (i = 1; i < nr; i++)
> >                  head[i].memcg_data = head->memcg_data;
> > -       css_get_many(&memcg->css, nr - 1);
> > +       if (PageMemcgKmem(head))
> > +               obj_cgroup_get_many(__page_objcg(head), nr - 1);
> > +       else
> > +               css_get_many(&memcg->css, nr - 1);
> >   }
> >
> >   #ifdef CONFIG_MEMCG_SWAP
> >
>
> This one seems to do the trick, I can no longer see the warning.

Thanks for your testing. I will send a fix patch.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [External] RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-31  6:22           ` Christian Borntraeger
  2021-03-31 11:42             ` [External] " Muchun Song
@ 2021-03-31 14:45             ` Muchun Song
  2021-04-01  0:25               ` Andrew Morton
  1 sibling, 1 reply; 10+ messages in thread
From: Muchun Song @ 2021-03-31 14:45 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Christian Borntraeger, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

On Wed, Mar 31, 2021 at 2:22 PM Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
>
>
> On 30.03.21 18:25, Muchun Song wrote:
> > On Tue, Mar 30, 2021 at 11:10 PM Christian Borntraeger
> > <borntraeger@de.ibm.com> wrote:
> >>
> >>
> >> On 30.03.21 15:49, Muchun Song wrote:
> >>> On Tue, Mar 30, 2021 at 9:27 PM Christian Borntraeger
> >>> <borntraeger@de.ibm.com> wrote:
> >>>>
> >>>> So bisect shows this for belows warning:
> >>>
> >>> Thanks for your effort on this. Can you share your config?
> >>
> >> attached (but its s390x) for next-20210330
> >
> > Thanks. Can you apply the following patch and help me test?
> > Very Thanks.
> >
> > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> > index 7fdc92e1983e..579408e4d46f 100644
> > --- a/include/linux/memcontrol.h
> > +++ b/include/linux/memcontrol.h
> > @@ -793,6 +793,12 @@ static inline void obj_cgroup_get(struct obj_cgroup *objcg)
> >          percpu_ref_get(&objcg->refcnt);
> >   }
> >
> > +static inline void obj_cgroup_get_many(struct obj_cgroup *objcg,
> > +                                      unsigned long nr)
> > +{
> > +       percpu_ref_get_many(&objcg->refcnt, nr);
> > +}
> > +
> >   static inline void obj_cgroup_put(struct obj_cgroup *objcg)
> >   {
> >          percpu_ref_put(&objcg->refcnt);
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index c0b83a396299..1634dba1044c 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -3133,7 +3133,10 @@ void split_page_memcg(struct page *head, unsigned int nr)
> >
> >          for (i = 1; i < nr; i++)
> >                  head[i].memcg_data = head->memcg_data;
> > -       css_get_many(&memcg->css, nr - 1);
> > +       if (PageMemcgKmem(head))
> > +               obj_cgroup_get_many(__page_objcg(head), nr - 1);
> > +       else
> > +               css_get_many(&memcg->css, nr - 1);
> >   }
> >
> >   #ifdef CONFIG_MEMCG_SWAP

Hi Andrew,

Now we have two choices to fix this issue.

1) Send a v6 patchset (Use obj_cgroup APIs to charge kmem pages)
    to fix this issue.
2) Send a separate fix patch (Just like above).

Both ways are ok for me. But I want to know which one is more
convenient for you.

Thanks.

> >
>
> This one seems to do the trick, I can no longer see the warning.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [External] RE: kernel warning percpu ref in obj_cgroup_release
  2021-03-31 14:45             ` Muchun Song
@ 2021-04-01  0:25               ` Andrew Morton
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew Morton @ 2021-04-01  0:25 UTC (permalink / raw)
  To: Muchun Song
  Cc: Stephen Rothwell, Linux Next Mailing List, Yang Shi,
	Christian Borntraeger, Linux Kernel Mailing List, linux-s390,
	Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
	Vladimir Davydov, Xiongchun Duan

On Wed, 31 Mar 2021 22:45:12 +0800 Muchun Song <songmuchun@bytedance.com> wrote:

> 
> Hi Andrew,
> 
> Now we have two choices to fix this issue.
> 
> 1) Send a v6 patchset (Use obj_cgroup APIs to charge kmem pages)
>     to fix this issue.
> 2) Send a separate fix patch (Just like above).
> 
> Both ways are ok for me. But I want to know which one is more
> convenient for you.

Either is OK.  2) is easier.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-04-01  0:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  9:52 linux-next: Tree for Mar 29 Stephen Rothwell
2021-03-30 11:32 ` kernel warning percpu ref in obj_cgroup_release (was: Re: linux-next: Tree for Mar 29) Christian Borntraeger
2021-03-30 13:27   ` kernel warning percpu ref in obj_cgroup_release Christian Borntraeger
2021-03-30 13:49     ` [External] " Muchun Song
2021-03-30 15:10       ` Christian Borntraeger
2021-03-30 16:25         ` [External] " Muchun Song
2021-03-31  6:22           ` Christian Borntraeger
2021-03-31 11:42             ` [External] " Muchun Song
2021-03-31 14:45             ` Muchun Song
2021-04-01  0:25               ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).