From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: linux-next: build warning after merge of the thermal tree
Date: Tue, 29 Oct 2019 10:05:15 +0100 [thread overview]
Message-ID: <CAMuHMdUCx31k3VJt=nYSkFXcOQdRhH7FiY8_f5RX4w4zaksP-w@mail.gmail.com> (raw)
In-Reply-To: <20191022102334.67e5d3d1@canb.auug.org.au>
On Tue, Oct 22, 2019 at 1:25 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the thermal tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/thermal/qcom/tsens-common.c:13:
> drivers/thermal/qcom/tsens-common.c: In function 'tsens_set_interrupt':
> include/linux/regmap.h:87:2: warning: 'index' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thermal/qcom/tsens-common.c:183:6: note: 'index' was declared here
> 183 | u32 index;
> | ^~~~~
> In file included from drivers/thermal/qcom/tsens-common.c:13:
> include/linux/regmap.h:87:2: warning: 'index_clear' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thermal/qcom/tsens-common.c:199:18: note: 'index_clear' was declared here
> 199 | u32 index_mask, index_clear;
> | ^~~~~~~~~~~
> drivers/thermal/qcom/tsens-common.c:199:6: warning: 'index_mask' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 199 | u32 index_mask, index_clear;
> | ^~~~~~~~~~
>
> Introduced by commit
>
> fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
And kisskb reported the following link failure on m68k:
ERROR: "__udivdi3" [drivers/thermal/qcom/qcom_tsens.ko] undefined!
Probably caused by a plain 64-bit division in the code.
I expect this shows up on other 32-bit platforms, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-10-29 9:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 23:23 linux-next: build warning after merge of the thermal tree Stephen Rothwell
2019-10-22 9:50 ` Amit Kucheria
2019-10-22 11:18 ` Stephen Rothwell
2019-10-24 7:26 ` Amit Kucheria
2019-10-29 9:05 ` Geert Uytterhoeven [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-27 0:34 Stephen Rothwell
2020-03-02 23:42 Stephen Rothwell
2020-03-03 0:17 ` Daniel Lezcano
2019-04-30 3:48 Stephen Rothwell
2017-09-01 0:52 Stephen Rothwell
2016-08-24 3:38 Stephen Rothwell
2016-08-24 7:56 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUCx31k3VJt=nYSkFXcOQdRhH7FiY8_f5RX4w4zaksP-w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).