From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: Kent Overstreet <kmo@daterainc.com>, Neil Brown <neilb@suse.de>,
linux-bcache@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH -next 2/2] bcache: Use max_t() when comparing different types
Date: Thu, 6 Feb 2014 10:00:35 +0100 [thread overview]
Message-ID: <CAMuHMdVDdGBG0b2BY4PZRGWn-2ts-qz9_OdUdnAE9gMp_zP3jw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdUv_xP-1A950i0U=Petaey-_VosSxh5sk44Gqti-ikY6w@mail.gmail.com>
On Mon, Feb 3, 2014 at 2:47 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Jan 15, 2014 at 12:06 PM, Joe Perches <joe@perches.com> wrote:
>> On Wed, 2014-01-15 at 10:06 +0100, Geert Uytterhoeven wrote:
>>> drivers/md/bcache/btree.c: In function ‘insert_u64s_remaining’:
>>> drivers/md/bcache/btree.c:1816: warning: comparison of distinct pointer types lacks a cast
>> []
>>> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
>> []
>>> @@ -1813,7 +1813,7 @@ static size_t insert_u64s_remaining(struct btree *b)
>>> if (b->keys.ops->is_extents)
>>> ret -= KEY_MAX_U64S;
>>>
>>> - return max(ret, 0L);
>>> + return max_t(ssize_t, ret, 0L);
>>
>> why not
>> return max(ret, 0);
>
> Indeed, that also works, on both 32-bit and 64-bit.
> Will resend, now all the issues moved from -next to Linus' tree.
However, sparse doesn't like it, so we'll have to go for v1?
From kbuild test robot fengguang.wu@intel.com:
>> drivers/md/bcache/btree.c:1816:16: sparse: incompatible types in comparison expression (different type sizes)
In file included from arch/x86/include/asm/percpu.h:44:0,
from arch/x86/include/asm/preempt.h:5,
from include/linux/preempt.h:18,
from include/linux/spinlock.h:50,
from include/linux/wait.h:8,
from include/linux/fs.h:6,
from include/linux/highmem.h:4,
from include/linux/bio.h:23,
from drivers/md/bcache/bcache.h:181,
from drivers/md/bcache/btree.c:23:
drivers/md/bcache/btree.c: In function 'insert_u64s_remaining':
include/linux/kernel.h:718:17: warning: comparison of distinct
pointer types lacks a cast [enabled by default]
(void) (&_max1 == &_max2); \
^
drivers/md/bcache/btree.c:1816:9: note: in expansion of macro 'max'
return max(ret, 0);
^
vim +1816 drivers/md/bcache/btree.c
1800 status);
1801 return true;
1802 } else
1803 return false;
1804 }
1805
1806 static size_t insert_u64s_remaining(struct btree *b)
1807 {
1808 ssize_t ret = bch_btree_keys_u64s_remaining(&b->keys);
1809
1810 /*
1811 * Might land in the middle of an existing extent and
have to split it
1812 */
1813 if (b->keys.ops->is_extents)
1814 ret -= KEY_MAX_U64S;
1815
> 1816 return max(ret, 0);
1817 }
1818
1819 static bool bch_btree_insert_keys(struct btree *b, struct btree_op *op,
1820 struct keylist *insert_keys,
1821 struct bkey *replace_key)
1822 {
1823 bool ret = false;
1824 int oldsize = bch_count_data(&b->keys);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-02-06 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 9:06 [PATCH -next 1/2] bcache: Use %zi to format size_t Geert Uytterhoeven
2014-01-15 9:06 ` [PATCH -next 2/2] bcache: Use max_t() when comparing different types Geert Uytterhoeven
2014-01-15 11:06 ` Joe Perches
2014-02-03 13:47 ` Geert Uytterhoeven
2014-02-06 9:00 ` Geert Uytterhoeven [this message]
2014-02-06 9:06 ` Joe Perches
2014-02-06 20:38 ` Andrew Morton
2014-02-06 20:45 ` Geert Uytterhoeven
2014-02-06 20:50 ` Andrew Morton
2014-02-06 20:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVDdGBG0b2BY4PZRGWn-2ts-qz9_OdUdnAE9gMp_zP3jw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).