From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] mm: cma: Discard clean pages during contiguous allocation instead of migration Date: Thu, 13 Sep 2012 21:17:19 +0200 Message-ID: References: <1347324112-14134-1-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-vb0-f46.google.com ([209.85.212.46]:44366 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783Ab2IMTRV (ORCPT ); Thu, 13 Sep 2012 15:17:21 -0400 In-Reply-To: <1347324112-14134-1-git-send-email-minchan@kernel.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kyungmin Park , Marek Szyprowski , Michal Nazarewicz , Rik van Riel , Mel Gorman , Linux-Next On Tue, Sep 11, 2012 at 2:41 AM, Minchan Kim wrote: > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -674,8 +674,10 @@ static enum page_references page_check_references(struct page *page, > static unsigned long shrink_page_list(struct list_head *page_list, > struct zone *zone, > struct scan_control *sc, > + enum ttu_flags ttu_flags, "enum ttu_flags" is defined on CONFIG_MMU=y only, causing on nommu: mm/vmscan.c:677:26: error: parameter 4 ('ttu_flags') has incomplete type mm/vmscan.c:987:5: error: 'TTU_UNMAP' undeclared (first use in this function) mm/vmscan.c:987:15: error: 'TTU_IGNORE_ACCESS' undeclared (first use in this function) mm/vmscan.c:1312:56: error: 'TTU_UNMAP' undeclared (first use in this function) E.g. http://kisskb.ellerman.id.au/kisskb/buildresult/7191694/ (h8300-defconfig) http://kisskb.ellerman.id.au/kisskb/buildresult/7191858/ (sh-allnoconfig) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds