From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Wolfgang Rohdewald <wolfgang@rohdewald.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: linux-next: Tree for Nov 2 (compiler-gcc.h)
Date: Sat, 3 Nov 2018 23:58:24 +0100 [thread overview]
Message-ID: <CANiq72mqO36FotJ6pHQpAB18DLEYV+kSL64Sc+A6yoqDu47bAg@mail.gmail.com> (raw)
In-Reply-To: <6ecaed34-eb66-24ed-e6c7-e33f9583be5e@infradead.org>
On Sat, Nov 3, 2018 at 5:10 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> No plugins are enabled.
> The failing randconfig file (for x86_64) is attached.
Confirmed with a built-from-sources 4.8.5 on current master
(d2ff0ff2c23f). The ICE also happens with 4.6.4. With 8.1.0, however,
we get an error instead:
In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:
drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
./drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak
declaration of 'stb0899_attach' being applied to a already existing,
static definition
static inline struct dvb_frontend *stb0899_attach(struct
stb0899_config *config,
^~~~~~~~~~~~~~
Which seems to have been spotted by kbuild months ago:
https://lkml.org/lkml/2018/3/10/358
The problem is in pctv452e_frontend_attach():
/*
* dvb_frontend will call dvb_detach for both stb0899_detach
* and stb0899_release but we only do dvb_attach(stb0899_attach).
* Increment the module refcount instead.
*/
symbol_get(stb0899_attach);
Here symbol_get() is declaring a weak function (due to
!CONFIG_MODULES) while this definition in stb0899_drv.h occurs (due to
!CONFIG_DVB_STB0899):
static inline struct dvb_frontend *stb0899_attach(struct stb0899_config *config,
struct i2c_adapter *i2c)
{
printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
return NULL;
}
I guess pctv452e should require CONFIG_DVB_STB0899, or similar. CC'ing
Mauro, Wolfgang, linux-media.
Hope that helps!
Cheers,
Miguel
next prev parent reply other threads:[~2018-11-03 22:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 3:30 linux-next: Tree for Nov 2 Stephen Rothwell
2018-11-02 10:44 ` Miguel Ojeda
2018-11-02 13:22 ` Stephen Rothwell
2018-11-02 13:57 ` Miguel Ojeda
2018-11-02 15:56 ` linux-next: Tree for Nov 2 (compiler-gcc.h) Randy Dunlap
2018-11-03 12:43 ` Miguel Ojeda
2018-11-03 16:10 ` Randy Dunlap
2018-11-03 22:58 ` Miguel Ojeda [this message]
2018-11-03 23:00 ` Randy Dunlap
2018-11-03 23:04 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72mqO36FotJ6pHQpAB18DLEYV+kSL64Sc+A6yoqDu47bAg@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=wolfgang@rohdewald.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).