From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF756C35DEE for ; Thu, 27 Feb 2020 17:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7B7C246A0 for ; Thu, 27 Feb 2020 17:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GFeWkNfA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729618AbgB0RNy (ORCPT ); Thu, 27 Feb 2020 12:13:54 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38621 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgB0RNx (ORCPT ); Thu, 27 Feb 2020 12:13:53 -0500 Received: by mail-wm1-f65.google.com with SMTP id a9so154729wmj.3 for ; Thu, 27 Feb 2020 09:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kRFodb2ms+/Ze84f7ezZLQgjnfHyEqMYKFplavQU274=; b=GFeWkNfAeFE1PGxbru1Sszjp4401EcQ+VWatx1HlhLSe4ix2kBEeJ41isVFUKdvpXf Qc5kYZCEp5CrqbH2wU0Qhzq6BBm0MsrxtA1EhRqOY10IY+N0Ssefg+CyCKkeVgOxbVtJ VqrKS2fJ06pY/5Sv/021+h54fqqCO7WwOsbDXrzZM6ejGQFYRK9CB/0onzt0KnP0Xyfg aUljwm5ng9jv7V1otJqoMYEdb76PfawPqdgV1TdgZBlgEaSieGAjel1n29ALB1XcT4Pt BpUBteZTDViUBBZD7Kua27z1UaRzJmAA2J1aKm3e0dVywvpTUP0Eqbex73loF8rZA4x2 wDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kRFodb2ms+/Ze84f7ezZLQgjnfHyEqMYKFplavQU274=; b=AqfhnlrRHdR/4BfFo5u3krRbYsgfDrd8DnfUhFIT1WVTCcoTtNhJgx50o2YKxWtEeC bW4iC+v5yPghKPweM0GlTOjXxPuwiaWk5n7LqhQ+uf+cnmUPgCibkxsDaFCgPmoffasg L80hYF9DrI8DrFu+RtaucfYOva76k7Sh9l7T8/ouCxV1O9rZyPoZq68YywOxDGIYyVlX FDUq/Cyzm5tsvTafe0IbdVKwf1QvREc1ZkxAABvfwdnD9TXWNG7J9wLzEC5BzRm9Sw4k Rtjom1QFBgKW8RZ2jpwPiv0DkmgSrW8b7T5PRVxndsyklAxj8LIkAnc5FQLh7SmVkduT 5L3Q== X-Gm-Message-State: APjAAAWmhSaa86HuBRBK1X9vucWsYRdFeiACQFn3+AcfzxvasI9i12eq qFROgcoqa+4HRf8atL5g8fAqKO7G68ifr34DiIfj8w== X-Google-Smtp-Source: APXvYqzFW1PtGlKB8R/X9OvHP+SCq22XUNfUC5pbpz3qORBFSTYYYtRqiPKMJqj1H+J2yo2wzf6sS/WyUUnY2nIBPpI= X-Received: by 2002:a1c:2358:: with SMTP id j85mr510453wmj.137.1582823629861; Thu, 27 Feb 2020 09:13:49 -0800 (PST) MIME-Version: 1.0 References: <20200227151143.6a6edaf9@canb.auug.org.au> In-Reply-To: From: Arjun Roy Date: Thu, 27 Feb 2020 09:13:38 -0800 Message-ID: Subject: Re: linux-next: build failure after merge of the akpm tree To: Geert Uytterhoeven Cc: Stephen Rothwell , Andrew Morton , Linux Next Mailing List , Linux Kernel Mailing List , David Miller Content-Type: text/plain; charset="UTF-8" Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Feb 27, 2020 at 1:03 AM Geert Uytterhoeven wrote: > > Hi Stephen et al, > > On Thu, Feb 27, 2020 at 5:12 AM Stephen Rothwell wrote: > > After merging the akpm tree, today's linux-next build (sparc defconfig) > > failed like this: > > > > In file included from include/linux/list.h:9:0, > > from include/linux/smp.h:12, > > from include/linux/kernel_stat.h:5, > > from mm/memory.c:42: > > mm/memory.c: In function 'insert_pages': > > mm/memory.c:1523:41: error: implicit declaration of function 'pte_index'; did you mean 'page_index'? [-Werror=implicit-function-declaration] > > remaining_pages_total, PTRS_PER_PTE - pte_index(addr)); > > ^ > > include/linux/kernel.h:842:40: note: in definition of macro '__typecheck' > > (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) > > ^ > > include/linux/kernel.h:866:24: note: in expansion of macro '__safe_cmp' > > __builtin_choose_expr(__safe_cmp(x, y), \ > > ^~~~~~~~~~ > > include/linux/kernel.h:934:27: note: in expansion of macro '__careful_cmp' > > #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) > > ^~~~~~~~~~~~~ > > mm/memory.c:1522:26: note: in expansion of macro 'min_t' > > pages_to_write_in_pmd = min_t(unsigned long, > > ^~~~~ > > Same issue on m68k, as per a report from kisskb. > > > Caused by patch > > > > "mm/memory.c: add vm_insert_pages()" > > > > sparc32 does not implement pte_index at all :-( > > Seems like about only half of the architectures do. > :/ I begin to suspect the only sane way to make this work is to have a per-arch header defined method, returning a bool saying whether pte_index() is meaningful or not on that arch, and early on in vm_insert_pages() if that bool returns true, to just call vm_insert_page() in a loop. -Arjun > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds