From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCHv2 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Date: Tue, 9 Sep 2014 14:19:07 -0300 Message-ID: References: <20140909124306.2d5a0d76@canb.auug.org.au> <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab@samsung.com> <540F15B2.3000902@samsung.com> <20140909120936.527bd852.m.chehab@samsung.com> <540F1D11.9030400@samsung.com> <20140909131036.7265121f.m.chehab@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-lb0-f171.google.com ([209.85.217.171]:65485 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151AbaIIRTJ (ORCPT ); Tue, 9 Sep 2014 13:19:09 -0400 In-Reply-To: <20140909131036.7265121f.m.chehab@samsung.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Mauro Carvalho Chehab Cc: Sylwester Nawrocki , Jacek Anaszewski , Linux Media Mailing List , Mauro Carvalho Chehab , Kukjin Kim , Kamil Debski , Kyungmin Park , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-next@vger.kernel.org" , linux-kernel , Stephen Rothwell On Tue, Sep 9, 2014 at 1:10 PM, Mauro Carvalho Chehab wrote: > ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] undefined! > > That happens because asm-generic doesn't like any ndelay time > bigger than 20us. > > Currently, usleep_range() couldn't simply be used, since > exynos4_jpeg_sw_reset() is called with a spinlock held. > > So, let's use ndelay() instead. You meant 'udelay() instead'.