linux-next: build warning after merge of the mmc tree

linux-next: build warning after merge of the mmc tree

[Stephen Rothwell]

Hi Ulf,

After merging the mmc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/irqflags.h:14:0,
                 from arch/arm/include/asm/bitops.h:27,
                 from include/linux/bitops.h:37,
                 from include/linux/kernel.h:10,
                 from include/asm-generic/bug.h:15,
                 from arch/arm/include/asm/bug.h:59,
                 from include/linux/bug.h:4,
                 from include/linux/thread_info.h:11,
                 from include/asm-generic/current.h:4,
                 from ./arch/arm/include/generated/asm/current.h:1,
                 from include/linux/sched.h:11,
                 from include/linux/blkdev.h:4,
                 from drivers/mmc/host/dw_mmc.c:14:
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_drto':
include/linux/typecheck.h:11:18: warning: comparison of distinct pointer types lacks a cast
  (void)(&__dummy == &__dummy2); \
                  ^
include/linux/spinlock.h:221:3: note: in expansion of macro 'typecheck'
   typecheck(unsigned long, flags); \
   ^
include/linux/spinlock.h:346:2: note: in expansion of macro 'raw_spin_lock_irqsave'
  raw_spin_lock_irqsave(spinlock_check(lock), flags); \
  ^
drivers/mmc/host/dw_mmc.c:1953:2: note: in expansion of macro 'spin_lock_irqsave'
  spin_lock_irqsave(&host->irq_lock, irqflags);
  ^

Introduced by commit

  80a2a5a7745b ("mmc: dw_mmc: Cleanup the DTO timer like the CTO one")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the mmc tree

[Doug Anderson]

Hi,

On Wed, Nov 1, 2017 at 6:36 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Ulf,
>
> After merging the mmc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/irqflags.h:14:0,
>                  from arch/arm/include/asm/bitops.h:27,
>                  from include/linux/bitops.h:37,
>                  from include/linux/kernel.h:10,
>                  from include/asm-generic/bug.h:15,
>                  from arch/arm/include/asm/bug.h:59,
>                  from include/linux/bug.h:4,
>                  from include/linux/thread_info.h:11,
>                  from include/asm-generic/current.h:4,
>                  from ./arch/arm/include/generated/asm/current.h:1,
>                  from include/linux/sched.h:11,
>                  from include/linux/blkdev.h:4,
>                  from drivers/mmc/host/dw_mmc.c:14:
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_drto':
> include/linux/typecheck.h:11:18: warning: comparison of distinct pointer types lacks a cast
>   (void)(&__dummy == &__dummy2); \
>                   ^
> include/linux/spinlock.h:221:3: note: in expansion of macro 'typecheck'
>    typecheck(unsigned long, flags); \
>    ^
> include/linux/spinlock.h:346:2: note: in expansion of macro 'raw_spin_lock_irqsave'
>   raw_spin_lock_irqsave(spinlock_check(lock), flags); \
>   ^
> drivers/mmc/host/dw_mmc.c:1953:2: note: in expansion of macro 'spin_lock_irqsave'
>   spin_lock_irqsave(&host->irq_lock, irqflags);
>   ^
>
> Introduced by commit
>
>   80a2a5a7745b ("mmc: dw_mmc: Cleanup the DTO timer like the CTO one")

Yes, the 0-day bot already complained about this.  The short answer is
that Ulf kindly volunteered to manually fix up my patch series where I
had introduced a variable in the wrong patch.  ...but in doing so he
introduced a small bug.

It should be very easy to fix.  Just need to change irqflags from
"unsigned int" to "unsigned long".


-Doug

Re: linux-next: build warning after merge of the mmc tree

[Ulf Hansson]

On 2 November 2017 at 02:47, Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Wed, Nov 1, 2017 at 6:36 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi Ulf,
>>
>> After merging the mmc tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> In file included from include/linux/irqflags.h:14:0,
>>                  from arch/arm/include/asm/bitops.h:27,
>>                  from include/linux/bitops.h:37,
>>                  from include/linux/kernel.h:10,
>>                  from include/asm-generic/bug.h:15,
>>                  from arch/arm/include/asm/bug.h:59,
>>                  from include/linux/bug.h:4,
>>                  from include/linux/thread_info.h:11,
>>                  from include/asm-generic/current.h:4,
>>                  from ./arch/arm/include/generated/asm/current.h:1,
>>                  from include/linux/sched.h:11,
>>                  from include/linux/blkdev.h:4,
>>                  from drivers/mmc/host/dw_mmc.c:14:
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_drto':
>> include/linux/typecheck.h:11:18: warning: comparison of distinct pointer types lacks a cast
>>   (void)(&__dummy == &__dummy2); \
>>                   ^
>> include/linux/spinlock.h:221:3: note: in expansion of macro 'typecheck'
>>    typecheck(unsigned long, flags); \
>>    ^
>> include/linux/spinlock.h:346:2: note: in expansion of macro 'raw_spin_lock_irqsave'
>>   raw_spin_lock_irqsave(spinlock_check(lock), flags); \
>>   ^
>> drivers/mmc/host/dw_mmc.c:1953:2: note: in expansion of macro 'spin_lock_irqsave'
>>   spin_lock_irqsave(&host->irq_lock, irqflags);
>>   ^
>>
>> Introduced by commit
>>
>>   80a2a5a7745b ("mmc: dw_mmc: Cleanup the DTO timer like the CTO one")
>
> Yes, the 0-day bot already complained about this.  The short answer is
> that Ulf kindly volunteered to manually fix up my patch series where I
> had introduced a variable in the wrong patch.  ...but in doing so he
> introduced a small bug.
>
> It should be very easy to fix.  Just need to change irqflags from
> "unsigned int" to "unsigned long".

Yes, problem fixed!

Kind regards
Uffe

linux-next: build warning after merge of the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi all,

After merging the mmc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mmc/host/dw_mmc.c: In function 'dw_mci_wait_hw_unbusy':
drivers/mmc/host/dw_mmc.c:239:16: warning: unused variable 'irqflags' [-Wunused-variable]
  unsigned long irqflags;
                ^~~~~~~~

Introduced by commit

  705a0f288113 ("mmc: dw_mmc: Add hardware unbusy interrupt support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

After merging the mmc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mmc/core/block.c: In function '__mmc_blk_ioctl_cmd':
drivers/mmc/core/block.c:500:6: warning: unused variable 'status' [-Wunused-variable]
  500 |  u32 status = 0;
      |      ^~~~~~

Introduced by commit

  05224f7e4975 ("mmc: block: Add CMD13 polling for MMC IOCTLS with R1B response")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the mmc tree

[Ulf Hansson]

On Tue, 22 Oct 2019 at 02:47, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mmc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/mmc/core/block.c: In function '__mmc_blk_ioctl_cmd':
> drivers/mmc/core/block.c:500:6: warning: unused variable 'status' [-Wunused-variable]
>   500 |  u32 status = 0;
>       |      ^~~~~~
>
> Introduced by commit
>
>   05224f7e4975 ("mmc: block: Add CMD13 polling for MMC IOCTLS with R1B response")
>
> --
> Cheers,
> Stephen Rothwell

Thanks for the report. I have amended the patch to address the warning.

Kind regards
Uffe

linux-next: build warning after merge of the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi all,

After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/mmc_hsq.o
see include/linux/module.h for more information

Introduced by commit

  eb1814dd49d5 ("mmc: Add MMC host software queue support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the mmc tree

[Baolin Wang]

Hi Stephen,

On Thu, Feb 20, 2020 at 7:31 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/mmc_hsq.o
> see include/linux/module.h for more information

I am sorry I missed this warning before, and I've sent out a patch to
fix this warning[1]. Thanks for reporting.

[1] https://lore.kernel.org/patchwork/patch/1196938/

linux-next: build warning after merge of the mmc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi all,

After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/mmc/core/pwrseq_sd8787.c: In function 'mmc_pwrseq_sd8787_probe':
drivers/mmc/core/pwrseq_sd8787.c:77:34: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   77 |  pwrseq->reset_pwrdwn_delay_ms = (u32)match->data;
      |                                  ^

Introduced by commit

  b2832b96fcf5 ("mmc: pwrseq: sd8787: add support for wilc1000")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]