From: Mike Turquette <mturquette@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: build failure after merge of the clk tree
Date: Thu, 26 Feb 2015 16:01:24 -0800 [thread overview]
Message-ID: <CAPtuhTgR-T-45QUuUfU_rCqR_yExbuQF-YQDCpVKeB4vyh9h7Q@mail.gmail.com> (raw)
In-Reply-To: <1424941761.27971.2.camel@AMDC1943>
On Thu, Feb 26, 2015 at 1:09 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On czw, 2015-02-26 at 13:14 +1100, Stephen Rothwell wrote:
>> Hi Mike,
>>
>> After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> drivers/clk/clk.c: In function 'clk_disable_unused_subtree':
>> drivers/clk/clk.c:514:3: error: label 'out' used but not defined
>> goto out;
>> ^
>>
>> Caused by commit a2146f032294 ("clk: Use lockdep asserts to find
>> missing hold of prepare_lock"). Commit c440525cb967 ("clk: Remove
>> unneeded NULL checks") removed that label along with the NULL check
>> that a2146f032294 reintroduces (was this a bad rebase?). Please do
>> simple build tests.
>>
>> I have used the clk tree from next-20150225 for today.
>
> Mike,
>
> It seems that my patch did not applied cleanly and the merge introduced
> such artifacts. My patch adds only lockdep_asserts and does not
> influence the program flow. I can rebase and resend the patch if you
> wish.
It's OK. I fixed it up locally the same day that I applied it but
didn't push the change out to my mirror in time to catch -next. It
will be fixed the next time Stephen pulls the clk tree.
Regards,
Mike
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2015-02-27 0:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 2:14 linux-next: build failure after merge of the clk tree Stephen Rothwell
2015-02-26 9:09 ` Krzysztof Kozlowski
2015-02-27 0:01 ` Mike Turquette [this message]
2015-02-27 0:06 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-01-03 23:04 Stephen Rothwell
2024-01-04 0:59 ` Stephen Boyd
2023-04-02 23:59 Stephen Rothwell
2023-04-05 0:28 ` Stephen Rothwell
2020-05-11 0:55 Stephen Rothwell
2020-05-13 3:20 ` Stephen Boyd
2020-05-13 3:28 ` Stephen Boyd
2020-01-07 21:47 Stephen Rothwell
2019-07-02 0:01 Stephen Rothwell
2019-07-02 1:14 ` Stephen Rothwell
2019-07-02 2:03 ` Stephen Rothwell
2019-07-05 1:24 ` Stephen Rothwell
2019-07-12 17:53 ` Stephen Boyd
2019-05-02 23:25 Stephen Rothwell
2019-05-03 15:55 ` Stephen Boyd
2018-11-29 22:03 Stephen Rothwell
2018-01-01 21:51 Stephen Rothwell
2018-01-02 19:58 ` Stephen Boyd
2017-12-10 23:16 Stephen Rothwell
2017-12-14 0:57 ` Stephen Boyd
2017-06-05 0:14 Stephen Rothwell
2015-08-12 7:19 Stephen Rothwell
2015-08-12 7:45 ` Geert Uytterhoeven
2015-08-12 8:23 ` Stephen Boyd
2015-08-12 8:03 ` Stephen Boyd
2015-07-27 4:11 Stephen Rothwell
2015-08-03 10:08 ` Tony Lindgren
2015-08-07 23:56 ` Stephen Boyd
2015-08-13 11:04 ` Olof Johansson
2015-02-27 3:08 Stephen Rothwell
2015-02-27 17:42 ` Stephen Boyd
2015-03-04 9:56 ` Geert Uytterhoeven
2015-03-05 0:15 ` Mike Turquette
2014-12-16 3:45 Stephen Rothwell
[not found] ` <20141216072034.29014.12434@quantum>
2014-12-17 3:47 ` Stephen Rothwell
2014-01-29 3:32 Stephen Rothwell
2014-01-29 10:02 ` Sebastian Hesselbarth
2013-04-15 5:04 Stephen Rothwell
2013-04-15 7:03 ` Sebastian Hesselbarth
2013-04-16 0:42 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPtuhTgR-T-45QUuUfU_rCqR_yExbuQF-YQDCpVKeB4vyh9h7Q@mail.gmail.com \
--to=mturquette@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).