From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hefty, Sean" Subject: [PATCH] rdma/addr: Initialize ret to fix build warning Date: Thu, 17 Mar 2011 16:35:39 -0700 Message-ID: References: <20110318100418.6556c92c.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mga02.intel.com ([134.134.136.20]:16188 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816Ab1CQXfm convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2011 19:35:42 -0400 In-Reply-To: <20110318100418.6556c92c.sfr@canb.auug.org.au> Content-Language: en-US Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell , Roland Dreier Cc: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Hal Rosenstock , Eric Dumazet , Tejun Heo , Changli Gao , "linux-rdma@vger.kernel.org" Commit b23dd4fe42b455af5c6e20966b7d6959fa8352ea (ipv4: Make output route lookup return rtable directly) resulted in leaving ret uninitialized, where it may later be returned. Signed-off-by: Sean Hefty --- I didn't actually test this, but it looks correct. drivers/infiniband/core/addr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index e0ef5fd..4ffc224 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -204,7 +204,7 @@ static int addr4_resolve(struct sockaddr_in *src_in, /* If the device does ARP internally, return 'done' */ if (rt->dst.dev->flags & IFF_NOARP) { - rdma_copy_addr(addr, rt->dst.dev, NULL); + ret = rdma_copy_addr(addr, rt->dst.dev, NULL); goto put; }