From: Anson Huang <anson.huang@nxp.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: RE: linux-next: build warning after merge of the clk tree
Date: Tue, 30 Apr 2019 01:44:58 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916B4CE00494BE730C07047F53A0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190430101939.76dc077c@canb.auug.org.au>
Hi, Stephen
Thanks for notice.
As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning,
Anson.
> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, April 30, 2019 8:20 AM
> To: Mike Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; Anson Huang <anson.huang@nxp.com>;
> Gustavo A. R. Silva <gustavo@embeddedor.com>; Kees Cook
> <keescook@chromium.org>
> Subject: linux-next: build warning after merge of the clk tree
>
> Hi all,
>
> After merging the clk tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
> pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> ^
> drivers/clk/imx/clk-pllv3.c:454:2: note: here
> case IMX_PLLV3_AV:
> ^~~~
>
> Introduced by commit
>
> 01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset")
>
> I get this warning because I am building with -Wimplicit-fallthrough in
> attempt to catch new additions early. The gcc warning can be turned off by
> adding a /* fall through */ comment at the point the fall through happens
> (assuming that the fall through is intentional).
>
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2019-04-30 1:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 0:19 linux-next: build warning after merge of the clk tree Stephen Rothwell
2019-04-30 1:44 ` Anson Huang [this message]
2019-04-30 5:56 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-06-29 23:53 Stephen Rothwell
2020-06-30 8:11 ` Maxime Ripard
2020-07-08 11:10 ` Stephen Rothwell
2020-07-16 0:25 ` Stephen Boyd
2019-08-15 23:57 Stephen Rothwell
2019-08-16 18:10 ` Stephen Boyd
2018-10-17 21:51 Stephen Rothwell
2018-10-18 18:21 ` Stephen Boyd
2016-12-11 21:39 Stephen Rothwell
2016-12-12 8:05 ` Boris Brezillon
2016-12-12 8:19 ` Stephen Rothwell
2015-05-06 4:05 Stephen Rothwell
2015-05-06 4:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916B4CE00494BE730C07047F53A0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).