From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7116C2D0EC for ; Thu, 26 Mar 2020 16:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAC0920775 for ; Thu, 26 Mar 2020 16:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727677AbgCZQYT convert rfc822-to-8bit (ORCPT ); Thu, 26 Mar 2020 12:24:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:13170 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727792AbgCZQYT (ORCPT ); Thu, 26 Mar 2020 12:24:19 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02QG3I5p035735 for ; Thu, 26 Mar 2020 12:24:18 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ywd2ugtdr-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2020 12:24:18 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2020 16:24:11 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Mar 2020 16:24:08 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02QGOCdc55574780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 16:24:12 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3EFF542047; Thu, 26 Mar 2020 16:24:12 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B79D42041; Thu, 26 Mar 2020 16:24:11 +0000 (GMT) Received: from [9.79.188.120] (unknown [9.79.188.120]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Mar 2020 16:24:10 +0000 (GMT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [powerpc] Intermittent crashes ( link_path_walk) with linux-next From: Sachin Sant In-Reply-To: <20200326134925.GP23230@ZenIV.linux.org.uk> Date: Thu, 26 Mar 2020 21:54:10 +0530 Cc: Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, Linux Next Mailing List Content-Transfer-Encoding: 8BIT References: <1CB4E533-FD97-4C39-87ED-4857F3AB9097@linux.vnet.ibm.com> <87h7ybwdih.fsf@mpe.ellerman.id.au> <20200326134925.GP23230@ZenIV.linux.org.uk> To: Al Viro X-Mailer: Apple Mail (2.3445.104.11) X-TM-AS-GCONF: 00 x-cbid: 20032616-4275-0000-0000-000003B3DCA2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20032616-4276-0000-0000-000038C9211D Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645 definitions=2020-03-26_06:2020-03-26,2020-03-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 mlxlogscore=999 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260120 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org > On 26-Mar-2020, at 7:19 PM, Al Viro wrote: > > On Thu, Mar 26, 2020 at 10:40:06PM +1100, Michael Ellerman wrote: > >>> The code in question (link_path_walk() in fs/namei.c ) was recently changed by >>> following commit: >>> >>> commit 881386f7e46a: >>> link_path_walk(): sample parent's i_uid and i_mode for the last component >> >> That and about 10 other commits. >> >> Unless Al can give us a clue we'll need to bisect. > > Already fixed yesterday. It's not link_path_walk(), it's handle_dots() > ignoring an error returned by step_into(). > > commit 5e3c3570ec97 is the broken one; commit 20971012f63e is its variant with the > fix folded in. So next-20200325 has the bug and next-20200326 should have it > fixed. Could you check the current -next and see if you still observe that crap? Thanks Al for the information. I confirm that today’s next tree (20200326) work for me. I can no longer recreate this problem. Thanks -Sachin