From: Song Liu <songliubraving@fb.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: linux-next: Tree for Aug 7 (mm/khugepaged.c)
Date: Wed, 7 Aug 2019 22:11:28 +0000 [thread overview]
Message-ID: <F53407FB-96CC-42E8-9862-105C92CC2B98@fb.com> (raw)
In-Reply-To: <abb5daa5-322e-55e8-a08d-4e938375451f@infradead.org>
> On Aug 7, 2019, at 2:30 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 8/7/19 2:27 PM, Andrew Morton wrote:
>> On Wed, 7 Aug 2019 21:00:04 +0000 Song Liu <songliubraving@fb.com> wrote:
>>
>>>>>
>>>>> Shall I resend the patch, or shall I send fix on top of current patch?
>>>>
>>>> Either is OK. If the difference is small I will turn it into an
>>>> incremental patch so that I (and others) can see what changed.
>>>
>>> Please find the patch to fix this at the end of this email. It applies
>>> right on top of "khugepaged: enable collapse pmd for pte-mapped THP".
>>> It may conflict a little with the "Enable THP for text section of
>>> non-shmem files" set, which renames function khugepaged_scan_shmem().
>>>
>>> Also, I found v3 of the set in linux-next. The latest is v4:
>>>
>>> https://lkml.org/lkml/2019/8/2/1587
>>> https://lkml.org/lkml/2019/8/2/1588
>>> https://lkml.org/lkml/2019/8/2/1589
>>
>> It's all a bit confusing. I'll drop
>>
>> mm-move-memcmp_pages-and-pages_identical.patch
>> uprobe-use-original-page-when-all-uprobes-are-removed.patch
>> uprobe-use-original-page-when-all-uprobes-are-removed-v2.patch
>> mm-thp-introduce-foll_split_pmd.patch
>> mm-thp-introduce-foll_split_pmd-v11.patch
>> uprobe-use-foll_split_pmd-instead-of-foll_split.patch
>> khugepaged-enable-collapse-pmd-for-pte-mapped-thp.patch
>> uprobe-collapse-thp-pmd-after-removing-all-uprobes.patch
>>
>> Please resolve Oleg's review comments and resend everything.
>>
>
> OK, that will take care of the build error that I am still seeing
> when SHMEM is not enabled:
>
> ../mm/khugepaged.c:1849:2: note: in expansion of macro ‘BUILD_BUG’
> BUILD_BUG();
> ^~~~~~~~~
This was broken by one of my other patch. Sorry!
The following patch (on top of linux-next/master) fixes it.
Thanks,
Song
================= 8< ==============================
From 4d6e3a3a28bf85b1debbb90c55f66c81e9ebb9ec Mon Sep 17 00:00:00 2001
From: Song Liu <songliubraving@fb.com>
Date: Wed, 7 Aug 2019 14:57:38 -0700
Subject: [PATCH] khugepaged: fix build without CONFIG_SHMEM
khugepaged_scan_file() should be fully bypassed without CONFIG_SHMEM.
Fixes: f57286140d96 ("mm,thp: add read-only THP support for (non-shmem) FS")
Signed-off-by: Song Liu <songliubraving@fb.com>
---
mm/khugepaged.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 272fed3ed0f0..40c25ddf29e4 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -1778,7 +1778,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages,
VM_BUG_ON(khugepaged_scan.address < hstart ||
khugepaged_scan.address + HPAGE_PMD_SIZE >
hend);
- if (vma->vm_file) {
+ if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) {
struct file *file;
pgoff_t pgoff = linear_page_index(vma,
khugepaged_scan.address);
--
2.17.1
next prev parent reply other threads:[~2019-08-07 22:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:36 linux-next: Tree for Aug 7 Stephen Rothwell
2019-08-07 15:11 ` linux-next: Tree for Aug 7 (mm/khugepaged.c) Randy Dunlap
2019-08-07 16:59 ` Song Liu
2019-08-07 20:10 ` Andrew Morton
2019-08-07 21:00 ` Song Liu
2019-08-07 21:27 ` Andrew Morton
2019-08-07 21:30 ` Randy Dunlap
2019-08-07 22:11 ` Song Liu [this message]
2019-08-08 1:31 ` Stephen Rothwell
2019-08-07 22:13 ` Song Liu
2019-08-08 1:20 ` Stephen Rothwell
2019-08-07 15:29 ` linux-next: Tree for Aug 7 (net/bridge/netfilter/nf_conntrack_bridge.c) Randy Dunlap
2019-08-07 15:57 ` Jeremy Sowden
2019-09-23 22:26 ` Ivan Kalvachev
2019-09-23 22:48 ` Jeremy Sowden
2019-08-08 5:13 ` linux-next: Tree for Aug 7 Michael Ellerman
2019-08-08 15:54 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F53407FB-96CC-42E8-9862-105C92CC2B98@fb.com \
--to=songliubraving@fb.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).