From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762A1C34026 for ; Tue, 18 Feb 2020 11:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3A1207FD for ; Tue, 18 Feb 2020 11:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726086AbgBRLk5 convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2020 06:40:57 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54430 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgBRLk4 (ORCPT ); Tue, 18 Feb 2020 06:40:56 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01IBaetk127268 for ; Tue, 18 Feb 2020 06:40:55 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2y6dkxhu5h-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 18 Feb 2020 06:40:55 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Feb 2020 11:40:53 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 18 Feb 2020 11:40:50 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01IBenR851052756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Feb 2020 11:40:49 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25807AE04D; Tue, 18 Feb 2020 11:40:49 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 259DBAE056; Tue, 18 Feb 2020 11:40:48 +0000 (GMT) Received: from [9.199.196.80] (unknown [9.199.196.80]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 18 Feb 2020 11:40:47 +0000 (GMT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9 From: Sachin Sant In-Reply-To: <0ba2a3c6-6593-2cee-1cef-983cd75f920f@virtuozzo.com> Date: Tue, 18 Feb 2020 17:10:47 +0530 Cc: Linux-Next Mailing List , linuxppc-dev@lists.ozlabs.org, Michal Hocko Content-Transfer-Encoding: 8BIT References: <3381CD91-AB3D-4773-BA04-E7A072A63968@linux.vnet.ibm.com> <0ba2a3c6-6593-2cee-1cef-983cd75f920f@virtuozzo.com> To: Kirill Tkhai X-Mailer: Apple Mail (2.3445.104.11) X-TM-AS-GCONF: 00 x-cbid: 20021811-0016-0000-0000-000002E7ED8D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20021811-0017-0000-0000-0000334B0109 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-18_02:2020-02-17,2020-02-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 adultscore=0 priorityscore=1501 mlxlogscore=923 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002180096 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org >> could you please test your boot with original patch from here: >> >> https://patchwork.kernel.org/patch/11360007/ > > After you tried the above patch instead of the problem patch, > do one more test and apply the below on current linux-next. > Please, say which of the patches makes your kernel bootable again. > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 63bb6a2aab81..7b9b48dcbc60 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -334,7 +334,7 @@ static int memcg_expand_one_shrinker_map(struct mem_cgroup *memcg, > if (!old) > return 0; > > - new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); > + new = kmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); > if (!new) > return -ENOMEM; > > @@ -378,7 +378,7 @@ static int memcg_alloc_shrinker_maps(struct mem_cgroup *memcg) > mutex_lock(&memcg_shrinker_map_mutex); > size = memcg_shrinker_map_size; > for_each_node(nid) { > - map = kvzalloc_node(sizeof(*map) + size, GFP_KERNEL, nid); > + map = kzalloc_node(sizeof(*map) + size, GFP_KERNEL, nid); > if (!map) { > memcg_free_shrinker_maps(memcg); > ret = -ENOMEM; With this incremental patch applied on top of current linux-next, machine fails to boot [ 8.868433] BUG: Kernel NULL pointer dereference on read at 0x000073b0 [ 8.868439] Faulting instruction address: 0xc0000000003d55f4 [ 8.868444] Oops: Kernel access of bad area, sig: 11 [#1] [ 8.868449] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries [ 8.868453] Modules linked in: [ 8.868458] CPU: 18 PID: 1 Comm: systemd Not tainted 5.6.0-rc2-next-20200218-autotest+ #4 [ 8.868463] NIP: c0000000003d55f4 LR: c0000000003d5b94 CTR: 0000000000000000 [ 8.868468] REGS: c0000008b3783710 TRAP: 0300 Not tainted (5.6.0-rc2-next-20200218-autotest+) [ 8.868474] MSR: 8000000000009033 CR: 24004844 XER: 00000000 [ 8.868481] CFAR: c00000000000dec4 DAR: 00000000000073b0 DSISR: 40000000 IRQMASK: 1 [ 8.868481] GPR00: c0000000003d5b94 c0000008b37839a0 c00000000155d400 c0000008b301f500 [ 8.868481] GPR04: 0000000000000dc0 0000000000000002 c0000000003fee38 c0000008bb298620 [ 8.868481] GPR08: 00000008ba1f0000 0000000000000001 0000000000000000 0000000000000000 [ 8.868481] GPR12: 0000000024004844 c00000001ec54200 0000000000000000 0000000000000000 [ 8.868481] GPR16: c0000008a1a60048 c000000001595898 c000000001750c18 0000000000000002 [ 8.868481] GPR20: c000000001750c28 c000000001624470 0000000fffffffe0 5deadbeef0000122 [ 8.868481] GPR24: 0000000000000001 0000000000000dc0 0000000000000002 c0000000003fee38 [ 8.868481] GPR28: c0000008b301f500 c0000008bb298620 0000000000000000 c00c000002286d00 [ 8.868529] NIP [c0000000003d55f4] ___slab_alloc+0x1f4/0x760 [ 8.868534] LR [c0000000003d5b94] __slab_alloc+0x34/0x60 [ 8.868538] Call Trace: [ 8.868541] [c0000008b37839a0] [c0000000003d5734] ___slab_alloc+0x334/0x760 (unreliable) [ 8.868547] [c0000008b3783a80] [c0000000003d5b94] __slab_alloc+0x34/0x60 [ 8.868553] [c0000008b3783ab0] [c0000000003d6fa0] __kmalloc_node+0x110/0x490 [ 8.868559] [c0000008b3783b30] [c0000000003fee38] mem_cgroup_css_online+0x108/0x270 [ 8.868565] [c0000008b3783b90] [c000000000235aa8] online_css+0x48/0xd0 [ 8.868571] [c0000008b3783bc0] [c00000000023eaec] cgroup_apply_control_enable+0x2ec/0x4d0 [ 8.868577] [c0000008b3783ca0] [c000000000242318] cgroup_mkdir+0x228/0x5f0 [ 8.868583] [c0000008b3783d10] [c00000000051e170] kernfs_iop_mkdir+0x90/0xf0 [ 8.868589] [c0000008b3783d50] [c00000000043dc00] vfs_mkdir+0x110/0x230 [ 8.868594] [c0000008b3783da0] [c000000000441c90] do_mkdirat+0xb0/0x1a0 [ 8.868601] [c0000008b3783e20] [c00000000000b278] system_call+0x5c/0x68 [ 8.868605] Instruction dump: [ 8.868608] 7c421378 e95f0000 714a0001 4082fff0 4bffff64 60000000 60000000 faa10088 [ 8.868615] 3ea2000c 3ab57070 7b4a1f24 7d55502a 2faa0000 409e0394 3d02002a [ 8.868623] ---[ end trace f9b8e3c36493f430 ]--- [ 8.870690] [ 9.870701] Kernel panic - not syncing: Fatal exception Thanks -Sachin