Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Felipe Balbi <balbi@ti.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Greg KH <greg@kroah.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: linux-next: build warning after merge of the usb tree
Date: Fri, 2 Nov 2012 10:18:57 -0400 (EDT)
Message-ID: <Pine.LNX.4.44L0.1211021014180.1356-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <20121102090743.GB17938@arwen.pp.htv.fi>

On Fri, 2 Nov 2012, Felipe Balbi wrote:

> Hi,
> 
> On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > 
> > Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> > library module").
> 
> Alex, why on earth is chipidea exporting symbols it doesn't own ?

That's at least partly my fault.  ehci-hcd.c now exports four symbols 
that it didn't before.  Since the ChipIdea driver does

	#include "../host/ehci-hcd.c"

it now exports them too, unintentionally.  A quick band-aid fix would 
be to protect those functions with

	#ifndef CHIPIDEA_EHCI

but the real fix is the patch I posted yesterday -- assuming it works 
right.  If we don't hear back from Alex soon, I will post the band-aid 
fix as a temporary stop-gap.

Alan Stern

  reply index

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  4:08 Stephen Rothwell
2012-11-02  9:07 ` Felipe Balbi
2012-11-02 14:18   ` Alan Stern [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-01  8:30 Stephen Rothwell
2021-06-01 17:39 ` Rajat Jain
2021-06-04 13:37   ` Greg KH
2021-04-26 12:44 Stephen Rothwell
2021-04-26 12:53 ` Greg KH
2021-05-21  0:40   ` Stephen Rothwell
2021-05-21  1:28     ` Fabio Estevam
2021-04-26 12:37 Stephen Rothwell
2021-04-26 12:53 ` Greg KH
2021-04-26 21:12   ` Thinh Nguyen
2021-03-10  2:49 Stephen Rothwell
2021-04-21  6:07 ` Stephen Rothwell
2021-04-21  6:22   ` Greg KH
2021-03-03  6:05 Stephen Rothwell
2021-02-03  5:13 Stephen Rothwell
2021-02-03  7:04 ` Benson Leung
2021-01-06  2:12 Stephen Rothwell
2021-01-13 22:48 ` Stephen Rothwell
2021-01-14  8:51   ` Greg KH
2020-11-20  5:15 Stephen Rothwell
2020-11-20  6:38 ` Prashant Malani
2020-01-06  3:41 Stephen Rothwell
2020-01-06  7:58 ` Krzysztof Kozlowski
2020-01-06  9:30   ` Greg KH
2018-09-11  2:47 Stephen Rothwell
2018-09-11  8:12 ` Greg KH
2017-11-02  4:06 Stephen Rothwell
2013-12-10  3:59 Stephen Rothwell
2010-11-17  2:14 Stephen Rothwell
2010-11-17  4:20 ` Greg KH
2010-05-17  6:16 Stephen Rothwell
2010-05-17 18:01 ` Greg KH
2010-05-17  6:09 Stephen Rothwell
2010-05-17 18:01 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1211021014180.1356-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git