From: Alan Stern <stern@rowland.harvard.edu>
To: Jan Beulich <JBeulich@suse.com>
Cc: sfr@canb.auug.org.au, rdunlap@infradead.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: linux-next: Tree for Oct 31 (ehci, dbgp)
Date: Fri, 2 Nov 2012 10:20:27 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1211021019450.1356-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <5093E0DF02000078000A6102@nat28.tlf.novell.com>
On Fri, 2 Nov 2012, Jan Beulich wrote:
> >>> On 02.11.12 at 15:01, Alan Stern <stern@rowland.harvard.edu> wrote:
> > On Thu, 1 Nov 2012, Jan Beulich wrote:
> >
> >> >>> Alan Stern <stern@rowland.harvard.edu> 11/01/12 9:39 PM >>>
> >> >On Thu, 1 Nov 2012, Jan Beulich wrote:
> >> >> >>> Alan Stern <stern@rowland.harvard.edu> 11/01/12 4:28 PM >>>
> >> >> >Evidently we need to change your new test in
> >> >> >drivers/usb/early/ehci-dbgp.c to:
> >> >> >
> >> >> >#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST)
> >> >> >
> >> >> >Upcoming changes to ehci-hcd will make this unnecessary in 3.8, but for
> >> >> >now we need it.
> >> >>
> >> >> Which tells me that the CONFIG_USB_SUPPORT version would have been
> >> >> the better one (and I would favor that over the ugly variant you suggest
> >> >> above).
> >> >
> >> >I also suggested IS_ENABLED(CONFIG_USB), which is no uglier than what
> >> >you submitted and would also fix this build error. How about using it
> >> >instead?
> >>
> >> Yes, that's better. Question then is - updated original patch or incremental
> > one?
> >
> > Greg will probably want an incremental patch, because the original has
> > already been merged.
>
> I actually sent both (the incremental as attachment - I hope that's
> going to be acceptable to him) in a submission earlier today.
Ah, okay, good.
Greg, whichever version you take, you can add:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2012-11-02 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 6:26 linux-next: Tree for Oct 31 Stephen Rothwell
2012-10-31 21:35 ` linux-next: Tree for Oct 31 (ehci, dbgp) Randy Dunlap
[not found] ` <509199A5.1090109-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2012-11-01 15:28 ` Alan Stern
2012-11-01 19:46 ` Jan Beulich
2012-11-01 20:39 ` Alan Stern
2012-11-01 20:49 ` Jan Beulich
2012-11-02 14:01 ` Alan Stern
2012-11-02 14:03 ` Jan Beulich
2012-11-02 14:20 ` Alan Stern [this message]
2012-11-02 15:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1211021019450.1356-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=JBeulich@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).