linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: linux-next: hid build failure
Date: Tue, 27 May 2008 11:14:01 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0805271111560.18218@twin.jikos.cz> (raw)
In-Reply-To: <20080527131441.06f3a67f.sfr@canb.auug.org.au>

On Tue, 27 May 2008, Stephen Rothwell wrote:

> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
> drivers/hid/usbhid/hiddev.c:767: warning: passing argument 1 of 'hiddev_ioctl' from incompatible pointer type
> drivers/hid/usbhid/hiddev.c:767: warning: passing argument 2 of 'hiddev_ioctl' makes integer from pointer without a cast
> drivers/hid/usbhid/hiddev.c:767: error: too many arguments to function 'hiddev_ioctl'
> Caused by commit f888433ea1f5dd6dc8487463c61c9e6d08e7ef62 ("HID: Switch
> hiddev to unlocked_ioctl") which I have reverted.

Hi Stephen,

thanks a lot for reporting, Alan's patch missed to change the prototype in 
the compat handler, and I missed this too. 

Should be now fixed in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2008-05-27  9:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27  3:14 linux-next: hid build failure Stephen Rothwell
2008-05-27  9:14 ` Jiri Kosina [this message]
2008-05-27 10:46   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0805271111560.18218@twin.jikos.cz \
    --to=jkosina@suse.cz \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).