* linux-next: hid build failure
@ 2008-05-27 3:14 Stephen Rothwell
2008-05-27 9:14 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-05-27 3:14 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-next, Alan Cox
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Hi Jiri,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
drivers/hid/usbhid/hiddev.c:767: warning: passing argument 1 of 'hiddev_ioctl' from incompatible pointer type
drivers/hid/usbhid/hiddev.c:767: warning: passing argument 2 of 'hiddev_ioctl' makes integer from pointer without a cast
drivers/hid/usbhid/hiddev.c:767: error: too many arguments to function 'hiddev_ioctl'
Caused by commit f888433ea1f5dd6dc8487463c61c9e6d08e7ef62 ("HID: Switch
hiddev to unlocked_ioctl") which I have reverted.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: hid build failure
2008-05-27 3:14 linux-next: hid build failure Stephen Rothwell
@ 2008-05-27 9:14 ` Jiri Kosina
2008-05-27 10:46 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2008-05-27 9:14 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Alan Cox
On Tue, 27 May 2008, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
> drivers/hid/usbhid/hiddev.c:767: warning: passing argument 1 of 'hiddev_ioctl' from incompatible pointer type
> drivers/hid/usbhid/hiddev.c:767: warning: passing argument 2 of 'hiddev_ioctl' makes integer from pointer without a cast
> drivers/hid/usbhid/hiddev.c:767: error: too many arguments to function 'hiddev_ioctl'
> Caused by commit f888433ea1f5dd6dc8487463c61c9e6d08e7ef62 ("HID: Switch
> hiddev to unlocked_ioctl") which I have reverted.
Hi Stephen,
thanks a lot for reporting, Alan's patch missed to change the prototype in
the compat handler, and I missed this too.
Should be now fixed in my tree.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-27 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-27 3:14 linux-next: hid build failure Stephen Rothwell
2008-05-27 9:14 ` Jiri Kosina
2008-05-27 10:46 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).