From: Jiri Kosina <jkosina@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH linux-next] serio: add ifdef for i8042 build fix
Date: Mon, 2 Jun 2008 10:44:36 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806021044010.6718@jikos.suse.cz> (raw)
In-Reply-To: <20080529184606.GA17728@anvil.corenet.prv>
On Thu, 29 May 2008, Dmitry Torokhov wrote:
> > Restrict variable usage by bounding it with ifdef/endif CONFIG_PNP.
> > linux-next-20080529/drivers/input/serio/i8042-x86ia64io.h:590: error: 'i8042_nopnp' undeclared (first use in this function)
> Thank you for the report. I'd rahther changed it as in the patch below.
> What do you think?
> If everyone agrees then I will fold it in Jiri's original patch to keep
> the trees bisectable.
Definitely proper fix, sorry for messing it up. Folding Randy's fix into
my patch is perfectly fine by me.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2008-06-02 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 8:25 linux-next: Tree for May 29 Stephen Rothwell
2008-05-29 16:44 ` Randy Dunlap
2008-05-29 16:56 ` [PATCH linux-next] serio: add ifdef for i8042 build fix Randy Dunlap
2008-05-29 18:46 ` Dmitry Torokhov
2008-05-29 19:17 ` Randy Dunlap
2008-06-02 8:44 ` Jiri Kosina [this message]
2008-05-29 18:28 ` [PATCH] linux-next: Tree for May 29 - build failure s390x -typo in ccw_timeout_log() Kamalesh Babulal
2008-05-29 19:06 ` Greg KH
2008-05-29 20:21 ` [BUG] linux-next: Tree for May 29 - WARNING: at kernel/lockdep.c:2680 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806021044010.6718@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).