From: Al Viro <viro@zeniv.linux.org.uk>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
LTP List <ltp@lists.linux.it>,
lkft-triage@lists.linaro.org, chrubis <chrubis@suse.cz>,
Jan Stancek <jstancek@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christian Brauner <christian@brauner.io>,
Kees Cook <keescook@chromium.org>, Peter Xu <peterx@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Vorel <pvorel@suse.cz>,
Richard Palethorpe <rpalethorpe@suse.com>,
Joerg.Vehlow@aox-tech.de
Subject: Re: LTP: madvise08.c:203: TFAIL: No sequence in dump after MADV_DODUMP.
Date: Mon, 15 Feb 2021 14:34:07 +0000 [thread overview]
Message-ID: <YCqGX36I+KR7SoA8@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <CA+G9fYsZnBv4wAEKYb0mgMd-BsgXcPUGBQ=VRKcONqAZry_4XQ@mail.gmail.com>
On Mon, Feb 15, 2021 at 02:11:15PM +0530, Naresh Kamboju wrote:
> fs/coredump.c:903:9: error: 'return' with a value, in function
> returning void [-Werror=return-type]
> 903 | return 0;
> | ^
>
> Build failed due to above error.
FWIW, here the test results in
Running tests.......
<<<test_start>>>
tag=madvise08 stime=1613398818
cmdline="madvise08"
contacts=""
analysis=exit
<<<test_output>>>
incrementing stop
tst_test.c:1250: TINFO: Timeout per run is 0h 05m 00s
madvise08.c:78: TINFO: Temporary core pattern is '/tmp/ltp-tgvQ3Lz1UZ/B6lwy6/dump-%p'
madvise08.c:117: TINFO: Dump file should be dump-2276
madvise08.c:201: TPASS: madvise(..., MADV_DONTDUMP)
madvise08.c:117: TINFO: Dump file should be dump-2277
madvise08.c:205: TPASS: madvise(..., MADV_DODUMP)
Summary:
passed 2
failed 0
skipped 0
warnings 0
<<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>
(built without -Werror=return-type, so I'd missed the warnings)
Anyway, I've folded the fix (with those stray return 0 removed, of course)
into #work.coredump and #for-next; works here. Could you test either
branch (in git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git)?
next prev parent reply other threads:[~2021-02-15 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 14:48 LTP: madvise08.c:203: TFAIL: No sequence in dump after MADV_DODUMP Naresh Kamboju
2021-01-25 15:11 ` Arnd Bergmann
2021-01-25 16:31 ` Naresh Kamboju
2021-02-14 19:55 ` Al Viro
2021-02-15 8:41 ` Naresh Kamboju
2021-02-15 14:34 ` Al Viro [this message]
2021-02-16 1:03 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCqGX36I+KR7SoA8@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Joerg.Vehlow@aox-tech.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christian@brauner.io \
--cc=chrubis@suse.cz \
--cc=ebiederm@xmission.com \
--cc=jstancek@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=ltp@lists.linux.it \
--cc=naresh.kamboju@linaro.org \
--cc=peterx@redhat.com \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).