Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the irqchip tree
@ 2021-04-08  6:35 Stephen Rothwell
  2021-04-08  7:56 ` Marc Zyngier
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2021-04-08  6:35 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Jonathan Neuschäfer, Linux Kernel Mailing List,
	Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi all,

After merging the irqchip tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/irqchip/irq-wpcm450-aic.c:9:10: fatal error: asm/exception.h: No such file or directory
    9 | #include <asm/exception.h>
      |          ^~~~~~~~~~~~~~~~~

Caused by commit

  fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")

I have used the irqchip tree from next-20210407 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2021-04-08  6:35 linux-next: build failure after merge of the irqchip tree Stephen Rothwell
@ 2021-04-08  7:56 ` Marc Zyngier
  2021-04-08  8:35   ` Jonathan Neuschäfer
  0 siblings, 1 reply; 12+ messages in thread
From: Marc Zyngier @ 2021-04-08  7:56 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jonathan Neuschäfer, Linux Kernel Mailing List,
	Linux Next Mailing List

Hi Stephen,

On 2021-04-08 07:35, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/irqchip/irq-wpcm450-aic.c:9:10: fatal error: asm/exception.h:
> No such file or directory
>     9 | #include <asm/exception.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")
> 
> I have used the irqchip tree from next-20210407 for today.

Thanks for the heads up. I guess that's the effect of COMPILE_TEST
which was apparently not very well tested... I'll drop it from Kconfig.

Jonathan, feel free to submit something re-enabling COMPILE_TEST once
you've worked out the missing dependencies.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2021-04-08  7:56 ` Marc Zyngier
@ 2021-04-08  8:35   ` Jonathan Neuschäfer
  0 siblings, 0 replies; 12+ messages in thread
From: Jonathan Neuschäfer @ 2021-04-08  8:35 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Stephen Rothwell, Jonathan Neuschäfer,
	Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Thu, Apr 08, 2021 at 08:56:18AM +0100, Marc Zyngier wrote:
> Hi Stephen,
> 
> On 2021-04-08 07:35, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the irqchip tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/irqchip/irq-wpcm450-aic.c:9:10: fatal error: asm/exception.h:
> > No such file or directory
> >     9 | #include <asm/exception.h>
> >       |          ^~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller")
> > 
> > I have used the irqchip tree from next-20210407 for today.
> 
> Thanks for the heads up. I guess that's the effect of COMPILE_TEST
> which was apparently not very well tested... I'll drop it from Kconfig.

Right, sorry about that.

> Jonathan, feel free to submit something re-enabling COMPILE_TEST once
> you've worked out the missing dependencies.

I used __exception_irq_entry from asm/exception.h, like other irqchip
drivers for ARM. This macro is only defined in arch/arm and arch/arm64.
So, AFAICS, there is no right set of dependencies for COMPILE_TEST.


Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2020-03-26  6:36 ` Stephen Rothwell
@ 2020-03-26  7:06   ` Michal Simek
  0 siblings, 0 replies; 12+ messages in thread
From: Michal Simek @ 2020-03-26  7:06 UTC (permalink / raw)
  To: Stephen Rothwell, Marc Zyngier
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michal Simek,
	Mubin Sayyed

Hi Stephen,

On 26. 03. 20 7:36, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 23 Mar 2020 17:59:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the irqchip tree, today's linux-next build (powerpc
>> ppc44x_defconfig) failed like this:
>>
>> drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
>> drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
>>   176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
>>       |          ^~~~~~~~~~~~~~~~~
>>       |          handle_bad_irq
>> drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
>> drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
>>   253 |   set_handle_irq(xil_intc_handle_irq);
>>       |   ^~~~~~~~~~~~~~
>>       |   generic_handle_irq
>>
>> Caused by commit
>>
>>   a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")
>>
>> I have reverted that commit (and commit
>>
>>   9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")
>>
>> that conflicted with the other revert).
> 
> I am still getting these errors.
> 


Marc: Can you please respond my email I sent on Monday when Stephen
reported this issue?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2020-03-23  6:59 Stephen Rothwell
  2020-03-23  8:08 ` Michal Simek
@ 2020-03-26  6:36 ` Stephen Rothwell
  2020-03-26  7:06   ` Michal Simek
  1 sibling, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2020-03-26  6:36 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michal Simek,
	Mubin Sayyed


[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

Hi all,

On Mon, 23 Mar 2020 17:59:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the irqchip tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
> drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
>   176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
>       |          ^~~~~~~~~~~~~~~~~
>       |          handle_bad_irq
> drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
> drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
>   253 |   set_handle_irq(xil_intc_handle_irq);
>       |   ^~~~~~~~~~~~~~
>       |   generic_handle_irq
> 
> Caused by commit
> 
>   a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")
> 
> I have reverted that commit (and commit
> 
>   9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")
> 
> that conflicted with the other revert).

I am still getting these errors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2020-03-23  6:59 Stephen Rothwell
@ 2020-03-23  8:08 ` Michal Simek
  2020-03-26  6:36 ` Stephen Rothwell
  1 sibling, 0 replies; 12+ messages in thread
From: Michal Simek @ 2020-03-23  8:08 UTC (permalink / raw)
  To: Stephen Rothwell, Marc Zyngier
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michal Simek,
	Mubin Sayyed

Hi Stephen,

On 23. 03. 20 7:59, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the irqchip tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
> drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
>   176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
>       |          ^~~~~~~~~~~~~~~~~
>       |          handle_bad_irq
> drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
> drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
>   253 |   set_handle_irq(xil_intc_handle_irq);
>       |   ^~~~~~~~~~~~~~
>       |   generic_handle_irq
> 
> Caused by commit
> 
>   a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")
> 
> I have reverted that commit (and commit
> 
>   9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")
> 
> that conflicted with the other revert).
> 

thanks for reporting this.

Marc: I completely forget about this wiring for very ancient platform.
AFAIK Xilinx is not testing this platform for years and would likely the
best to remove support for it completely.
The second option is to get xintc_get_irq() back with note about powerpc
because it won't be that simple change all PPC platform to generic
domain irq handler.
Any other suggestion?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: build failure after merge of the irqchip tree
@ 2020-03-23  6:59 Stephen Rothwell
  2020-03-23  8:08 ` Michal Simek
  2020-03-26  6:36 ` Stephen Rothwell
  0 siblings, 2 replies; 12+ messages in thread
From: Stephen Rothwell @ 2020-03-23  6:59 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Michal Simek,
	Mubin Sayyed


[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

Hi all,

After merging the irqchip tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
  176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
      |          ^~~~~~~~~~~~~~~~~
      |          handle_bad_irq
drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
  253 |   set_handle_irq(xil_intc_handle_irq);
      |   ^~~~~~~~~~~~~~
      |   generic_handle_irq

Caused by commit

  a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")

I have reverted that commit (and commit

  9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")

that conflicted with the other revert).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2018-10-08  3:06 Stephen Rothwell
@ 2018-10-08  7:06 ` Marc Zyngier
  0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2018-10-08  7:06 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Richard Fitzgerald

Hi Stephen,

On Mon, 08 Oct 2018 04:06:21 +0100,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi Marc,
> 
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/irqchip/irq-madera.c:21:
> include/linux/irqchip/irq-madera.h: In function 'madera_get_irq_mapping':
> include/linux/irqchip/irq-madera.h:99:37: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
>   return regmap_irq_get_virq(madera->irq_data, irq);
>                                      ^~~~~~~~
>                                      irq_dev
> drivers/irqchip/irq-madera.c: In function 'madera_irq_probe':
> drivers/irqchip/irq-madera.c:217:34: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
>        &madera_irq_chip, &madera->irq_data);
>                                   ^~~~~~~~
>                                   irq_dev
> drivers/irqchip/irq-madera.c: In function 'madera_irq_remove':
> drivers/irqchip/irq-madera.c:238:43: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
>   regmap_del_irq_chip(madera->irq, madera->irq_data);
>                                            ^~~~~~~~
>                                            irq_dev
> 
> Caused by commit
> 
>   b817ff5c9509 ("irqchip: Add driver for Cirrus Logic Madera codecs")
> 
> I have used the irqchip tree from next-20181005 for today.

Thanks for doing that. I've now dropped this commit from irqchip-next.

Richard, I'll let you route this patch to the appropriate tree.

Cheers,

	M.

-- 
Jazz is not dead, it just smell funny.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: build failure after merge of the irqchip tree
@ 2018-10-08  3:06 Stephen Rothwell
  2018-10-08  7:06 ` Marc Zyngier
  0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2018-10-08  3:06 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Richard Fitzgerald


[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi Marc,

After merging the irqchip tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/irqchip/irq-madera.c:21:
include/linux/irqchip/irq-madera.h: In function 'madera_get_irq_mapping':
include/linux/irqchip/irq-madera.h:99:37: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
  return regmap_irq_get_virq(madera->irq_data, irq);
                                     ^~~~~~~~
                                     irq_dev
drivers/irqchip/irq-madera.c: In function 'madera_irq_probe':
drivers/irqchip/irq-madera.c:217:34: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
       &madera_irq_chip, &madera->irq_data);
                                  ^~~~~~~~
                                  irq_dev
drivers/irqchip/irq-madera.c: In function 'madera_irq_remove':
drivers/irqchip/irq-madera.c:238:43: error: 'struct madera' has no member named 'irq_data'; did you mean 'irq_dev'?
  regmap_del_irq_chip(madera->irq, madera->irq_data);
                                           ^~~~~~~~
                                           irq_dev

Caused by commit

  b817ff5c9509 ("irqchip: Add driver for Cirrus Logic Madera codecs")

I have used the irqchip tree from next-20181005 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2015-04-13  7:05 Stephen Rothwell
  2015-04-13  9:10 ` Stefan Agner
@ 2015-04-13 10:50 ` Jason Cooper
  1 sibling, 0 replies; 12+ messages in thread
From: Jason Cooper @ 2015-04-13 10:50 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Stefan Agner

Hi Stephen,

On Mon, Apr 13, 2015 at 05:05:39PM +1000, Stephen Rothwell wrote:
> Hi Jason,
> 
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
> kernel/irq/generic-chip.c:408:2: error: implicit declaration of function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
>   irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
>   ^
> 
> Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
> domain").  The only declaration of irq_domain_set_info() depends on
> CONFIG_IRQ_DOMAIN_HIERARCHY.

Sorry about that.  I was rushing a bit in case the merge window was delayed a
week.  It wasn't, so I'll drop this for v4.1.

It's also a gentle reminder that I need to do *more* thorough testing
with genirq changes before pushing. :-/

thx,

Jason.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: linux-next: build failure after merge of the irqchip tree
  2015-04-13  7:05 Stephen Rothwell
@ 2015-04-13  9:10 ` Stefan Agner
  2015-04-13 10:50 ` Jason Cooper
  1 sibling, 0 replies; 12+ messages in thread
From: Stefan Agner @ 2015-04-13  9:10 UTC (permalink / raw)
  To: Jason Cooper; +Cc: linux-next, linux-kernel, Stephen Rothwell

Hi Jason,

On 2015-04-13 09:05, Stephen Rothwell wrote:
> Hi Jason,
> 
> After merging the irqchip tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
> kernel/irq/generic-chip.c:408:2: error: implicit declaration of
> function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
>   irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
>   ^

Hm, sorry about that, I did not notice that this function is only
available with domain hierarchy. I guess making domain hierarchy a
dependency of genirq is a bit harsh...

--
Stefan

> 
> Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
> domain").  The only declaration of irq_domain_set_info() depends on
> CONFIG_IRQ_DOMAIN_HIERARCHY.
> 
> I have used the irqchip tree from next-20150410 fot today.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* linux-next: build failure after merge of the irqchip tree
@ 2015-04-13  7:05 Stephen Rothwell
  2015-04-13  9:10 ` Stefan Agner
  2015-04-13 10:50 ` Jason Cooper
  0 siblings, 2 replies; 12+ messages in thread
From: Stephen Rothwell @ 2015-04-13  7:05 UTC (permalink / raw)
  To: Jason Cooper; +Cc: linux-next, linux-kernel, Stefan Agner


[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Hi Jason,

After merging the irqchip tree, today's linux-next build (x86_64
allmodconfig) failed like this:

kernel/irq/generic-chip.c: In function 'irq_map_generic_chip':
kernel/irq/generic-chip.c:408:2: error: implicit declaration of function 'irq_domain_set_info' [-Werror=implicit-function-declaration]
  irq_domain_set_info(d, virq, hw_irq, chip, gc, ct->handler, NULL, NULL);
  ^

Caused by commit 3f6b2c298240 ("genirq: Generic chip: Support hierarchy
domain").  The only declaration of irq_domain_set_info() depends on
CONFIG_IRQ_DOMAIN_HIERARCHY.

I have used the irqchip tree from next-20150410 fot today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, back to index

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08  6:35 linux-next: build failure after merge of the irqchip tree Stephen Rothwell
2021-04-08  7:56 ` Marc Zyngier
2021-04-08  8:35   ` Jonathan Neuschäfer
  -- strict thread matches above, loose matches on Subject: below --
2020-03-23  6:59 Stephen Rothwell
2020-03-23  8:08 ` Michal Simek
2020-03-26  6:36 ` Stephen Rothwell
2020-03-26  7:06   ` Michal Simek
2018-10-08  3:06 Stephen Rothwell
2018-10-08  7:06 ` Marc Zyngier
2015-04-13  7:05 Stephen Rothwell
2015-04-13  9:10 ` Stefan Agner
2015-04-13 10:50 ` Jason Cooper

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git