From: Oscar Salvador <osalvador@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: linux-next: Tree for Apr 6 (arch/x86/mm/init_64.c)
Date: Tue, 6 Apr 2021 21:57:03 +0200 [thread overview]
Message-ID: <YGy9DwRZ+dFKi9/c@localhost.localdomain> (raw)
In-Reply-To: <a7895e6e-b00a-4b75-6506-ca38af495829@infradead.org>
On Tue, Apr 06, 2021 at 11:39:47AM -0700, Randy Dunlap wrote:
> > Looks like that compound "if" is too much for gcc 7.5.0 to handle:
> >
> > } else if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) &&
> > vmemmap_pmd_is_unused(addr, next)) {
> > free_hugepage_table(pmd_page(*pmd),
> > altmap);
> > spin_lock(&init_mm.page_table_lock);
> > pmd_clear(pmd);
> > spin_unlock(&init_mm.page_table_lock);
> > }
> >
> >
>
> This is what I am using for now:
Hi Randy
Yeah, that is what v4 was using [1].
We decided to get rid of the ifdef for costimetic reasons but it seems
it does not do the trick.
I will ask Andrew to squash that on top.
[1] https://patchwork.kernel.org/project/linux-mm/patch/20210301083230.30924-4-osalvador@suse.de/
Thanks
>
> ---
> ---
> arch/x86/mm/init_64.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --- linux-next-20210406.orig/arch/x86/mm/init_64.c
> +++ linux-next-20210406/arch/x86/mm/init_64.c
> @@ -1123,14 +1123,16 @@ remove_pmd_table(pmd_t *pmd_start, unsig
> pmd_clear(pmd);
> spin_unlock(&init_mm.page_table_lock);
> pages++;
> - } else if (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) &&
> - vmemmap_pmd_is_unused(addr, next)) {
> + }
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> + else if (vmemmap_pmd_is_unused(addr, next)) {
> free_hugepage_table(pmd_page(*pmd),
> altmap);
> spin_lock(&init_mm.page_table_lock);
> pmd_clear(pmd);
> spin_unlock(&init_mm.page_table_lock);
> }
> +#endif
>
> continue;
> }
>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-04-06 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 12:31 linux-next: Tree for Apr 6 Stephen Rothwell
2021-04-06 18:32 ` linux-next: Tree for Apr 6 (arch/x86/mm/init_64.c) Randy Dunlap
2021-04-06 18:39 ` Randy Dunlap
2021-04-06 19:57 ` Oscar Salvador [this message]
2021-04-06 22:25 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGy9DwRZ+dFKi9/c@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).