From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: linux-next: Tree for May 13 (mm/page_alloc.c, <linux/mm.h>: sizeof(struct page))
Date: Thu, 13 May 2021 22:27:25 +0100 [thread overview]
Message-ID: <YJ2ZvZaR9PTyPp8S@casper.infradead.org> (raw)
In-Reply-To: <b7ebb44d-5dd7-7941-234b-f727691ed1f4@infradead.org>
On Thu, May 13, 2021 at 10:29:49AM -0700, Randy Dunlap wrote:
> On 5/12/21 10:44 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20210512:
> >
>
> on x86_64:
>
> In function ‘__mm_zero_struct_page.isra.75’,
> inlined from ‘__init_single_page.isra.76’ at ../mm/page_alloc.c:1494:2:
> ./../include/linux/compiler_types.h:328:38: error: call to ‘__compiletime_assert_162’ declared with attribute error: BUILD_BUG_ON failed: sizeof(struct page) > 80
Hmm.
struct {
long unsigned int _pt_pad_1; /* 8 8 */
pgtable_t pmd_huge_pte; /* 16 8 */
long unsigned int _pt_pad_2; /* 24 8 */
union {
struct mm_struct * pt_mm; /* 32 8 */
atomic_t pt_frag_refcount; /* 32 4 */
}; /* 32 8 */
spinlock_t ptl; /* 40 72 */
}; /* 8 104 */
#if ALLOC_SPLIT_PTLOCKS
spinlock_t *ptl;
#else
spinlock_t ptl;
#endif
something has disabled ALLOC_SPLIT_PTLOCKS when it ought to be enabled.
#if USE_SPLIT_PTE_PTLOCKS
#define ALLOC_SPLIT_PTLOCKS (SPINLOCK_SIZE > BITS_PER_LONG/8)
#else
#define ALLOC_SPLIT_PTLOCKS 0
#endif
Oh. This is Anshuman's fault.
commit 9b8a39056e2472592a5e5897987387f43038b8ba
Author: Anshuman Khandual <anshuman.khandual@arm.com>
Date: Tue May 11 15:06:01 2021 +1000
mm/thp: make ALLOC_SPLIT_PTLOCKS dependent on USE_SPLIT_PTE_PTLOCKS
next prev parent reply other threads:[~2021-05-13 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 5:44 linux-next: Tree for May 13 Stephen Rothwell
2021-05-13 17:29 ` linux-next: Tree for May 13 (mm/page_alloc.c, <linux/mm.h>: sizeof(struct page)) Randy Dunlap
2021-05-13 21:27 ` Matthew Wilcox [this message]
2021-05-18 4:03 ` Anshuman Khandual
2021-05-18 4:59 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ2ZvZaR9PTyPp8S@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).