From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
Thierry Reding <treding@nvidia.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the tegra tree
Date: Wed, 6 Oct 2021 20:00:32 +0200 [thread overview]
Message-ID: <YV3kQPYVKraegCf5@orome.fritz.box> (raw)
In-Reply-To: <445e6daa-f210-74c5-cf8d-4aa138136b7e@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6020 bytes --]
On Tue, Oct 05, 2021 at 02:54:43AM +0300, Dmitry Osipenko wrote:
> 05.10.2021 02:39, Stephen Rothwell пишет:
> > Hi all,
> >
> > After merging the tegra tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from arch/x86/include/asm/bug.h:84,
> > from include/linux/bug.h:5,
> > from arch/x86/include/asm/paravirt.h:15,
> > from arch/x86/include/asm/irqflags.h:63,
> > from include/linux/irqflags.h:16,
> > from include/linux/rcupdate.h:26,
> > from include/linux/rculist.h:11,
> > from include/linux/pid.h:5,
> > from include/linux/sched.h:14,
> > from include/linux/ratelimit.h:6,
> > from include/linux/dev_printk.h:16,
> > from include/linux/device.h:15,
> > from include/linux/of_reserved_mem.h:5,
> > from drivers/memory/tegra/tegra210-emc-table.c:6:
> > include/linux/clk/tegra.h: In function 'tegra_cpu_rail_off_ready':
> > include/linux/clk/tegra.h:112:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 112 | if (WARN_ON(!tegra_cpu_car_ops->rail_off_ready))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h:112:15: note: each undeclared identifier is reported only once for each function it appears in
> > 112 | if (WARN_ON(!tegra_cpu_car_ops->rail_off_ready))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h: In function 'tegra_cpu_clock_suspend':
> > include/linux/clk/tegra.h:120:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 120 | if (WARN_ON(!tegra_cpu_car_ops->suspend))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h: In function 'tegra_cpu_clock_resume':
> > include/linux/clk/tegra.h:128:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 128 | if (WARN_ON(!tegra_cpu_car_ops->resume))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > In file included from arch/x86/include/asm/bug.h:84,
> > from include/linux/bug.h:5,
> > from include/linux/cpumask.h:14,
> > from arch/x86/include/asm/cpumask.h:5,
> > from arch/x86/include/asm/msr.h:11,
> > from arch/x86/include/asm/processor.h:22,
> > from arch/x86/include/asm/timex.h:5,
> > from include/linux/timex.h:65,
> > from include/linux/time32.h:13,
> > from include/linux/time.h:60,
> > from include/linux/stat.h:19,
> > from include/linux/module.h:13,
> > from drivers/media/cec/platform/tegra/tegra_cec.c:14:
> > include/linux/clk/tegra.h: In function 'tegra_cpu_rail_off_ready':
> > include/linux/clk/tegra.h:112:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 112 | if (WARN_ON(!tegra_cpu_car_ops->rail_off_ready))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h:112:15: note: each undeclared identifier is reported only once for each function it appears in
> > 112 | if (WARN_ON(!tegra_cpu_car_ops->rail_off_ready))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h: In function 'tegra_cpu_clock_suspend':
> > include/linux/clk/tegra.h:120:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 120 | if (WARN_ON(!tegra_cpu_car_ops->suspend))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> > include/linux/clk/tegra.h: In function 'tegra_cpu_clock_resume':
> > include/linux/clk/tegra.h:128:15: error: 'tegra_cpu_car_ops' undeclared (first use in this function)
> > 128 | if (WARN_ON(!tegra_cpu_car_ops->resume))
> > | ^~~~~~~~~~~~~~~~~
> > include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> > 121 | int __ret_warn_on = !!(condition); \
> > | ^~~~~~~~~
> >
> > Presumably caused by commit
> >
> > bbe30ae68d14 ("cpuidle: tegra: Enable compile testing")
> >
> > I have used the tegra tree from next-20211001 for today.
> >
>
> Stephen, thank you. Now I recall what was the actual reason for my
> version of the patch [1]. Thierry, please use my original patch, thanks.
>
> [1]
> https://patchwork.ozlabs.org/project/linux-tegra/patch/20210912202907.28471-5-digetx@gmail.com/
Sorry, I forgot to reply to this yesterday. I found a simpler fix for
this and I pushed that yesterday. Today's linux-next didn't have the
build failure anymore, so I guess it worked.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-06 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 23:39 linux-next: build failure after merge of the tegra tree Stephen Rothwell
2021-10-04 23:54 ` Dmitry Osipenko
2021-10-06 18:00 ` Thierry Reding [this message]
2021-10-06 18:27 ` Dmitry Osipenko
-- strict thread matches above, loose matches on Subject: below --
2020-05-10 22:51 Stephen Rothwell
2020-05-12 21:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV3kQPYVKraegCf5@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=ccross@android.com \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sfr@canb.auug.org.au \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).