From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A05C433F5 for ; Mon, 21 Mar 2022 15:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350544AbiCUPrk (ORCPT ); Mon, 21 Mar 2022 11:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350517AbiCUPra (ORCPT ); Mon, 21 Mar 2022 11:47:30 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9B665370A; Mon, 21 Mar 2022 08:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AEeSeutZfJtu2nIPuVFGjj2ShykAWgOjHpmhtGwOQnc=; b=ban8yFbw+5HuTNu6qlubpGMcDs 3OBD6aMZ4bm1OggDFeh+2L2p0OzCRcUhhCeLzlYZnag6JQPpRlOdT7BIpikJipkVZzysYMNz747Pj YnGn5XuPWflO5LbmIM1PgDmdAUAZNEs1trbWwUp1pkgbQLfoPM382N+Uh5ToNU8h+pIKYRpUho8in JY236BxNqB2GSG3MUC2T/60BtDgxDgerC+ngYlr4Mj5oaQiCLY3thXipHQRD415FIKAo1G48Y6ebv lJQk5ooR1YXLwZ+qrO4kaLz2dRUzLXKQZpyKyCgOSpwZPo3HdlyPLzkxdfKuv0KXASDrXMBwdhVVo CUxgeiMQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWKE1-00AiA1-OO; Mon, 21 Mar 2022 15:45:41 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 936783001CD; Mon, 21 Mar 2022 16:45:40 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 31210203A7684; Mon, 21 Mar 2022 16:45:40 +0100 (CET) Date: Mon, 21 Mar 2022 16:45:40 +0100 From: Peter Zijlstra To: Stephen Rothwell Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List , Linux Next Mailing List , mhiramat@kernel.org, rostedt@goodmis.org, ast@kernel.org, hjl.tools@gmail.com, rick.p.edgecombe@intel.com, rppt@kernel.org, linux-toolchains@vger.kernel.org, Andrew.Cooper3@citrix.com, ndesaulniers@google.com, Linus Torvalds Subject: Re: linux-next: build warnings after merge of the tip tree Message-ID: References: <20220321140327.777f9554@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Mar 21, 2022 at 04:28:06PM +0100, Peter Zijlstra wrote: > On Mon, Mar 21, 2022 at 02:45:16PM +0100, Peter Zijlstra wrote: > > On Mon, Mar 21, 2022 at 02:08:23PM +0100, Peter Zijlstra wrote: > > > On Mon, Mar 21, 2022 at 02:04:05PM +0100, Peter Zijlstra wrote: > > > > On Mon, Mar 21, 2022 at 01:55:49PM +0100, Peter Zijlstra wrote: > > > > > On Mon, Mar 21, 2022 at 02:03:27PM +1100, Stephen Rothwell wrote: > > > > > > Hi all, > > > > > > > > > > > > After merging the tip tree, today's linux-next build (x864 allmodconfig) > > > > > > produced these new warnings: > > > > > > > > > > > > vmlinux.o: warning: objtool: arch_rethook_prepare()+0x55: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: arch_rethook_trampoline_callback()+0x3e: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x93e: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x5f2: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x4a7: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: __rethook_find_ret_addr()+0x81: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: __rethook_find_ret_addr()+0x90: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: rethook_trampoline_handler()+0x8c: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > vmlinux.o: warning: objtool: rethook_trampoline_handler()+0x9b: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > > > > > Hurmph, lemme go figure out where that code comes from, I've not seen > > > > > those. > > > > > > > > Ahh, something tracing. I'll go do some patches on top of it. > > > > > > Also, that x86 patch has never his x86@kernel.org and doesn't have an > > > ACK from any x86 person :-((( > > > > Worse, it adds a 3rd return trampoline without replacing any of the > > existing two :-( > > > > Why was this merged? > > It additionally gets ret wrong: > > vmlinux.o: warning: objtool: arch_rethook_trampoline()+0x4a: missing int3 after ret > > and afaict regs->ss is garbage (much like kretprobes it appears). > > Can we please unmerge this stuff and try again later? This landing in -next only today (after having been committed last friday night) is another clue it should probably go next round.