* linux-next: build warning after merge of the driver-core.current tree
@ 2022-04-21 5:26 Stephen Rothwell
2022-04-21 6:49 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2022-04-21 5:26 UTC (permalink / raw)
To: Greg KH
Cc: Greg Kroah-Hartman, Tony Luck, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
Hi all,
After merging the driver-core.current tree, today's linux-next build
(x86_64 allnoconfig) produced this warning:
drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
158 | struct device *dev = kobj_to_dev(kobj);
| ^~~
Introduced by commit
aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the driver-core.current tree
2022-04-21 5:26 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
@ 2022-04-21 6:49 ` Greg KH
2022-04-21 15:45 ` [PATCH] topology/sysfs: Fix allnoconfig build breakage Luck, Tony
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2022-04-21 6:49 UTC (permalink / raw)
To: Stephen Rothwell, Tony Luck
Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Apr 21, 2022 at 03:26:45PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allnoconfig) produced this warning:
>
> drivers/base/topology.c: In function 'topology_is_visible':
> drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
> 158 | struct device *dev = kobj_to_dev(kobj);
> | ^~~
>
> Introduced by commit
>
> aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")
Tony, can you please send a fixup patch for this, or should I just
revert this commit for now?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 6:49 ` Greg KH
@ 2022-04-21 15:45 ` Luck, Tony
2022-04-21 15:53 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Luck, Tony @ 2022-04-21 15:45 UTC (permalink / raw)
To: Greg KH
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
158 | struct device *dev = kobj_to_dev(kobj);
This is because the topology_ppin(dev->id) macro expands to:
(cpu_data(dev->id).ppin)
and with CONFIG_SMP=n the cpu_data() macro expands to boot_cpu_data
(ignoring its argument) with the end result:
boot_cpu_data.ppin
My CPP-fu wasn't up to a modification to topology_ppin(), so I added a
(probably redundant) check for "dev" being a NULL pointer.
Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Better fixes with clever CPP macro tricks gratefully welcomed
---
drivers/base/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/topology.c b/drivers/base/topology.c
index 706dbf8bf249..31fae51fd340 100644
--- a/drivers/base/topology.c
+++ b/drivers/base/topology.c
@@ -157,7 +157,7 @@ static umode_t topology_is_visible(struct kobject *kobj,
{
struct device *dev = kobj_to_dev(kobj);
- if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
+ if (!dev || (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id)))
return 0;
return attr->mode;
--
2.35.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 15:45 ` [PATCH] topology/sysfs: Fix allnoconfig build breakage Luck, Tony
@ 2022-04-21 15:53 ` Greg KH
2022-04-21 16:19 ` [PATCH v2] " Luck, Tony
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2022-04-21 15:53 UTC (permalink / raw)
To: Luck, Tony
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Apr 21, 2022 at 08:45:34AM -0700, Luck, Tony wrote:
> drivers/base/topology.c: In function 'topology_is_visible':
> drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
> 158 | struct device *dev = kobj_to_dev(kobj);
>
> This is because the topology_ppin(dev->id) macro expands to:
>
> (cpu_data(dev->id).ppin)
>
> and with CONFIG_SMP=n the cpu_data() macro expands to boot_cpu_data
> (ignoring its argument) with the end result:
>
> boot_cpu_data.ppin
>
> My CPP-fu wasn't up to a modification to topology_ppin(), so I added a
> (probably redundant) check for "dev" being a NULL pointer.
>
> Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
>
> ---
> Better fixes with clever CPP macro tricks gratefully welcomed
> ---
> drivers/base/topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/topology.c b/drivers/base/topology.c
> index 706dbf8bf249..31fae51fd340 100644
> --- a/drivers/base/topology.c
> +++ b/drivers/base/topology.c
> @@ -157,7 +157,7 @@ static umode_t topology_is_visible(struct kobject *kobj,
> {
> struct device *dev = kobj_to_dev(kobj);
>
> - if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
> + if (!dev || (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id)))
!dev is impossible to ever hit, that's the sign that the code is wrong
and needs to be fixed :(
Sorry, this is not going to be an acceptable change.
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 15:53 ` Greg KH
@ 2022-04-21 16:19 ` Luck, Tony
2022-04-21 23:22 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Luck, Tony @ 2022-04-21 16:19 UTC (permalink / raw)
To: Greg KH
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
158 | struct device *dev = kobj_to_dev(kobj);
This is because the topology_ppin(dev->id) macro expands to:
(cpu_data(dev->id).ppin)
and with CONFIG_SMP=n the cpu_data() macro expands to boot_cpu_data
(ignoring its argument) with the end result:
boot_cpu_data.ppin
Fix by just checking whether the boot_cpu has a PPIN instead of whether
this specific CPU has one.
Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
I don't believe it will ever be possible to have no PPIN on the boot CPU,
but somehow have PPINs on other CPUs (or vice versa)
drivers/base/topology.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/base/topology.c b/drivers/base/topology.c
index 706dbf8bf249..11a56a10188d 100644
--- a/drivers/base/topology.c
+++ b/drivers/base/topology.c
@@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = {
static umode_t topology_is_visible(struct kobject *kobj,
struct attribute *attr, int unused)
{
- struct device *dev = kobj_to_dev(kobj);
-
- if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
+ if (attr == &dev_attr_ppin.attr && !boot_cpu_data.ppin)
return 0;
return attr->mode;
--
2.35.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 16:19 ` [PATCH v2] " Luck, Tony
@ 2022-04-21 23:22 ` Stephen Rothwell
2022-04-21 23:38 ` Luck, Tony
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2022-04-21 23:22 UTC (permalink / raw)
To: Luck, Tony; +Cc: Greg KH, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
Hi Tony,
On Thu, 21 Apr 2022 09:19:59 -0700 "Luck, Tony" <tony.luck@intel.com> wrote:
>
> Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
This is actually commit aa63a74d4535.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 23:22 ` Stephen Rothwell
@ 2022-04-21 23:38 ` Luck, Tony
2022-04-22 0:00 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Luck, Tony @ 2022-04-21 23:38 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, Linux Kernel Mailing List, Linux Next Mailing List
>> Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
>
> This is actually commit aa63a74d4535.
Doh! I looked in my tree, not in Greg's.
Doesn't matter much, Greg is going to revert as I haven't come up with a good[1]
way to fix this.
-Tony
[1] I found two bad ways. First one made Greg barf. This one breaks the build for over
50% of supported architectures :-(
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-21 23:38 ` Luck, Tony
@ 2022-04-22 0:00 ` Stephen Rothwell
2022-04-22 2:51 ` Luck, Tony
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2022-04-22 0:00 UTC (permalink / raw)
To: Luck, Tony; +Cc: Greg KH, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
Hi Tony,
On Thu, 21 Apr 2022 23:38:28 +0000 "Luck, Tony" <tony.luck@intel.com> wrote:
>
> >> Fixes: c3702a746ff5 ("topology/sysfs: Hide PPIN on systems that do not support it.")
> >
> > This is actually commit aa63a74d4535.
>
> Doh! I looked in my tree, not in Greg's.
>
> Doesn't matter much, Greg is going to revert as I haven't come up with a good[1]
> way to fix this.
>
> -Tony
>
> [1] I found two bad ways. First one made Greg barf. This one breaks the build for over
> 50% of supported architectures :-(
I assume that there is some good reason that topology_ppin() is not
implemented as a static inline function?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-22 0:00 ` Stephen Rothwell
@ 2022-04-22 2:51 ` Luck, Tony
2022-04-22 6:00 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Luck, Tony @ 2022-04-22 2:51 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Apr 22, 2022 at 10:00:54AM +1000, Stephen Rothwell wrote:
> I assume that there is some good reason that topology_ppin() is not
> implemented as a static inline function?
I don't think so. I just cut & pasted how all the other topology_*()
things were implemented.
Making it a static inline appears to fix this problem. But before
embarrassing myself with a third broken version I'll let zero day
crunch on:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git hide_ppin
to see if there is some subtle config or arch where the inline trick
doesn't work.
Thanks for the idea! :-)
-Tony
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-22 2:51 ` Luck, Tony
@ 2022-04-22 6:00 ` Greg KH
2022-04-22 6:27 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2022-04-22 6:00 UTC (permalink / raw)
To: Luck, Tony
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Apr 21, 2022 at 07:51:02PM -0700, Luck, Tony wrote:
> On Fri, Apr 22, 2022 at 10:00:54AM +1000, Stephen Rothwell wrote:
> > I assume that there is some good reason that topology_ppin() is not
> > implemented as a static inline function?
>
> I don't think so. I just cut & pasted how all the other topology_*()
> things were implemented.
>
> Making it a static inline appears to fix this problem. But before
> embarrassing myself with a third broken version I'll let zero day
> crunch on:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git hide_ppin
>
> to see if there is some subtle config or arch where the inline trick
> doesn't work.
>
> Thanks for the idea! :-)
Why not just do the following, which passes my build tests here:
diff --git a/drivers/base/topology.c b/drivers/base/topology.c
index 706dbf8bf249..ac6ad9ab67f9 100644
--- a/drivers/base/topology.c
+++ b/drivers/base/topology.c
@@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = {
static umode_t topology_is_visible(struct kobject *kobj,
struct attribute *attr, int unused)
{
- struct device *dev = kobj_to_dev(kobj);
-
- if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
+ if (attr == &dev_attr_ppin.attr && !topology_ppin(kobj_to_dev(kobj)->id))
return 0;
return attr->mode;
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2] topology/sysfs: Fix allnoconfig build breakage.
2022-04-22 6:00 ` Greg KH
@ 2022-04-22 6:27 ` Greg KH
0 siblings, 0 replies; 15+ messages in thread
From: Greg KH @ 2022-04-22 6:27 UTC (permalink / raw)
To: Luck, Tony
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Apr 22, 2022 at 08:00:50AM +0200, Greg KH wrote:
> On Thu, Apr 21, 2022 at 07:51:02PM -0700, Luck, Tony wrote:
> > On Fri, Apr 22, 2022 at 10:00:54AM +1000, Stephen Rothwell wrote:
> > > I assume that there is some good reason that topology_ppin() is not
> > > implemented as a static inline function?
> >
> > I don't think so. I just cut & pasted how all the other topology_*()
> > things were implemented.
> >
> > Making it a static inline appears to fix this problem. But before
> > embarrassing myself with a third broken version I'll let zero day
> > crunch on:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git hide_ppin
> >
> > to see if there is some subtle config or arch where the inline trick
> > doesn't work.
> >
> > Thanks for the idea! :-)
>
> Why not just do the following, which passes my build tests here:
>
>
> diff --git a/drivers/base/topology.c b/drivers/base/topology.c
> index 706dbf8bf249..ac6ad9ab67f9 100644
> --- a/drivers/base/topology.c
> +++ b/drivers/base/topology.c
> @@ -155,9 +155,7 @@ static struct attribute *default_attrs[] = {
> static umode_t topology_is_visible(struct kobject *kobj,
> struct attribute *attr, int unused)
> {
> - struct device *dev = kobj_to_dev(kobj);
> -
> - if (attr == &dev_attr_ppin.attr && !topology_ppin(dev->id))
> + if (attr == &dev_attr_ppin.attr && !topology_ppin(kobj_to_dev(kobj)->id))
> return 0;
>
> return attr->mode;
I've sent this as real patch now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the driver-core.current tree
2010-04-29 23:45 ` Greg KH
@ 2010-04-30 0:01 ` Stephen Rothwell
0 siblings, 0 replies; 15+ messages in thread
From: Stephen Rothwell @ 2010-04-30 0:01 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, linux-kernel, David Woodhouse, Tomas Winkler
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
Hi Greg,
On Thu, 29 Apr 2010 16:45:25 -0700 Greg KH <greg@kroah.com> wrote:
>
> > Thanks, I've fixed this up, the release call should not have 'const'
> > on it as it is going to touch the pointer passed to it :)
>
> And it's now pushed out in my tree.
Excellent, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the driver-core.current tree
2010-04-29 23:43 ` Greg KH
@ 2010-04-29 23:45 ` Greg KH
2010-04-30 0:01 ` Stephen Rothwell
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2010-04-29 23:45 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, David Woodhouse, Tomas Winkler
On Thu, Apr 29, 2010 at 04:43:47PM -0700, Greg KH wrote:
> On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> > Hi Grant,
> >
> > After merging the driver-core.current tree, today's linux-next build
> > (x86_64 allmodconfig) produced this warning:
> >
> > drivers/base/firmware_class.c: In function 'release_firmware':
> > drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> > drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> >
> > Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> > ("firmware_class: fix memory leak - free allocated pages").
>
> Thanks, I've fixed this up, the release call should not have 'const'
> on it as it is going to touch the pointer passed to it :)
And it's now pushed out in my tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: linux-next: build warning after merge of the driver-core.current tree
2010-04-29 23:35 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
@ 2010-04-29 23:43 ` Greg KH
2010-04-29 23:45 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2010-04-29 23:43 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, David Woodhouse, Tomas Winkler
On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> Hi Grant,
>
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/base/firmware_class.c: In function 'release_firmware':
> drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
>
> Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> ("firmware_class: fix memory leak - free allocated pages").
Thanks, I've fixed this up, the release call should not have 'const'
on it as it is going to touch the pointer passed to it :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* linux-next: build warning after merge of the driver-core.current tree
@ 2010-04-29 23:35 Stephen Rothwell
2010-04-29 23:43 ` Greg KH
0 siblings, 1 reply; 15+ messages in thread
From: Stephen Rothwell @ 2010-04-29 23:35 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, linux-kernel, David Woodhouse, Tomas Winkler
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Hi Grant,
After merging the driver-core.current tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:
drivers/base/firmware_class.c: In function 'release_firmware':
drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
("firmware_class: fix memory leak - free allocated pages").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-04-22 6:27 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 5:26 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
2022-04-21 6:49 ` Greg KH
2022-04-21 15:45 ` [PATCH] topology/sysfs: Fix allnoconfig build breakage Luck, Tony
2022-04-21 15:53 ` Greg KH
2022-04-21 16:19 ` [PATCH v2] " Luck, Tony
2022-04-21 23:22 ` Stephen Rothwell
2022-04-21 23:38 ` Luck, Tony
2022-04-22 0:00 ` Stephen Rothwell
2022-04-22 2:51 ` Luck, Tony
2022-04-22 6:00 ` Greg KH
2022-04-22 6:27 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-04-29 23:35 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
2010-04-29 23:43 ` Greg KH
2010-04-29 23:45 ` Greg KH
2010-04-30 0:01 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).