From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2B6C433EF for ; Thu, 12 May 2022 12:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353633AbiELMXY (ORCPT ); Thu, 12 May 2022 08:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244210AbiELMXW (ORCPT ); Thu, 12 May 2022 08:23:22 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1852211E1EE for ; Thu, 12 May 2022 05:23:21 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id n8so4416832qke.11 for ; Thu, 12 May 2022 05:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/dqcXTObxTtO1V6/bZade+lRAjqtWrFdg0RrAzpzvMc=; b=kMzS8vTGcfljyvBPw+zA5U4fV+xgXwoWkeP5GZCv+jUmhDvG7DmroDuFk9j0B0wi6d 4OWaXMUM/zg1DqHG35P2jypybc3RqSpsGQ9nFhx1iaddGMEtxYA9k5gISq3EtWYescX9 LOf+M8jVzAvQ3EViKcJDXXkw9/Ua151rwj2tMki7WvgU5aYfsd4erpljcuz9daR0W71n MsUbuNWHkONE46UqG5l6O/j7kF/5sRYY7TN8jpd2gdpXLYbUyy28OGetV9xEXj0lf83l 3m5HRjcOCTV4yZC/W/w+spIhqIZAMAD6f4BXnm1yYsvTXQzWEqokuvqhX/vdxis19I7D desg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dqcXTObxTtO1V6/bZade+lRAjqtWrFdg0RrAzpzvMc=; b=26mfI+00onwEAQTkNV+d2H3kGdMhahxtYBk/MhCYIQ9ikxZ4STHBqPAyAsO0avifwY ZsduYnajpcyd4G7vZoI+XoqrQ+KegIZHMMARk+3FEv8zphnV5eysLyYcFnxCZxOqILMz HjYePAqQJj413oT0p9cqPt98G6BdRd5lWE8UbNrsU3EnPoWNU9xQnFkvG9vOBYaFAPl7 lhx5oRTbm3lBInGaEn7Lt2fUpGINrMEpxwZ0Afutjs3d5SHBZGstdeOG33TJaq6Sk+t5 UTl+W0PZoxB0eorM2Qey2YfIOtPPKDfjwxu6WwZmefUtcgDMjq4wJl5emVQnRIfmqA/2 0L8w== X-Gm-Message-State: AOAM530FrUtcQpmdrldRo5QIANCEWzLjlkxhRlGML2sGikAkod9Hzky+ HaPY46vH2wvThsYKD52lWZ9wcdkWwjnraA== X-Google-Smtp-Source: ABdhPJwzBHgPAHf2HQk8rCbT71hRtFDjr+O1EShN21bHsc+FkfTfeygnqsW74ivRYIADcxGQbTFwhA== X-Received: by 2002:a05:620a:2545:b0:680:a456:ba9e with SMTP id s5-20020a05620a254500b00680a456ba9emr23013666qko.490.1652358200237; Thu, 12 May 2022 05:23:20 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:14fe]) by smtp.gmail.com with ESMTPSA id b8-20020a05620a04e800b0069fc13ce22esm2798975qkh.95.2022.05.12.05.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 05:23:19 -0700 (PDT) Date: Thu, 12 May 2022 08:23:18 -0400 From: Johannes Weiner To: Stephen Rothwell Cc: Andrew Morton , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the mm tree Message-ID: References: <20220512194607.74ee330d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512194607.74ee330d@canb.auug.org.au> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, May 12, 2022 at 07:46:07PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the mm tree, today's linux-next build (powerpc allnoconfig, > powerpc ppc44x_defconfig and arm64 defconfig) produced this warning: > > WARNING: unmet direct dependencies detected for ARCH_ENABLE_MEMORY_HOTREMOVE > Depends on [n]: MEMORY_HOTPLUG [=n] > Selected by [y]: > - PPC [=y] > Building: powerpc64 allnoconfig > > WARNING: unmet direct dependencies detected for ARCH_ENABLE_MEMORY_HOTREMOVE > Depends on [n]: MEMORY_HOTPLUG [=n] > Selected by [y]: > - PPC [=y] > > WARNING: unmet direct dependencies detected for ARCH_ENABLE_MEMORY_HOTREMOVE > Depends on [n]: MEMORY_HOTPLUG [=n] > Selected by [y]: > - ARM64 [=y] > > WARNING: unmet direct dependencies detected for ARCH_ENABLE_MEMORY_HOTREMOVE > Depends on [n]: MEMORY_HOTPLUG [=n] > Selected by [y]: > - ARM64 [=y] > > Probably introduced by commit > > 52bc69c65c03 ("mm: Kconfig: group swap, slab, hotplug and thp options into submenus") Sorry about the noise, I must be blind. And x86 does arch/x86/Kconfig: select ARCH_ENABLE_MEMORY_HOTREMOVE if MEMORY_HOTPLUG that's why it didn't trigger for me. This should be the last one, I triple checked the commit. --- >From 588d2c5ba815df3b8028e198b7543a5450c24b33 Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Thu, 12 May 2022 08:11:17 -0400 Subject: [PATCH] mm: Kconfig: group swap, slab, hotplug and thp options into submenus fix fix WARNING: unmet direct dependencies detected for ARCH_ENABLE_MEMORY_HOTREMOVE Depends on [n]: MEMORY_HOTPLUG [=n] Selected by [y]: - PPC [=y] This is a symbol for the architecture to declare a feature. It mustn't be conditional on user selection. Move it out of 'if MEMORY_HOTPLUG'. Reported-by: Stephen Rothwell Signed-off-by: Johannes Weiner --- mm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index c2f4a547ab00..f63d8dc36511 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -436,6 +436,9 @@ config HAVE_BOOTMEM_INFO_NODE config ARCH_ENABLE_MEMORY_HOTPLUG bool +config ARCH_ENABLE_MEMORY_HOTREMOVE + bool + # eventually, we can have this option just 'select SPARSEMEM' menuconfig MEMORY_HOTPLUG bool "Memory hotplug" @@ -462,9 +465,6 @@ config MEMORY_HOTPLUG_DEFAULT_ONLINE Say N here if you want the default policy to keep all hot-plugged memory blocks in 'offline' state. -config ARCH_ENABLE_MEMORY_HOTREMOVE - bool - config MEMORY_HOTREMOVE bool "Allow for memory hot remove" select HAVE_BOOTMEM_INFO_NODE if (X86_64 || PPC64) -- 2.35.3