From: Yury Norov <yury.norov@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: linux-next: build warning after merge of the bluetooth tree
Date: Sun, 5 Jun 2022 15:40:27 -0700 [thread overview]
Message-ID: <Yp0w21pH4R6WaC1R@yury-laptop> (raw)
In-Reply-To: <20220606080631.0c3014f2@canb.auug.org.au>
On Mon, Jun 06, 2022 at 08:06:31AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 24 May 2022 08:22:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 16 May 2022 17:57:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the bluetooth tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > In file included from include/linux/cpumask.h:12,
> > > from include/linux/mm_types_task.h:14,
> > > from include/linux/mm_types.h:5,
> > > from include/linux/buildid.h:5,
> > > from include/linux/module.h:14,
> > > from net/bluetooth/mgmt.c:27:
> > > In function 'bitmap_copy',
> > > inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:270:2,
> > > inlined from 'bitmap_from_u64' at include/linux/bitmap.h:622:2,
> > > inlined from 'set_device_flags' at net/bluetooth/mgmt.c:4534:4:
> > > include/linux/bitmap.h:261:9: warning: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] of object 'flags' with type 'long unsigned int[1]' [-Warray-bounds]
> > > 261 | memcpy(dst, src, len);
> > > | ^~~~~~~~~~~~~~~~~~~~~
> > > In file included from include/linux/kasan-checks.h:5,
> > > from include/asm-generic/rwonce.h:26,
> > > from ./arch/arm/include/generated/asm/rwonce.h:1,
> > > from include/linux/compiler.h:248,
> > > from include/linux/build_bug.h:5,
> > > from include/linux/container_of.h:5,
> > > from include/linux/list.h:5,
> > > from include/linux/module.h:12,
> > > from net/bluetooth/mgmt.c:27:
> > > net/bluetooth/mgmt.c: In function 'set_device_flags':
> > > net/bluetooth/mgmt.c:4532:40: note: 'flags' declared here
> > > 4532 | DECLARE_BITMAP(flags, __HCI_CONN_NUM_FLAGS);
> > > | ^~~~~
> > > include/linux/types.h:11:23: note: in definition of macro 'DECLARE_BITMAP'
> > > 11 | unsigned long name[BITS_TO_LONGS(bits)]
> > > | ^~~~
> > >
> > > Introduced by commit
> > >
> > > a9a347655d22 ("Bluetooth: MGMT: Add conditions for setting HCI_CONN_FLAG_REMOTE_WAKEUP")
> > >
> > > Bitmaps consist of unsigned longs (in this case 32 bits) ...
> > >
> > > (This warning only happens due to chnges in the bitmap tree.)
> >
> > I still got this warning yesterday ...
>
> And today, I get this warning when build Linus' tree :-(
Hi Stephen,
I completely forgot about this bug, and sent a quick fix when this
was spotted by Sudip [1]. Linus proposed another fix [2] that drops
bitmap API in net/bluetooth/mgmt.c.
I would prefer Linus' version, and this is the way I already suggested
to Luiz before in this thread.
Thanks,
Yury
[1] https://lore.kernel.org/lkml/YpyJ9qTNHJzz0FHY@debian/t/
[2] https://lore.kernel.org/lkml/CAHk-=whqgEA=OOPQs7JF=xps3VxjJ5uUnfXgzTv4gqTDhraZFA@mail.gmail.com/T/#mcf29754f405443ca7d2a18db863c7a20439bd5a0
next prev parent reply other threads:[~2022-06-05 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 7:57 linux-next: build warning after merge of the bluetooth tree Stephen Rothwell
2022-05-23 22:22 ` Stephen Rothwell
2022-06-05 22:06 ` Stephen Rothwell
2022-06-05 22:40 ` Yury Norov [this message]
2022-06-06 1:16 ` Stephen Rothwell
[not found] <PH0PR11MB51264FB7874380983C3A653BD3CF9@PH0PR11MB5126.namprd11.prod.outlook.com>
2022-05-16 18:18 ` Yury Norov
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 0:07 Stephen Rothwell
2019-03-17 23:30 Stephen Rothwell
2017-11-14 0:56 Stephen Rothwell
2017-11-14 9:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp0w21pH4R6WaC1R@yury-laptop \
--to=yury.norov@gmail.com \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).