From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Conor Dooley <conor.dooley@microchip.com>
Cc: Linux Crypto List <linux-crypto@vger.kernel.org>,
Huan Feng <huan.feng@starfivetech.com>,
Jia Jie Ho <jiajie.ho@starfivetech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it
Date: Tue, 23 May 2023 10:33:38 +0800 [thread overview]
Message-ID: <ZGwmAp5RPqAjVMCg@gondor.apana.org.au> (raw)
In-Reply-To: <20230523103637.20175fbc@canb.auug.org.au>
On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote:
>
> That did not fix it :-(
OK, this patch should fix it:
---8<---
A platform option like AMBA should never be selected by a driver.
Use a dependency instead.
Also remove the depenency on DMADEVICES because the driver builds
just fine without it. Instead add a dependency on HAS_DMA for dma
mapping support.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig
index 908c162ba79a..59002abcc0ad 100644
--- a/drivers/crypto/starfive/Kconfig
+++ b/drivers/crypto/starfive/Kconfig
@@ -4,14 +4,13 @@
config CRYPTO_DEV_JH7110
tristate "StarFive JH7110 cryptographic engine driver"
- depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES
+ depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST
+ depends on HAS_DMA
select CRYPTO_ENGINE
select CRYPTO_HMAC
select CRYPTO_SHA256
select CRYPTO_SHA512
select CRYPTO_SM3_GENERIC
- select ARM_AMBA
- select AMBA_PL08X
help
Support for StarFive JH7110 crypto hardware acceleration engine.
This module provides acceleration for public key algo,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-05-23 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 0:52 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2023-05-22 5:15 ` Herbert Xu
2023-05-23 0:36 ` Stephen Rothwell
2023-05-23 2:33 ` Herbert Xu [this message]
2023-05-23 6:56 ` [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it Conor Dooley
2023-05-23 7:31 ` Jia Jie Ho
2023-05-25 1:25 ` Stephen Rothwell
2023-06-06 9:12 ` Geert Uytterhoeven
2023-06-06 9:31 ` Herbert Xu
2023-06-06 9:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGwmAp5RPqAjVMCg@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=conor.dooley@microchip.com \
--cc=huan.feng@starfivetech.com \
--cc=jiajie.ho@starfivetech.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).