Re: [PATCH next] Fix the build failed caused by -Wstringop-overflow

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Wenyu Huang <huangwenyu5@huawei.com>,
	pmladek@suse.com, rostedt@goodmis.org, linux@rasmusvillemoes.dk,
	senozhatsky@chromium.org, akpm@linux-foundation.org,
	linux-next@vger.kernel.org, gustavoars@kernel.org
Subject: Re: [PATCH next] Fix the build failed caused by -Wstringop-overflow
Date: Thu, 30 Nov 2023 20:05:17 +0200	[thread overview]
Message-ID: <ZWjO3dAJonO05JYI@smile.fi.intel.com> (raw)
In-Reply-To: <508507b2-be1d-403a-876e-f49f5d0a2a49@embeddedor.com>

On Thu, Nov 30, 2023 at 11:56:29AM -0600, Gustavo A. R. Silva wrote:
> On 11/30/23 11:48, Andy Shevchenko wrote:
> > On Thu, Nov 30, 2023 at 09:52:42AM -0600, Gustavo A. R. Silva wrote:
> > > On 11/30/23 04:57, Wenyu Huang wrote:

...

> > > > Fixes: 89741e7e42f6 ("Makefile: Enable -Wstringop-overflow globally")
> > > 
> > > The commit ID is from a patch that's currently in linux-next, which
> > > does not guarantee it's a stable commit. So, it shouldn't be used
> > > for any tag in any changelog text. In fact, it has changed a couple
> > > of times in the last couple of weeks.
> > 
> > I disagree on this in general.
> > 
> > The case in practice I have. I does something in new cycle that broke the
> > enumeration of some devices. The patch is in the maintainer's tree pending
> > for the next release (v6.8-rc1). There are I see two options:
> > - revert patch completely and redo it properly
> > - add a fix (which is one liner)
> > 
> > Now, what you are suggesting is to drop the Fixes tag on the grounds that
> > the culprit and the fix are to be in the same release (as we go let's say
> > with the latter approach). In case that the culprit will be backported
> > (let's say to satisfy dependencies, as per se it's not a fix), it will
> > bring a regression and become unnoticed for some time until first reports
> > will appear. Additional resources would be need for all this.
> > 
> > So, I'm fully in favour of using Fixes tag as it makes clear if we have
> > some broken changes in the kernel for which the fix is known and exists.
> 
> I'm fully in favor, as well. :)
> 
> I'm talking about patches in linux-next, exclusively.

And I am. And I think it's a good practice independently on the Linux Next
case. The only what you should think about is that the maintainer has to
take care about proper commit ID in case they rebase their tree (spoiler:
they shouldn't in 99.99% of cases).

My "in general" was to make sure we are on the page not specifically related
to _this_ patch.

-- 
With Best Regards,
Andy Shevchenko