From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77A2BF9D6; Fri, 22 Dec 2023 09:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cbauCZsW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64C1BC433C7; Fri, 22 Dec 2023 09:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703238307; bh=xZfg4L5TU7fI1+1+F6mSp16buS2mVlhYp0S//OYZt+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cbauCZsW3Gu1ZFsRvqmf+PIh0wkQoPpdwzr3/LbX5jf9pNO/yIKlnLV32thjaOzOg qWFKljJZdvRQTfmmFjcJSfWO7do9VSO6pb8fZ0rUjCEgrZWOgMKpFblV6X2LXHwlHp JGXDEbvN2K6/YfzmlfBdJSC/Tp6aeaUBrpBWF/+f2mUKXLPnejHAmPRkuQwzt29gDj O9rBwMmfqewY/Rr8SJF6mL2mW1p1TnqwpLf/bFkf7aacQT4N4LVAeXYOP3e1A8fd/n WKKt3hs516tKemejFCvds27UXUq6mRkIgTAQwJuCobJa300ZBDZHdH7w0CmXNRr5D0 qeuUG/kg+23sw== Date: Fri, 22 Dec 2023 15:15:01 +0530 From: Vinod Koul To: Stephen Rothwell Cc: Jan Kuliga , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the dmaengine tree Message-ID: References: <20231222142956.3ee9749f@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231222142956.3ee9749f@canb.auug.org.au> On 22-12-23, 14:29, Stephen Rothwell wrote: > Hi all, > > After merging the dmaengine tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes] > 729 | xdma_prep_interleaved_dma(struct dma_chan *chan, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Introduced by commit > > 01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers") > > It should probably be static. Right, fixed and sent the patch https://lore.kernel.org/all/20231222094001.731889-1-vkoul@kernel.org/ Thanks for the report -- ~Vinod