linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the bitmap tree
Date: Wed, 8 May 2024 21:24:41 +0800	[thread overview]
Message-ID: <Zjt9GRTRgjfgtOwd@visitorckw-System-Product-Name> (raw)
In-Reply-To: <20240508162755.7d339509@canb.auug.org.au>

On Wed, May 08, 2024 at 04:27:55PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bitmap tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> lib/test_bitops.c: In function 'test_fns':
> lib/test_bitops.c:56:9: error: cleanup argument not a function
>    56 |         unsigned long *buf __free(kfree) = NULL;
>       |         ^~~~~~~~
> lib/test_bitops.c:60:15: error: implicit declaration of function 'kmalloc_array' [-Werror=implicit-function-declaration]
>    60 |         buf = kmalloc_array(10000, sizeof(unsigned long), GFP_KERNEL);
>       |               ^~~~~~~~~~~~~
> lib/test_bitops.c:60:13: error: assignment to 'long unsigned int *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>    60 |         buf = kmalloc_array(10000, sizeof(unsigned long), GFP_KERNEL);
>       |             ^
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   777c893e12fa ("lib/test_bitops: Add benchmark test for fns()")
>
> I have used the bitmap tree from next-20240507 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

Hi Yury,

I believe the following patch can resolve this issue. If you agree that
this patch is correct, could you help me fold it into the commit that
caused the error mentioned above?

Regards,
Kuan-Wei

From e028ad2415fc1b9cf7f59faa298ac7d6c2723b4a Mon Sep 17 00:00:00 2001
From: Kuan-Wei Chiu <visitorckw@gmail.com>
Date: Wed, 8 May 2024 21:16:50 +0800
Subject: [PATCH] lib/test_bitops: Fix compilation error on ppc64_defconfig

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
 lib/test_bitops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/test_bitops.c b/lib/test_bitops.c
index ee4759ced0f6..564bc486b599 100644
--- a/lib/test_bitops.c
+++ b/lib/test_bitops.c
@@ -8,6 +8,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/printk.h>
+#include <linux/slab.h>
 
 /* a tiny module only meant to test
  *
-- 
2.34.1




  reply	other threads:[~2024-05-08 13:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  6:27 linux-next: build failure after merge of the bitmap tree Stephen Rothwell
2024-05-08 13:24 ` Kuan-Wei Chiu [this message]
2024-05-08 22:18   ` Yury Norov
  -- strict thread matches above, loose matches on Subject: below --
2023-10-20  4:49 Stephen Rothwell
2023-10-19  6:01 Stephen Rothwell
2023-10-19 15:58 ` Yury Norov
2023-10-20  4:24   ` Yury Norov
2023-10-20  4:51     ` Stephen Rothwell
2023-10-20 12:33       ` Yury Norov
2023-11-02 11:41         ` Alexander Lobakin
2022-09-26 23:53 broonie
2022-09-27  0:37 ` Yury Norov
2022-09-27 18:56   ` Mark Brown
2022-09-20  8:08 Stephen Rothwell
2022-09-20 14:49 ` Yury Norov
2022-07-27 10:29 Stephen Rothwell
2022-07-22  9:16 Stephen Rothwell
2022-07-22 19:29 ` Yury Norov
2022-07-15 10:29 Stephen Rothwell
2022-07-08  7:47 Stephen Rothwell
2022-05-02  8:15 Stephen Rothwell
2022-04-19  4:29 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zjt9GRTRgjfgtOwd@visitorckw-System-Product-Name \
    --to=visitorckw@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).