From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67830C0015E for ; Tue, 15 Aug 2023 16:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231821AbjHOQVC (ORCPT ); Tue, 15 Aug 2023 12:21:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238477AbjHOQUm (ORCPT ); Tue, 15 Aug 2023 12:20:42 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C040E110 for ; Tue, 15 Aug 2023 09:20:41 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686f74a8992so804942b3a.1 for ; Tue, 15 Aug 2023 09:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1692116441; x=1692721241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TdxYwnLPec1MidJur/zecjHkvcyfCyI9WQjbMF3wcS8=; b=vyVpwe6k5qqVpx87pXYNaqSEyPyOV08XF8rrkniWizN7Ixcm53113jUPxVs63ieQku /k0e8QDhDielPuyZClzs/ud8xDAEmhzivtE7LzvZxfRyQxK24WwCUBVfjKyagrFuzYjM riomaGCFPwXiRkmNriROYB+k0ydZbXbTlw7/K1kFY4qGokzoMteD9l55x+HM34zap1hB OmXwCeJgWlhSjypVoKSyBVW7ES2cfiFXEwd9BSMXPClaU8KH4yv/2EZNrRgKidOyS3RR sZAkFunB60DGELTFy0ybFFWM7je0vSjG+q9m0sPnZ6cEwaCQATT8KiGd2iIAJqnfVMmP Qbyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692116441; x=1692721241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TdxYwnLPec1MidJur/zecjHkvcyfCyI9WQjbMF3wcS8=; b=R8fTXOv58BFNI1nK1FM2rASoJQJDHqQ0Q8rF2xnxOQgDXEx/pcT2W+IzOPsA6Ssuz0 qBTUjFVVaQBEffQoZMR7Nt6pv6Y+kugu46baTgrvoK5GMZop+j4bG2bA/4xMUgISwV25 TTXBF93xG1YN5q3UaCQW/HcYe+IvKP7tLnH3KlrLxE6pYLbaT1dRLywsewPdF+fEWIXt D1LHVBoFjAdGpQ9jJg/L/oLBzPEOxskmZABlr3JoD8uYgrivRXvc3SSwEDkNAEMvaxNI PyHPBSbs/OebsfJupMXxJFGd3H8H3Ssr1bK/WHwUSk6tvGQPbrxGDV/2OyVT7po8+wX6 GvrQ== X-Gm-Message-State: AOJu0YzYoU+55zCoB0jAYG4rtp64oiaAsUURg8ouomZtfTreiPGgHFiS k0Yzi108B5OEsgpIykiSeANL5A== X-Google-Smtp-Source: AGHT+IGbvO0FyIVIttj436tW6W4rd51Q6NzyuT+7tt2dsmuChWhUPB088VQ1SL+eJ/oBKERqUO//qQ== X-Received: by 2002:a05:6a20:9191:b0:12e:f6e6:882b with SMTP id v17-20020a056a20919100b0012ef6e6882bmr17320538pzd.1.1692116441236; Tue, 15 Aug 2023 09:20:41 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 25-20020aa79219000000b006884549adc8sm1495528pfo.29.2023.08.15.09.20.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 09:20:40 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 10:20:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: Fixes tag needs some work in the block tree Content-Language: en-US To: Song Liu Cc: Yu Kuai , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List , "yukuai (C)" References: <20230815091931.4dd2b277@canb.auug.org.au> <8c946512-0cc4-fbc5-ca36-0e2c6d636eb2@huaweicloud.com> <48f834c2-b283-4b02-9407-4a0842d4ed72@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 8/15/23 10:17 AM, Song Liu wrote: > On Wed, Aug 16, 2023 at 12:07?AM Jens Axboe wrote: >> >> On 8/15/23 9:58 AM, Song Liu wrote: >>> On Tue, Aug 15, 2023 at 11:08?PM Jens Axboe wrote: >>>> >>>> On 8/14/23 9:21 PM, Yu Kuai wrote: >>>>> Hi, >>>>> >>>>> ? 2023/08/15 7:19, Stephen Rothwell ??: >>>>>> Hi all, >>>>>> >>>>>> In commit >>>>>> >>>>>> 71070e7bd25d ("md/raid10: fix a 'conf->barrier' leakage in raid10_takeover()") >>>>>> >>>>>> Fixes tag >>>>>> >>>>>> Fixes: 4d27e927344a ("md: don't quiesce in mddev_suspend()") >>>>>> >>>>>> has these problem(s): >>>>>> >>>>>> - Target SHA1 does not exist >>>>> >>>>> Sorry about this, the commit was picked from previous md-next branch, >>>>> and I didn't know that it will change... >>>> >>>> It's most likely not your fault, I'm guessing Song rebased that branch >>>> and this is why the sha changed. Song? >>> >>> Yeah, it is my fault. I am really sorry for this issue. >>> >>>> >>>>> Is there any way that I can fix this ? >>>> >>>> Only way to fix this is if I rewind my branch and Song updates his >>>> branch to not have this issue, and then sends a new pull request. >>> >>> Yes please. Let's fix this. >> >> Please send a new one, I've dropped the old one. > > Is this the for-6.6/block branch? I haven't seen the change yet. The top > commit on the branch (as I see) is > > 306d74055754 ("ublk: Switch to memdup_user_nul() helper") Where are you looking? It's at: commit 66a6a5d0ec852eaced589da066376e69397cd71e (origin/for-6.6/block, for-6.6/block) Author: Ruan Jinjie Date: Tue Aug 15 19:48:14 2023 +0800 ublk: Switch to memdup_user_nul() helper since about 15 min ago. -- Jens Axboe