From: Guenter Roeck <linux@roeck-us.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Wim Van Sebroeck <wim@iguana.be>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the watchdog tree
Date: Tue, 15 Dec 2020 20:11:29 -0800 [thread overview]
Message-ID: <aa69afba-c9a8-0c64-d097-6b32c3f0a133@roeck-us.net> (raw)
In-Reply-To: <20201216135608.4e7a72e5@canb.auug.org.au>
[-- Attachment #1.1: Type: text/plain, Size: 1387 bytes --]
On 12/15/20 6:56 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Sun, 13 Dec 2020 22:09:55 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 12/13/20 9:23 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the watchdog tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> In file included from include/linux/device.h:15,
>>> from include/linux/acpi.h:15,
>>> from drivers/watchdog/iTCO_wdt.c:48:
>>> drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
>>> drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
>>> 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
>>> | ^~
>>
>> Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
>>
>> Guenter
>>
>>> include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
>>> 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
>>> | ^~~
>>>
>>> Caused by commit
>>>
>>> 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
>>
>>> I have used the wtchdog tree from next-20201211 for today.
>
> I am still getting this build failure.
>
Yes, we'll have to wait for Wim to either drop the patch or fix it up.
Guenter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-16 4:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 5:23 linux-next: build failure after merge of the watchdog tree Stephen Rothwell
2020-12-14 6:09 ` Guenter Roeck
2020-12-16 2:56 ` Stephen Rothwell
2020-12-16 4:11 ` Guenter Roeck [this message]
2020-12-16 15:27 ` Wim Van Sebroeck
2020-12-17 7:04 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 5:38 Stephen Rothwell
2021-06-21 8:08 ` Wim Van Sebroeck
2021-06-22 15:27 ` Vaittinen, Matti
2014-09-26 5:40 Stephen Rothwell
2014-09-26 5:51 ` Guenter Roeck
2014-09-26 6:29 ` Stephen Rothwell
2014-09-26 6:49 ` Guenter Roeck
2014-09-26 5:56 ` Pramod Gurav
2014-09-26 6:12 ` Guenter Roeck
2014-09-26 6:34 ` Stephen Rothwell
2014-09-26 6:47 ` Guenter Roeck
2011-11-01 5:37 Stephen Rothwell
2011-11-01 12:02 ` Mark Brown
2011-11-02 16:43 ` Wim Van Sebroeck
2011-01-10 3:12 Stephen Rothwell
2011-01-10 7:27 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa69afba-c9a8-0c64-d097-6b32c3f0a133@roeck-us.net \
--to=linux@roeck-us.net \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).