Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the sound-asoc tree
@ 2019-08-09  3:08 Stephen Rothwell
  2019-08-13  3:16 ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2019-08-09  3:08 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 2700 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/kobject.h:19,
                 from include/linux/device.h:16,
                 from include/sound/hdaudio.h:9,
                 from include/sound/hdaudio_ext.h:5,
                 from sound/soc/sof/intel/hda-dsp.c:18:
sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in this function)
  list_for_each_entry(hlink, &bus->hlink_list, list)
                      ^~~~~
include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
       ^~~
sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is reported only once for each function it appears in
  list_for_each_entry(hlink, &bus->hlink_list, list)
                      ^~~~~
include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
       ^~~
In file included from include/linux/list.h:9,
                 from include/linux/kobject.h:19,
                 from include/linux/device.h:16,
                 from include/sound/hdaudio.h:9,
                 from include/sound/hdaudio_ext.h:5,
                 from sound/soc/sof/intel/hda-dsp.c:18:
sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in this function)
  list_for_each_entry(hlink, &bus->hlink_list, list)
                              ^~~
include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
  void *__mptr = (void *)(ptr);     \
                          ^~~
include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
  list_entry((ptr)->next, type, member)
  ^~~~~~~~~~
include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
  for (pos = list_first_entry(head, typeof(*pos), member); \
             ^~~~~~~~~~~~~~~~
sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro 'list_for_each_entry'
  list_for_each_entry(hlink, &bus->hlink_list, list)
  ^~~~~~~~~~~~~~~~~~~
sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
 #else
  ^~~~
sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
 #endif
  ^~~~~

Caused by commit

  c2f16a94a804 ("Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4")

Looks like the merge resolution is not quite right.

I have used the sound-asoc tree from next-20190808 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-08-09  3:08 linux-next: build failure after merge of the sound-asoc tree Stephen Rothwell
@ 2019-08-13  3:16 ` Stephen Rothwell
  2019-08-13 11:21   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2019-08-13  3:16 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 2934 bytes --]

Hi all,

On Fri, 9 Aug 2019 13:08:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from include/linux/kobject.h:19,
>                  from include/linux/device.h:16,
>                  from include/sound/hdaudio.h:9,
>                  from include/sound/hdaudio_ext.h:5,
>                  from sound/soc/sof/intel/hda-dsp.c:18:
> sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
> sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in this function)
>   list_for_each_entry(hlink, &bus->hlink_list, list)
>                       ^~~~~
> include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>        ^~~
> sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is reported only once for each function it appears in
>   list_for_each_entry(hlink, &bus->hlink_list, list)
>                       ^~~~~
> include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>        ^~~
> In file included from include/linux/list.h:9,
>                  from include/linux/kobject.h:19,
>                  from include/linux/device.h:16,
>                  from include/sound/hdaudio.h:9,
>                  from include/sound/hdaudio_ext.h:5,
>                  from sound/soc/sof/intel/hda-dsp.c:18:
> sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in this function)
>   list_for_each_entry(hlink, &bus->hlink_list, list)
>                               ^~~
> include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
>   void *__mptr = (void *)(ptr);     \
>                           ^~~
> include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
>   list_entry((ptr)->next, type, member)
>   ^~~~~~~~~~
> include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
>   for (pos = list_first_entry(head, typeof(*pos), member); \
>              ^~~~~~~~~~~~~~~~
> sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro 'list_for_each_entry'
>   list_for_each_entry(hlink, &bus->hlink_list, list)
>   ^~~~~~~~~~~~~~~~~~~
> sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
>  #else
>   ^~~~
> sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
>  #endif
>   ^~~~~
> 
> Caused by commit
> 
>   c2f16a94a804 ("Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4")
> 
> Looks like the merge resolution is not quite right.
> 
> I have used the sound-asoc tree from next-20190808 for today.

I am still getting this failure ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-08-13  3:16 ` Stephen Rothwell
@ 2019-08-13 11:21   ` Mark Brown
  2019-08-13 13:52     ` Pierre-Louis Bossart
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2019-08-13 11:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Pierre-Louis Bossart, Cezary Rojewski

[-- Attachment #1: Type: text/plain, Size: 2704 bytes --]

On Tue, Aug 13, 2019 at 01:16:11PM +1000, Stephen Rothwell wrote:
> On Fri, 9 Aug 2019 13:08:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
> > sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in this function)
> >   list_for_each_entry(hlink, &bus->hlink_list, list)
> >                       ^~~~~
> > include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
> >   for (pos = list_first_entry(head, typeof(*pos), member); \
> >        ^~~
> > sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is reported only once for each function it appears in
> >   list_for_each_entry(hlink, &bus->hlink_list, list)
> >                       ^~~~~
> > include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
> >   for (pos = list_first_entry(head, typeof(*pos), member); \
> >        ^~~
> > In file included from include/linux/list.h:9,
> >                  from include/linux/kobject.h:19,
> >                  from include/linux/device.h:16,
> >                  from include/sound/hdaudio.h:9,
> >                  from include/sound/hdaudio_ext.h:5,
> >                  from sound/soc/sof/intel/hda-dsp.c:18:
> > sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in this function)
> >   list_for_each_entry(hlink, &bus->hlink_list, list)
> >                               ^~~
> > include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
> >   void *__mptr = (void *)(ptr);     \
> >                           ^~~
> > include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
> >   list_entry((ptr)->next, type, member)
> >   ^~~~~~~~~~
> > include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
> >   for (pos = list_first_entry(head, typeof(*pos), member); \
> >              ^~~~~~~~~~~~~~~~
> > sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro 'list_for_each_entry'
> >   list_for_each_entry(hlink, &bus->hlink_list, list)
> >   ^~~~~~~~~~~~~~~~~~~
> > sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
> >  #else
> >   ^~~~
> > sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
> >  #endif
> >   ^~~~~
> > 
> > Caused by commit
> > 
> >   c2f16a94a804 ("Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4")
> > 
> > Looks like the merge resolution is not quite right.
> > 
> > I have used the sound-asoc tree from next-20190808 for today.

> I am still getting this failure ...

Intel people, any thoughts?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-08-13 11:21   ` Mark Brown
@ 2019-08-13 13:52     ` Pierre-Louis Bossart
  0 siblings, 0 replies; 193+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-13 13:52 UTC (permalink / raw)
  To: Mark Brown, Stephen Rothwell
  Cc: Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Cezary Rojewski


>>> Looks like the merge resolution is not quite right.
>>>
>>> I have used the sound-asoc tree from next-20190808 for today.
> 
>> I am still getting this failure ...
> 
> Intel people, any thoughts?

I provided a solution on alsa-devel yesterday, see 'ASoC: SOF: fix HDA 
direct MMIO access'



^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-04-03  4:27     ` Baolin Wang
@ 2019-04-03  4:43       ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2019-04-03  4:43 UTC (permalink / raw)
  To: Baolin Wang
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Yintang Ren

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Wed, Apr 03, 2019 at 12:27:53PM +0800, Baolin Wang wrote:
> On Wed, 3 Apr 2019 at 11:35, Mark Brown <broonie@kernel.org> wrote:

> > We can't leave this broken in -next for that long, can you please post
> > the patch now if you've already got it?

> OK, but I need some time to setup my environment to send this patch
> and I'll try to fix this ASAP. Thanks.

Don't worry about it, I can do things directly - it was just if you had
the patch already it seemed better to use yours but if it's going to be
painful to set up a dev environment there's no need to worry.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-04-03  3:35   ` Mark Brown
@ 2019-04-03  4:27     ` Baolin Wang
  2019-04-03  4:43       ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Baolin Wang @ 2019-04-03  4:27 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Yintang Ren

On Wed, 3 Apr 2019 at 11:35, Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote:
>
> > snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
>
> > obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
>
> > I will send out one incremental patch to fix this issue after my
> > business trip. Thanks.
>
> We can't leave this broken in -next for that long, can you please post
> the patch now if you've already got it?

OK, but I need some time to setup my environment to send this patch
and I'll try to fix this ASAP. Thanks.

-- 
Baolin Wang
Best Regards

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-04-03  2:12 ` Baolin Wang
@ 2019-04-03  3:35   ` Mark Brown
  2019-04-03  4:27     ` Baolin Wang
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2019-04-03  3:35 UTC (permalink / raw)
  To: Baolin Wang
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Yintang Ren

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote:

> snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o

> obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o

> I will send out one incremental patch to fix this issue after my
> business trip. Thanks.

We can't leave this broken in -next for that long, can you please post
the patch now if you've already got it?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-04-03  0:11 Stephen Rothwell
@ 2019-04-03  2:12 ` Baolin Wang
  2019-04-03  3:35   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Baolin Wang @ 2019-04-03  2:12 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Yintang Ren

Hi,

On Wed, 3 Apr 2019 at 08:11, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "sprd_platform_compr_ops" [sound/soc/sprd/sprd-pcm-dma.ko] undefined!
>
> Caused by commit
>
>   cce1396936ef ("ASoC: sprd: Add Spreadtrum audio compress offload support")
>
> I have used the sound-asoc tree from next-20190402 for today.
>

Thanks for pointing this out. I think I should fix the Makefile like this

snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o

obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o

I will send out one incremental patch to fix this issue after my
business trip. Thanks.
-- 
Baolin Wang
Best Regards

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2019-04-03  0:11 Stephen Rothwell
  2019-04-03  2:12 ` Baolin Wang
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2019-04-03  0:11 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Baolin Wang,
	Yintang Ren

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "sprd_platform_compr_ops" [sound/soc/sprd/sprd-pcm-dma.ko] undefined!

Caused by commit

  cce1396936ef ("ASoC: sprd: Add Spreadtrum audio compress offload support")

I have used the sound-asoc tree from next-20190402 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-04-01 11:11       ` Michael Ellerman
@ 2019-04-02  5:14         ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2019-04-02  5:14 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Annaliese McDermond,
	Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Mon, Apr 01, 2019 at 10:11:44PM +1100, Michael Ellerman wrote:

> Anyway I think what you've done in next, make the code depend on
> COMMON_CLOCK, is the best option. If anyone cares about that driver on
> powerpc platforms that don't support COMMON_CLOCK they should speak up.

It's probably fine for now for this one driver but it's going to cause
issues going forwards since we're trying to make the framework's clock
handling more standard.  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-03-27 11:57     ` Mark Brown
@ 2019-04-01 11:11       ` Michael Ellerman
  2019-04-02  5:14         ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Michael Ellerman @ 2019-04-01 11:11 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Annaliese McDermond,
	Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev

Mark Brown <broonie@kernel.org> writes:
> On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote:
>> Mark Brown <broonie@kernel.org> writes:
>
>> > Hrm, seems PowerPC is still not using the common clock API - is there
>> > any plan for that?  There are some ASoC PowerPC uses so it's going to be
>> > a bit of an issue as we expand our use of the clock API.
>
>> I don't know anything about the common clock API. What would it involve
>> for powerpc to use it?
>
> It's what's in drivers/clk - you'd have to provide clock drivers for all
> the clocks that are current supported by arch-specific code, make sure
> that those drivers can be instantiated and then remove the custom
> implementation of the clock API in arch/powerpc in favour of those.

OK. I realise we do have some support for the common clock API, but only
on certain sub-platforms (PPC_MPC512x, PPC_MPC52xx, PPC_E500MC).

On other platforms we have nothing at all AFAICS.

Seems Ben posted an RFC to support it in 2009, but nothing since:
  http://patchwork.ozlabs.org/patch/31551/


Anyway I think what you've done in next, make the code depend on
COMMON_CLOCK, is the best option. If anyone cares about that driver on
powerpc platforms that don't support COMMON_CLOCK they should speak up.

cheers

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-03-27  4:29   ` Michael Ellerman
@ 2019-03-27 11:57     ` Mark Brown
  2019-04-01 11:11       ` Michael Ellerman
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2019-03-27 11:57 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Annaliese McDermond,
	Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote:
> Mark Brown <broonie@kernel.org> writes:

> > Hrm, seems PowerPC is still not using the common clock API - is there
> > any plan for that?  There are some ASoC PowerPC uses so it's going to be
> > a bit of an issue as we expand our use of the clock API.

> I don't know anything about the common clock API. What would it involve
> for powerpc to use it?

It's what's in drivers/clk - you'd have to provide clock drivers for all
the clocks that are current supported by arch-specific code, make sure
that those drivers can be instantiated and then remove the custom
implementation of the clock API in arch/powerpc in favour of those.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-03-26 13:15 ` Mark Brown
@ 2019-03-27  4:29   ` Michael Ellerman
  2019-03-27 11:57     ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Michael Ellerman @ 2019-03-27  4:29 UTC (permalink / raw)
  To: Mark Brown, Stephen Rothwell
  Cc: Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Annaliese McDermond,
	Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev

Mark Brown <broonie@kernel.org> writes:
> On Tue, Mar 26, 2019 at 01:33:49PM +1100, Stephen Rothwell wrote:
>
>> After merging the sound-asoc tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>
>> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare':
>> include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type 'struct clk_hw'
>>   BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
>>                                 ^~~~~~
>
> Hrm, seems PowerPC is still not using the common clock API - is there
> any plan for that?  There are some ASoC PowerPC uses so it's going to be
> a bit of an issue as we expand our use of the clock API.

I don't know anything about the common clock API. What would it involve
for powerpc to use it?

cheers

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2019-03-26 23:03 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2019-03-26 23:03 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Viorel Suman

[-- Attachment #1: Type: text/plain, Size: 2402 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/printk.h:330,
                 from include/linux/kernel.h:15,
                 from include/linux/clk.h:16,
                 from sound/soc/fsl/fsl_audmix.c:8:
sound/soc/fsl/fsl_audmix.c: In function 'fsl_audmix_state_trans':
include/linux/dynamic_debug.h:80:13: error: initializer element is not constant
   .format = (fmt),    \
             ^
include/linux/dynamic_debug.h:116:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
  DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt);  \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:136:2: note: in expansion of macro '__dynamic_func_call'
  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:150:2: note: in expansion of macro '_dynamic_func_call'
  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
  ^~~~~~~~~~~~~~~~~~
include/linux/device.h:1493:2: note: in expansion of macro 'dynamic_dev_dbg'
  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~
sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg'
   dev_dbg(comp->dev, prm.msg);
   ^~~~~~~
include/linux/dynamic_debug.h:80:13: note: (near initialization for '__UNIQUE_ID_ddebug374.format')
   .format = (fmt),    \
             ^
include/linux/dynamic_debug.h:116:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
  DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt);  \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:136:2: note: in expansion of macro '__dynamic_func_call'
  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:150:2: note: in expansion of macro '_dynamic_func_call'
  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
  ^~~~~~~~~~~~~~~~~~
include/linux/device.h:1493:2: note: in expansion of macro 'dynamic_dev_dbg'
  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~
sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg'
   dev_dbg(comp->dev, prm.msg);
   ^~~~~~~

Caused by commit

  be1df61cf06e ("ASoC: fsl: Add Audio Mixer CPU DAI driver")

I have reverted that commit (and its 2 following ones) for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-03-26  2:33 Stephen Rothwell
@ 2019-03-26 13:15 ` Mark Brown
  2019-03-27  4:29   ` Michael Ellerman
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2019-03-26 13:15 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Annaliese McDermond,
	Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Tue, Mar 26, 2019 at 01:33:49PM +1100, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:

> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare':
> include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type 'struct clk_hw'
>   BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
>                                 ^~~~~~

Hrm, seems PowerPC is still not using the common clock API - is there
any plan for that?  There are some ASoC PowerPC uses so it's going to be
a bit of an issue as we expand our use of the clock API.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2019-03-26  2:33 Stephen Rothwell
  2019-03-26 13:15 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2019-03-26  2:33 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Annaliese McDermond

[-- Attachment #1: Type: text/plain, Size: 16943 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/soc/codecs/tlv320aic32x4-clk.c:19:16: error: field 'hw' has incomplete type
  struct clk_hw hw;
                ^~
In file included from include/linux/init.h:5,
                 from include/linux/io.h:22,
                 from include/linux/clk-provider.h:9,
                 from sound/soc/codecs/tlv320aic32x4-clk.c:10:
sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare':
include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type 'struct clk_hw'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
                                ^~~~~~
include/linux/compiler.h:328:9: note: in definition of macro '__compiletime_assert'
   if (!(condition))     \
         ^~~~~~~~~
include/linux/compiler.h:348:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:979:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
  ^~~~~~~~~~~~~~~~
include/linux/kernel.h:979:20: note: in expansion of macro '__same_type'
  BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
                    ^~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:17:29: note: in expansion of macro 'container_of'
 #define to_clk_aic32x4(_hw) container_of(_hw, struct clk_aic32x4, hw)
                             ^~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:49:28: note: in expansion of macro 'to_clk_aic32x4'
  struct clk_aic32x4 *pll = to_clk_aic32x4(hw);
                            ^~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c: At top level:
sound/soc/codecs/tlv320aic32x4-clk.c:257:21: error: variable 'aic32x4_pll_ops' has initializer but incomplete type
 static const struct clk_ops aic32x4_pll_ops = {
                     ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:258:3: error: 'const struct clk_ops' has no member named 'prepare'
  .prepare = clk_aic32x4_pll_prepare,
   ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:258:13: warning: excess elements in struct initializer
  .prepare = clk_aic32x4_pll_prepare,
             ^~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:258:13: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:259:3: error: 'const struct clk_ops' has no member named 'unprepare'
  .unprepare = clk_aic32x4_pll_unprepare,
   ^~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:259:15: warning: excess elements in struct initializer
  .unprepare = clk_aic32x4_pll_unprepare,
               ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:259:15: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:260:3: error: 'const struct clk_ops' has no member named 'is_prepared'
  .is_prepared = clk_aic32x4_pll_is_prepared,
   ^~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:260:17: warning: excess elements in struct initializer
  .is_prepared = clk_aic32x4_pll_is_prepared,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:260:17: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:261:3: error: 'const struct clk_ops' has no member named 'recalc_rate'
  .recalc_rate = clk_aic32x4_pll_recalc_rate,
   ^~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:261:17: warning: excess elements in struct initializer
  .recalc_rate = clk_aic32x4_pll_recalc_rate,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:261:17: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:262:3: error: 'const struct clk_ops' has no member named 'round_rate'
  .round_rate = clk_aic32x4_pll_round_rate,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:262:16: warning: excess elements in struct initializer
  .round_rate = clk_aic32x4_pll_round_rate,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:262:16: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:263:3: error: 'const struct clk_ops' has no member named 'set_rate'
  .set_rate = clk_aic32x4_pll_set_rate,
   ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:263:14: warning: excess elements in struct initializer
  .set_rate = clk_aic32x4_pll_set_rate,
              ^~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:263:14: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:264:3: error: 'const struct clk_ops' has no member named 'set_parent'
  .set_parent = clk_aic32x4_pll_set_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:264:16: warning: excess elements in struct initializer
  .set_parent = clk_aic32x4_pll_set_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:264:16: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:265:3: error: 'const struct clk_ops' has no member named 'get_parent'
  .get_parent = clk_aic32x4_pll_get_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:265:16: warning: excess elements in struct initializer
  .get_parent = clk_aic32x4_pll_get_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:265:16: note: (near initialization for 'aic32x4_pll_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:287:21: error: variable 'aic32x4_codec_clkin_ops' has initializer but incomplete type
 static const struct clk_ops aic32x4_codec_clkin_ops = {
                     ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:288:3: error: 'const struct clk_ops' has no member named 'set_parent'
  .set_parent = clk_aic32x4_codec_clkin_set_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:288:16: warning: excess elements in struct initializer
  .set_parent = clk_aic32x4_codec_clkin_set_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:288:16: note: (near initialization for 'aic32x4_codec_clkin_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:289:3: error: 'const struct clk_ops' has no member named 'get_parent'
  .get_parent = clk_aic32x4_codec_clkin_get_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:289:16: warning: excess elements in struct initializer
  .get_parent = clk_aic32x4_codec_clkin_get_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:289:16: note: (near initialization for 'aic32x4_codec_clkin_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:346:21: error: variable 'aic32x4_div_ops' has initializer but incomplete type
 static const struct clk_ops aic32x4_div_ops = {
                     ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:347:3: error: 'const struct clk_ops' has no member named 'prepare'
  .prepare = clk_aic32x4_div_prepare,
   ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:347:13: warning: excess elements in struct initializer
  .prepare = clk_aic32x4_div_prepare,
             ^~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:347:13: note: (near initialization for 'aic32x4_div_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:348:3: error: 'const struct clk_ops' has no member named 'unprepare'
  .unprepare = clk_aic32x4_div_unprepare,
   ^~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:348:15: warning: excess elements in struct initializer
  .unprepare = clk_aic32x4_div_unprepare,
               ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:348:15: note: (near initialization for 'aic32x4_div_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:349:3: error: 'const struct clk_ops' has no member named 'set_rate'
  .set_rate = clk_aic32x4_div_set_rate,
   ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:349:14: warning: excess elements in struct initializer
  .set_rate = clk_aic32x4_div_set_rate,
              ^~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:349:14: note: (near initialization for 'aic32x4_div_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:350:3: error: 'const struct clk_ops' has no member named 'round_rate'
  .round_rate = clk_aic32x4_div_round_rate,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:350:16: warning: excess elements in struct initializer
  .round_rate = clk_aic32x4_div_round_rate,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:350:16: note: (near initialization for 'aic32x4_div_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:351:3: error: 'const struct clk_ops' has no member named 'recalc_rate'
  .recalc_rate = clk_aic32x4_div_recalc_rate,
   ^~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:351:17: warning: excess elements in struct initializer
  .recalc_rate = clk_aic32x4_div_recalc_rate,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:351:17: note: (near initialization for 'aic32x4_div_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:372:21: error: variable 'aic32x4_bdiv_ops' has initializer but incomplete type
 static const struct clk_ops aic32x4_bdiv_ops = {
                     ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:373:3: error: 'const struct clk_ops' has no member named 'prepare'
  .prepare = clk_aic32x4_div_prepare,
   ^~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:373:13: warning: excess elements in struct initializer
  .prepare = clk_aic32x4_div_prepare,
             ^~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:373:13: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:374:3: error: 'const struct clk_ops' has no member named 'unprepare'
  .unprepare = clk_aic32x4_div_unprepare,
   ^~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:374:15: warning: excess elements in struct initializer
  .unprepare = clk_aic32x4_div_unprepare,
               ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:374:15: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:375:3: error: 'const struct clk_ops' has no member named 'set_parent'
  .set_parent = clk_aic32x4_bdiv_set_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:375:16: warning: excess elements in struct initializer
  .set_parent = clk_aic32x4_bdiv_set_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:375:16: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:376:3: error: 'const struct clk_ops' has no member named 'get_parent'
  .get_parent = clk_aic32x4_bdiv_get_parent,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:376:16: warning: excess elements in struct initializer
  .get_parent = clk_aic32x4_bdiv_get_parent,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:376:16: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:377:3: error: 'const struct clk_ops' has no member named 'set_rate'
  .set_rate = clk_aic32x4_div_set_rate,
   ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:377:14: warning: excess elements in struct initializer
  .set_rate = clk_aic32x4_div_set_rate,
              ^~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:377:14: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:378:3: error: 'const struct clk_ops' has no member named 'round_rate'
  .round_rate = clk_aic32x4_div_round_rate,
   ^~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:378:16: warning: excess elements in struct initializer
  .round_rate = clk_aic32x4_div_round_rate,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:378:16: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c:379:3: error: 'const struct clk_ops' has no member named 'recalc_rate'
  .recalc_rate = clk_aic32x4_div_recalc_rate,
   ^~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:379:17: warning: excess elements in struct initializer
  .recalc_rate = clk_aic32x4_div_recalc_rate,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:379:17: note: (near initialization for 'aic32x4_bdiv_ops')
sound/soc/codecs/tlv320aic32x4-clk.c: In function 'aic32x4_register_clk':
sound/soc/codecs/tlv320aic32x4-clk.c:440:23: error: storage size of 'init' isn't known
  struct clk_init_data init;
                       ^~~~
sound/soc/codecs/tlv320aic32x4-clk.c:460:9: error: implicit declaration of function 'devm_clk_register'; did you mean 'device_register'? [-Werror=implicit-function-declaration]
  return devm_clk_register(dev, &priv->hw);
         ^~~~~~~~~~~~~~~~~
         device_register
sound/soc/codecs/tlv320aic32x4-clk.c:440:23: warning: unused variable 'init' [-Wunused-variable]
  struct clk_init_data init;
                       ^~~~
sound/soc/codecs/tlv320aic32x4-clk.c: At top level:
sound/soc/codecs/tlv320aic32x4-clk.c:257:29: error: storage size of 'aic32x4_pll_ops' isn't known
 static const struct clk_ops aic32x4_pll_ops = {
                             ^~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:287:29: error: storage size of 'aic32x4_codec_clkin_ops' isn't known
 static const struct clk_ops aic32x4_codec_clkin_ops = {
                             ^~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:346:29: error: storage size of 'aic32x4_div_ops' isn't known
 static const struct clk_ops aic32x4_div_ops = {
                             ^~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:372:29: error: storage size of 'aic32x4_bdiv_ops' isn't known
 static const struct clk_ops aic32x4_bdiv_ops = {
                             ^~~~~~~~~~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c: In function 'aic32x4_register_clk':
sound/soc/codecs/tlv320aic32x4-clk.c:461:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit

  514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")

This build has

CONFIG_SND_SOC_TLV320AIC32X4=y
CONFIG_SND_SOC_TLV320AIC32X4_I2C=y
CONFIG_SND_SOC_TLV320AIC32X4_SPI=y

but CONFIG_COMMON_CLK is not set.  I assume tha bove get set due to
"select" statements and we get this warning:

WARNING: unmet direct dependencies detected for SND_SOC_TLV320AIC32X4
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && COMMON_CLK [=n]
  Selected by [y]:
  - SND_SOC_TLV320AIC32X4_I2C [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y]
  - SND_SOC_TLV320AIC32X4_SPI [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SPI_MASTER [=y]

I have disabled that driver for now using:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 26 Mar 2019 13:18:03 +1100
Subject: [PATCH] disable the SND_SOC_TLV320AIC32X4 driver for now

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/Kconfig | 5 +++--
 sound/soc/fsl/Kconfig    | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 6e99320c79b8..c225c81a7aef 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -180,8 +180,6 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_TLV320AIC23_SPI if SPI_MASTER
 	select SND_SOC_TLV320AIC26 if SPI_MASTER
 	select SND_SOC_TLV320AIC31XX if I2C
-	select SND_SOC_TLV320AIC32X4_I2C if I2C
-	select SND_SOC_TLV320AIC32X4_SPI if SPI_MASTER
 	select SND_SOC_TLV320AIC3X if I2C
 	select SND_SOC_TPA6130A2 if I2C
 	select SND_SOC_TLV320DAC33 if I2C
@@ -1105,15 +1103,18 @@ config SND_SOC_TLV320AIC31XX
 
 config SND_SOC_TLV320AIC32X4
 	tristate
+	depends on BROKEN
 	depends on COMMON_CLK
 
 config SND_SOC_TLV320AIC32X4_I2C
 	tristate "Texas Instruments TLV320AIC32x4 audio CODECs - I2C"
+	depends on BROKEN
 	depends on I2C
 	select SND_SOC_TLV320AIC32X4
 
 config SND_SOC_TLV320AIC32X4_SPI
 	tristate "Texas Instruments TLV320AIC32x4 audio CODECs - SPI"
+	depends on BROKEN
 	depends on SPI_MASTER
 	select SND_SOC_TLV320AIC32X4
 
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 7b1d9970be8b..d7b4f9d4d61d 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -207,6 +207,7 @@ config SND_MXC_SOC_WM1133_EV1
 
 config SND_SOC_MX27VIS_AIC32X4
 	tristate "SoC audio support for Visstrim M10 boards"
+	depends on BROKEN
 	depends on MACH_IMX27_VISSTRIM_M10 && I2C
 	select SND_SOC_TLV320AIC32X4
 	select SND_SOC_IMX_PCM_DMA
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-02-08  8:39   ` Takashi Iwai
@ 2019-02-08 12:53     ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2019-02-08 12:53 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Maruthi Srinivas Bayyavarapu

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

On Fri, Feb 08, 2019 at 09:39:39AM +0100, Takashi Iwai wrote:

> > Mark, could you apply it on your tree?

> And I already took back the API change from for-next branch for
> avoiding the bisection breakage.

> > Or let me pull your tree into mine.

> ... so Mark, please send a pull request to me for ASoC merges, so that
> I can apply the API change.

Done.  This sort of thing is why I like having lots of topic branches :/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-02-08  7:37 ` Takashi Iwai
@ 2019-02-08  8:39   ` Takashi Iwai
  2019-02-08 12:53     ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Takashi Iwai @ 2019-02-08  8:39 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Maruthi Srinivas Bayyavarapu

On Fri, 08 Feb 2019 08:37:25 +0100,
Takashi Iwai wrote:
> 
> On Fri, 08 Feb 2019 03:18:23 +0100,
> Stephen Rothwell wrote:
> > 
> > Hi all,
> > 
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > sound/soc/xilinx/xlnx_formatter_pcm.c: In function 'xlnx_formatter_pcm_new':
> > sound/soc/xilinx/xlnx_formatter_pcm.c:539:9: error: void value not ignored as it ought to be
> >   return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     SNDRV_DMA_TYPE_DEV, component->dev,
> >     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     xlnx_pcm_hardware.buffer_bytes_max,
> >     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     xlnx_pcm_hardware.buffer_bytes_max);
> >     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > sound/soc/xilinx/xlnx_formatter_pcm.c:543:1: warning: control reaches end of non-void function [-Wreturn-type]
> >  }
> >  ^
> > 
> > Caused by commit
> > 
> >   6f6c3c36f091 ("ASoC: xlnx: add pcm formatter platform driver")
> > 
> > interacting with commit
> > 
> >   9adb5165f1de ("ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void")
> > 
> > from the sound tree.
> > 
> > I have applied the following merge fix patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Fri, 8 Feb 2019 13:14:24 +1100
> > Subject: [PATCH] Asoc: xlnx: fix up for snd_pcm_lib_preallocate_pages_for_all() API change
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  sound/soc/xilinx/xlnx_formatter_pcm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c
> > index 97177d35652e..dc8721f4f56b 100644
> > --- a/sound/soc/xilinx/xlnx_formatter_pcm.c
> > +++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
> > @@ -536,10 +536,11 @@ static int xlnx_formatter_pcm_new(struct snd_soc_pcm_runtime *rtd)
> >  {
> >  	struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
> >  								    DRV_NAME);
> > -	return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> > +	snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> >  			SNDRV_DMA_TYPE_DEV, component->dev,
> >  			xlnx_pcm_hardware.buffer_bytes_max,
> >  			xlnx_pcm_hardware.buffer_bytes_max);
> > +	return 0;
> >  }
> >  
> >  static const struct snd_pcm_ops xlnx_formatter_pcm_ops = {
> > -- 
> > 2.20.1
> 
> Thanks Stephen.
> 
> Mark, could you apply it on your tree?

And I already took back the API change from for-next branch for
avoiding the bisection breakage.

> Or let me pull your tree into mine.

... so Mark, please send a pull request to me for ASoC merges, so that
I can apply the API change.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2019-02-08  2:18 Stephen Rothwell
@ 2019-02-08  7:37 ` Takashi Iwai
  2019-02-08  8:39   ` Takashi Iwai
  0 siblings, 1 reply; 193+ messages in thread
From: Takashi Iwai @ 2019-02-08  7:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux Next Mailing List,
	Linux Kernel Mailing List, Maruthi Srinivas Bayyavarapu

On Fri, 08 Feb 2019 03:18:23 +0100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/xilinx/xlnx_formatter_pcm.c: In function 'xlnx_formatter_pcm_new':
> sound/soc/xilinx/xlnx_formatter_pcm.c:539:9: error: void value not ignored as it ought to be
>   return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     SNDRV_DMA_TYPE_DEV, component->dev,
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     xlnx_pcm_hardware.buffer_bytes_max,
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     xlnx_pcm_hardware.buffer_bytes_max);
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/xilinx/xlnx_formatter_pcm.c:543:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
> 
> Caused by commit
> 
>   6f6c3c36f091 ("ASoC: xlnx: add pcm formatter platform driver")
> 
> interacting with commit
> 
>   9adb5165f1de ("ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void")
> 
> from the sound tree.
> 
> I have applied the following merge fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 8 Feb 2019 13:14:24 +1100
> Subject: [PATCH] Asoc: xlnx: fix up for snd_pcm_lib_preallocate_pages_for_all() API change
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  sound/soc/xilinx/xlnx_formatter_pcm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c
> index 97177d35652e..dc8721f4f56b 100644
> --- a/sound/soc/xilinx/xlnx_formatter_pcm.c
> +++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
> @@ -536,10 +536,11 @@ static int xlnx_formatter_pcm_new(struct snd_soc_pcm_runtime *rtd)
>  {
>  	struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
>  								    DRV_NAME);
> -	return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> +	snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
>  			SNDRV_DMA_TYPE_DEV, component->dev,
>  			xlnx_pcm_hardware.buffer_bytes_max,
>  			xlnx_pcm_hardware.buffer_bytes_max);
> +	return 0;
>  }
>  
>  static const struct snd_pcm_ops xlnx_formatter_pcm_ops = {
> -- 
> 2.20.1

Thanks Stephen.

Mark, could you apply it on your tree?
Or let me pull your tree into mine.


Takashi

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2019-02-08  2:18 Stephen Rothwell
  2019-02-08  7:37 ` Takashi Iwai
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2019-02-08  2:18 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood, Takashi Iwai
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Maruthi Srinivas Bayyavarapu

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/xilinx/xlnx_formatter_pcm.c: In function 'xlnx_formatter_pcm_new':
sound/soc/xilinx/xlnx_formatter_pcm.c:539:9: error: void value not ignored as it ought to be
  return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    SNDRV_DMA_TYPE_DEV, component->dev,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    xlnx_pcm_hardware.buffer_bytes_max,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    xlnx_pcm_hardware.buffer_bytes_max);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/xilinx/xlnx_formatter_pcm.c:543:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit

  6f6c3c36f091 ("ASoC: xlnx: add pcm formatter platform driver")

interacting with commit

  9adb5165f1de ("ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void")

from the sound tree.

I have applied the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 8 Feb 2019 13:14:24 +1100
Subject: [PATCH] Asoc: xlnx: fix up for snd_pcm_lib_preallocate_pages_for_all() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/xilinx/xlnx_formatter_pcm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c
index 97177d35652e..dc8721f4f56b 100644
--- a/sound/soc/xilinx/xlnx_formatter_pcm.c
+++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
@@ -536,10 +536,11 @@ static int xlnx_formatter_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
 	struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
 								    DRV_NAME);
-	return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+	snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
 			SNDRV_DMA_TYPE_DEV, component->dev,
 			xlnx_pcm_hardware.buffer_bytes_max,
 			xlnx_pcm_hardware.buffer_bytes_max);
+	return 0;
 }
 
 static const struct snd_pcm_ops xlnx_formatter_pcm_ops = {
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-04-17 23:51 Stephen Rothwell
@ 2018-04-18 14:49 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2018-04-18 14:49 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

On Wed, Apr 18, 2018 at 09:51:13AM +1000, Stephen Rothwell wrote:

> Caused by commit

>   81e9b0a07889 ("ASoC: topology: Give more data to clients via callbacks")

> I have used the sound-aoc tree from next-20180416 again today.

Ugh, reverted that and the following commit which depends on it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-04-17 23:51 Stephen Rothwell
  2018-04-18 14:49 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-04-17 23:51 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 2823 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/intel/skylake/skl-topology.c: In function 'skl_fill_sink_instance_id':
sound/soc/intel/skylake/skl-topology.c:833:45: error: 'struct skl_kpb_params' has no member named 'u'
   struct skl_mod_inst_map *inst = kpb_params->u.map;
                                             ^~
sound/soc/intel/skylake/skl-topology.c: In function 'skl_tplg_find_moduleid_from_uuid':
sound/soc/intel/skylake/skl-topology.c:953:17: error: 'struct skl_kpb_params' has no member named 'u'
     &uuid_params->u.map_uuid[i].mod_uuid);
                 ^~
sound/soc/intel/skylake/skl-topology.c:959:10: error: 'struct skl_kpb_params' has no member named 'u'
    params->u.map[i].mod_id = module_id;
          ^~
sound/soc/intel/skylake/skl-topology.c:960:10: error: 'struct skl_kpb_params' has no member named 'u'
    params->u.map[i].inst_id =
          ^~
sound/soc/intel/skylake/skl-topology.c:961:16: error: 'struct skl_kpb_params' has no member named 'u'
     uuid_params->u.map_uuid[i].inst_id;
                ^~
sound/soc/intel/skylake/skl-topology.c: At top level:
sound/soc/intel/skylake/skl-topology.c:3544:5: error: conflicting types for 'skl_tplg_init'
 int skl_tplg_init(struct snd_soc_component *component, struct hdac_ext_bus *ebus)
     ^~~~~~~~~~~~~
In file included from sound/soc/intel/skylake/skl-topology.c:27:0:
sound/soc/intel/skylake/skl-topology.h:463:5: note: previous declaration of 'skl_tplg_init' was here
 int skl_tplg_init(struct snd_soc_platform *platform,
     ^~~~~~~~~~~~~
sound/soc/intel/skylake/skl-pcm.c: In function 'skl_populate_modules':
sound/soc/intel/skylake/skl-pcm.c:1351:4: error: implicit declaration of function 'skl_tplg_add_moduleid_in_bind_params'; did you mean 'skl_tplg_update_pipe_params'? [-Werror=implicit-function-declaration]
    skl_tplg_add_moduleid_in_bind_params(skl, w);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    skl_tplg_update_pipe_params
sound/soc/intel/skylake/skl-pcm.c: In function 'skl_platform_soc_probe':
sound/soc/intel/skylake/skl-pcm.c:1372:23: error: passing argument 1 of 'skl_tplg_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
   ret = skl_tplg_init(component, ebus);
                       ^~~~~~~~~
In file included from sound/soc/intel/skylake/skl-pcm.c:28:0:
sound/soc/intel/skylake/skl-topology.h:463:5: note: expected 'struct snd_soc_platform *' but argument is of type 'struct snd_soc_component *'
 int skl_tplg_init(struct snd_soc_platform *platform,
     ^~~~~~~~~~~~~

Caused by commit

  81e9b0a07889 ("ASoC: topology: Give more data to clients via callbacks")

I have used the sound-aoc tree from next-20180416 again today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2018-04-17  1:22 ` Shuming [范書銘]
@ 2018-04-17  2:14   ` Shuming [范書銘]
  0 siblings, 0 replies; 193+ messages in thread
From: Shuming [范書銘] @ 2018-04-17  2:14 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bard Liao

Hi all,

I already sent the patch. 
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-April/134522.html

I apologize for the inconvenience.

Thanks!

Regards,
Shuming Fan


-----Original Message-----
From: Shuming [­S®Ñ»Ê] 
Sent: Tuesday, April 17, 2018 9:23 AM
To: 'Stephen Rothwell'; Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List
Subject: RE: linux-next: build failure after merge of the sound-asoc tree

Hi all,

I think I miss the header file (#include <linux/acpi.h>) I will fix it ASAP. Sorry about that.

Thanks!

Regards,
Shuming Fan


-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
Sent: Tuesday, April 17, 2018 9:03 AM
To: Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Shuming [­S®Ñ»Ê]
Subject: linux-next: build failure after merge of the sound-asoc tree

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function 'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
   .acpi_match_table = ACPI_PTR(rt1305_acpi_match)
                       ^~~~~~~~
                       ERR_PTR
sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')
sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')

Caused by commit

  29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")

I have used the sound-asoc tree from next-20180416 for today.

--
Cheers,
Stephen Rothwell

------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2018-04-17  1:02 Stephen Rothwell
@ 2018-04-17  1:22 ` Shuming [范書銘]
  2018-04-17  2:14   ` Shuming [范書銘]
  0 siblings, 1 reply; 193+ messages in thread
From: Shuming [范書銘] @ 2018-04-17  1:22 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi all,

I think I miss the header file (#include <linux/acpi.h>)
I will fix it ASAP. Sorry about that.

Thanks!

Regards,
Shuming Fan


-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Tuesday, April 17, 2018 9:03 AM
To: Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Shuming [­S®Ñ»Ê]
Subject: linux-next: build failure after merge of the sound-asoc tree

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function 'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
   .acpi_match_table = ACPI_PTR(rt1305_acpi_match)
                       ^~~~~~~~
                       ERR_PTR
sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')
sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')

Caused by commit

  29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")

I have used the sound-asoc tree from next-20180416 for today.

-- 
Cheers,
Stephen Rothwell

------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-04-17  1:02 Stephen Rothwell
  2018-04-17  1:22 ` Shuming [范書銘]
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-04-17  1:02 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Shuming Fan

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function 'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
   .acpi_match_table = ACPI_PTR(rt1305_acpi_match)
                       ^~~~~~~~
                       ERR_PTR
sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')
sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')

Caused by commit

  29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")

I have used the sound-asoc tree from next-20180416 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-27 11:27         ` Mark Brown
@ 2018-03-27 12:45           ` Mukunda,Vijendar
  0 siblings, 0 replies; 193+ messages in thread
From: Mukunda,Vijendar @ 2018-03-27 12:45 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Akshu Agrawal, Alex Deucher



On Tuesday 27 March 2018 04:57 PM, Mark Brown wrote:
> On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote:
>> On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
> 
>>> You need to mention dependencies between patches when publishing and I
>>> don't seem to have a copy of that patch, according to the list archives
>>> Alex asked you to make some chnages to it.
> 
>>     Changes suggested by Alex already implemented and posted .
>>     Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
>>     dependent on below patch.
> 
>>     https://patchwork.kernel.org/patch/10296597/
> 
> I'm working offline so these links aren't doing anything useful for me,
> sorry.

submitted fresh patch set which includes dependent patch.
Please ignore this mail thread.
> 
>>     We will publish patch dependencies while sending patches.
> 
> Please.
> 

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-22  5:54       ` Mukunda,Vijendar
@ 2018-03-27 11:27         ` Mark Brown
  2018-03-27 12:45           ` Mukunda,Vijendar
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2018-03-27 11:27 UTC (permalink / raw)
  To: Mukunda,Vijendar
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Akshu Agrawal, Alex Deucher

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote:
> On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:

> > You need to mention dependencies between patches when publishing and I
> > don't seem to have a copy of that patch, according to the list archives
> > Alex asked you to make some chnages to it.

>    Changes suggested by Alex already implemented and posted .
>    Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
>    dependent on below patch.

>    https://patchwork.kernel.org/patch/10296597/

I'm working offline so these links aren't doing anything useful for me,
sorry.

>    We will publish patch dependencies while sending patches.

Please.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-22  1:38     ` Mark Brown
@ 2018-03-22  5:54       ` Mukunda,Vijendar
  2018-03-27 11:27         ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Mukunda,Vijendar @ 2018-03-22  5:54 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Akshu Agrawal, Alex Deucher



On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
> On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote:
>
>> There is a patch dependency .
>> Below patch not merged yet. We submitted for upstream review.
>> [PATCH V2] ASoC: dwc: I2S Controller instance param added
> You need to mention dependencies between patches when publishing and I
> don't seem to have a copy of that patch, according to the list archives
> Alex asked you to make some chnages to it.

    Changes suggested by Alex already implemented and posted .
    Current patch (https://patchwork.kernel.org/patch/10298281/ ) is
    dependent on below patch.

    https://patchwork.kernel.org/patch/10296597/

    We will publish patch dependencies while sending patches.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-21  5:45   ` Mukunda,Vijendar
@ 2018-03-22  1:38     ` Mark Brown
  2018-03-22  5:54       ` Mukunda,Vijendar
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2018-03-22  1:38 UTC (permalink / raw)
  To: Mukunda,Vijendar
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Akshu Agrawal, Alex Deucher

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote:

> There is a patch dependency .
> Below patch not merged yet. We submitted for upstream review.
> [PATCH V2] ASoC: dwc: I2S Controller instance param added

You need to mention dependencies between patches when publishing and I
don't seem to have a copy of that patch, according to the list archives
Alex asked you to make some chnages to it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-21  2:45 ` Mark Brown
@ 2018-03-21  5:45   ` Mukunda,Vijendar
  2018-03-22  1:38     ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Mukunda,Vijendar @ 2018-03-21  5:45 UTC (permalink / raw)
  To: Mark Brown, Stephen Rothwell
  Cc: Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Akshu Agrawal, Alex Deucher



On Wednesday 21 March 2018 08:15 AM, Mark Brown wrote:
> On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
>
>> Caused by commit
>>    363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
>> I have used the sound-asoc tree from next-20180320 for today.
> Dropped.


There is a patch dependency .
Below patch not merged yet. We submitted for upstream review.
[PATCH V2] ASoC: dwc: I2S Controller instance param added

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-21  2:30 Stephen Rothwell
@ 2018-03-21  2:45 ` Mark Brown
  2018-03-21  5:45   ` Mukunda,Vijendar
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2018-03-21  2:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List, Vijendar Mukunda, Akshu Agrawal,
	Alex Deucher

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:

> Caused by commit

>   363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")

> I have used the sound-asoc tree from next-20180320 for today.

Dropped.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-03-21  2:30 Stephen Rothwell
  2018-03-21  2:45 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-03-21  2:30 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Vijendar Mukunda, Akshu Agrawal, Alex Deucher

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/amd/acp-pcm-dma.c: In function 'acp_dma_open':
sound/soc/amd/acp-pcm-dma.c:714:35: error: 'struct dw_i2s_dev' has no member named 'i2s_instance'; did you mean 'i2s_base'?
   adata->i2s_play_instance = dev->i2s_instance;
                                   ^~~~~~~~~~~~
                                   i2s_base
sound/soc/amd/acp-pcm-dma.c:715:35: error: 'I2S_SP_INSTANCE' undeclared (first use in this function); did you mean 'SS_ONSTACK'?
   if (adata->i2s_play_instance == I2S_SP_INSTANCE)
                                   ^~~~~~~~~~~~~~~
                                   SS_ONSTACK
sound/soc/amd/acp-pcm-dma.c:715:35: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/amd/acp-pcm-dma.c:717:40: error: 'I2S_BT_INSTANCE' undeclared (first use in this function); did you mean 'I2S_SP_INSTANCE'?
   else if (adata->i2s_play_instance == I2S_BT_INSTANCE)
                                        ^~~~~~~~~~~~~~~
                                        I2S_SP_INSTANCE
sound/soc/amd/acp-pcm-dma.c:722:38: error: 'struct dw_i2s_dev' has no member named 'i2s_instance'; did you mean 'i2s_base'?
   adata->i2s_capture_instance = dev->i2s_instance;
                                      ^~~~~~~~~~~~
                                      i2s_base
sound/soc/amd/acp-pcm-dma.c: In function 'acp_dma_close':
sound/soc/amd/acp-pcm-dma.c:1046:8: error: 'I2S_BT_INSTANCE' undeclared (first use in this function)
   case I2S_BT_INSTANCE:
        ^~~~~~~~~~~~~~~
sound/soc/amd/acp-pcm-dma.c:1049:8: error: 'I2S_SP_INSTANCE' undeclared (first use in this function); did you mean 'I2S_BT_INSTANCE'?
   case I2S_SP_INSTANCE:
        ^~~~~~~~~~~~~~~
        I2S_BT_INSTANCE

Caused by commit

  363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")

I have used the sound-asoc tree from next-20180320 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2018-03-13  6:09 Stephen Rothwell
@ 2018-03-13  8:52 ` Adam Thomson
  0 siblings, 0 replies; 193+ messages in thread
From: Adam Thomson @ 2018-03-13  8:52 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Adam Thomson

On 13 March 2018 06:09, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/soc/codecs/da7219.o: In function `.da7219_remove':
> da7219.c:(.text+0xcbc): undefined reference to `.clkdev_drop'
> 
> Caused by commit
> 
>   fc8f7ea2d6c0 ("ASoC: da7219: Add common clock usage for providing DAI clks")
> 
> CONFIG_CLKDEV_LOOKUP is not set for this build.
> 
> I have reverted that commit for today.

My bad. Apologies for this. :(

Mark, I'll send a follow up patch to fix this ASAP.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-03-13  6:09 Stephen Rothwell
  2018-03-13  8:52 ` Adam Thomson
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-03-13  6:09 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Adam Thomson

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/soc/codecs/da7219.o: In function `.da7219_remove':
da7219.c:(.text+0xcbc): undefined reference to `.clkdev_drop'

Caused by commit

  fc8f7ea2d6c0 ("ASoC: da7219: Add common clock usage for providing DAI clks")

CONFIG_CLKDEV_LOOKUP is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-03-01 23:54 Stephen Rothwell
@ 2018-03-02  2:49 ` John Hsu
  0 siblings, 0 replies; 193+ messages in thread
From: John Hsu @ 2018-03-02  2:49 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List

On 3/2/2018 7:54 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/intel/boards/cht_bsw_nau8824.c: In function 'cht_codec_init':
> sound/soc/intel/boards/cht_bsw_nau8824.c:137:29: error: passing argument 1 of 'nau8824_enable_jack_detect' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   nau8824_enable_jack_detect(codec, jack);
>                              ^~~~~
> In file included from sound/soc/intel/boards/cht_bsw_nau8824.c:31:0:
> sound/soc/intel/boards/../../codecs/nau8824.h:474:5: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
>  int nau8824_enable_jack_detect(struct snd_soc_component *component,
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   5b00ce63e07f ("ASoC: Intel: add nau8824 sound card")
>
> I have used the sound-asoc tree from next-20180301 for today.
>

The fix patch has submitted. Please check the link as follows:
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/132811.html
[alsa-devel] [PATCH] ASoC: Intel: fix argument error in nau8824 machine


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-03-01 23:54 Stephen Rothwell
  2018-03-02  2:49 ` John Hsu
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-03-01 23:54 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, John Hsu

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/intel/boards/cht_bsw_nau8824.c: In function 'cht_codec_init':
sound/soc/intel/boards/cht_bsw_nau8824.c:137:29: error: passing argument 1 of 'nau8824_enable_jack_detect' from incompatible pointer type [-Werror=incompatible-pointer-types]
  nau8824_enable_jack_detect(codec, jack);
                             ^~~~~
In file included from sound/soc/intel/boards/cht_bsw_nau8824.c:31:0:
sound/soc/intel/boards/../../codecs/nau8824.h:474:5: note: expected 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
 int nau8824_enable_jack_detect(struct snd_soc_component *component,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  5b00ce63e07f ("ASoC: Intel: add nau8824 sound card")

I have used the sound-asoc tree from next-20180301 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-02-15 15:33   ` Mark Brown
@ 2018-02-16  0:01     ` Kuninori Morimoto
  0 siblings, 0 replies; 193+ messages in thread
From: Kuninori Morimoto @ 2018-02-16  0:01 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List


Hi Mark

> > Thank you for reporting.
> > It is my fault, this patch might cause other issue.
> > I'm asking to Mark to remove it from his branch.
> 
> Dropped.

Thank you !

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-02-15  2:49 ` Kuninori Morimoto
@ 2018-02-15 15:33   ` Mark Brown
  2018-02-16  0:01     ` Kuninori Morimoto
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2018-02-15 15:33 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Stephen Rothwell, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Thu, Feb 15, 2018 at 02:49:44AM +0000, Kuninori Morimoto wrote:
> 
> Hi Stephen
> 
> Thank you for reporting.
> It is my fault, this patch might cause other issue.
> I'm asking to Mark to remove it from his branch.

Dropped.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2018-02-15  0:35 Stephen Rothwell
@ 2018-02-15  2:49 ` Kuninori Morimoto
  2018-02-15 15:33   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Kuninori Morimoto @ 2018-02-15  2:49 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List


Hi Stephen

Thank you for reporting.
It is my fault, this patch might cause other issue.
I'm asking to Mark to remove it from his branch.

> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> /home/sfr/next/next/sound/soc/soc-core.c: In function 'snd_soc_register_codec':
> /home/sfr/next/next/sound/soc/soc-core.c:3818:8: error: too many arguments to function 'snd_soc_register_dais'
>   ret = snd_soc_register_dais(&codec->component, dai_drv, num_dai, false);
>         ^~~~~~~~~~~~~~~~~~~~~
> /home/sfr/next/next/sound/soc/soc-core.c:3114:12: note: declared here
>  static int snd_soc_register_dais(struct snd_soc_component *component,
>             ^~~~~~~~~~~~~~~~~~~~~   
> 
> Caused by commit
> 
>   a8768c52c511 ("ASoC: soc-core: remove legacy_dai_naming from snd_soc_register_dais()")
> 
> I have used the sound-asoc tree from next-20180214 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2018-02-15  0:35 Stephen Rothwell
  2018-02-15  2:49 ` Kuninori Morimoto
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2018-02-15  0:35 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

/home/sfr/next/next/sound/soc/soc-core.c: In function 'snd_soc_register_codec':
/home/sfr/next/next/sound/soc/soc-core.c:3818:8: error: too many arguments to function 'snd_soc_register_dais'
  ret = snd_soc_register_dais(&codec->component, dai_drv, num_dai, false);
        ^~~~~~~~~~~~~~~~~~~~~
/home/sfr/next/next/sound/soc/soc-core.c:3114:12: note: declared here
 static int snd_soc_register_dais(struct snd_soc_component *component,
            ^~~~~~~~~~~~~~~~~~~~~   

Caused by commit

  a8768c52c511 ("ASoC: soc-core: remove legacy_dai_naming from snd_soc_register_dais()")

I have used the sound-asoc tree from next-20180214 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-11-29  0:50 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2017-11-29  0:50 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "snd_soc_disconnect_sync" [sound/soc/sh/rcar/snd-soc-rcar.ko] undefined!

Caused by commit

  180d9ef58104 ("ASoC: rsnd: call snd_soc_disconnect_sync() when remove")

I have used the sound-asco tree from next-20171128 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2017-09-20 11:54 ` robert.jarzmik
@ 2017-09-20 11:56   ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2017-09-20 11:56 UTC (permalink / raw)
  To: robert.jarzmik
  Cc: Stephen Rothwell, Linux-Next Mailing List,
	Linux Kernel Mailing List, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

On Wed, Sep 20, 2017 at 01:54:47PM +0200, robert.jarzmik@free.fr wrote:

> I will resend an incremental version of this patch alone Mark this evening if that
> suits you, with the bracket missing in wm9712.c:661 added.

I fixed this already.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2017-09-20  2:01 Stephen Rothwell
@ 2017-09-20 11:54 ` robert.jarzmik
  2017-09-20 11:56   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: robert.jarzmik @ 2017-09-20 11:54 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi Stephen and Mark,

This is my mess. And today my mailer is not my usual one, please don't blame me
for its probably awfull rendering.

Somehow, in my last serie, in wm9712_soc_probe(), a closing bracket has disappeared.
This affects only wm9712.c, not the others, ie. the commit :
 - 2ed1a8e "ASoC: wm9712: add ac97 new bus support"

I will resend an incremental version of this patch alone Mark this evening if that
suits you, with the bracket missing in wm9712.c:661 added.

Cheers.

--
Robert

[1] The diff, scrambled probably by my mailer, will look like the attached piece.
    My mailer refuses to add a TAB so I cannot inline it with a scissor.

[-- Attachment #2: wm9712.diff --]
[-- Type: text/x-patch, Size: 339 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-09-20  2:01 Stephen Rothwell
  2017-09-20 11:54 ` robert.jarzmik
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2017-09-20  2:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Robert Jarzmik

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe':
sound/soc/codecs/wm9712.c:675:12: error: invalid storage class for function 'wm9712_soc_remove'
 static int wm9712_soc_remove(struct snd_soc_codec *codec)
            ^
sound/soc/codecs/wm9712.c:675:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 static int wm9712_soc_remove(struct snd_soc_codec *codec)
 ^
sound/soc/codecs/wm9712.c:690:13: error: initializer element is not constant
  .remove =  wm9712_soc_remove,
             ^
sound/soc/codecs/wm9712.c:690:13: note: (near initialization for 'soc_codec_dev_wm9712.remove')
sound/soc/codecs/wm9712.c:705:12: error: invalid storage class for function 'wm9712_probe'
 static int wm9712_probe(struct platform_device *pdev)
            ^
sound/soc/codecs/wm9712.c:722:12: error: invalid storage class for function 'wm9712_remove'
 static int wm9712_remove(struct platform_device *pdev)
            ^
sound/soc/codecs/wm9712.c:733:11: error: initializer element is not constant
  .probe = wm9712_probe,
           ^
sound/soc/codecs/wm9712.c:733:11: note: (near initialization for 'wm9712_codec_driver.probe')
sound/soc/codecs/wm9712.c:734:12: error: initializer element is not constant
  .remove = wm9712_remove,
            ^
sound/soc/codecs/wm9712.c:734:12: note: (near initialization for 'wm9712_codec_driver.remove')
In file included from sound/soc/codecs/wm9712.c:18:0:
sound/soc/codecs/wm9712.c:737:24: error: invalid storage class for function 'wm9712_codec_driver_init'
 module_platform_driver(wm9712_codec_driver);
                        ^
include/linux/device.h:1500:19: note: in definition of macro 'module_driver'
 static int __init __driver##_init(void) \
                   ^
sound/soc/codecs/wm9712.c:737:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(wm9712_codec_driver);
 ^
In file included from sound/soc/codecs/wm9712.c:16:0:
include/linux/module.h:129:42: error: invalid storage class for function '__inittest'
  static inline initcall_t __maybe_unused __inittest(void)  \
                                          ^
include/linux/device.h:1504:1: note: in expansion of macro 'module_init'
 module_init(__driver##_init); \
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^
sound/soc/codecs/wm9712.c:737:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(wm9712_codec_driver);
 ^
sound/soc/codecs/wm9712.c:737:1: warning: 'alias' attribute ignored [-Wattributes]
In file included from sound/soc/codecs/wm9712.c:18:0:
sound/soc/codecs/wm9712.c:737:24: error: invalid storage class for function 'wm9712_codec_driver_exit'
 module_platform_driver(wm9712_codec_driver);
                        ^
include/linux/device.h:1505:20: note: in definition of macro 'module_driver'
 static void __exit __driver##_exit(void) \
                    ^
sound/soc/codecs/wm9712.c:737:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(wm9712_codec_driver);
 ^
include/linux/device.h:1505:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 static void __exit __driver##_exit(void) \
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^
sound/soc/codecs/wm9712.c:737:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(wm9712_codec_driver);
 ^
In file included from sound/soc/codecs/wm9712.c:16:0:
include/linux/module.h:135:42: error: invalid storage class for function '__exittest'
  static inline exitcall_t __maybe_unused __exittest(void)  \
                                          ^
include/linux/device.h:1509:1: note: in expansion of macro 'module_exit'
 module_exit(__driver##_exit);
 ^
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
  module_driver(__platform_driver, platform_driver_register, \
  ^
sound/soc/codecs/wm9712.c:737:1: note: in expansion of macro 'module_platform_driver'
 module_platform_driver(wm9712_codec_driver);
 ^
sound/soc/codecs/wm9712.c:737:1: warning: 'alias' attribute ignored [-Wattributes]
In file included from include/linux/module.h:18:0,
                 from sound/soc/codecs/wm9712.c:16:
include/linux/moduleparam.h:21:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 static const char __UNIQUE_ID(name)[]       \
 ^
include/linux/module.h:160:32: note: in expansion of macro '__MODULE_INFO'
 #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                ^
include/linux/module.h:207:42: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description)
                                          ^
sound/soc/codecs/wm9712.c:739:1: note: in expansion of macro 'MODULE_DESCRIPTION'
 MODULE_DESCRIPTION("ASoC WM9711/WM9712 driver");
 ^
sound/soc/codecs/wm9712.c:741:1: error: expected declaration or statement at end of input
 MODULE_LICENSE("GPL");
 ^
sound/soc/codecs/wm9712.c: At top level:
sound/soc/codecs/wm9712.c:637:12: warning: 'wm9712_soc_probe' defined but not used [-Wunused-function]
 static int wm9712_soc_probe(struct snd_soc_codec *codec)
            ^

Caused by commit

  2ed1a8e0ce8d ("ASoC: wm9712: add ac97 new bus support")

I have used the sound-asoc tree from next-20170919 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
@ 2017-08-25  7:58 Hsin-yu Chao
  0 siblings, 0 replies; 193+ messages in thread
From: Hsin-yu Chao @ 2017-08-25  7:58 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List

Sorry for the trouble.
Looks like these rt5514_spi_* functions should be guarded by #if
IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI)
I'll resend the patch to address this.

Thanks,
Hsin-yu

On Fri, Aug 25, 2017 at 3:41 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/codecs/rt5514.c: In function 'rt5514_dsp_voice_wake_up_put':
> sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function 'rt5514_spi_burst_write' [-Werror=implicit-function-declaration]
>      ret = rt5514_spi_burst_write(0x4ff80000,
>            ^
>
> Caused by commit
>
>   d18420b0a0b8 ("ASoC: rt5514: expose Hotword Model control")
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-08-25  7:41 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2017-08-25  7:41 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hsin-Yu Chao

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/soc/codecs/rt5514.c: In function 'rt5514_dsp_voice_wake_up_put':
sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function 'rt5514_spi_burst_write' [-Werror=implicit-function-declaration]
     ret = rt5514_spi_burst_write(0x4ff80000,
           ^

Caused by commit

  d18420b0a0b8 ("ASoC: rt5514: expose Hotword Model control")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2017-06-30  1:51   ` Stephen Rothwell
@ 2017-07-03  3:21     ` Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2017-07-03  3:21 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Bard Liao, Linux-Next Mailing List, Linux Kernel Mailing List

Hi all,

On Fri, 30 Jun 2017 11:51:35 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 29 Jun 2017 02:01:16 +0000 Bard Liao <bardliao@realtek.com> wrote:
> >  
> > > -----Original Message-----
> > > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> > > Sent: Thursday, June 29, 2017 9:54 AM
> > > To: Mark Brown; Liam Girdwood
> > > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > > Subject: linux-next: build failure after merge of the sound-asoc tree
> > > 
> > > Hi all,
> > > 
> > > After merging the sound-asoc tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> > > function)
> > >   struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> > >                                                          ^
> > > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > > reported only once for each function it appears in
> > > sound/soc/codecs/rt5670.c: At top level:
> > > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > > pointer type [-Werror=incompatible-pointer-types]
> > >   .set_sysclk = rt5670_set_codec_sysclk,
> > >                 ^
> > > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > > 'soc_codec_dev_rt5670.set_sysclk')
> > > cc1: some warnings being treated as errors
> > > 
> > > Caused by commit
> > > 
> > >   6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> > > 
> > > I have used the sound-asoc tree from next-20170628 for today.    
> > 
> > Sorry about that. I just sent a patch to fix it. Please check the attached.  
> 
> I have applied your patch (attached) for today.
> 
> Mark, Liam, please apply.
> 
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

Ping?

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2017-06-29  2:01 ` Bard Liao
@ 2017-06-30  1:51   ` Stephen Rothwell
  2017-07-03  3:21     ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2017-06-30  1:51 UTC (permalink / raw)
  To: Bard Liao
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]

Hi Bard,

On Thu, 29 Jun 2017 02:01:16 +0000 Bard Liao <bardliao@realtek.com> wrote:
>
> > -----Original Message-----
> > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> > Sent: Thursday, June 29, 2017 9:54 AM
> > To: Mark Brown; Liam Girdwood
> > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > Subject: linux-next: build failure after merge of the sound-asoc tree
> > 
> > Hi all,
> > 
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> > function)
> >   struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> >                                                          ^
> > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > reported only once for each function it appears in
> > sound/soc/codecs/rt5670.c: At top level:
> > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > pointer type [-Werror=incompatible-pointer-types]
> >   .set_sysclk = rt5670_set_codec_sysclk,
> >                 ^
> > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > 'soc_codec_dev_rt5670.set_sysclk')
> > cc1: some warnings being treated as errors
> > 
> > Caused by commit
> > 
> >   6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> > 
> > I have used the sound-asoc tree from next-20170628 for today.  
> 
> Sorry about that. I just sent a patch to fix it. Please check the attached.

I have applied your patch (attached) for today.

Mark, Liam, please apply.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: 0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch --]
[-- Type: text/x-patch, Size: 1019 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2017-06-29  1:54 Stephen Rothwell
@ 2017-06-29  2:01 ` Bard Liao
  2017-06-30  1:51   ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Bard Liao @ 2017-06-29  2:01 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Thursday, June 29, 2017 9:54 AM
> To: Mark Brown; Liam Girdwood
> Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> Subject: linux-next: build failure after merge of the sound-asoc tree
> 
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this
> function)
>   struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
>                                                          ^
> sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> reported only once for each function it appears in
> sound/soc/codecs/rt5670.c: At top level:
> sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> pointer type [-Werror=incompatible-pointer-types]
>   .set_sysclk = rt5670_set_codec_sysclk,
>                 ^
> sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> 'soc_codec_dev_rt5670.set_sysclk')
> cc1: some warnings being treated as errors
> 
> Caused by commit
> 
>   6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> 
> I have used the sound-asoc tree from next-20170628 for today.

Sorry about that. I just sent a patch to fix it. Please check the attached.

> 
> --
> Cheers,
> Stephen Rothwell
> 
> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch --]
[-- Type: application/octet-stream, Size: 1018 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-06-29  1:54 Stephen Rothwell
  2017-06-29  2:01 ` Bard Liao
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2017-06-29  1:54 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bard Liao

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this function)
  struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
                                                         ^
sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/codecs/rt5670.c: At top level:
sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .set_sysclk = rt5670_set_codec_sysclk,
                ^
sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for 'soc_codec_dev_rt5670.set_sysclk')
cc1: some warnings being treated as errors

Caused by commit

  6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")

I have used the sound-asoc tree from next-20170628 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-06-16  2:04 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2017-06-16  2:04 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Christophe Jaillet

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/soc/rockchip/rockchip_i2s.c: In function 'rockchip_i2s_probe':
sound/soc/rockchip/rockchip_i2s.c:649:3: error: 'err' undeclared (first use in this function)
   err = -ENOMEM;
   ^

Caused by commit

  c3a3d3c41b74 ("ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe'")

I have used the sound-asoc tree from next-20170615 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2017-06-14  1:26 Stephen Rothwell
@ 2017-06-14  2:22 ` Kuninori Morimoto
  0 siblings, 0 replies; 193+ messages in thread
From: Kuninori Morimoto @ 2017-06-14  2:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, Linux-Next Mailing List,
	Linux Kernel Mailing List


Hi Stephen

> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!
> ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!
> 
> Caused by commit
> 
>   bb24a3ba3f52 ("ASoC: simple-scu-card: use asoc_simple_card_clk_xxx()")
> 
> These symbols are not exported to modules.
> 
> I have used the sound-asoc tree from next-20170613 for today.

Thanks.
I posted this fixup patch few hours ago

To: Mark Brown <broonie@kernel.org>
Subject: [PATCH] ASoC: simple_card_utils: add EXPORT_SYMBOL_GPL() for asoc_simple_card_clk_xxx()
CC: Linux-ALSA <alsa-devel@alsa-project.org>, Simon <horms@verge.net.au>, <linux-renesas-soc@vger.kernel.org>
Date: Wed, 14 Jun 2017 01:04:11 +0000


Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-06-14  1:26 Stephen Rothwell
  2017-06-14  2:22 ` Kuninori Morimoto
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2017-06-14  1:26 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!
ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!

Caused by commit

  bb24a3ba3f52 ("ASoC: simple-scu-card: use asoc_simple_card_clk_xxx()")

These symbols are not exported to modules.

I have used the sound-asoc tree from next-20170613 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2017-06-08  3:37 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2017-06-08  3:37 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-topology.c: In function 'soc_tplg_widget_ready':
sound/soc/soc-topology.c:352:42: error: 'struct snd_soc_tplg_ops' has no member named 'widget_ready'
  if (tplg->comp && tplg->ops && tplg->ops->widget_ready)
                                          ^
sound/soc/soc-topology.c:353:19: error: 'struct snd_soc_tplg_ops' has no member named 'widget_ready'
   return tplg->ops->widget_ready(tplg->comp, w, tplg_w);
                   ^
sound/soc/soc-topology.c: In function 'soc_tplg_dai_load':
sound/soc/soc-topology.c:364:10: error: too many arguments to function 'tplg->ops->dai_load'
   return tplg->ops->dai_load(tplg->comp, dai_drv, pcm, dai);
          ^
sound/soc/soc-topology.c: In function 'soc_tplg_dai_create':
sound/soc/soc-topology.c:1722:8: error: too few arguments to function 'soc_tplg_dai_load'
  ret = soc_tplg_dai_load(tplg, dai_drv);
        ^
sound/soc/soc-topology.c:359:12: note: declared here
 static int soc_tplg_dai_load(struct soc_tplg *tplg,
            ^
sound/soc/soc-topology.c: In function 'soc_tplg_dai_config':
sound/soc/soc-topology.c:2205:8: error: too few arguments to function 'soc_tplg_dai_load'
  ret = soc_tplg_dai_load(tplg, dai_drv);
        ^
sound/soc/soc-topology.c:359:12: note: declared here
 static int soc_tplg_dai_load(struct soc_tplg *tplg,
            ^

Caused by commit

  c8597af855f3 ("ASoC: topology: Allow bespoke configuration post widget creation")

Forgotten commit of an include file update?

I have used the sound-asoc tree from next-20170607 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-12-06 12:55     ` Lee Jones
@ 2016-12-06 13:22       ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2016-12-06 13:22 UTC (permalink / raw)
  To: Lee Jones
  Cc: Kuninori Morimoto, Stephen Rothwell, Liam Girdwood, linux-next,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Tue, Dec 06, 2016 at 12:55:38PM +0000, Lee Jones wrote:
> On Tue, 06 Dec 2016, Mark Brown wrote:
> > On Tue, Dec 06, 2016 at 12:41:15AM +0000, Kuninori Morimoto wrote:

> > > 	8ca9edc837932469b81b8b47ea43a074b6add970
> > > 	("mfd: davinci_voicecodec: Tidyup header difinitions")

> > Reverted.  Lee, there is actually a dependency here...

> No idea what you're talking about.

You were saying there were no dependencies for the ASoC bit of
Morimoto-san's cq9vc series.

> Are you going to allude to the patch you reverted?

The one Stephen identified.

> I assume you wish for me to pick it up?

Or if you could send me a pull request for the MFD bits.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-12-06  9:37   ` Mark Brown
@ 2016-12-06 12:55     ` Lee Jones
  2016-12-06 13:22       ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Lee Jones @ 2016-12-06 12:55 UTC (permalink / raw)
  To: Mark Brown
  Cc: Kuninori Morimoto, Stephen Rothwell, Liam Girdwood, linux-next,
	linux-kernel

On Tue, 06 Dec 2016, Mark Brown wrote:

> On Tue, Dec 06, 2016 at 12:41:15AM +0000, Kuninori Morimoto wrote:
> > > In file included from sound/soc/codecs/cq93vc.c:32:0:
> > > include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h: No such file or directory
> > > 
> 
> > As I indicated on cover letter, this patch is based on
> 
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git :: for-mfd-next
> 
> > 	Especially this commit
> 
> > 	8ca9edc837932469b81b8b47ea43a074b6add970
> > 	("mfd: davinci_voicecodec: Tidyup header difinitions")
> 
> Reverted.  Lee, there is actually a dependency here...

No idea what you're talking about.

Are you going to allude to the patch you reverted?

I assume you wish for me to pick it up?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-12-06  0:41 ` Kuninori Morimoto
@ 2016-12-06  9:37   ` Mark Brown
  2016-12-06 12:55     ` Lee Jones
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2016-12-06  9:37 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel, lee.jones

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Tue, Dec 06, 2016 at 12:41:15AM +0000, Kuninori Morimoto wrote:
> > In file included from sound/soc/codecs/cq93vc.c:32:0:
> > include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h: No such file or directory
> > 

> As I indicated on cover letter, this patch is based on

> 	git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git :: for-mfd-next

> 	Especially this commit

> 	8ca9edc837932469b81b8b47ea43a074b6add970
> 	("mfd: davinci_voicecodec: Tidyup header difinitions")

Reverted.  Lee, there is actually a dependency here...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-12-06  0:14 Stephen Rothwell
@ 2016-12-06  0:41 ` Kuninori Morimoto
  2016-12-06  9:37   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Kuninori Morimoto @ 2016-12-06  0:41 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel


Hi Stephen, Mark

> In file included from sound/soc/codecs/cq93vc.c:32:0:
> include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h: No such file or directory
> 
> Probably caused by commit
> 
>   4de429888c5b ("ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC")
> 
> I have used the sound-asoc tree from next-20161205 for today.

As I indicated on cover letter, this patch is based on

	git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git :: for-mfd-next

	Especially this commit

	8ca9edc837932469b81b8b47ea43a074b6add970
	("mfd: davinci_voicecodec: Tidyup header difinitions")

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-12-06  0:14 Stephen Rothwell
  2016-12-06  0:41 ` Kuninori Morimoto
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-12-06  0:14 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from sound/soc/codecs/cq93vc.c:32:0:
include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h: No such file or directory

Probably caused by commit

  4de429888c5b ("ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC")

I have used the sound-asoc tree from next-20161205 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-11-14  0:28 Stephen Rothwell
@ 2016-11-14  9:45 ` Richard Fitzgerald
  0 siblings, 0 replies; 193+ messages in thread
From: Richard Fitzgerald @ 2016-11-14  9:45 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

Yes, it's because Mark applied a chain of patches but missed the first
patch in the chain that added the wm_coeff_base_reg() function

On Mon, 2016-11-14 at 11:28 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/wm_adsp.c: In function 'wm_coeff_write_acked_control':
> sound/soc/codecs/wm_adsp.c:791:8: error: implicit declaration of function 'wm_coeff_base_reg' [-Werror=implicit-function-declaration]
>   ret = wm_coeff_base_reg(ctl, &reg);
>         ^
> 
> Caused by commit
> 
>   f4f0c4c60c39 ("ASoC: wm_adsp: Signal firmware shutdown through event control")
> 
> I have used the sound-asoc tree from next-20161111 for today.
> 

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-11-14  0:28 Stephen Rothwell
  2016-11-14  9:45 ` Richard Fitzgerald
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-11-14  0:28 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Richard Fitzgerald

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/wm_adsp.c: In function 'wm_coeff_write_acked_control':
sound/soc/codecs/wm_adsp.c:791:8: error: implicit declaration of function 'wm_coeff_base_reg' [-Werror=implicit-function-declaration]
  ret = wm_coeff_base_reg(ctl, &reg);
        ^

Caused by commit

  f4f0c4c60c39 ("ASoC: wm_adsp: Signal firmware shutdown through event control")

I have used the sound-asoc tree from next-20161111 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-11-08  3:18 ` Chen-Yu Tsai
@ 2016-11-09 14:41   ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2016-11-09 14:41 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Tue, Nov 08, 2016 at 11:18:29AM +0800, Chen-Yu Tsai wrote:

> sound-asoc is missing patch

>     ASoC: sun4i-codec: Add support for optional reset control to quirks
>     http://www.spinics.net/lists/alsa-devel/msg56289.html

> which commit 8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback
> through headphone output") depends on. This was part of the same series that
> I posted:

I don't have that...

> A new version of the remaining patches was posted yesterday:

>     http://www.spinics.net/lists/alsa-devel/msg56443.html

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-11-08  2:47 Stephen Rothwell
@ 2016-11-08  3:18 ` Chen-Yu Tsai
  2016-11-09 14:41   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Chen-Yu Tsai @ 2016-11-08  3:18 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel, Chen-Yu Tsai

Hi,

On Tue, Nov 8, 2016 at 10:47 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> sound/soc/sunxi/sun4i-codec.c:1188:2: error: unknown field 'has_reset' specified in initializer
>   .has_reset = true,
>   ^
> sound/soc/sunxi/sun4i-codec.c:1188:15: warning: excess elements in struct initializer
>   .has_reset = true,
>                ^
> sound/soc/sunxi/sun4i-codec.c:1188:15: note: (near initialization for 'sun6i_a31_codec_quirks')
>
> Caused by commit
>
>   8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback through headphone output")
>
> I have used the sound-asoc tree from next-20161028 for today.

sound-asoc is missing patch

    ASoC: sun4i-codec: Add support for optional reset control to quirks
    http://www.spinics.net/lists/alsa-devel/msg56289.html

which commit 8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback
through headphone output") depends on. This was part of the same series that
I posted:

    http://www.spinics.net/lists/alsa-devel/msg56283.html

A new version of the remaining patches was posted yesterday:

    http://www.spinics.net/lists/alsa-devel/msg56443.html

The build failure should be resolved once Mark merges the remaining patches,
though some reordering might be needed to maintain bisectability.


Regards
ChenYu

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-11-08  2:47 Stephen Rothwell
  2016-11-08  3:18 ` Chen-Yu Tsai
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-11-08  2:47 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Chen-Yu Tsai

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/soc/sunxi/sun4i-codec.c:1188:2: error: unknown field 'has_reset' specified in initializer
  .has_reset = true,
  ^
sound/soc/sunxi/sun4i-codec.c:1188:15: warning: excess elements in struct initializer
  .has_reset = true,
               ^
sound/soc/sunxi/sun4i-codec.c:1188:15: note: (near initialization for 'sun6i_a31_codec_quirks') 

Caused by commit

  8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback through headphone output")

I have used the sound-asoc tree from next-20161028 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-08-23  2:27 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2016-08-23  2:27 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, John Hsu

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/sound/soc.h:415:0,
                 from sound/soc/codecs/nau8810.c:27:
sound/soc/codecs/nau8810.c:441:3: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
   &nau8810_loopback),
   ^
include/sound/soc-dapm.h:111:19: note: in definition of macro 'SND_SOC_DAPM_SWITCH'
  .kcontrol_news = wcontrols, .num_kcontrols = 1}
                   ^
sound/soc/codecs/nau8810.c:441:3: note: (near initialization for 'nau8810_dapm_widgets[11].kcontrol_news')
   &nau8810_loopback),
   ^
include/sound/soc-dapm.h:111:19: note: in definition of macro 'SND_SOC_DAPM_SWITCH'
  .kcontrol_news = wcontrols, .num_kcontrols = 1}
                   ^

Caused by commit

  b6970b48e384 ("ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10")

I have used the sound-asoc tree from next-20160822 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-08-08  0:50 Stephen Rothwell
@ 2016-08-08  1:29 ` Kuninori Morimoto
  0 siblings, 0 replies; 193+ messages in thread
From: Kuninori Morimoto @ 2016-08-08  1:29 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel


Hi

> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig build) failed like this:
> 
> sound/soc/generic/simple-card.c: In function 'asoc_simple_card_dai_link_of':
> sound/soc/generic/simple-card.c:350:8: error: implicit declaration of function 'asoc_simple_card_parse_clk_cpu' [-Werror=implicit-function-declaration]
>   ret = asoc_simple_card_parse_clk_cpu(cpu, dai_link, cpu_dai);
>         ^
> sound/soc/generic/simple-card.c:354:8: error: implicit declaration of function 'asoc_simple_card_parse_clk_codec' [-Werror=implicit-function-declaration]
>   ret = asoc_simple_card_parse_clk_codec(codec, dai_link, codec_dai);
>         ^
> sound/soc/sh/rcar/rsrc-card.c: In function 'rsrc_card_parse_links':
> sound/soc/sh/rcar/rsrc-card.c:193:9: error: implicit declaration of function 'asoc_simple_card_parse_clk_cpu' [-Werror=implicit-function-declaration]
>    ret = asoc_simple_card_parse_clk_cpu(np, dai_link, dai_props);
>          ^
> sound/soc/sh/rcar/rsrc-card.c:232:9: error: implicit declaration of function 'asoc_simple_card_parse_clk_codec' [-Werror=implicit-function-declaration]
>    ret = asoc_simple_card_parse_clk_codec(np, dai_link, dai_props);
>          ^
> 
> Caused by commits
> 
>   28abd99b6e40 ("ASoC: simple-card: use asoc_simple_card_parse_clk()")
>   c9a235da8a61 ("ASoC: rsrc-card: use asoc_simple_card_parse_clk()")
> 
> I have used the sound-asoc tree from next-20160805 for today.

It seems topic/simple branch is missing [1/7], but has [2/7], [3/7] patches.
I'm asking it to Mark now.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-08-08  0:50 Stephen Rothwell
  2016-08-08  1:29 ` Kuninori Morimoto
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-08-08  0:50 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Kuninori Morimoto

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig build) failed like this:

sound/soc/generic/simple-card.c: In function 'asoc_simple_card_dai_link_of':
sound/soc/generic/simple-card.c:350:8: error: implicit declaration of function 'asoc_simple_card_parse_clk_cpu' [-Werror=implicit-function-declaration]
  ret = asoc_simple_card_parse_clk_cpu(cpu, dai_link, cpu_dai);
        ^
sound/soc/generic/simple-card.c:354:8: error: implicit declaration of function 'asoc_simple_card_parse_clk_codec' [-Werror=implicit-function-declaration]
  ret = asoc_simple_card_parse_clk_codec(codec, dai_link, codec_dai);
        ^
sound/soc/sh/rcar/rsrc-card.c: In function 'rsrc_card_parse_links':
sound/soc/sh/rcar/rsrc-card.c:193:9: error: implicit declaration of function 'asoc_simple_card_parse_clk_cpu' [-Werror=implicit-function-declaration]
   ret = asoc_simple_card_parse_clk_cpu(np, dai_link, dai_props);
         ^
sound/soc/sh/rcar/rsrc-card.c:232:9: error: implicit declaration of function 'asoc_simple_card_parse_clk_codec' [-Werror=implicit-function-declaration]
   ret = asoc_simple_card_parse_clk_codec(np, dai_link, dai_props);
         ^

Caused by commits

  28abd99b6e40 ("ASoC: simple-card: use asoc_simple_card_parse_clk()")
  c9a235da8a61 ("ASoC: rsrc-card: use asoc_simple_card_parse_clk()")

I have used the sound-asoc tree from next-20160805 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-05-11  1:07 Stephen Rothwell
@ 2016-05-11  3:38 ` Vinod Koul
  0 siblings, 0 replies; 193+ messages in thread
From: Vinod Koul @ 2016-05-11  3:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel, Ramesh Babu,
	Senthilnathan Veppur, Mengdong Lin

On Wed, May 11, 2016 at 11:07:02AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/intel/boards/bxt_rt298.c:257:3: error: unknown field 'be_id' specified in initializer
>    .be_id = 0,
>    ^
> sound/soc/intel/boards/bxt_rt298.c:274:3: error: unknown field 'be_id' specified in initializer
>    .be_id = 1,
>    ^
> sound/soc/intel/boards/bxt_rt298.c:274:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>    .be_id = 1,
>             ^
> sound/soc/intel/boards/bxt_rt298.c:274:12: note: (near initialization for 'broxton_rt298_dais[7].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:285:3: error: unknown field 'be_id' specified in initializer
>    .be_id = 3,
>    ^
> sound/soc/intel/boards/bxt_rt298.c:285:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>    .be_id = 3,
>             ^
> sound/soc/intel/boards/bxt_rt298.c:285:12: note: (near initialization for 'broxton_rt298_dais[8].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:296:3: error: unknown field 'be_id' specified in initializer 
>    .be_id = 4,
>    ^
> sound/soc/intel/boards/bxt_rt298.c:296:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>    .be_id = 4,
>             ^
> sound/soc/intel/boards/bxt_rt298.c:296:12: note: (near initialization for 'broxton_rt298_dais[9].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:307:3: error: unknown field 'be_id' specified in initializer 
>    .be_id = 5,
>    ^
> sound/soc/intel/boards/bxt_rt298.c:307:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>    .be_id = 5,
>             ^
> 
> Caused by commit
> 
>   76016322ec56 ("ASoC: Intel: Add Broxton-P machine driver")
> 
> interacting with commit
> 
>   2f0ad49104cb ("ASoC: Change DAI link's be_id to a generic id")

My bad, patch was generated against topic/intel of Mark's tree and I should
have checked the -next branch as well

> 
> I applied the following fix patch that should have happened in the
> merge commit
> 
>   8554363b9f0f ("Merge remote-tracking branches 'asoc/topic/dai-link', 'asoc/topic/davinci', 'asoc/topic/dwc' and 'asoc/topic/es8328' into asoc-next")
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 11 May 2016 11:03:25 +1000
> Subject: [PATCH] ASoC: Intel: fix up for DAI link's be_id change
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Vinod Koul <vinod.koul@intel.com>

I guess Mark you will merge this as well?


> ---
>  sound/soc/intel/boards/bxt_rt298.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/bxt_rt298.c b/sound/soc/intel/boards/bxt_rt298.c
> index 1b845ff779f3..f4787515c0ed 100644
> --- a/sound/soc/intel/boards/bxt_rt298.c
> +++ b/sound/soc/intel/boards/bxt_rt298.c
> @@ -254,7 +254,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
>  	{
>  		/* SSP5 - Codec */
>  		.name = "SSP5-Codec",
> -		.be_id = 0,
> +		.id = 0,
>  		.cpu_dai_name = "SSP5 Pin",
>  		.platform_name = "0000:00:0e.0",
>  		.no_pcm = 1,
> @@ -271,7 +271,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
>  	},
>  	{
>  		.name = "dmic01",
> -		.be_id = 1,
> +		.id = 1,
>  		.cpu_dai_name = "DMIC01 Pin",
>  		.codec_name = "dmic-codec",
>  		.codec_dai_name = "dmic-hifi",
> @@ -282,7 +282,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
>  	},
>  	{
>  		.name = "iDisp1",
> -		.be_id = 3,
> +		.id = 3,
>  		.cpu_dai_name = "iDisp1 Pin",
>  		.codec_name = "ehdaudio0D2",
>  		.codec_dai_name = "intel-hdmi-hifi1",
> @@ -293,7 +293,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
>  	},
>  	{
>  		.name = "iDisp2",
> -		.be_id = 4,
> +		.id = 4,
>  		.cpu_dai_name = "iDisp2 Pin",
>  		.codec_name = "ehdaudio0D2",
>  		.codec_dai_name = "intel-hdmi-hifi2",
> @@ -304,7 +304,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
>  	},
>  	{
>  		.name = "iDisp3",
> -		.be_id = 5,
> +		.id = 5,
>  		.cpu_dai_name = "iDisp3 Pin",
>  		.codec_name = "ehdaudio0D2",
>  		.codec_dai_name = "intel-hdmi-hifi3",
> -- 
> 2.7.0
> 
> -- 
> Cheers,
> Stephen Rothwell

Thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-05-11  1:07 Stephen Rothwell
  2016-05-11  3:38 ` Vinod Koul
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-05-11  1:07 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Ramesh Babu, Senthilnathan Veppur,
	Vinod Koul, Mengdong Lin

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/intel/boards/bxt_rt298.c:257:3: error: unknown field 'be_id' specified in initializer
   .be_id = 0,
   ^
sound/soc/intel/boards/bxt_rt298.c:274:3: error: unknown field 'be_id' specified in initializer
   .be_id = 1,
   ^
sound/soc/intel/boards/bxt_rt298.c:274:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   .be_id = 1,
            ^
sound/soc/intel/boards/bxt_rt298.c:274:12: note: (near initialization for 'broxton_rt298_dais[7].stream_name')
sound/soc/intel/boards/bxt_rt298.c:285:3: error: unknown field 'be_id' specified in initializer
   .be_id = 3,
   ^
sound/soc/intel/boards/bxt_rt298.c:285:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   .be_id = 3,
            ^
sound/soc/intel/boards/bxt_rt298.c:285:12: note: (near initialization for 'broxton_rt298_dais[8].stream_name')
sound/soc/intel/boards/bxt_rt298.c:296:3: error: unknown field 'be_id' specified in initializer 
   .be_id = 4,
   ^
sound/soc/intel/boards/bxt_rt298.c:296:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   .be_id = 4,
            ^
sound/soc/intel/boards/bxt_rt298.c:296:12: note: (near initialization for 'broxton_rt298_dais[9].stream_name')
sound/soc/intel/boards/bxt_rt298.c:307:3: error: unknown field 'be_id' specified in initializer 
   .be_id = 5,
   ^
sound/soc/intel/boards/bxt_rt298.c:307:12: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   .be_id = 5,
            ^

Caused by commit

  76016322ec56 ("ASoC: Intel: Add Broxton-P machine driver")

interacting with commit

  2f0ad49104cb ("ASoC: Change DAI link's be_id to a generic id")

I applied the following fix patch that should have happened in the
merge commit

  8554363b9f0f ("Merge remote-tracking branches 'asoc/topic/dai-link', 'asoc/topic/davinci', 'asoc/topic/dwc' and 'asoc/topic/es8328' into asoc-next")

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 11 May 2016 11:03:25 +1000
Subject: [PATCH] ASoC: Intel: fix up for DAI link's be_id change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/intel/boards/bxt_rt298.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/soc/intel/boards/bxt_rt298.c b/sound/soc/intel/boards/bxt_rt298.c
index 1b845ff779f3..f4787515c0ed 100644
--- a/sound/soc/intel/boards/bxt_rt298.c
+++ b/sound/soc/intel/boards/bxt_rt298.c
@@ -254,7 +254,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
 	{
 		/* SSP5 - Codec */
 		.name = "SSP5-Codec",
-		.be_id = 0,
+		.id = 0,
 		.cpu_dai_name = "SSP5 Pin",
 		.platform_name = "0000:00:0e.0",
 		.no_pcm = 1,
@@ -271,7 +271,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
 	},
 	{
 		.name = "dmic01",
-		.be_id = 1,
+		.id = 1,
 		.cpu_dai_name = "DMIC01 Pin",
 		.codec_name = "dmic-codec",
 		.codec_dai_name = "dmic-hifi",
@@ -282,7 +282,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
 	},
 	{
 		.name = "iDisp1",
-		.be_id = 3,
+		.id = 3,
 		.cpu_dai_name = "iDisp1 Pin",
 		.codec_name = "ehdaudio0D2",
 		.codec_dai_name = "intel-hdmi-hifi1",
@@ -293,7 +293,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
 	},
 	{
 		.name = "iDisp2",
-		.be_id = 4,
+		.id = 4,
 		.cpu_dai_name = "iDisp2 Pin",
 		.codec_name = "ehdaudio0D2",
 		.codec_dai_name = "intel-hdmi-hifi2",
@@ -304,7 +304,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
 	},
 	{
 		.name = "iDisp3",
-		.be_id = 5,
+		.id = 5,
 		.cpu_dai_name = "iDisp3 Pin",
 		.codec_name = "ehdaudio0D2",
 		.codec_dai_name = "intel-hdmi-hifi3",
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2016-05-06 12:02   ` Mark Brown
@ 2016-05-06 13:39     ` Opensource [Adam Thomson]
  0 siblings, 0 replies; 193+ messages in thread
From: Opensource [Adam Thomson] @ 2016-05-06 13:39 UTC (permalink / raw)
  To: Mark Brown, Opensource [Adam Thomson]
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Sathyanarayana Nujella

On May 06, 2016, 13:03, Mark Brown wrote:

> > This patch was the 3rd in of a set of 3, and the header you added below was
> > added as part of the 2nd patch of that set, hence why it is missing here. I
> > assume the first 2 patches are still being reviewed by Mark.
> 
> Yes.  The ID patch should have been the first one here, put the simple
> stuff first.

In my mind it makes sense to only add this after support to use it is in place
in the driver, hence the ordering.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-05-06  9:48 ` Opensource [Adam Thomson]
@ 2016-05-06 12:02   ` Mark Brown
  2016-05-06 13:39     ` Opensource [Adam Thomson]
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2016-05-06 12:02 UTC (permalink / raw)
  To: Opensource [Adam Thomson]
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Sathyanarayana Nujella

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Fri, May 06, 2016 at 09:48:51AM +0000, Opensource [Adam Thomson] wrote:

> This patch was the 3rd in of a set of 3, and the header you added below was
> added as part of the 2nd patch of that set, hence why it is missing here. I
> assume the first 2 patches are still being reviewed by Mark.

Yes.  The ID patch should have been the first one here, put the simple
stuff first.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2016-05-06  0:57 Stephen Rothwell
@ 2016-05-06  9:48 ` Opensource [Adam Thomson]
  2016-05-06 12:02   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Opensource [Adam Thomson] @ 2016-05-06  9:48 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Opensource [Adam Thomson],
	Sathyanarayana Nujella

On May 06, 2016, 01:58, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function
> 'ACPI_PTR' [-Werror=implicit-function-declaration]
>    .acpi_match_table = ACPI_PTR(da7219_acpi_match),
>                        ^
> sound/soc/codecs/da7219.c:1964:23: error: initializer element is not constant
> sound/soc/codecs/da7219.c:1964:23: note: (near initialization for
> 'da7219_i2c_driver.driver.acpi_match_table')
> 
> Caused by commit
> 
>   5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")
> 
> I added this patch for today:

This patch was the 3rd in of a set of 3, and the header you added below was
added as part of the 2nd patch of that set, hence why it is missing here. I
assume the first 2 patches are still being reviewed by Mark.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-05-06  0:57 Stephen Rothwell
  2016-05-06  9:48 ` Opensource [Adam Thomson]
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-05-06  0:57 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Adam Thomson, Sathyanarayana Nujella

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function 'ACPI_PTR' [-Werror=implicit-function-declaration]
   .acpi_match_table = ACPI_PTR(da7219_acpi_match),
                       ^
sound/soc/codecs/da7219.c:1964:23: error: initializer element is not constant
sound/soc/codecs/da7219.c:1964:23: note: (near initialization for 'da7219_i2c_driver.driver.acpi_match_table')

Caused by commit

  5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 6 May 2016 10:52:45 +1000
Subject: [PATCH] ASoC: da7219: include acpi.h for ACPI_PTR

Fixed: 5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/da7219.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 17e2119f211b..1d9f4ff4355a 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -20,6 +20,7 @@
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/regulator/consumer.h>
+#include <linux/acpi.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-04-22  8:40 ` Philipp Zabel
  2016-04-22  8:58   ` Mark Brown
@ 2016-04-22  9:21   ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2016-04-22  9:21 UTC (permalink / raw)
  To: Philipp Zabel
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel, Jyri Sarha

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

On Fri, Apr 22, 2016 at 10:40:11AM +0200, Philipp Zabel wrote:

> --------8<--------
> From: Philipp Zabel <p.zabel@pengutronix.de>
> Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control

Please also use subject lines that match the style for the subsystem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-04-22  8:40 ` Philipp Zabel
@ 2016-04-22  8:58   ` Mark Brown
  2016-04-22  9:21   ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2016-04-22  8:58 UTC (permalink / raw)
  To: Philipp Zabel
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel, Jyri Sarha

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

On Fri, Apr 22, 2016 at 10:40:11AM +0200, Philipp Zabel wrote:

> --------8<--------
> From: Philipp Zabel <p.zabel@pengutronix.de>
> Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control

Please don't bury patches in the middle of e-mails.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2016-04-22  2:03 Stephen Rothwell
@ 2016-04-22  8:40 ` Philipp Zabel
  2016-04-22  8:58   ` Mark Brown
  2016-04-22  9:21   ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Philipp Zabel @ 2016-04-22  8:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel, Jyri Sarha

Am Freitag, den 22.04.2016, 12:03 +1000 schrieb Stephen Rothwell:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from include/linux/notifier.h:13:0,
>                  from include/linux/memory_hotplug.h:6,
>                  from include/linux/mmzone.h:744,
>                  from include/linux/gfp.h:5,
>                  from include/linux/kmod.h:22,
>                  from include/linux/module.h:13,
>                  from sound/soc/codecs/hdmi-codec.c:15:
> sound/soc/codecs/hdmi-codec.c: In function 'hdmi_eld_ctl_get':
> sound/soc/codecs/hdmi-codec.c:68:17: error: 'struct hdmi_codec_priv' has no member named 'eld_lock'
>   mutex_lock(&hcp->eld_lock);
>                  ^
> include/linux/mutex.h:146:44: note: in definition of macro 'mutex_lock'
>  #define mutex_lock(lock) mutex_lock_nested(lock, 0)
>                                             ^
> sound/soc/codecs/hdmi-codec.c:70:19: error: 'struct hdmi_codec_priv' has no member named 'eld_lock'
>   mutex_unlock(&hcp->eld_lock);
>                    ^
> 
> Caused by commit
> 
>   81151cfb6bfe ("ASoC: hdmi-codec: Add ELD control")
> 
> I have used the sound-asoc tree from next-20160421 for today.

Sorry, the mutex_lock slipped through when reordering the patches.
That should be part of the "Use HDMI notifications to add jack support"
patch instead.

regards
Philipp

--------8<--------
From: Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control

---
 sound/soc/codecs/hdmi-codec.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index c78333b..8e36e88 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -65,9 +65,7 @@ static int hdmi_eld_ctl_get(struct snd_kcontrol *kcontrol,
 	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
 	struct hdmi_codec_priv *hcp = snd_soc_component_get_drvdata(component);
 
-	mutex_lock(&hcp->eld_lock);
 	memcpy(ucontrol->value.bytes.data, hcp->eld, sizeof(hcp->eld));
-	mutex_unlock(&hcp->eld_lock);
 
 	return 0;
 }
-- 
2.8.0.rc3

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2016-04-22  2:03 Stephen Rothwell
  2016-04-22  8:40 ` Philipp Zabel
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2016-04-22  2:03 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Philipp Zabel, Jyri Sarha

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/notifier.h:13:0,
                 from include/linux/memory_hotplug.h:6,
                 from include/linux/mmzone.h:744,
                 from include/linux/gfp.h:5,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from sound/soc/codecs/hdmi-codec.c:15:
sound/soc/codecs/hdmi-codec.c: In function 'hdmi_eld_ctl_get':
sound/soc/codecs/hdmi-codec.c:68:17: error: 'struct hdmi_codec_priv' has no member named 'eld_lock'
  mutex_lock(&hcp->eld_lock);
                 ^
include/linux/mutex.h:146:44: note: in definition of macro 'mutex_lock'
 #define mutex_lock(lock) mutex_lock_nested(lock, 0)
                                            ^
sound/soc/codecs/hdmi-codec.c:70:19: error: 'struct hdmi_codec_priv' has no member named 'eld_lock'
  mutex_unlock(&hcp->eld_lock);
                   ^

Caused by commit

  81151cfb6bfe ("ASoC: hdmi-codec: Add ELD control")

I have used the sound-asoc tree from next-20160421 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-11-20 12:06   ` Mark Brown
@ 2015-11-20 14:58     ` Vinod Koul
  0 siblings, 0 replies; 193+ messages in thread
From: Vinod Koul @ 2015-11-20 14:58 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Mengdong Lin, Harsha Priya, Conrad Cooke, Naveen M,
	Sathya Prakash M R, Yong Zhi, Fang, Yang A,
	Sathyanarayana Nujella

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Fri, Nov 20, 2015 at 12:06:13PM +0000, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> > On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
> 
> > > Caused by commit
> > > 
> > >   a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine driver")
> 
> > Okay both went it same time, I will send a patch for this
> 
> Not seeing that patch...

Sorry for the delay. I have the patches, testing it now. couple of hours and
it should be on the list :)

Thanks
-- 
~Vinod

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-11-19  3:02 ` Vinod Koul
  2015-11-19 10:38   ` Mark Brown
@ 2015-11-20 12:06   ` Mark Brown
  2015-11-20 14:58     ` Vinod Koul
  1 sibling, 1 reply; 193+ messages in thread
From: Mark Brown @ 2015-11-20 12:06 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Mengdong Lin, Harsha Priya, Conrad Cooke, Naveen M,
	Sathya Prakash M R, Yong Zhi, Fang, Yang A,
	Sathyanarayana Nujella

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:

> > Caused by commit
> > 
> >   a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine driver")

> Okay both went it same time, I will send a patch for this

Not seeing that patch...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-11-19  3:02 ` Vinod Koul
@ 2015-11-19 10:38   ` Mark Brown
  2015-11-20 12:06   ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2015-11-19 10:38 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Mengdong Lin, Harsha Priya, Conrad Cooke, Naveen M,
	Sathya Prakash M R, Yong Zhi, Fang, Yang A,
	Sathyanarayana Nujella

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:

> >   a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine driver")

> Okay both went it same time, I will send a patch for this

> Somehow Feng's bot missed this...

There was a mail about it - it came out too close to when Stephen
usually pulls for me to do anything about backing things out.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-11-19  0:35 Stephen Rothwell
@ 2015-11-19  3:02 ` Vinod Koul
  2015-11-19 10:38   ` Mark Brown
  2015-11-20 12:06   ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Vinod Koul @ 2015-11-19  3:02 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel,
	Mengdong Lin, Harsha Priya, Conrad Cooke, Naveen M,
	Sathya Prakash M R, Yong Zhi, Fang, Yang A,
	Sathyanarayana Nujella

On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/fsl/fsl-asoc-card.c: In function 'fsl_asoc_card_late_probe':
> sound/soc/fsl/fsl-asoc-card.c:420:38: error: 'struct snd_soc_card' has no member named 'rtd'
>   struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
>                                       ^
> sound/soc/fsl/fsl-asoc-card.c:427:37: error: 'struct snd_soc_card' has no member named 'rtd'
>    struct snd_soc_codec *codec = card->rtd[0].codec;
>                                      ^
> 
> Caused by commit
> 
>   5015920a1732 ("ASoC: Vendor drivers get a link's runtime by snd_soc_get_pcm_runtime()")
> 
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c: In function 'skl_get_codec_dai':
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c:43:13: error: 'struct snd_soc_card' has no member named 'rtd'
>    rtd = card->rtd + i;
>              ^
> 
> Caused by commit
> 
>   a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine driver")
Okay both went it same time, I will send a patch for this

Somehow Feng's bot missed this...

-- 
~Vinod

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-11-19  0:35 Stephen Rothwell
  2015-11-19  3:02 ` Vinod Koul
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-11-19  0:35 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Mengdong Lin, Harsha Priya,
	Conrad Cooke, Naveen M, Sathya Prakash M R, Yong Zhi, Fang,
	Yang A, Sathyanarayana Nujella, Vinod Koul

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/fsl/fsl-asoc-card.c: In function 'fsl_asoc_card_late_probe':
sound/soc/fsl/fsl-asoc-card.c:420:38: error: 'struct snd_soc_card' has no member named 'rtd'
  struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
                                      ^
sound/soc/fsl/fsl-asoc-card.c:427:37: error: 'struct snd_soc_card' has no member named 'rtd'
   struct snd_soc_codec *codec = card->rtd[0].codec;
                                     ^

Caused by commit

  5015920a1732 ("ASoC: Vendor drivers get a link's runtime by snd_soc_get_pcm_runtime()")

sound/soc/intel/boards/skl_nau88l25_ssm4567.c: In function 'skl_get_codec_dai':
sound/soc/intel/boards/skl_nau88l25_ssm4567.c:43:13: error: 'struct snd_soc_card' has no member named 'rtd'
   rtd = card->rtd + i;
             ^

Caused by commit

  a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine driver")

I have used the sound-asoc tree from next-20151118 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-09-21  1:23 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2015-09-21  1:23 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Bard Liao

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt5645.c: In function 'rt5645_i2c_probe':
sound/soc/codecs/rt5645.c:3277:21: error: 'dmi_platform_intel_broadwel' undeclared (first use in this function)
    dmi_check_system(dmi_platform_intel_broadwel)
                     ^
sound/soc/codecs/rt5645.c:3277:21: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/codecs/rt5645.c:3278:3: error: expected ')' before 'rt5645'
   rt5645->pdata = *rt5645_pdata;
   ^
sound/soc/codecs/rt5645.c:3478:1: error: expected expression before '}' token
 }
 ^
sound/soc/codecs/rt5645.c:3264:15: warning: unused variable 'val' [-Wunused-variable]
  unsigned int val;
               ^
sound/soc/codecs/rt5645.c:3263:11: warning: unused variable 'i' [-Wunused-variable]
  int ret, i;
           ^
sound/soc/codecs/rt5645.c:3263:6: warning: unused variable 'ret' [-Wunused-variable]
  int ret, i;
      ^
sound/soc/codecs/rt5645.c: At top level:
sound/soc/codecs/rt5645.c:2894:13: warning: 'rt5645_jack_detect_work' defined but not used [-Wunused-function]
 static void rt5645_jack_detect_work(struct work_struct *work)
             ^
sound/soc/codecs/rt5645.c:3090:34: warning: 'rt5645_dai' defined but not used [-Wunused-variable]
 static struct snd_soc_dai_driver rt5645_dai[] = {
                                  ^
sound/soc/codecs/rt5645.c:3131:36: warning: 'soc_codec_dev_rt5645' defined but not used [-Wunused-variable]
 static struct snd_soc_codec_driver soc_codec_dev_rt5645 = {
                                    ^
sound/soc/codecs/rt5645.c:3232:29: warning: 'dmi_platform_intel_broadwell' defined but not used [-Wunused-variable]
 static struct snd_soc_codec_driver soc_codec_dev_rt5645 = {
                                    ^
sound/soc/codecs/rt5645.c:3232:29: warning: 'dmi_platform_intel_broadwell' defined but not used [-Wunused-variable]
 static struct dmi_system_id dmi_platform_intel_broadwell[] __initdata = {
                             ^
sound/soc/codecs/rt5645.c:3244:12: warning: 'rt5645_parse_dt' defined but not used [-Wunused-function]
 static int rt5645_parse_dt(struct rt5645_priv *rt5645, struct device *dev)
            ^
sound/soc/codecs/rt5645.c: In function 'rt5645_i2c_probe':
sound/soc/codecs/rt5645.c:3478:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit

  3dbabe60c832 ("ASoC: rt5645: Add dmi for Broadwell")

I have used the sound-asoc tree from next-20150918 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-31  7:51         ` Stephen Rothwell
@ 2015-08-31  8:18           ` Ricard Wanderlof
  0 siblings, 0 replies; 193+ messages in thread
From: Ricard Wanderlof @ 2015-08-31  8:18 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel


On Mon, 31 Aug 2015, Stephen Rothwell wrote:

> On Mon, 31 Aug 2015 17:48:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof <ricard.wanderlof@axis.com> wrote:
> > >
> > > On Fri, 28 Aug 2015, Mark Brown wrote:
> > > 
> > > > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote:
> > > > > On Fri, 28 Aug 2015, Stephen Rothwell wrote:
> > > > 
> > > > > In fact the exact same construct is used by a handful of other codec 
> > > > > drivers which apparently don't fail.
> > > > 
> > > > > I'm suspecting something slightly more convoluted like a missing 
> > > > #include .
> > > > 
> > > > No, the issue is that you have used a different variable name when 
> > > > declaring the IDs and when referencing them in the module device table.
> > > 
> > > Yeah, I realized that upon closer inspection. 
> > > 
> > > What bugs me is that my ARM gcc didn't seem to flag this, whereas the 
> > > x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my 
> > > build.
> > 
> > Do you have CONFIG_MODULE set in your build? (just guessing)
> 
> Actually what matters is if you build the driver as a module or not.
> See include/linux/module.h and the definitions of MODULE_DEVICE_TABLE().

Bingo.

Haven't verified that, but it's true, the kernel build for our ARM system 
is largely monolithic as we have no need to reconfigure it once it has 
been built. Whereas in my x86 test build the driver was built as a module.

Thanks Stegphen!

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-31  7:48       ` Stephen Rothwell
@ 2015-08-31  7:51         ` Stephen Rothwell
  2015-08-31  8:18           ` Ricard Wanderlof
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-08-31  7:51 UTC (permalink / raw)
  To: Ricard Wanderlof; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

Hi Ricard,

On Mon, 31 Aug 2015 17:48:42 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof <ricard.wanderlof@axis.com> wrote:
> >
> > On Fri, 28 Aug 2015, Mark Brown wrote:
> > 
> > > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote:
> > > > On Fri, 28 Aug 2015, Stephen Rothwell wrote:
> > > 
> > > > In fact the exact same construct is used by a handful of other codec 
> > > > drivers which apparently don't fail.
> > > 
> > > > I'm suspecting something slightly more convoluted like a missing 
> > > #include .
> > > 
> > > No, the issue is that you have used a different variable name when 
> > > declaring the IDs and when referencing them in the module device table.
> > 
> > Yeah, I realized that upon closer inspection. 
> > 
> > What bugs me is that my ARM gcc didn't seem to flag this, whereas the 
> > x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my 
> > build.
> 
> Do you have CONFIG_MODULE set in your build? (just guessing)

Actually what matters is if you build the driver as a module or not.
See include/linux/module.h and the definitions of MODULE_DEVICE_TABLE().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-31  7:04     ` Ricard Wanderlof
@ 2015-08-31  7:48       ` Stephen Rothwell
  2015-08-31  7:51         ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-08-31  7:48 UTC (permalink / raw)
  To: Ricard Wanderlof; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

Hi Ricard,

On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof <ricard.wanderlof@axis.com> wrote:
>
> On Fri, 28 Aug 2015, Mark Brown wrote:
> 
> > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote:
> > > On Fri, 28 Aug 2015, Stephen Rothwell wrote:
> > 
> > > In fact the exact same construct is used by a handful of other codec 
> > > drivers which apparently don't fail.
> > 
> > > I'm suspecting something slightly more convoluted like a missing 
> > #include .
> > 
> > No, the issue is that you have used a different variable name when 
> > declaring the IDs and when referencing them in the module device table.
> 
> Yeah, I realized that upon closer inspection. 
> 
> What bugs me is that my ARM gcc didn't seem to flag this, whereas the 
> x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my 
> build.

Do you have CONFIG_MODULE set in your build? (just guessing)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-28 15:45   ` Mark Brown
@ 2015-08-31  7:04     ` Ricard Wanderlof
  2015-08-31  7:48       ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Ricard Wanderlof @ 2015-08-31  7:04 UTC (permalink / raw)
  To: Mark Brown; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel


On Fri, 28 Aug 2015, Mark Brown wrote:

> On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote:
> > On Fri, 28 Aug 2015, Stephen Rothwell wrote:
> 
> > In fact the exact same construct is used by a handful of other codec 
> > drivers which apparently don't fail.
> 
> > I'm suspecting something slightly more convoluted like a missing 
> #include .
> 
> No, the issue is that you have used a different variable name when 
> declaring the IDs and when referencing them in the module device table.

Yeah, I realized that upon closer inspection. 

What bugs me is that my ARM gcc didn't seem to flag this, whereas the 
x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my 
build.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-28  7:40 ` Ricard Wanderlof
@ 2015-08-28 15:45   ` Mark Brown
  2015-08-31  7:04     ` Ricard Wanderlof
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2015-08-28 15:45 UTC (permalink / raw)
  To: Ricard Wanderlof
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote:
> On Fri, 28 Aug 2015, Stephen Rothwell wrote:

> In fact the exact same construct is used by a handful of other codec 
> drivers which apparently don't fail.

> I'm suspecting something slightly more convoluted like a missing #include .

No, the issue is that you have used a different variable name when
declaring the IDs and when referencing them in the module device table.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-08-28  1:50 Stephen Rothwell
@ 2015-08-28  7:40 ` Ricard Wanderlof
  2015-08-28 15:45   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Ricard Wanderlof @ 2015-08-28  7:40 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel


On Fri, 28 Aug 2015, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from sound/soc/codecs/ics43432.c:12:0:
> sound/soc/codecs/ics43432.c:60:25: error: 'ics43432_dt_ids' undeclared here (not in a function)
>  MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
>                          ^
> include/linux/module.h:223:21: note: in definition of macro 'MODULE_DEVICE_TABLE'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                      ^
> include/linux/module.h:223:27: error: '__mod_of__ics43432_dt_ids_device_table' aliased to undefined symbol 'ics43432_dt_ids'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                            ^ 
> sound/soc/codecs/ics43432.c:60:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
>  MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
>  ^
> 
> Caused by commit
> 
>   3b7ce99748f0 ("ASoC: ics43432: Add codec driver for InvenSense ICS-43432")
> 
> Not really build tested with CONFIG_OF set, right? :-(

Well, actually, yes.

In fact the exact same construct is used by a handful of other codec 
drivers which apparently don't fail.

I'm suspecting something slightly more convoluted like a missing #include .

> I have reverted that commit for today.

Ok. I'll get to work on this ASAP.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-08-28  1:50 Stephen Rothwell
  2015-08-28  7:40 ` Ricard Wanderlof
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-08-28  1:50 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Ricard Wanderlof

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from sound/soc/codecs/ics43432.c:12:0:
sound/soc/codecs/ics43432.c:60:25: error: 'ics43432_dt_ids' undeclared here (not in a function)
 MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
                         ^
include/linux/module.h:223:21: note: in definition of macro 'MODULE_DEVICE_TABLE'
 extern const typeof(name) __mod_##type##__##name##_device_table  \
                     ^
include/linux/module.h:223:27: error: '__mod_of__ics43432_dt_ids_device_table' aliased to undefined symbol 'ics43432_dt_ids'
 extern const typeof(name) __mod_##type##__##name##_device_table  \
                           ^ 
sound/soc/codecs/ics43432.c:60:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
 MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
 ^

Caused by commit

  3b7ce99748f0 ("ASoC: ics43432: Add codec driver for InvenSense ICS-43432")

Not really build tested with CONFIG_OF set, right? :-(

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-07-17  4:25 Stephen Rothwell
@ 2015-07-20  3:44 ` Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2015-07-20  3:44 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Arnaud Pouliquen

Hi all,

On Fri, 17 Jul 2015 14:25:01 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_suspend':
> sound/soc/sti/sti_uniperif.c:81:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
>   ret = pinctrl_pm_select_sleep_state(uni->dev);
>   ^
> sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_resume':
> sound/soc/sti/sti_uniperif.c:102:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
>   ret = pinctrl_pm_select_default_state(uni->dev);
>   ^
> 
> Caused by commit
> 
>   f3bd847eb0a7 ("ASoC: sti: Add uniperipheral dai driver")

ping!  I still needed this today.

> 
> I have added this fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 17 Jul 2015 14:21:37 +1000
> Subject: [PATCH] ASoC: sti: included needed header file
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  sound/soc/sti/sti_uniperif.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
> index 749e6b294184..ab8d36af6dcb 100644
> --- a/sound/soc/sti/sti_uniperif.c
> +++ b/sound/soc/sti/sti_uniperif.c
> @@ -6,6 +6,7 @@
>   */
>  
>  #include <linux/module.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  #include "uniperif.h"
>  
> -- 
> 2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-07-17  4:25 Stephen Rothwell
  2015-07-20  3:44 ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-07-17  4:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Arnaud Pouliquen

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_suspend':
sound/soc/sti/sti_uniperif.c:81:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
  ret = pinctrl_pm_select_sleep_state(uni->dev);
  ^
sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_resume':
sound/soc/sti/sti_uniperif.c:102:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  ret = pinctrl_pm_select_default_state(uni->dev);
  ^

Caused by commit

  f3bd847eb0a7 ("ASoC: sti: Add uniperipheral dai driver")

I have added this fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Jul 2015 14:21:37 +1000
Subject: [PATCH] ASoC: sti: included needed header file

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/sti/sti_uniperif.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
index 749e6b294184..ab8d36af6dcb 100644
--- a/sound/soc/sti/sti_uniperif.c
+++ b/sound/soc/sti/sti_uniperif.c
@@ -6,6 +6,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/pinctrl/consumer.h>
 
 #include "uniperif.h"
 
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-06-04  4:02 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2015-06-04  4:02 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from sound/soc/soc-dapm.c:43:0:
include/sound/soc.h:30:32: fatal error: sound/soc-topology.h: No such file or directory
 #include <sound/soc-topology.h>
                                ^

Several more of these ...

Caused by commit b2eef86fedbf ("ASoC: topology: Add topology core").
Looks like a file was missed.

I have used the sound-asoc tree from next-20150603 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-06-02  2:51 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2015-06-02  2:51 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-dapm.c: In function 'dapm_kcontrol_data_alloc':
sound/soc/soc-dapm.c:387:4: error: implicit declaration of function 'snd_soc_dapm_new_control' [-Werror=implicit-function-declaration]
    data->widget = snd_soc_dapm_new_control(widget->dapm,
    ^
sound/soc/soc-dapm.c:387:17: warning: assignment makes pointer from integer without a cast
    data->widget = snd_soc_dapm_new_control(widget->dapm,
                 ^
sound/soc/soc-dapm.c: At top level:
sound/soc/soc-dapm.c:3269:1: error: conflicting types for 'snd_soc_dapm_new_control'
 snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
 ^
sound/soc/soc-dapm.c:387:19: note: previous implicit declaration of 'snd_soc_dapm_new_control' was here
    data->widget = snd_soc_dapm_new_control(widget->dapm,
                   ^

Caused by commit 02aa78abec6e ("ASoC: DAPM: Add APIs to create
individual DAPM controls").

I have used the sound-asoc tree from next-20150601 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2015-04-30  2:05 Stephen Rothwell
@ 2015-04-30  2:14 ` Bard Liao
  0 siblings, 0 replies; 193+ messages in thread
From: Bard Liao @ 2015-04-30  2:14 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

Dear All,

I will send a patch to fix it immediately.

Thanks.

Bard Liao

Computer Peripherals Business Unit
Realtek Semiconductor Corp.
886-3-578-0211 ext. 3334
bardliao@realtek.com


> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Thursday, April 30, 2015 10:06 AM
> To: Mark Brown; Liam Girdwood
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Bard Liao
> Subject: linux-next: build failure after merge of the sound-asoc tree
> 
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> sound/soc/codecs/rt5645.c: In function 'rt5645_set_jack_detect':
> sound/soc/codecs/rt5645.c:2555:2: error: implicit declaration of function
> 'rt5645_irq_detection' [-Werror=implicit-function-declaration]
>   rt5645_irq_detection(rt5645);
>   ^
> sound/soc/codecs/rt5645.c: At top level:
> sound/soc/codecs/rt5645.c:2591:12: error: static declaration of
> 'rt5645_irq_detection' follows non-static declaration  static int
> rt5645_irq_detection(struct rt5645_priv *rt5645)
>             ^
> sound/soc/codecs/rt5645.c:2555:2: note: previous implicit declaration of
> 'rt5645_irq_detection' was here
>   rt5645_irq_detection(rt5645);
>   ^
> sound/soc/codecs/rt5645.c:2591:12: warning: 'rt5645_irq_detection'
> defined but not used [-Wunused-function]  static int
> rt5645_irq_detection(struct rt5645_priv *rt5645)
>             ^
> 
> Caused by commit 6e747d5311fc ("ASoC: rt5645: Adds push button
> support for rt5650").
> 
> I have used the sound-asoc tree from next-20150429 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> 
> ------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-04-30  2:05 Stephen Rothwell
  2015-04-30  2:14 ` Bard Liao
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-04-30  2:05 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Bard Liao

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

sound/soc/codecs/rt5645.c: In function 'rt5645_set_jack_detect':
sound/soc/codecs/rt5645.c:2555:2: error: implicit declaration of function 'rt5645_irq_detection' [-Werror=implicit-function-declaration]
  rt5645_irq_detection(rt5645);
  ^
sound/soc/codecs/rt5645.c: At top level:
sound/soc/codecs/rt5645.c:2591:12: error: static declaration of 'rt5645_irq_detection' follows non-static declaration
 static int rt5645_irq_detection(struct rt5645_priv *rt5645)
            ^
sound/soc/codecs/rt5645.c:2555:2: note: previous implicit declaration of 'rt5645_irq_detection' was here
  rt5645_irq_detection(rt5645);
  ^
sound/soc/codecs/rt5645.c:2591:12: warning: 'rt5645_irq_detection' defined but not used [-Wunused-function]
 static int rt5645_irq_detection(struct rt5645_priv *rt5645)
            ^

Caused by commit 6e747d5311fc ("ASoC: rt5645: Adds push button support
for rt5650").

I have used the sound-asoc tree from next-20150429 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2015-03-12  2:11 ` Stephen Rothwell
@ 2015-03-12  2:50   ` Bard Liao
  0 siblings, 0 replies; 193+ messages in thread
From: Bard Liao @ 2015-03-12  2:50 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Thursday, March 12, 2015 10:12 AM
> To: Mark Brown; Liam Girdwood
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Bard Liao
> Subject: Re: linux-next: build failure after merge of the sound-asoc tree
> 
> Hi all,
> 
> On Tue, 10 Mar 2015 13:01:20 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/soc/codecs/rt5670.c: In function 'is_sys_clk_from_pll':
> > sound/soc/codecs/rt5670.c:519:38: error: 'struct snd_soc_dapm_widget'
> has no member named 'codec'
> >   struct snd_soc_codec *codec = source->codec;
> >                                       ^
> >

Hi

Please apply Lars-Peter's "ASoC: rt5670: Replace w->codec
snd_soc_dapm_to_codec(w->dapm)" patch
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-January/086618.html

Thanks.

> > Caused by commit 485372dc24ca ("ASoC: rt5670: Check sysclk source by
> > private data")?
> 
> Still getting this.
> 
> > sound/soc/codecs/rt5670.c: In function 'rt5670_set_dai_sysclk':
> > sound/soc/codecs/rt5670.c:2272:1: error: expected expression before
> > '<<' token  <<<<<<< HEAD  ^
> > sound/soc/codecs/rt5670.c:2284:1: error: expected expression before
> > '>>' token  >>>>>>> v4.0-rc3  ^
> >
> > Oops :-(
> 
> This has been fixed.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> 
> ------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-03-10  2:01 Stephen Rothwell
@ 2015-03-12  2:11 ` Stephen Rothwell
  2015-03-12  2:50   ` Bard Liao
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-03-12  2:11 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Bard Liao

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Hi all,

On Tue, 10 Mar 2015 13:01:20 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/rt5670.c: In function 'is_sys_clk_from_pll':
> sound/soc/codecs/rt5670.c:519:38: error: 'struct snd_soc_dapm_widget' has no member named 'codec'
>   struct snd_soc_codec *codec = source->codec;
>                                       ^
> 
> Caused by commit 485372dc24ca ("ASoC: rt5670: Check sysclk source by
> private data")?

Still getting this.

> sound/soc/codecs/rt5670.c: In function 'rt5670_set_dai_sysclk':
> sound/soc/codecs/rt5670.c:2272:1: error: expected expression before '<<' token
>  <<<<<<< HEAD
>  ^
> sound/soc/codecs/rt5670.c:2284:1: error: expected expression before '>>' token
>  >>>>>>> v4.0-rc3
>  ^
> 
> Oops :-(

This has been fixed.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-03-10  2:01 Stephen Rothwell
  2015-03-12  2:11 ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-03-10  2:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Bard Liao

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt5670.c: In function 'is_sys_clk_from_pll':
sound/soc/codecs/rt5670.c:519:38: error: 'struct snd_soc_dapm_widget' has no member named 'codec'
  struct snd_soc_codec *codec = source->codec;
                                      ^

Caused by commit 485372dc24ca ("ASoC: rt5670: Check sysclk source by
private data")?

sound/soc/codecs/rt5670.c: In function 'rt5670_set_dai_sysclk':
sound/soc/codecs/rt5670.c:2272:1: error: expected expression before '<<' token
 <<<<<<< HEAD
 ^
sound/soc/codecs/rt5670.c:2284:1: error: expected expression before '>>' token
 >>>>>>> v4.0-rc3
 ^

Oops :-(

I have used the cound-asoc tree from next-20150306 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-02-09  3:36 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2015-02-09  3:36 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Kenneth Westfield, Banajit Goswami

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from sound/soc/codecs/max98357a.c:15:0:
include/linux/module.h:138:40: error: '__mod_of__max98357a_device_id_device_table' aliased to undefined symbol 'max98357a_device_id'
   extern const struct type##_device_id __mod_##type##__##name##_device_table \
                                        ^
sound/soc/codecs/max98357a.c:138:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
 MODULE_DEVICE_TABLE(of, max98357a_device_id);
 ^

Caused by commit af5adf129369 ("ASoC: max98357a: Add MAX98357A codec driver").

I have added the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 9 Feb 2015 14:34:40 +1100
Subject: [PATCH] ASoC: max98357a: fix !CONFIG_OF build

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/max98357a.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c
index 98b915314d7a..ac169f9f4329 100644
--- a/sound/soc/codecs/max98357a.c
+++ b/sound/soc/codecs/max98357a.c
@@ -135,4 +135,6 @@ module_platform_driver(max98357a_platform_driver);
 MODULE_DESCRIPTION("Maxim MAX98357A Codec Driver");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:" DRV_NAME);
+#ifdef CONFIG_OF
 MODULE_DEVICE_TABLE(of, max98357a_device_id);
+#endif
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-01-28  9:50   ` Charles Keepax
@ 2015-01-28 11:06     ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2015-01-28 11:06 UTC (permalink / raw)
  To: Charles Keepax
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Wed, Jan 28, 2015 at 09:50:40AM +0000, Charles Keepax wrote:
> On Wed, Jan 28, 2015 at 09:09:35AM +0000, Charles Keepax wrote:

> > Very sorry guys my fault, not sure how that slipped through. Mark
> > do you want an incremental fix or shall I respin the two patches
> > in question?

> Ah... ok I think I just timed my patch very badly in relation to
> Lar's changes and it was building here so I failed to notice the
> error. I see you have fixed it in the merge are you happy to go
> with that solution?

It should be fixed for tomorrow I think - the zero day tester was quite
slow for some reason.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-01-28  9:09 ` Charles Keepax
@ 2015-01-28  9:50   ` Charles Keepax
  2015-01-28 11:06     ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Charles Keepax @ 2015-01-28  9:50 UTC (permalink / raw)
  To: broonie
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Lars-Peter Clausen

On Wed, Jan 28, 2015 at 09:09:35AM +0000, Charles Keepax wrote:
> On Wed, Jan 28, 2015 at 01:00:47PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > sound/soc/codecs/arizona.c: In function 'arizona_out_ev':
> > sound/soc/codecs/arizona.c:738:57: error: 'struct snd_soc_dapm_widget' has no member named 'codec'
> >   struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
> >                                                          ^
> > 
> > Caused by commit 054e1b489227 ("ASoC: arizona: Add delay for output
> > disable") interacting with commit 96da4e5b2e1d ("ASoC: Remove codec
> > field from snd_soc_dapm_widget").  It needed to be fixed up in merge
> > commit 7659e0ab1afa ("Merge remote-tracking branches
> > 'asoc/topic/ad193x', 'asoc/topic/alc5632', 'asoc/topic/arizona' and
> > 'asoc/topic/atmel' into asoc-next").
> > 
> > I have used the sound-asoc tree from next-20150127 for today.
> > -- 
> 
> Very sorry guys my fault, not sure how that slipped through. Mark
> do you want an incremental fix or shall I respin the two patches
> in question?

Ah... ok I think I just timed my patch very badly in relation to
Lar's changes and it was building here so I failed to notice the
error. I see you have fixed it in the merge are you happy to go
with that solution?

Thanks,
Charles

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2015-01-28  2:00 Stephen Rothwell
@ 2015-01-28  9:09 ` Charles Keepax
  2015-01-28  9:50   ` Charles Keepax
  0 siblings, 1 reply; 193+ messages in thread
From: Charles Keepax @ 2015-01-28  9:09 UTC (permalink / raw)
  To: broonie
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel,
	Lars-Peter Clausen

On Wed, Jan 28, 2015 at 01:00:47PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> sound/soc/codecs/arizona.c: In function 'arizona_out_ev':
> sound/soc/codecs/arizona.c:738:57: error: 'struct snd_soc_dapm_widget' has no member named 'codec'
>   struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
>                                                          ^
> 
> Caused by commit 054e1b489227 ("ASoC: arizona: Add delay for output
> disable") interacting with commit 96da4e5b2e1d ("ASoC: Remove codec
> field from snd_soc_dapm_widget").  It needed to be fixed up in merge
> commit 7659e0ab1afa ("Merge remote-tracking branches
> 'asoc/topic/ad193x', 'asoc/topic/alc5632', 'asoc/topic/arizona' and
> 'asoc/topic/atmel' into asoc-next").
> 
> I have used the sound-asoc tree from next-20150127 for today.
> -- 

Very sorry guys my fault, not sure how that slipped through. Mark
do you want an incremental fix or shall I respin the two patches
in question?

Thanks,
Charles

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2015-01-28  2:00 Stephen Rothwell
  2015-01-28  9:09 ` Charles Keepax
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2015-01-28  2:00 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Charles Keepax, Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

sound/soc/codecs/arizona.c: In function 'arizona_out_ev':
sound/soc/codecs/arizona.c:738:57: error: 'struct snd_soc_dapm_widget' has no member named 'codec'
  struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
                                                         ^

Caused by commit 054e1b489227 ("ASoC: arizona: Add delay for output
disable") interacting with commit 96da4e5b2e1d ("ASoC: Remove codec
field from snd_soc_dapm_widget").  It needed to be fixed up in merge
commit 7659e0ab1afa ("Merge remote-tracking branches
'asoc/topic/ad193x', 'asoc/topic/alc5632', 'asoc/topic/arizona' and
'asoc/topic/atmel' into asoc-next").

I have used the sound-asoc tree from next-20150127 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-10-21  0:33 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2014-10-21  0:33 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Oder Chiou

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/rt5677-spi.o: In function `rt5677_spi_driver_init':
rt5677-spi.c:(.init.text+0x0): multiple definition of `init_module'
sound/soc/codecs/rt5677.o:rt5677.c:(.init.text+0x0): first defined here
sound/soc/codecs/rt5677-spi.o: In function `rt5677_spi_driver_exit':
rt5677-spi.c:(.exit.text+0x0): multiple definition of `cleanup_module'
sound/soc/codecs/rt5677.o:rt5677.c:(.exit.text+0x0): first defined here

Probably caused by commit af48f1d08a54 ("ASoC: rt5677: Support DSP
function for VAD application").

I have used the sound-asoc tree from next-20141020 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2014-08-18  6:51 ` Sean Cross
@ 2014-08-18 14:09   ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2014-08-18 14:09 UTC (permalink / raw)
  To: Sean Cross; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On Mon, Aug 18, 2014 at 02:51:15PM +0800, Sean Cross wrote:

> That gives it almost the exact same kernel config as the SGTL5000.

> Is this the sort of thing you can apply on your end, or would you like
> me to resubmit a v12 with just this file?  I'm afraid I don't have a PPC
> toolchain to test with.

Please submit your fix using the normal submission process.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2014-08-17 22:30 Stephen Rothwell
@ 2014-08-18  6:51 ` Sean Cross
  2014-08-18 14:09   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Sean Cross @ 2014-08-18  6:51 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

On 08/18/14 06:30, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> sound/soc/fsl/imx-pcm-fiq.c:31:21: fatal error: asm/fiq.h: No such file or directory
>  #include <asm/fiq.h>
>                      ^
>
> Caused by commit 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine
> driver").  Presumably it will only build on arm?
>
> I reverted that commit for today.
The following patch should fix the problem:

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index c0ace69..13199b5 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -237,8 +237,6 @@ config SND_SOC_IMX_ES8328
     select SND_SOC_IMX_PCM_DMA
     select SND_SOC_IMX_AUDMUX
     select SND_SOC_FSL_SSI
-    select SND_SOC_FSL_UTILS
-    select SND_SOC_IMX_PCM_FIQ
     help
       Say Y if you want to add support for the ES8328 audio codec connected
       via SSI/I2S over either SPI or I2C.

That gives it almost the exact same kernel config as the SGTL5000.

Is this the sort of thing you can apply on your end, or would you like
me to resubmit a v12 with just this file?  I'm afraid I don't have a PPC
toolchain to test with.


Sean


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 880 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-08-17 22:30 Stephen Rothwell
  2014-08-18  6:51 ` Sean Cross
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2014-08-17 22:30 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Sean Cross

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc allyesconfig)
failed like this:

sound/soc/fsl/imx-pcm-fiq.c:31:21: fatal error: asm/fiq.h: No such file or directory
 #include <asm/fiq.h>
                     ^

Caused by commit 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine
driver").  Presumably it will only build on arm?

I reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-04-15  1:49 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2014-04-15  1:49 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Alexander Shiyan

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build
(x86_64_allmodconfig) failed like this:

sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe':
sound/soc/fsl/fsl_ssi.c:1471:2: error: implicit declaration of function 'of_find_node_by_path' [-Werror=implicit-function-declaration]
  sprop = of_get_property(of_find_node_by_path("/"), "compatible", NULL);
  ^

Probably caused by commit eba9e06f0ceb ("ASoC: fsl: Separation of the
main audio options and boards").

I have used the sound-asoc tree from next-20140414 for today.
-- 
Cheers,
Stephen Rothwell <sfr@canb.auug.org.au>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-04-15  1:47 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2014-04-15  1:47 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build
(x86_64_allmodconfig) failed like this:

sound/soc/codecs/wm8997.c:248:1: error: implicit declaration of function 'SOC_VALUE' [-Werror=implicit-function-declaration]
 SOC_VALUE("ISRC1 FSL", arizona_isrc_fsl[0]),
 ^

Caused by commit e13dd8ce39a8 ("ASoC: wm8997: Replace usage deprecated
MUX/ENUM macros").

I have used the version of the sound-asoc tree from next-20140414 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2014-03-19 10:17 ` Mark Brown
@ 2014-03-19 20:30   ` Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2014-03-19 20:30 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, linux-next, linux-kernel, Nicolin Chen,
	Jean-Francois Moine

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi Mark,

On Wed, 19 Mar 2014 10:17:01 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> Sorry, it's fixed already - your fetch must've raced with my fix last
> night.

No worries, that can happen since I fetch all the trees before I start
merging.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2014-03-19  1:10 Stephen Rothwell
@ 2014-03-19 10:17 ` Mark Brown
  2014-03-19 20:30   ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2014-03-19 10:17 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, linux-next, linux-kernel, Nicolin Chen,
	Jean-Francois Moine

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

On Wed, Mar 19, 2014 at 12:10:00PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Sorry, it's fixed already - your fetch must've raced with my fix last
night.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-03-19  1:10 Stephen Rothwell
  2014-03-19 10:17 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2014-03-19  1:10 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Nicolin Chen, Jean-Francois Moine

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/generic/simple-card.c: In function 'asoc_simple_card_parse_of':
sound/soc/generic/simple-card.c:188:47: error: 'struct simple_card_data' has no member named 'daifmt'
   ret = asoc_simple_card_sub_parse_of(np, priv->daifmt,
                                               ^
sound/soc/generic/simple-card.c:201:47: error: 'struct simple_card_data' has no member named 'daifmt'
   ret = asoc_simple_card_sub_parse_of(np, priv->daifmt,
                                               ^

Caused by commit 56556f333ae3 ("ASoC: simple-card: overwrite cpu_dai->fmt
with codec_dai->fmt"). daifmt was removed from struct simple_card_data in
commit c56c4d74c6f9 ("ASoC: simple-card: Simplify code").

I have used the sound-asoc tree from next-20140318 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2014-02-20  3:01 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2014-02-20  3:01 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "snd_pcm_hw_constraint_mask64" [sound/soc/codecs/snd-soc-adau1977.ko] undefined!

Caused by commit 603597c9375b ("ASoC: Add ADAU1977 CODEC driver").

I have used the sound-asoc tree from next-20140219 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2013-11-29  0:54 Stephen Rothwell
@ 2013-11-29 12:36 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2013-11-29 12:36 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Brian Austin

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

On Fri, Nov 29, 2013 at 11:54:07AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Fixed, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-11-29  0:54 Stephen Rothwell
  2013-11-29 12:36 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2013-11-29  0:54 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Brian Austin

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/cs42l52.c: In function 'cs42l52_i2c_probe':
sound/soc/codecs/cs42l52.c:1235:10: error: 'struct cs42l52_platform_data' has no member named 'chgfreq_divisor'
     pdata->chgfreq_divisor = val32;
          ^

Caused by commit 391fc59db876 ("ASoC: cs42l52: Add devicetree support for
CS42L52").

I have used the sound-asoc tree from next-20131128 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2013-07-16  3:18 Stephen Rothwell
@ 2013-07-16 11:52 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2013-07-16 11:52 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

On Tue, Jul 16, 2013 at 01:18:28PM +1000, Stephen Rothwell wrote:

> Caused by commit df7e4082f47d ("ASoC: tegra: Enable COMPILE_TEST
> builds").  If you are going to do that, please test via (at least) an
> x86_64 allmodconf build.  Including asm/mach-types.h is an architecture
> dependency.

I'm *very* surprised that the zero day tester didn't report this -
normally it's much faster at allmodconfigs than anything I have
available to me but it didn't report anything except the usual problem
with s390 not being converted over to genirq.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-07-16  3:18 Stephen Rothwell
  2013-07-16 11:52 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2013-07-16  3:18 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/tegra/tegra_alc5632.c:16:28: fatal error: asm/mach-types.h: No such file or directory
 #include <asm/mach-types.h>
                            ^

Caused by commit df7e4082f47d ("ASoC: tegra: Enable COMPILE_TEST
builds").  If you are going to do that, please test via (at least) an
x86_64 allmodconf build.  Including asm/mach-types.h is an architecture
dependency.

sound/soc/omap/omap-pcm.c: In function 'omap_pcm_preallocate_dma_buffer':
sound/soc/omap/omap-pcm.c:171:2: error: implicit declaration of function 'dma_alloc_writecombine' [-Werror=implicit-function-declaration]
  buf->area = dma_alloc_writecombine(pcm->card->dev, size,
  ^
sound/soc/omap/omap-pcm.c:171:12: warning: assignment makes pointer from integer without a cast [enabled by default]
  buf->area = dma_alloc_writecombine(pcm->card->dev, size,
            ^
sound/soc/omap/omap-pcm.c: In function 'omap_pcm_free_dma_buffers':
sound/soc/omap/omap-pcm.c:195:3: error: implicit declaration of function 'dma_free_writecombine' [-Werror=implicit-function-declaration]
   dma_free_writecombine(pcm->card->dev, buf->bytes,
   ^

Caused by commit 6109b2fca632 ("ASoC: omap: Enable COMPILE_TEST build for
DT platforms").  In this case, a missing include.

I have used the version of the sound-asoc tree from next-20130715 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-06-17  3:46 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2013-06-17  3:46 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Rajeev Kumar

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

make[4]: *** No rule to make target `sound/soc/spear/spear_evb.o', needed by `sound/soc/spear/built-in.o'.  Stop.

Caused by commit e58070ee4fdf ("ASoC: Add Kconfig and Makefile to support
SPEAr audio driver").

I have used the version of the sound-asoc -tree from next-20130607 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-03-21  2:13 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2013-03-21  2:13 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mfd/wm5102-tables.c: In function 'wm5102_readable_register':
drivers/mfd/wm5102-tables.c:1172:7: error: 'ARIZONA_SPK_CTRL_2' undeclared (first use in this function)
drivers/mfd/wm5102-tables.c:1172:7: note: each undeclared identifier is reported only once for each function it appears in
drivers/mfd/wm5102-tables.c:1173:7: error: 'ARIZONA_SPK_CTRL_3' undeclared (first use in this function)

Caused by commit 7b00b5ecd312 ("mfd: wm5102: Add additional speaker
control registers").  Missing change to an include file?

sound/soc/codecs/arizona.c: In function 'arizona_init_spk':
sound/soc/codecs/arizona.c:205:28: error: 'arizona' undeclared (first use in this function)
sound/soc/codecs/arizona.c:205:28: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit 6f384ccffdf0 ("ASoC: arizona: Log thermal events").

I have used the sound-asoc tree from next-20130320 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-02-08  0:57 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2013-02-08  0:57 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-core.c: In function 'snd_soc_dai_digital_mute':
sound/soc/soc-core.c:3555:22: error: 'const struct snd_soc_dai_ops' has no member named 'mute_stream'
sound/soc/soc-core.c:3556:26: error: 'const struct snd_soc_dai_ops' has no member named 'mute_stream'

Caused by commit df6dc7a26e7d ("ASoC: core: Allow digital mute for
capture").

I have used the sound-asoc tree from next-20130207 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-02-05  1:46 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2013-02-05  1:46 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regmap_async_complete" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!

I have used the version of the sound-asoc tree from next-20130204 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-01-23  2:17 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2013-01-23  2:17 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/jz4740.c: In function 'jz4740_codec_probe':
sound/soc/codecs/jz4740.c:364:2: error: implicit declaration of function 'devm_ioremap_resource' [-Werror=implicit-function-declaration]
sound/soc/codecs/jz4740.c:364:7: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit bc96ea9b07ad ("ASoC: Convert to devm_ioremap_resource()").\
I think that devm_ioremap_resource() must be being introduced via a 
different tree, since there is no mention of it in linux-next (besides
what is done in this commit).  Please build test.

I have used the sound-asoc tree from next-20130122 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2013-01-14  1:04 Stephen Rothwell
@ 2013-01-14  4:55 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2013-01-14  4:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, linux-next, linux-kernel, Kuninori Morimoto, Greg KH

On Mon, Jan 14, 2013 at 12:04:00PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build
> (x86_64allmodconfig) failed like this:

Applied, thanks.

> As an aside, should ak4642_of_match be marked "const"?

Probably.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2013-01-14  1:04 Stephen Rothwell
  2013-01-14  4:55 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2013-01-14  1:04 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Kuninori Morimoto, Greg KH

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build
(x86_64allmodconfig) failed like this:

sound/soc/codecs/ak4642.c:550:46: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__devinitconst'
sound/soc/codecs/ak4642.c:556:1: error: '__mod_of_device_table' aliased to undefined symbol 'ak4642_of_match'
sound/soc/codecs/ak4642.c:556:1: error: '__mod_of_device_table' aliased to external symbol 'ak4642_of_match'

Caused by commit bbf1453e28e4 ("ASoC: ak4642: add Device Tree support")
interacting with commit 54b956b90360 ("Remove __dev* markings from
init.h") from the driver-core.current tree.

As an aside, should ak4642_of_match be marked "const"?

I have added the following merge fix patch for today (which could be
applied to the sound-asoc tree directly - please):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 14 Jan 2013 11:59:50 +1100
Subject: [PATCH] ASoC: ak4642: remove __devinitconst annotation

CONFIG_HOTPLUG is always true now and the __dev* macros have been removed.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/ak4642.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
index c78794d..2d03787 100644
--- a/sound/soc/codecs/ak4642.c
+++ b/sound/soc/codecs/ak4642.c
@@ -547,7 +547,7 @@ static int ak4642_i2c_remove(struct i2c_client *client)
 	return 0;
 }
 
-static struct of_device_id ak4642_of_match[] __devinitconst = {
+static struct of_device_id ak4642_of_match[] = {
 	{ .compatible = "asahi-kasei,ak4642",	.data = &soc_codec_dev_ak4642},
 	{ .compatible = "asahi-kasei,ak4643",	.data = &soc_codec_dev_ak4642},
 	{ .compatible = "asahi-kasei,ak4648",	.data = &soc_codec_dev_ak4648},
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-10-29 20:46   ` Stephen Rothwell
@ 2012-10-30 12:11     ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-10-30 12:11 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Tue, Oct 30, 2012 at 07:46:31AM +1100, Stephen Rothwell wrote:

> Then you need to have a different branch being tested by Fenguang and
> friends to what you have in linux-next.   The stuff that you put into
> linux-next has to be at least build tested, so you should delay pushing
> it up to your linux-next included branch until after that is done.

Which is what I was doing, as I said I had thought I'd pushed up
something different to what was actually there.

> This case was particularly irritating because you were the developer of
> the patch that was broken which indicates that you are not even testing
> your own development work before pushing it out for others to work on top
> of.

I don't treat my own patches any differently to any other patches I push
out; in this case the issue was a mistaken fix for a merge issue cherry
picking the code out of a working branch into the public branch.  

With a huge chunk of new device enablement like this it's just not
possible to do anything except build testing on the branches in -next,
there'll be at least some cross tree issues getting in the way of
actually running anything.  At that point all the issues with time spent
doing build tests apply; as I keep saying I will tend to do some if I
have time but it can fall by the wayside and they're not the tests
anyone else does.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-10-29 18:15 ` Mark Brown
@ 2012-10-29 20:46   ` Stephen Rothwell
  2012-10-30 12:11     ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-10-29 20:46 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

Hi Mark,

On Mon, 29 Oct 2012 18:15:34 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> Honestly when I'm travelling with the automated build testing Fenguang
> and friends are doing it's actually faster to just push things up rather
> than doing testing of branches like this locally, their build farm
> usually kicks in very close to the time it takes me to do a single fresh
> build.

Then you need to have a different branch being tested by Fenguang and
friends to what you have in linux-next.   The stuff that you put into
linux-next has to be at least build tested, so you should delay pushing
it up to your linux-next included branch until after that is done.

This case was particularly irritating because you were the developer of
the patch that was broken which indicates that you are not even testing
your own development work before pushing it out for others to work on top
of.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-10-29  0:48 Stephen Rothwell
@ 2012-10-29 18:15 ` Mark Brown
  2012-10-29 20:46   ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2012-10-29 18:15 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

On Mon, Oct 29, 2012 at 11:48:48AM +1100, Stephen Rothwell wrote:

> Caused by commit 2882fcb3cfe6 ("ASoC: adsp: Add ADSP base support").
> Please build test this stuff - there is a typo in the Makefile.  :-(

Actually already fixed, just forgot to push up.  

Honestly when I'm travelling with the automated build testing Fenguang
and friends are doing it's actually faster to just push things up rather
than doing testing of branches like this locally, their build farm
usually kicks in very close to the time it takes me to do a single fresh
build.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-10-29  0:48 Stephen Rothwell
  2012-10-29 18:15 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-10-29  0:48 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

make[4]: *** No rule to make target `sound/soc/codecs/snd-soc-wm-adsp.c', needed by `sound/soc/codecs/snd-soc-wm-adsp.o'.  Stop.

Caused by commit 2882fcb3cfe6 ("ASoC: adsp: Add ADSP base support").
Please build test this stuff - there is a typo in the Makefile.  :-(

I have used the sound-asoc tree from next-20121026 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-29  3:38 Stephen Rothwell
@ 2012-06-29  7:09 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-06-29  7:09 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, linux-next, linux-kernel, Vipin Kumar, Rajeev Kumar

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

On Fri, Jun 29, 2012 at 01:38:11PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Already fixed before you sent this.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-29  3:38 Stephen Rothwell
  2012-06-29  7:09 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-29  3:38 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Vipin Kumar, Rajeev Kumar

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/spdif_receiver.o: In function `init_module':
spdif_receiver.c:(.init.text+0x0): multiple definition of `init_module'
sound/soc/codecs/spdif_transciever.o:spdif_transciever.c:(.init.text+0x0): first defined here
sound/soc/codecs/spdif_receiver.o: In function `cleanup_module':
spdif_receiver.c:(.exit.text+0x0): multiple definition of `cleanup_module'
sound/soc/codecs/spdif_transciever.o:spdif_transciever.c:(.exit.text+0x0): first defined here

Caused by commit cdf605255c2b ("ASoC: spdif_receiver: Add support for
spdif in Audio Codec").

I have used the sound-asoc tree from next-20120628 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-25  6:09 ` Rajeev kumar
  2012-06-25  8:06   ` viresh kumar
@ 2012-06-25  9:03   ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-06-25  9:03 UTC (permalink / raw)
  To: Rajeev kumar; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Mon, Jun 25, 2012 at 11:39:30AM +0530, Rajeev kumar wrote:

> 3. We can pick the patches circulated by Viresh Kumar where we don't
> have HAVE_CLK defined for x86_64, then the inline routines like
> following should come into play:

This is what *should* be happening, in conjunction with architectures
doing the trivial work required to turn the clock API on now that there
is a generic clock API, but both of these things seem to be going
nowhere.  I've applied a bodge until someone decides it's worth applying
the stubs.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-25  6:09 ` Rajeev kumar
@ 2012-06-25  8:06   ` viresh kumar
  2012-06-25  9:03   ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: viresh kumar @ 2012-06-25  8:06 UTC (permalink / raw)
  To: Rajeev kumar, Mark Brown
  Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

On 25/06/12 07:09, Rajeev kumar wrote:
> 1. Protecting clk_get/clk_put* calls under macro 'CONFIG_HAVE_CLK' in
> the driver.

Not at all now.

> 2. Adding a check in Kconfig for HAVE_CLK.
> (But that will limit the compilation of this driver for only platforms
> which are ARM based/or similar).

Not actually required

> 3. We can pick the patches circulated by Viresh Kumar where we don't
> have HAVE_CLK defined for x86_64, then the inline routines like
> following should come into play:

That's the best. But probably Mark need to pull in AKPM's tree first into
sound-asoc tree. Mark?

--
Viresh

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-25  4:11 Stephen Rothwell
@ 2012-06-25  6:09 ` Rajeev kumar
  2012-06-25  8:06   ` viresh kumar
  2012-06-25  9:03   ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Rajeev kumar @ 2012-06-25  6:09 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

Hi Stephen,

On 6/25/2012 9:41 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "clk_disable" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_get" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_enable" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_put" [sound/soc/dwc/designware_i2s.ko] undefined!

I have checked this on ARM platform where these definitions are 
available (clk_get/clk_put* variants are usually used by ARM platforms).

To ensure compilation does not fail on x86_64 we can do either of three 
things:

1. Protecting clk_get/clk_put* calls under macro 'CONFIG_HAVE_CLK' in 
the driver.

2. Adding a check in Kconfig for HAVE_CLK.
(But that will limit the compilation of this driver for only platforms 
which are ARM based/or similar).

3. We can pick the patches circulated by Viresh Kumar where we don't 
have HAVE_CLK defined for x86_64, then the inline routines like 
following should come into play:

static inline unsigned long clk_get_rate(struct clk *clk)
{
         return 0;
}

See the patches for the same here:
http://lkml.org/lkml/2012/4/24/154

Please let me know your opinion.

Best Regards
Rajeev

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-25  4:11 Stephen Rothwell
  2012-06-25  6:09 ` Rajeev kumar
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-25  4:11 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Rajeev Kumar

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "clk_disable" [sound/soc/dwc/designware_i2s.ko] undefined!
ERROR: "clk_get" [sound/soc/dwc/designware_i2s.ko] undefined!
ERROR: "clk_enable" [sound/soc/dwc/designware_i2s.ko] undefined!
ERROR: "clk_put" [sound/soc/dwc/designware_i2s.ko] undefined!

Caused by commit 3a9cf8efd7b6 ("ASoC: Add support for synopsys i2s
controller as per ASoC framework").  According to the Kconfig in the
patch, this driver depends on nothing ...

I have used the sound-asoc tree from next-20120622 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-13  2:52 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-13  2:52 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Ola Lilja

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

FATAL: modpost: GPL-incompatible module snd-soc-ab8500-codec.ko uses GPL-only symbol 'snd_soc_put_xr_sx'

Caused by commit 679d7abdc754 ("ASoC: codecs: Add AB8500 codec-driver").
I think the license string is spelt "GPL" or "GPL v2" not "GPLv2".

I have used the sound-asoc tree from next-20120608 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-12  1:59 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-12  1:59 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Ola Lilja

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/ab8500-codec.c:35:43: fatal error: linux/mfd/abx500/ab8500-codec.h: No such file or directory

Caused by commit 679d7abdc754 ("ASoC: codecs: Add AB8500 codec-driver").

I have used the sound-asoc tree from next-20120608 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-05  9:43   ` Mark Brown
@ 2012-06-05 10:05     ` MR Swami Reddy
  0 siblings, 0 replies; 193+ messages in thread
From: MR Swami Reddy @ 2012-06-05 10:05 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Girdwood, Liam, linux-next, Deshpande A, Vishwas

On Tuesday 05 June 2012 03:13 PM, Mark Brown wrote:
> On Tue, Jun 05, 2012 at 12:25:07PM +0530, MR Swami Reddy wrote:
>
>> There is a typo in the sound/soc/codecs/Makefile for isabelle.o
> I've made this change and squashed it down.

Thank you.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-05  6:55 ` MR Swami Reddy
@ 2012-06-05  9:43   ` Mark Brown
  2012-06-05 10:05     ` MR Swami Reddy
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2012-06-05  9:43 UTC (permalink / raw)
  To: MR Swami Reddy
  Cc: Stephen Rothwell, Girdwood, Liam, linux-next, Deshpande A, Vishwas

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

On Tue, Jun 05, 2012 at 12:25:07PM +0530, MR Swami Reddy wrote:

> There is a typo in the sound/soc/codecs/Makefile for isabelle.o

I've made this change and squashed it down.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-05  1:25 Stephen Rothwell
@ 2012-06-05  6:55 ` MR Swami Reddy
  2012-06-05  9:43   ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: MR Swami Reddy @ 2012-06-05  6:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Girdwood, Liam, linux-next, Deshpande A, Vishwas

On Tuesday 05 June 2012 06:55 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> make[4]: *** No rule to make target `sound/soc/codecs/snd-soc-isabelle.c', needed by `sound/soc/codecs/snd-soc-isabelle.o'.  Stop.
>
> Caused by commit 4567db1722aa ("ASoC: Support TI Isabelle Audio
> driver").  Was this ever built?
>
> I have used the sound-asoc tree from next-20120601 again for today.
Hi Stephen,

There is a typo in the sound/soc/codecs/Makefile for isabelle.o

I will be sending the below patch is to fix the build issue.
--
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 196e939..fdc1ff6 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -17,7 +17,7 @@ snd-soc-cx20442-objs := cx20442.o
 snd-soc-da7210-objs := da7210.o
 snd-soc-dfbmcs320-objs := dfbmcs320.o
 snd-soc-dmic-objs := dmic.o
-snd-soc-isabelle := isabelle.o
+snd-soc-isabelle-objs := isabelle.o
 snd-soc-l3-objs := l3.o
 snd-soc-lm49453-objs := lm49453.o
 snd-soc-max98088-objs := max98088.o
---


Thanks
Swami

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-05  1:25 Stephen Rothwell
  2012-06-05  6:55 ` MR Swami Reddy
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-05  1:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, M R Swami Reddy, Vishwas A Deshpande

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

make[4]: *** No rule to make target `sound/soc/codecs/snd-soc-isabelle.c', needed by `sound/soc/codecs/snd-soc-isabelle.o'.  Stop.

Caused by commit 4567db1722aa ("ASoC: Support TI Isabelle Audio
driver").  Was this ever built?

I have used the sound-asoc tree from next-20120601 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-06-04  3:25 Stephen Rothwell
@ 2012-06-04  7:19 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-06-04  7:19 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Ola Lilja

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On Mon, Jun 04, 2012 at 01:25:00PM +1000, Stephen Rothwell wrote:

> ERROR: "clk_enable" [sound/soc/snd-soc-core.ko] undefined!
> ERROR: "clk_disable" [sound/soc/snd-soc-core.ko] undefined!
> ERROR: "clk_get" [sound/soc/snd-soc-core.ko] undefined!

Oh, fail - it looks like the stubs for the clock API didn't actually
manage to get merged.  Should be fixed, anyway.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-06-04  3:25 Stephen Rothwell
  2012-06-04  7:19 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-06-04  3:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Ola Lilja

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "clk_enable" [sound/soc/snd-soc-core.ko] undefined!
ERROR: "clk_disable" [sound/soc/snd-soc-core.ko] undefined!
ERROR: "clk_get" [sound/soc/snd-soc-core.ko] undefined!

Caused by commit d7e7eb91551a ("ASoC: core: Add widget
SND_SOC_DAPM_CLOCK_SUPPLY").  This build does not have CONFIG_COMMON_CLK
set.  Probably missing select or dependency.

I have used the sound-asoc tree from next-20120601 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au


[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-05-10  9:09   ` Mark Brown
@ 2012-05-10 12:12     ` Linus Walleij
  0 siblings, 0 replies; 193+ messages in thread
From: Linus Walleij @ 2012-05-10 12:12 UTC (permalink / raw)
  To: Mark Brown
  Cc: Stephen Rothwell, Ola Lilja, Liam Girdwood, linux-next, linux-kernel

On Thu, May 10, 2012 at 11:09 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, May 10, 2012 at 10:30:50AM +0200, Linus Walleij wrote:
>
>>  menuconfig SND_SOC_UX500
>>         tristate "SoC Audio support for Ux500 platform"
>>         depends on SND_SOC
>> +       depends on MFD_DB8500_PRCMU
>>         help
>>                 Say Y if you want to enable ASoC-support for
>>                 any of the Ux500 platforms (e.g. U8500).
>
> I applied this (without your signoff as you didn't supply one so it'll
> show up as my patch,

Sorry, Acked-by :-)

>> But it seems it has a wider dependency on some MOP500 board
>> stuff being merged first, which is more of a problem I think, part
>> of that is pending in the Ux500 tree.
>
> If this has a dependency on a particular board the driver is badly
> broken, this is the driver for the SoC I2S controller so it should work
> with any board.
>
> That said in terms of applying the change the arch/arm stuff shouldn't
> be an issue - it was just registering devices and clocks.  The driver
> won't load until the two trees are merged but that's not an issue, it's
> not going to run anyway if we delay applying it.

Yeah let's see if it works, if it breaks again we can just pull it out
and defer it.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-05-10  8:35   ` Ola Lilja
@ 2012-05-10  9:11     ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-05-10  9:11 UTC (permalink / raw)
  To: Ola Lilja
  Cc: Linus Walleij, Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On Thu, May 10, 2012 at 10:35:13AM +0200, Ola Lilja wrote:

> True! I think we should put it in the "config
> SND_SOC_UX500_PLAT_MSP_I2S", though.

That won't work, the machine drivers should be selecting the I2S
controller driver so the dependency on it will get ignored, and
presumably any ux500 system is going to have this dependency.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-05-10  8:30 ` Linus Walleij
  2012-05-10  8:35   ` Ola Lilja
@ 2012-05-10  9:09   ` Mark Brown
  2012-05-10 12:12     ` Linus Walleij
  1 sibling, 1 reply; 193+ messages in thread
From: Mark Brown @ 2012-05-10  9:09 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Stephen Rothwell, Ola Lilja, Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Thu, May 10, 2012 at 10:30:50AM +0200, Linus Walleij wrote:

>  menuconfig SND_SOC_UX500
>         tristate "SoC Audio support for Ux500 platform"
>         depends on SND_SOC
> +       depends on MFD_DB8500_PRCMU
>         help
>                 Say Y if you want to enable ASoC-support for
>                 any of the Ux500 platforms (e.g. U8500).

I applied this (without your signoff as you didn't supply one so it'll
show up as my patch, I'm not sure if I'll have time to publish the
change later on today and want to get it into -next tomorrow).

> But it seems it has a wider dependency on some MOP500 board
> stuff being merged first, which is more of a problem I think, part
> of that is pending in the Ux500 tree.

If this has a dependency on a particular board the driver is badly
broken, this is the driver for the SoC I2S controller so it should work
with any board.

That said in terms of applying the change the arch/arm stuff shouldn't
be an issue - it was just registering devices and clocks.  The driver
won't load until the two trees are merged but that's not an issue, it's
not going to run anyway if we delay applying it.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-05-10  8:30 ` Linus Walleij
@ 2012-05-10  8:35   ` Ola Lilja
  2012-05-10  9:11     ` Mark Brown
  2012-05-10  9:09   ` Mark Brown
  1 sibling, 1 reply; 193+ messages in thread
From: Ola Lilja @ 2012-05-10  8:35 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Stephen Rothwell, Mark Brown, Liam Girdwood, linux-next, linux-kernel

On 05/10/2012 10:30 AM, Linus Walleij wrote:

> On Thu, May 10, 2012 at 6:33 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>> After merging the sound-asoc tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from sound/soc/ux500/ux500_msp_dai.c:21:0:
>> include/linux/mfd/dbx500-prcmu.h:614:19: error: redefinition of 'prcmu_abb_read'
>> include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of 'prcmu_abb_read' was here
>> include/linux/mfd/dbx500-prcmu.h:619:19: error: redefinition of 'prcmu_abb_write'
>> include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of 'prcmu_abb_write' was here
>> include/linux/mfd/dbx500-prcmu.h:630:19: error: redefinition of 'prcmu_config_clkout'
>> include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of 'prcmu_config_clkout' was here
>> include/linux/mfd/dbx500-prcmu.h:692:20: error: redefinition of 'prcmu_ac_wake_req'
>> include/linux/mfd/db8500-prcmu.h:683:20: note: previous definition of 'prcmu_ac_wake_req' was here
>> include/linux/mfd/dbx500-prcmu.h:694:20: error: redefinition of 'prcmu_ac_sleep_req'
>> include/linux/mfd/db8500-prcmu.h:685:20: note: previous definition of 'prcmu_ac_sleep_req' was here
>> sound/soc/ux500/ux500_msp_dai.c:23:27: fatal error: mach/hardware.h: No such file or directory
>> sound/soc/ux500/ux500_msp_i2s.c:21:27: fatal error: mach/hardware.h: No such file or directory
>>
>> Possibly caused by commit 3592b7f69a54 ("ASoC: Ux500: Add MSP I2S-driver").
>>
>> I have used the version of the sound-asoc tree from next-20120508 for today.
> 
> The PRCMU driver is only available on the UX500 platforms so building
> on x86_64 does not make sense.
> 
> Ola/Mark: a simple patch like this should solve the issue I think?


True! I think we should put it in the "config SND_SOC_UX500_PLAT_MSP_I2S", though.

> 
> diff --git a/sound/soc/ux500/Kconfig b/sound/soc/ux500/Kconfig
> index 9b0ae4e..f454f06 100644
> --- a/sound/soc/ux500/Kconfig
> +++ b/sound/soc/ux500/Kconfig
> @@ -4,6 +4,7 @@
>  menuconfig SND_SOC_UX500
>         tristate "SoC Audio support for Ux500 platform"
>         depends on SND_SOC
> +       depends on MFD_DB8500_PRCMU
>         help
>                 Say Y if you want to enable ASoC-support for
>                 any of the Ux500 platforms (e.g. U8500).
> 
> 
> But it seems it has a wider dependency on some MOP500 board
> stuff being merged first, which is more of a problem I think, part
> of that is pending in the Ux500 tree.
> 
> Yours,
> Linus Walleij

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-05-10  4:33 Stephen Rothwell
@ 2012-05-10  8:30 ` Linus Walleij
  2012-05-10  8:35   ` Ola Lilja
  2012-05-10  9:09   ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Linus Walleij @ 2012-05-10  8:30 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Ola Lilja
  Cc: Liam Girdwood, linux-next, linux-kernel

On Thu, May 10, 2012 at 6:33 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from sound/soc/ux500/ux500_msp_dai.c:21:0:
> include/linux/mfd/dbx500-prcmu.h:614:19: error: redefinition of 'prcmu_abb_read'
> include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of 'prcmu_abb_read' was here
> include/linux/mfd/dbx500-prcmu.h:619:19: error: redefinition of 'prcmu_abb_write'
> include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of 'prcmu_abb_write' was here
> include/linux/mfd/dbx500-prcmu.h:630:19: error: redefinition of 'prcmu_config_clkout'
> include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of 'prcmu_config_clkout' was here
> include/linux/mfd/dbx500-prcmu.h:692:20: error: redefinition of 'prcmu_ac_wake_req'
> include/linux/mfd/db8500-prcmu.h:683:20: note: previous definition of 'prcmu_ac_wake_req' was here
> include/linux/mfd/dbx500-prcmu.h:694:20: error: redefinition of 'prcmu_ac_sleep_req'
> include/linux/mfd/db8500-prcmu.h:685:20: note: previous definition of 'prcmu_ac_sleep_req' was here
> sound/soc/ux500/ux500_msp_dai.c:23:27: fatal error: mach/hardware.h: No such file or directory
> sound/soc/ux500/ux500_msp_i2s.c:21:27: fatal error: mach/hardware.h: No such file or directory
>
> Possibly caused by commit 3592b7f69a54 ("ASoC: Ux500: Add MSP I2S-driver").
>
> I have used the version of the sound-asoc tree from next-20120508 for today.

The PRCMU driver is only available on the UX500 platforms so building
on x86_64 does not make sense.

Ola/Mark: a simple patch like this should solve the issue I think?

diff --git a/sound/soc/ux500/Kconfig b/sound/soc/ux500/Kconfig
index 9b0ae4e..f454f06 100644
--- a/sound/soc/ux500/Kconfig
+++ b/sound/soc/ux500/Kconfig
@@ -4,6 +4,7 @@
 menuconfig SND_SOC_UX500
        tristate "SoC Audio support for Ux500 platform"
        depends on SND_SOC
+       depends on MFD_DB8500_PRCMU
        help
                Say Y if you want to enable ASoC-support for
                any of the Ux500 platforms (e.g. U8500).


But it seems it has a wider dependency on some MOP500 board
stuff being merged first, which is more of a problem I think, part
of that is pending in the Ux500 tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-05-10  4:33 Stephen Rothwell
  2012-05-10  8:30 ` Linus Walleij
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-05-10  4:33 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Ola Lilja

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from sound/soc/ux500/ux500_msp_dai.c:21:0:
include/linux/mfd/dbx500-prcmu.h:614:19: error: redefinition of 'prcmu_abb_read'
include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of 'prcmu_abb_read' was here
include/linux/mfd/dbx500-prcmu.h:619:19: error: redefinition of 'prcmu_abb_write'
include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of 'prcmu_abb_write' was here
include/linux/mfd/dbx500-prcmu.h:630:19: error: redefinition of 'prcmu_config_clkout'
include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of 'prcmu_config_clkout' was here
include/linux/mfd/dbx500-prcmu.h:692:20: error: redefinition of 'prcmu_ac_wake_req'
include/linux/mfd/db8500-prcmu.h:683:20: note: previous definition of 'prcmu_ac_wake_req' was here
include/linux/mfd/dbx500-prcmu.h:694:20: error: redefinition of 'prcmu_ac_sleep_req'
include/linux/mfd/db8500-prcmu.h:685:20: note: previous definition of 'prcmu_ac_sleep_req' was here
sound/soc/ux500/ux500_msp_dai.c:23:27: fatal error: mach/hardware.h: No such file or directory
sound/soc/ux500/ux500_msp_i2s.c:21:27: fatal error: mach/hardware.h: No such file or directory

Possibly caused by commit 3592b7f69a54 ("ASoC: Ux500: Add MSP I2S-driver").

I have used the version of the sound-asoc tree from next-20120508 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-04-03  1:26 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-04-03  1:26 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regcache_sync_region" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!

Caused by commit 26b427a701f8 ("ASoC: wm8962: Implement DSP2
configuration initialisation").  regcache_sync_region() is not exported
to modules.

I have used the sound-asoc tree from next-20120330 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-04-02  1:34 Stephen Rothwell
@ 2012-04-02 15:04 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-04-02 15:04 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Rhyland Klein

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Mon, Apr 02, 2012 at 11:34:24AM +1000, Stephen Rothwell wrote:

> Caused by commit 9dd90c5db040 ("ASoC: max98095: add jack detection").
> At least build test, please.

Should be fixed now.  My build tests are currently broken in mainline
by some perf issues (which I reported with a patch).  I should really
update to sidestep these issues.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-04-02  1:34 Stephen Rothwell
  2012-04-02 15:04 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-04-02  1:34 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Rhyland Klein

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64_allmodconfig)
failed like this:

sound/soc/codecs/max98095.c: In function 'max98095_jack_detect_enable':
sound/soc/codecs/max98095.c:2229:14: error: 'struct max98095_priv' has no member named 'jack_detect_delay'
sound/soc/codecs/max98095.c:2230:18: error: 'struct max98095_priv' has no member named 'jack_detect_delay'

Caused by commit 9dd90c5db040 ("ASoC: max98095: add jack detection").
At least build test, please.

I have used the sound-asoc tree from next-20120330 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-02-06 16:50 ` Liam Girdwood
  2012-02-06 16:53   ` Mark Brown
@ 2012-02-06 22:02   ` Stephen Rothwell
  1 sibling, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-02-06 22:02 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: Mark Brown, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Hi Liam,

On Mon, 06 Feb 2012 16:50:58 +0000 Liam Girdwood <lrg@ti.com> wrote:
>
> Btw, I have a new email address at TI now, any chance you could update
> your scripts. Thanks !

Done.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-02-06 16:50 ` Liam Girdwood
@ 2012-02-06 16:53   ` Mark Brown
  2012-02-06 22:02   ` Stephen Rothwell
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2012-02-06 16:53 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: Stephen Rothwell, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

On Mon, Feb 06, 2012 at 04:50:58PM +0000, Liam Girdwood wrote:
> 
> From e3e06e913cb74a57b603a2e7ac0f08c995af4969 Mon Sep 17 00:00:00 2001
> From: Liam Girdwood <lrg@ti.com>
> Date: Mon, 6 Feb 2012 16:36:04 +0000
> Subject: [PATCH] ASoC: max9768 - Fix build and use new add control API.
> 
> Fix build breakage by using the correct API call to add kcontrols.

Applied, thnaks, but I had to hand edit the changelog since the patch
was at the bottom of another mail.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-02-06  1:25 Stephen Rothwell
@ 2012-02-06 16:50 ` Liam Girdwood
  2012-02-06 16:53   ` Mark Brown
  2012-02-06 22:02   ` Stephen Rothwell
  0 siblings, 2 replies; 193+ messages in thread
From: Liam Girdwood @ 2012-02-06 16:50 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, linux-next, linux-kernel

Hi Stephen,

Btw, I have a new email address at TI now, any chance you could update
your scripts. Thanks !

On Mon, 2012-02-06 at 12:25 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/max9768.c: In function 'max9768_probe':
> sound/soc/codecs/max9768.c:138:3: error: implicit declaration of function 'snd_soc_add_controls' [-Werror=implicit-function-declaration]
> 
> Caused by commit 022658beab55 ("ASoC: core: Add support for DAI and
> machine kcontrols").
> 
> I have used the sound-asoc tree from next-20120203 for today.

Sorry, this should fix it.

>From e3e06e913cb74a57b603a2e7ac0f08c995af4969 Mon Sep 17 00:00:00 2001
From: Liam Girdwood <lrg@ti.com>
Date: Mon, 6 Feb 2012 16:36:04 +0000
Subject: [PATCH] ASoC: max9768 - Fix build and use new add control API.

Fix build breakage by using the correct API call to add kcontrols.

Signed-off-by: Liam Girdwood <lrg@ti.com>
---
 sound/soc/codecs/max9768.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/max9768.c b/sound/soc/codecs/max9768.c
index 79e9901..17b3ec2 100644
--- a/sound/soc/codecs/max9768.c
+++ b/sound/soc/codecs/max9768.c
@@ -135,7 +135,7 @@ static int max9768_probe(struct snd_soc_codec *codec)
 	}
 
 	if (gpio_is_valid(max9768->mute_gpio)) {
-		ret = snd_soc_add_controls(codec, max9768_mute,
+		ret = snd_soc_add_codec_controls(codec, max9768_mute,
 				ARRAY_SIZE(max9768_mute));
 		if (ret)
 			return ret;
-- 
1.7.5.4

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-02-06  1:25 Stephen Rothwell
  2012-02-06 16:50 ` Liam Girdwood
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2012-02-06  1:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/max9768.c: In function 'max9768_probe':
sound/soc/codecs/max9768.c:138:3: error: implicit declaration of function 'snd_soc_add_controls' [-Werror=implicit-function-declaration]

Caused by commit 022658beab55 ("ASoC: core: Add support for DAI and
machine kcontrols").

I have used the sound-asoc tree from next-20120203 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-01-23 10:47 ` Mark Brown
@ 2012-01-23 13:10   ` Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-01-23 13:10 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, linux-kernel, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

Hi Mark,

On Mon, 23 Jan 2012 10:47:22 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Mon, Jan 23, 2012 at 12:14:22PM +1100, Stephen Rothwell wrote:
> 
> > Caused by commit 899896379670 ("ASoC: sgtl5000: Convert to table based
> > DAPM and control init").  Please at least build this stuff :-(
> 
> Mainline doesn't build (and wouldn't usefully run) for any of my
> interesting configs right now which does tend to push testing of -next
> down the priority list.  Hopefully the fixes will make it into mainline
> at some point soon.

The above remark was aimed past you at the developer involved (who has
already responded).  People should not be feeding you untested patches.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-01-23  1:14 Stephen Rothwell
  2012-01-23  2:25 ` Fabio Estevam
@ 2012-01-23 10:47 ` Mark Brown
  2012-01-23 13:10   ` Stephen Rothwell
  1 sibling, 1 reply; 193+ messages in thread
From: Mark Brown @ 2012-01-23 10:47 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Fabio Estevam

On Mon, Jan 23, 2012 at 12:14:22PM +1100, Stephen Rothwell wrote:

> Caused by commit 899896379670 ("ASoC: sgtl5000: Convert to table based
> DAPM and control init").  Please at least build this stuff :-(

Mainline doesn't build (and wouldn't usefully run) for any of my
interesting configs right now which does tend to push testing of -next
down the priority list.  Hopefully the fixes will make it into mainline
at some point soon.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2012-01-23  1:14 Stephen Rothwell
@ 2012-01-23  2:25 ` Fabio Estevam
  2012-01-23 10:47 ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Fabio Estevam @ 2012-01-23  2:25 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel

On 1/22/2012 11:14 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/sgtl5000.c:1398:18: error: 'sgtl500_dapm_widgets' undeclared here (not in a function)
> sound/soc/codecs/sgtl5000.c:1399:22: error: negative width in bit-field '<anonymous>'
> sound/soc/codecs/sgtl5000.c:1400:17: error: 'sgtl500_dapm_routes' undeclared here (not in a function)
> sound/soc/codecs/sgtl5000.c:1401:21: error: negative width in bit-field '<anonymous>'

My apologies. I have just sent the corrected patch to the alsa-devel list.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2012-01-23  1:14 Stephen Rothwell
  2012-01-23  2:25 ` Fabio Estevam
  2012-01-23 10:47 ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Stephen Rothwell @ 2012-01-23  1:14 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/sgtl5000.c:1398:18: error: 'sgtl500_dapm_widgets' undeclared here (not in a function)
sound/soc/codecs/sgtl5000.c:1399:22: error: negative width in bit-field '<anonymous>'
sound/soc/codecs/sgtl5000.c:1400:17: error: 'sgtl500_dapm_routes' undeclared here (not in a function)
sound/soc/codecs/sgtl5000.c:1401:21: error: negative width in bit-field '<anonymous>'

Caused by commit 899896379670 ("ASoC: sgtl5000: Convert to table based
DAPM and control init").  Please at least build this stuff :-(

I have used the sound-asoc tree from next-20120120 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-12-15  3:38 Stephen Rothwell
@ 2011-12-15  6:10 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2011-12-15  6:10 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Thu, Dec 15, 2011 at 02:38:32PM +1100, Stephen Rothwell wrote:

> Caused by commit f6a9336879ca ("ASoC: Convert wm8993 to devm_kzalloc
> ()").  I really should not be seeing this sort of build problem ...

So, the big problem with this stuff is that I can't usefully do much
with my for-next tree directly except for build test it and it's
difficult to usefully do anything with the resulting binaries especially
as the configurations which usually turn things up are generally very
slow to build.  This means I tend to mostly test on my work tree which
does contain some other code (often code which is required in order to
do an actual test) with substantially different configurations and pure
for-next tests tend to drop off the end of the day.  Doing them in
parallel tends not to work so well due to the I/O scheduler issues and
the impact on disk cache.

In this case the fix for the typo got squashed into a change that isn't
published yet by mistake.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-12-15  3:38 Stephen Rothwell
  2011-12-15  6:10 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2011-12-15  3:38 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/wm8993.c: In function 'wm8993_i2c_probe':
sound/soc/codecs/wm8993.c:1594:29: error: 'dev' undeclared (first use in this function)

Caused by commit f6a9336879ca ("ASoC: Convert wm8993 to devm_kzalloc
()").  I really should not be seeing this sort of build problem ...

I have used the sound-asoc tree from next-20111214 for today,

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-12-13  3:58 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-12-13  3:58 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/base/regmap/regmap.c: In function 'regmap_reinit_cache':
drivers/base/regmap/regmap.c:259:2: error: too many arguments to function 'regcache_init'
drivers/base/regmap/internal.h:109:5: note: declared here

Caused by commit bf315173359b ("regmap: Allow drivers to reinitialise the
register cache at runtime").

I have used the sound-asoc tree from next-20111212 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-10-06  2:22 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-10-06  2:22 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Peter Ujfalusi

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/wm_hubs.c: In function 'wm8993_put_dc_servo':
sound/soc/codecs/wm_hubs.c:225:2: error: implicit declaration of function 'snd_soc_put_volsw_2r' [-Werror=implicit-function-declaration]
sound/soc/codecs/wm_hubs.c: At top level:
sound/soc/codecs/wm_hubs.c:365:1: error: 'snd_soc_get_volsw_2r' undeclared here (not in a function)

Caused by commit 0f9887d11e7c ("ASoC: Consolidate use of controls with
custom get/put function").

I have used the sound-asoc tree from next-20111005 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-08-11  4:06 ` Mark Brown
@ 2011-08-12  0:37   ` Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-08-12  0:37 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

Hi Mark,

On Thu, 11 Aug 2011 13:06:23 +0900 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Thu, Aug 11, 2011 at 01:11:29PM +1000, Stephen Rothwell wrote:
> 
> > Caused by commit 40045a85df0e ("ASoC: Fix SPI driver binding for WM8987").
> 
> No it wasn't, it was there already.  Anyway, should be fixed now.

Thanks.

> Do you have any idea what you're doing to turn on this detection?  It
> really shouldn't be something that's specific to the x86 build but
> there's nothing obvious I can see that does it.

My x86_64 allmodconfig build is (effectively) done like this (I am using
gcc v4.5.2):

echo CONFIG_PROFILE_ALL_BRANCHES=n >../x86_64_allmodconfig.except
echo CONFIG_DEBUG_INFO=n >>../x86_64_allmodconfig.except
echo CONFIG_X86_DECODER_SELFTEST=n >>../x86_64_allmodconfig.except
KCONFIG_ALLCONFIG=../x86_64_allmodconfig.except \
        make O=../x86_64_allmodconfig allmodconfig
make O=../x86_64_allmodconfig -j48 -s

> Out of interest you used to carry reverts for commits when you'd
> identified them but that seems not to happen any more?

It depends on when I find a problem.  If I find a build problem
immediately after mergeing a particular tree, I reset linux-next and use
the previous version of the tree instead.  If I do not find the problem
until after I have completely merged all the trees, I may revert a
problem commit, or add a patch (is there is an interaction between two
trees).  In the latter case I will carry the revert or patch as long as
needed.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-08-11  3:11 Stephen Rothwell
@ 2011-08-11  4:06 ` Mark Brown
  2011-08-12  0:37   ` Stephen Rothwell
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2011-08-11  4:06 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Thu, Aug 11, 2011 at 01:11:29PM +1000, Stephen Rothwell wrote:

> sound/soc/codecs/snd-soc-wm8750: struct spi_device_id is 40 bytes.  The last of 2 is:
> 0x77 0x6d 0x38 0x39 0x38 0x37 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> FATAL: sound/soc/codecs/snd-soc-wm8750: struct spi_device_id is not terminated with a NULL entry!

> Caused by commit 40045a85df0e ("ASoC: Fix SPI driver binding for WM8987").

No it wasn't, it was there already.  Anyway, should be fixed now.

Do you have any idea what you're doing to turn on this detection?  It
really shouldn't be something that's specific to the x86 build but
there's nothing obvious I can see that does it.

Out of interest you used to carry reverts for commits when you'd
identified them but that seems not to happen any more?

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-08-11  3:11 Stephen Rothwell
  2011-08-11  4:06 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2011-08-11  3:11 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/snd-soc-wm8750: struct spi_device_id is 40 bytes.  The last of 2 is:
0x77 0x6d 0x38 0x39 0x38 0x37 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: sound/soc/codecs/snd-soc-wm8750: struct spi_device_id is not terminated with a NULL entry!

Caused by commit 40045a85df0e ("ASoC: Fix SPI driver binding for WM8987").

I have used the sound-asoc tree from next-20110809 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-08-10  0:25 Stephen Rothwell
@ 2011-08-10  4:55 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2011-08-10  4:55 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Wed, Aug 10, 2011 at 10:25:25AM +1000, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Should be fixed now.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-08-10  0:25 Stephen Rothwell
  2011-08-10  4:55 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2011-08-10  0:25 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/wm8750.c:785:1: error: '__mod_spi_device_table' aliased to undefined symbol 'wm8750_spi_id'
sound/soc/codecs/wm8750.c:785:1: error: '__mod_spi_device_table' aliased to undefined symbol 'wm8750_spi_id'

Caused by commit 40045a85df0e ("ASoC: Fix SPI driver binding for WM8987").

I have used the sound-asoc tree from next-20110809 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au


[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-06-14  3:43 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-06-14  3:43 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-dapm.c: In function 'is_connected_output_ep':
sound/soc/soc-dapm.c:596:11: error: 'struct snd_soc_dapm_path' has no member named 'weak'
sound/soc/soc-dapm.c: In function 'is_connected_input_ep':
sound/soc/soc-dapm.c:649:11: error: 'struct snd_soc_dapm_path' has no member named 'weak'
sound/soc/soc-dapm.c: In function 'dapm_supply_check_power':
sound/soc/soc-dapm.c:733:11: error: 'struct snd_soc_dapm_path' has no member named 'weak'
sound/soc/soc-dapm.c: In function 'snd_soc_dapm_weak_route':
sound/soc/soc-dapm.c:1848:8: error: 'struct snd_soc_dapm_path' has no member named 'weak'

Caused by commit bf3a9e137cf1 ("ASoC: Add weak routes for sidetone style paths").

I have used the sound-asoc from next-20110610 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-06-07  1:55 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-06-07  1:55 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Lars-Peter Clausen

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/ad1836.c:130:2: error: 'AD183X_ADC_CTRL1' undeclared here (not in a function)

Caused by commit f97d0c6d5f94 ("ASoC: AD1836: Add input gain control for
ADC2").

I have used the sound-asoc tree from next-20110606 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-04-28  1:53 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-04-28  1:53 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-utils.o: In function `cleanup_module':
(.exit.text+0x0): multiple definition of `cleanup_module'
sound/soc/soc-core.o:(.exit.text+0x0): first defined here
sound/soc/soc-utils.o: In function `init_module':
(.init.text+0x0): multiple definition of `init_module'
sound/soc/soc-core.o:(.init.text+0x0): first defined here

Probably caused by commit 848dd8beef44 ("ASoC: Add more natural support
for no-DMA DAIs")?

I have used the sound-asoc tree from next-20110427 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-04-12  1:59 Stephen Rothwell
@ 2011-04-12  4:48 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2011-04-12  4:48 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Tue, Apr 12, 2011 at 11:59:54AM +1000, Stephen Rothwell wrote:

> sound/soc/codecs/wm1250-ev1.c:76: error: '__mod_i2c_device_table' aliased to undefined symbol 'wm1250_ev1__id'

Fixed now.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-04-12  1:59 Stephen Rothwell
  2011-04-12  4:48 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2011-04-12  1:59 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

sound/soc/codecs/wm1250-ev1.c:76: error: '__mod_i2c_device_table' aliased to undefined symbol 'wm1250_ev1__id'

Caused by commit 4bb3f43c6e3f ("ASoC: Add initial WM1250-EV1 Springbank
audio I/O module driver").

I have used the sound-asoc tree from next-20110411 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2011-03-07  1:56 Stephen Rothwell
@ 2011-03-07 11:47 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2011-03-07 11:47 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Javier Martin

On Mon, Mar 07, 2011 at 12:56:59PM +1100, Stephen Rothwell wrote:

> Caused by commit 1d471cd1261a44a3b28350bef7e5113a4609c106 ("ASoC: Add TI
> tlv320aic32x4 codec support").

> I have used the sound-asoc tree fomr next-20110304 for today.

Fixed now.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-03-07  1:56 Stephen Rothwell
  2011-03-07 11:47 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2011-03-07  1:56 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Javier Martin

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build
(x86_64_allmodconfig) failed like this:

sound/soc/codecs/tlv320aic32x4.c: In function 'aic32x4_set_bias_level':
sound/soc/codecs/tlv320aic32x4.c:605: error: 'struct snd_soc_codec' has no member named 'bias_level'

Caused by commit 1d471cd1261a44a3b28350bef7e5113a4609c106 ("ASoC: Add TI
tlv320aic32x4 codec support").

I have used the sound-asoc tree fomr next-20110304 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2011-02-15  2:33 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2011-02-15  2:33 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/wm8903.c:376: error: redefinition of 'wm8903_dcs_event'
sound/soc/codecs/wm8903.c:279: note: previous definition of 'wm8903_dcs_event' was here
sound/soc/codecs/wm8903.c:398: error: redefinition of 'wm8903_seq_notifier'
sound/soc/codecs/wm8903.c:301: note: previous definition of 'wm8903_seq_notifier' was here

It looks like commit "ASoC: Actively manage WM8903 DC servo
configuration" has been applied twice as commits c5b6a9feaeb0 and
8e715c3194e4.

I have used the version of the sound-asoc tree from next-20110214 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-12-28  2:17   ` Mark Brown
@ 2010-12-30 12:24     ` Takashi Iwai
  0 siblings, 0 replies; 193+ messages in thread
From: Takashi Iwai @ 2010-12-30 12:24 UTC (permalink / raw)
  To: Mark Brown; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

At Tue, 28 Dec 2010 02:17:48 +0000,
Mark Brown wrote:
> 
> On Tue, Dec 28, 2010 at 10:48:34AM +1100, Stephen Rothwell wrote:
> 
> > Mark, I reversed the order of the trees today ...
> 
> That's expected, Takashi is on holiday at the minute so not updating his
> tree.  Merging ASoC first will mean you get the fixes in ASoC plus the
> additional stuff in the sound tree which seems more sensible.

I pulled now.  Let me know if it's still broken (maybe in the new year?)


thanks,

Takashi

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-12-27 23:48 ` Stephen Rothwell
@ 2010-12-28  2:17   ` Mark Brown
  2010-12-30 12:24     ` Takashi Iwai
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2010-12-28  2:17 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Takashi Iwai

On Tue, Dec 28, 2010 at 10:48:34AM +1100, Stephen Rothwell wrote:

> Mark, I reversed the order of the trees today ...

That's expected, Takashi is on holiday at the minute so not updating his
tree.  Merging ASoC first will mean you get the fixes in ASoC plus the
additional stuff in the sound tree which seems more sensible.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-12-27 23:40 Stephen Rothwell
  2010-12-27 23:48 ` Stephen Rothwell
@ 2010-12-28  2:15 ` Mark Brown
  1 sibling, 0 replies; 193+ messages in thread
From: Mark Brown @ 2010-12-28  2:15 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Tue, Dec 28, 2010 at 10:40:24AM +1100, Stephen Rothwell wrote:

> In sound/soc/codecs/wm8962.c, the tracepoint is protected by
> CONFIG_SOUND_SOC_WM8962_MODULE, it should be CONFIG_SND_SOC_WM8962_MODULE.

Should be fixed now.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-12-27 23:40 Stephen Rothwell
@ 2010-12-27 23:48 ` Stephen Rothwell
  2010-12-28  2:17   ` Mark Brown
  2010-12-28  2:15 ` Mark Brown
  1 sibling, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2010-12-27 23:48 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Takashi Iwai

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

Hi Mark, Takashi,

On Tue, 28 Dec 2010 10:40:24 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
> 
> In sound/soc/codecs/wm8962.c, the tracepoint is protected by
> CONFIG_SOUND_SOC_WM8962_MODULE, it should be CONFIG_SND_SOC_WM8962_MODULE.

I also got the same error in the sound tree, so I used the version of the
sound tree that would have been in next-20101223 again today.

Mark, I reversed the order of the trees today ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2010-12-27 23:40 Stephen Rothwell
  2010-12-27 23:48 ` Stephen Rothwell
  2010-12-28  2:15 ` Mark Brown
  0 siblings, 2 replies; 193+ messages in thread
From: Stephen Rothwell @ 2010-12-27 23:40 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!

In sound/soc/codecs/wm8962.c, the tracepoint is protected by
CONFIG_SOUND_SOC_WM8962_MODULE, it should be CONFIG_SND_SOC_WM8962_MODULE.

I have used the sound-asoc tree from next-20101221 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-12-23  1:02 Stephen Rothwell
@ 2010-12-23  2:12 ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2010-12-23  2:12 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel

On Thu, Dec 23, 2010 at 12:02:43PM +1100, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

> ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
> ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8903.ko] undefined!

> Caused by commit 1c9e9795b5e2348df619fd6010d7583dc9b8c811 ("ASoC: Add
> jack IRQ trace to 88pm860x driver").

It's not that commit - that's for a totally different driver to those
above which can't build on x86 as x86 lacks generic hardirqs.  I've
pushed up a change which ifdefs out all the tracepoints when things are
built modular, but it seems unfortunate that x86 isn't doing the right
thing here, whatever ARM is doing seems to DTRT.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2010-12-23  1:02 Stephen Rothwell
  2010-12-23  2:12 ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2010-12-23  1:02 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "__tracepoint_snd_soc_jack_irq" [sound/soc/codecs/snd-soc-wm8903.ko] undefined!

Caused by commit 1c9e9795b5e2348df619fd6010d7583dc9b8c811 ("ASoC: Add
jack IRQ trace to 88pm860x driver").

I have used the sound-asoc tree from next-20101221 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2010-12-01  0:31 Stephen Rothwell
  0 siblings, 0 replies; 193+ messages in thread
From: Stephen Rothwell @ 2010-12-01  0:31 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Jarkko Nikula

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-core.c: In function 'soc_probe_aux_dev':
sound/soc/soc-core.c:1647: error: 'struct snd_soc_dapm_context' has no member named 'list'
sound/soc/soc-core.c:1647: error: 'struct snd_soc_card' has no member named 'dapm_list'

Caused by commit 2eea392d0a28a0a07d36a9da544eb40f81bf4cb6 ("ASoC: Add
support for optional auxiliary dailess codecs").

I have used the version of the sound-asoc tree from next-20101130 for today
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-10-19  0:30     ` Peter Hsiang
@ 2010-10-19  0:43       ` Mark Brown
  0 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2010-10-19  0:43 UTC (permalink / raw)
  To: Peter Hsiang; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

On Mon, Oct 18, 2010 at 05:30:39PM -0700, Peter Hsiang wrote:
> On Mon, Oct 18, 2010, Mark Brown wrote:

> > Your patch was apparently not generated against the mainline Makefile or
> > Kconfig and the automated conflict resolution tool I used (which is
> > normally fairly reliable) appears to have misplaced the header.  I've
> > restored the driver with the readdition of the header.

> .../pub/scm/linux/kernel/git/next/linux-next.git  Right?

As previously advised several times you should be submitting against the
latest for-whatever branch of 

  git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git

for ASoC.  That will *generally* be what's in -next but not always.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2010-10-19  0:07   ` Mark Brown
@ 2010-10-19  0:30     ` Peter Hsiang
  2010-10-19  0:43       ` Mark Brown
  0 siblings, 1 reply; 193+ messages in thread
From: Peter Hsiang @ 2010-10-19  0:30 UTC (permalink / raw)
  To: Mark Brown; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

On Mon, Oct 18, 2010, Mark Brown wrote:
> On Mon, Oct 18, 2010 at 01:25:12PM -0700, Peter Hsiang wrote:
> 
> > This message seems to be saying that this header file is missing.
> > However, this header file was included in the patch that was submitted,
> > and it did compile fine here before the submit.
> > I don't understand why it's not there after it was applied?
> 
> Your patch was apparently not generated against the mainline Makefile or
> Kconfig and the automated conflict resolution tool I used (which is
> normally fairly reliable) appears to have misplaced the header.  I've
> restored the driver with the readdition of the header.

.../pub/scm/linux/kernel/git/next/linux-next.git  Right?
Thanks!

Peter

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-10-18 20:25 ` Peter Hsiang
@ 2010-10-19  0:07   ` Mark Brown
  2010-10-19  0:30     ` Peter Hsiang
  0 siblings, 1 reply; 193+ messages in thread
From: Mark Brown @ 2010-10-19  0:07 UTC (permalink / raw)
  To: Peter Hsiang; +Cc: Stephen Rothwell, Liam Girdwood, linux-next, linux-kernel

On Mon, Oct 18, 2010 at 01:25:12PM -0700, Peter Hsiang wrote:

> This message seems to be saying that this header file is missing.
> However, this header file was included in the patch that was submitted,
> and it did compile fine here before the submit.
> I don't understand why it's not there after it was applied?

Your patch was apparently not generated against the mainline Makefile or
Kconfig and the automated conflict resolution tool I used (which is
normally fairly reliable) appears to have misplaced the header.  I've
restored the driver with the readdition of the header.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* RE: linux-next: build failure after merge of the sound-asoc tree
  2010-10-18  3:29 Stephen Rothwell
  2010-10-18  3:39 ` Stephen Rothwell
  2010-10-18  5:03 ` Mark Brown
@ 2010-10-18 20:25 ` Peter Hsiang
  2010-10-19  0:07   ` Mark Brown
  2 siblings, 1 reply; 193+ messages in thread
From: Peter Hsiang @ 2010-10-18 20:25 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel

On Sun, Oct 17, 2010, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/max98088.c:28:28: error: sound/max98088.h: No such file or
> directory
> 

Mark, 

This message seems to be saying that this header file is missing.
However, this header file was included in the patch that was submitted,
and it did compile fine here before the submit.
I don't understand why it's not there after it was applied?

Thanks,

Peter

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-10-18  3:39 ` Stephen Rothwell
@ 2010-10-18  5:44   ` Takashi Iwai
  0 siblings, 0 replies; 193+ messages in thread
From: Takashi Iwai @ 2010-10-18  5:44 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Liam Girdwood, linux-next, linux-kernel, Peter Hsiang

At Mon, 18 Oct 2010 14:39:25 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> On Mon, 18 Oct 2010 14:29:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > sound/soc/codecs/max98088.c:28:28: error: sound/max98088.h: No such file or directory
> 	.
> 	.
> > 
> > Caused by commit e65d255a5a610ce9e185e0df855250706aca7c21 ("ASoC: Add
> > max98088 CODEC driver").
> > 
> > Please, please build test what you are submitting.
> > 
> > I have used the sound-asoc tree from next-20101015 for today.
> 
> I have also had to use the version of the sound tree from next-20101015
> since it had merged the sound-asoc tree.

Mark now fixed it (just removed the driver), and I pulled it to sound
tree, too.  Sorry for inconvenience.


Takashi

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-10-18  3:29 Stephen Rothwell
  2010-10-18  3:39 ` Stephen Rothwell
@ 2010-10-18  5:03 ` Mark Brown
  2010-10-18 20:25 ` Peter Hsiang
  2 siblings, 0 replies; 193+ messages in thread
From: Mark Brown @ 2010-10-18  5:03 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Peter Hsiang

On Mon, Oct 18, 2010 at 02:29:34PM +1100, Stephen Rothwell wrote:

> Please, please build test what you are submitting.

> I have used the sound-asoc tree from next-20101015 for today.

Pushed a reversion of the MAX98088 driver so this will be fixed
tomorrow.

^ permalink raw reply	[flat|nested] 193+ messages in thread

* Re: linux-next: build failure after merge of the sound-asoc tree
  2010-10-18  3:29 Stephen Rothwell
@ 2010-10-18  3:39 ` Stephen Rothwell
  2010-10-18  5:44   ` Takashi Iwai
  2010-10-18  5:03 ` Mark Brown
  2010-10-18 20:25 ` Peter Hsiang
  2 siblings, 1 reply; 193+ messages in thread
From: Stephen Rothwell @ 2010-10-18  3:39 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood, Takashi Iwai
  Cc: linux-next, linux-kernel, Peter Hsiang

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Hi all,

On Mon, 18 Oct 2010 14:29:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/max98088.c:28:28: error: sound/max98088.h: No such file or directory
	.
	.
> 
> Caused by commit e65d255a5a610ce9e185e0df855250706aca7c21 ("ASoC: Add
> max98088 CODEC driver").
> 
> Please, please build test what you are submitting.
> 
> I have used the sound-asoc tree from next-20101015 for today.

I have also had to use the version of the sound tree from next-20101015
since it had merged the sound-asoc tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

* linux-next: build failure after merge of the sound-asoc tree
@ 2010-10-18  3:29 Stephen Rothwell
  2010-10-18  3:39 ` Stephen Rothwell
                   ` (2 more replies)
  0 siblings, 3 replies; 193+ messages in thread
From: Stephen Rothwell @ 2010-10-18  3:29 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: linux-next, linux-kernel, Peter Hsiang

[-- Attachment #1: Type: text/plain, Size: 3791 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/max98088.c:28:28: error: sound/max98088.h: No such file or directory
sound/soc/codecs/max98088.c: In function 'max98088_setup_eq1':
sound/soc/codecs/max98088.c:1712: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1713: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1714: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1716: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1720: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1720: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1728: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1730: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1731: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1732: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1733: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1734: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c: In function 'max98088_setup_eq2':
sound/soc/codecs/max98088.c:1759: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1760: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1761: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1763: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1767: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1767: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1775: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1777: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1778: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1779: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1780: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1781: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c: In function 'max98088_put_eq_enum':
sound/soc/codecs/max98088.c:1800: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c: In function 'max98088_handle_eq_pdata':
sound/soc/codecs/max98088.c:1851: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1852: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1861: error: invalid use of undefined type 'struct max98088_eq_cfg'
sound/soc/codecs/max98088.c:1861: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1876: error: invalid use of undefined type 'struct max98088_eq_cfg'
sound/soc/codecs/max98088.c:1876: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c: In function 'max98088_handle_pdata':
sound/soc/codecs/max98088.c:1902: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1905: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1913: error: dereferencing pointer to incomplete type
sound/soc/codecs/max98088.c:1918: error: dereferencing pointer to incomplete type

Caused by commit e65d255a5a610ce9e185e0df855250706aca7c21 ("ASoC: Add
max98088 CODEC driver").

Please, please build test what you are submitting.

I have used the sound-asoc tree from next-20101015 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 193+ messages in thread

end of thread, back to index

Thread overview: 193+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  3:08 linux-next: build failure after merge of the sound-asoc tree Stephen Rothwell
2019-08-13  3:16 ` Stephen Rothwell
2019-08-13 11:21   ` Mark Brown
2019-08-13 13:52     ` Pierre-Louis Bossart
  -- strict thread matches above, loose matches on Subject: below --
2019-04-03  0:11 Stephen Rothwell
2019-04-03  2:12 ` Baolin Wang
2019-04-03  3:35   ` Mark Brown
2019-04-03  4:27     ` Baolin Wang
2019-04-03  4:43       ` Mark Brown
2019-03-26 23:03 Stephen Rothwell
2019-03-26  2:33 Stephen Rothwell
2019-03-26 13:15 ` Mark Brown
2019-03-27  4:29   ` Michael Ellerman
2019-03-27 11:57     ` Mark Brown
2019-04-01 11:11       ` Michael Ellerman
2019-04-02  5:14         ` Mark Brown
2019-02-08  2:18 Stephen Rothwell
2019-02-08  7:37 ` Takashi Iwai
2019-02-08  8:39   ` Takashi Iwai
2019-02-08 12:53     ` Mark Brown
2018-04-17 23:51 Stephen Rothwell
2018-04-18 14:49 ` Mark Brown
2018-04-17  1:02 Stephen Rothwell
2018-04-17  1:22 ` Shuming [范書銘]
2018-04-17  2:14   ` Shuming [范書銘]
2018-03-21  2:30 Stephen Rothwell
2018-03-21  2:45 ` Mark Brown
2018-03-21  5:45   ` Mukunda,Vijendar
2018-03-22  1:38     ` Mark Brown
2018-03-22  5:54       ` Mukunda,Vijendar
2018-03-27 11:27         ` Mark Brown
2018-03-27 12:45           ` Mukunda,Vijendar
2018-03-13  6:09 Stephen Rothwell
2018-03-13  8:52 ` Adam Thomson
2018-03-01 23:54 Stephen Rothwell
2018-03-02  2:49 ` John Hsu
2018-02-15  0:35 Stephen Rothwell
2018-02-15  2:49 ` Kuninori Morimoto
2018-02-15 15:33   ` Mark Brown
2018-02-16  0:01     ` Kuninori Morimoto
2017-11-29  0:50 Stephen Rothwell
2017-09-20  2:01 Stephen Rothwell
2017-09-20 11:54 ` robert.jarzmik
2017-09-20 11:56   ` Mark Brown
2017-08-25  7:58 Hsin-yu Chao
2017-08-25  7:41 Stephen Rothwell
2017-06-29  1:54 Stephen Rothwell
2017-06-29  2:01 ` Bard Liao
2017-06-30  1:51   ` Stephen Rothwell
2017-07-03  3:21     ` Stephen Rothwell
2017-06-16  2:04 Stephen Rothwell
2017-06-14  1:26 Stephen Rothwell
2017-06-14  2:22 ` Kuninori Morimoto
2017-06-08  3:37 Stephen Rothwell
2016-12-06  0:14 Stephen Rothwell
2016-12-06  0:41 ` Kuninori Morimoto
2016-12-06  9:37   ` Mark Brown
2016-12-06 12:55     ` Lee Jones
2016-12-06 13:22       ` Mark Brown
2016-11-14  0:28 Stephen Rothwell
2016-11-14  9:45 ` Richard Fitzgerald
2016-11-08  2:47 Stephen Rothwell
2016-11-08  3:18 ` Chen-Yu Tsai
2016-11-09 14:41   ` Mark Brown
2016-08-23  2:27 Stephen Rothwell
2016-08-08  0:50 Stephen Rothwell
2016-08-08  1:29 ` Kuninori Morimoto
2016-05-11  1:07 Stephen Rothwell
2016-05-11  3:38 ` Vinod Koul
2016-05-06  0:57 Stephen Rothwell
2016-05-06  9:48 ` Opensource [Adam Thomson]
2016-05-06 12:02   ` Mark Brown
2016-05-06 13:39     ` Opensource [Adam Thomson]
2016-04-22  2:03 Stephen Rothwell
2016-04-22  8:40 ` Philipp Zabel
2016-04-22  8:58   ` Mark Brown
2016-04-22  9:21   ` Mark Brown
2015-11-19  0:35 Stephen Rothwell
2015-11-19  3:02 ` Vinod Koul
2015-11-19 10:38   ` Mark Brown
2015-11-20 12:06   ` Mark Brown
2015-11-20 14:58     ` Vinod Koul
2015-09-21  1:23 Stephen Rothwell
2015-08-28  1:50 Stephen Rothwell
2015-08-28  7:40 ` Ricard Wanderlof
2015-08-28 15:45   ` Mark Brown
2015-08-31  7:04     ` Ricard Wanderlof
2015-08-31  7:48       ` Stephen Rothwell
2015-08-31  7:51         ` Stephen Rothwell
2015-08-31  8:18           ` Ricard Wanderlof
2015-07-17  4:25 Stephen Rothwell
2015-07-20  3:44 ` Stephen Rothwell
2015-06-04  4:02 Stephen Rothwell
2015-06-02  2:51 Stephen Rothwell
2015-04-30  2:05 Stephen Rothwell
2015-04-30  2:14 ` Bard Liao
2015-03-10  2:01 Stephen Rothwell
2015-03-12  2:11 ` Stephen Rothwell
2015-03-12  2:50   ` Bard Liao
2015-02-09  3:36 Stephen Rothwell
2015-01-28  2:00 Stephen Rothwell
2015-01-28  9:09 ` Charles Keepax
2015-01-28  9:50   ` Charles Keepax
2015-01-28 11:06     ` Mark Brown
2014-10-21  0:33 Stephen Rothwell
2014-08-17 22:30 Stephen Rothwell
2014-08-18  6:51 ` Sean Cross
2014-08-18 14:09   ` Mark Brown
2014-04-15  1:49 Stephen Rothwell
2014-04-15  1:47 Stephen Rothwell
2014-03-19  1:10 Stephen Rothwell
2014-03-19 10:17 ` Mark Brown
2014-03-19 20:30   ` Stephen Rothwell
2014-02-20  3:01 Stephen Rothwell
2013-11-29  0:54 Stephen Rothwell
2013-11-29 12:36 ` Mark Brown
2013-07-16  3:18 Stephen Rothwell
2013-07-16 11:52 ` Mark Brown
2013-06-17  3:46 Stephen Rothwell
2013-03-21  2:13 Stephen Rothwell
2013-02-08  0:57 Stephen Rothwell
2013-02-05  1:46 Stephen Rothwell
2013-01-23  2:17 Stephen Rothwell
2013-01-14  1:04 Stephen Rothwell
2013-01-14  4:55 ` Mark Brown
2012-10-29  0:48 Stephen Rothwell
2012-10-29 18:15 ` Mark Brown
2012-10-29 20:46   ` Stephen Rothwell
2012-10-30 12:11     ` Mark Brown
2012-06-29  3:38 Stephen Rothwell
2012-06-29  7:09 ` Mark Brown
2012-06-25  4:11 Stephen Rothwell
2012-06-25  6:09 ` Rajeev kumar
2012-06-25  8:06   ` viresh kumar
2012-06-25  9:03   ` Mark Brown
2012-06-13  2:52 Stephen Rothwell
2012-06-12  1:59 Stephen Rothwell
2012-06-05  1:25 Stephen Rothwell
2012-06-05  6:55 ` MR Swami Reddy
2012-06-05  9:43   ` Mark Brown
2012-06-05 10:05     ` MR Swami Reddy
2012-06-04  3:25 Stephen Rothwell
2012-06-04  7:19 ` Mark Brown
2012-05-10  4:33 Stephen Rothwell
2012-05-10  8:30 ` Linus Walleij
2012-05-10  8:35   ` Ola Lilja
2012-05-10  9:11     ` Mark Brown
2012-05-10  9:09   ` Mark Brown
2012-05-10 12:12     ` Linus Walleij
2012-04-03  1:26 Stephen Rothwell
2012-04-02  1:34 Stephen Rothwell
2012-04-02 15:04 ` Mark Brown
2012-02-06  1:25 Stephen Rothwell
2012-02-06 16:50 ` Liam Girdwood
2012-02-06 16:53   ` Mark Brown
2012-02-06 22:02   ` Stephen Rothwell
2012-01-23  1:14 Stephen Rothwell
2012-01-23  2:25 ` Fabio Estevam
2012-01-23 10:47 ` Mark Brown
2012-01-23 13:10   ` Stephen Rothwell
2011-12-15  3:38 Stephen Rothwell
2011-12-15  6:10 ` Mark Brown
2011-12-13  3:58 Stephen Rothwell
2011-10-06  2:22 Stephen Rothwell
2011-08-11  3:11 Stephen Rothwell
2011-08-11  4:06 ` Mark Brown
2011-08-12  0:37   ` Stephen Rothwell
2011-08-10  0:25 Stephen Rothwell
2011-08-10  4:55 ` Mark Brown
2011-06-14  3:43 Stephen Rothwell
2011-06-07  1:55 Stephen Rothwell
2011-04-28  1:53 Stephen Rothwell
2011-04-12  1:59 Stephen Rothwell
2011-04-12  4:48 ` Mark Brown
2011-03-07  1:56 Stephen Rothwell
2011-03-07 11:47 ` Mark Brown
2011-02-15  2:33 Stephen Rothwell
2010-12-27 23:40 Stephen Rothwell
2010-12-27 23:48 ` Stephen Rothwell
2010-12-28  2:17   ` Mark Brown
2010-12-30 12:24     ` Takashi Iwai
2010-12-28  2:15 ` Mark Brown
2010-12-23  1:02 Stephen Rothwell
2010-12-23  2:12 ` Mark Brown
2010-12-01  0:31 Stephen Rothwell
2010-10-18  3:29 Stephen Rothwell
2010-10-18  3:39 ` Stephen Rothwell
2010-10-18  5:44   ` Takashi Iwai
2010-10-18  5:03 ` Mark Brown
2010-10-18 20:25 ` Peter Hsiang
2010-10-19  0:07   ` Mark Brown
2010-10-19  0:30     ` Peter Hsiang
2010-10-19  0:43       ` Mark Brown

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox