* [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
@ 2013-03-29 14:12 Peter Hurley
2013-03-29 17:12 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Peter Hurley @ 2013-03-29 14:12 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Peter Hurley, Xiong Zhou, Mark Brown
The linux-next tree has failed to build for last 7 days with these
errors:
MODPOST 2490 modules
ERROR: "arizona_rate_text" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
ERROR: "arizona_rate_val" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
WARNING: modpost: Found 5 section mismatch(es).
Patches submitted by Xiong Zhou <jencce.kernel@gmail.com> to fix this
have been rejected.
Until the author(s) resolve the situation, mark the offenders as BROKEN.
Cc: Xiong Zhou <jencce.kernel@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
sound/soc/codecs/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 18fea10..470b66b 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -79,7 +79,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_WM0010 if SPI_MASTER
select SND_SOC_WM1250_EV1 if I2C
select SND_SOC_WM2000 if I2C
- select SND_SOC_WM2200 if I2C
+ select SND_SOC_WM2200 if I2C && BROKEN
select SND_SOC_WM5100 if I2C
select SND_SOC_WM5102 if MFD_WM5102
select SND_SOC_WM5110 if MFD_WM5110
@@ -153,6 +153,7 @@ config SND_SOC_WM_HUBS
config SND_SOC_WM_ADSP
tristate
+ depends on BROKEN
default y if SND_SOC_WM5102=y
default y if SND_SOC_WM2200=y
default m if SND_SOC_WM5102=m
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
2013-03-29 14:12 [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN Peter Hurley
@ 2013-03-29 17:12 ` Mark Brown
2013-03-29 18:45 ` Peter Hurley
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-03-29 17:12 UTC (permalink / raw)
To: Peter Hurley; +Cc: Stephen Rothwell, linux-next, Xiong Zhou
[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]
On Fri, Mar 29, 2013 at 10:12:27AM -0400, Peter Hurley wrote:
> The linux-next tree has failed to build for last 7 days with these
> errors:
In some pretty specific and basically unrealistic configurations rather
than anything a human is likely to want to use or the core automatic
ones.
> MODPOST 2490 modules
> ERROR: "arizona_rate_text" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
> ERROR: "arizona_rate_val" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
> WARNING: modpost: Found 5 section mismatch(es).
> Patches submitted by Xiong Zhou <jencce.kernel@gmail.com> to fix this
> have been rejected.
> Until the author(s) resolve the situation, mark the offenders as BROKEN.
I'm not going to apply this, it's clearly not a constructive or helpful
effort to address the issue - it's not engaging with any of the
discussion about how to resolve the issue (there's no mention of the
suggested fix for example).
If you're going to run randconfigs that's great and the testing is
useful but if you're going to send patches as well as reports it would
be really helpful to look at what the code is doing so that the change
makes sense rather than just sending the first thing that springs to
mind. The smarter the stuff that gets sent is the more likely it is to
either get merged or encourage people to work on the problem.
In this case it seems like Xiong is likely to fix things and it'd be
much better overall to get a fix from Xiong merged (which we seem to be
progressing towards).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
2013-03-29 17:12 ` Mark Brown
@ 2013-03-29 18:45 ` Peter Hurley
2013-03-29 18:50 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Peter Hurley @ 2013-03-29 18:45 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, linux-next, Xiong Zhou
On Fri, 2013-03-29 at 17:12 +0000, Mark Brown wrote:
> On Fri, Mar 29, 2013 at 10:12:27AM -0400, Peter Hurley wrote:
>
> > The linux-next tree has failed to build for last 7 days with these
> > errors:
>
> In some pretty specific and basically unrealistic configurations rather
> than anything a human is likely to want to use or the core automatic
> ones.
>
> > MODPOST 2490 modules
> > ERROR: "arizona_rate_text" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
> > ERROR: "arizona_rate_val" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
> > WARNING: modpost: Found 5 section mismatch(es).
>
> > Patches submitted by Xiong Zhou <jencce.kernel@gmail.com> to fix this
> > have been rejected.
>
> > Until the author(s) resolve the situation, mark the offenders as BROKEN.
>
> I'm not going to apply this, it's clearly not a constructive or helpful
> effort to address the issue - it's not engaging with any of the
> discussion about how to resolve the issue (there's no mention of the
> suggested fix for example).
>
> If you're going to run randconfigs that's great and the testing is
> useful but if you're going to send patches as well as reports it would
> be really helpful to look at what the code is doing so that the change
> makes sense rather than just sending the first thing that springs to
> mind. The smarter the stuff that gets sent is the more likely it is to
> either get merged or encourage people to work on the problem.
>
> In this case it seems like Xiong is likely to fix things and it'd be
> much better overall to get a fix from Xiong merged (which we seem to be
> progressing towards).
This is stock Ubuntu configs.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
2013-03-29 18:45 ` Peter Hurley
@ 2013-03-29 18:50 ` Mark Brown
2013-03-30 12:30 ` Xiong Zhou
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2013-03-29 18:50 UTC (permalink / raw)
To: Peter Hurley; +Cc: Stephen Rothwell, linux-next, Xiong Zhou
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
On Fri, Mar 29, 2013 at 02:45:54PM -0400, Peter Hurley wrote:
> This is stock Ubuntu configs.
Then the stock Ubuntu configuration is not a sensible one, enabling
SND_SOC_ALL_CODECS for any purpose other than build coverage testing is
just a waste of time - that's all it does.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
2013-03-29 18:50 ` Mark Brown
@ 2013-03-30 12:30 ` Xiong Zhou
2013-03-30 13:52 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Xiong Zhou @ 2013-03-30 12:30 UTC (permalink / raw)
To: Mark Brown; +Cc: Peter Hurley, Stephen Rothwell, linux-next, Xiong Zhou
On Fri, 29 Mar 2013, Mark Brown wrote:
> On Fri, Mar 29, 2013 at 02:45:54PM -0400, Peter Hurley wrote:
>
> > This is stock Ubuntu configs.
>
> Then the stock Ubuntu configuration is not a sensible one, enabling
> SND_SOC_ALL_CODECS for any purpose other than build coverage testing is
> just a waste of time - that's all it does.
>
Take a look at this:
MFD_ARIZONA_I2C select
> -------- > MFD_ARIZONA <-|
MDF_ARIZONA_SPI |
|
|depends on
|
|
SND_SOC_ALL_CODECS-\ / \
I2C ---------/| MFD_WM5110 MFD_WM5102
| | |
| |select | select
| | |
v v v
SND_SOC_WM2200 SND_SOC_WM5102 SND_SOC_WM5110
| | | |
|____________________| |___________|
| |
| if M/Y | if M/Y
v v
SND_SOC_WM_ADSP SND_SOC_ARIZONA
If I2C is enabled normally, and SND_SOC_ALL_CODECS is keeped in the
sound card configure options.
Then, disable ALL options in:
Device drivers ---->
Multifunction device drivers --->
which includes MFD_ARIZONA_I2C and MDF_ARIZONA_SPI.
So the failure comes. Yes, this config is kind of specific, not much.
The definition of one array which is cited by one module comes in
another module, and this dependence does not appear in Kconfig
architecture. Indeed, the help text of ALL_CODECS reminds the
separated surpporting bus options. Still I think this is unreasonable.
Even though build coverage test is the only proper purpose. It breaks
the whole building procedure.
I think copying the same array definition across c file is ugly, and Mark
said that this is not a Kconfig issue. So far, I have not got any other
idea to fix this. Code cruising.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
2013-03-30 12:30 ` Xiong Zhou
@ 2013-03-30 13:52 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2013-03-30 13:52 UTC (permalink / raw)
To: Xiong Zhou; +Cc: Peter Hurley, Stephen Rothwell, linux-next
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
On Sat, Mar 30, 2013 at 08:30:39PM +0800, Xiong Zhou wrote:
> So the failure comes. Yes, this config is kind of specific, not much.
Right, but look at what the options are doing - ALL_CODECS is purely for
build coverage so someone seeing the issue in this form must be running
a partial build coverage test which happens to cover a relatively
obscure subsystem. This is why none of the all*configs that are run on
-next as standard fail.
> The definition of one array which is cited by one module comes in
> another module, and this dependence does not appear in Kconfig
> architecture. Indeed, the help text of ALL_CODECS reminds the
> separated surpporting bus options. Still I think this is unreasonable.
> Even though build coverage test is the only proper purpose. It breaks
> the whole building procedure.
I'm not saying this doesn't need to be fixed, I'm saying we need a sane
fix.
> I think copying the same array definition across c file is ugly, and Mark
> said that this is not a Kconfig issue. So far, I have not got any other
> idea to fix this. Code cruising.
I actually looked at this earlier and sent a fix for it (didn't get
round to mailing this thread yet, sorry), the code wouldn't have worked
at all for WM2200 - this is the sort of thing that should be apparent as
soon as people start asking questions like "why was this dependency
added, is it sensible?" which should be among the first questions asked
when turning up something like this, especially for recent changes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-30 13:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-29 14:12 [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN Peter Hurley
2013-03-29 17:12 ` Mark Brown
2013-03-29 18:45 ` Peter Hurley
2013-03-29 18:50 ` Mark Brown
2013-03-30 12:30 ` Xiong Zhou
2013-03-30 13:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).