From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [patch] x86, kvm: fix build failure with CONFIG_SMP disabled Date: Wed, 17 Apr 2013 17:09:19 -0700 (PDT) Message-ID: References: <20130417170450.5dd6e5f450de4d5bf197d997@canb.auug.org.au> <516EE5AB.4080201@infradead.org> <516F37FF.8040703@infradead.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mail-pd0-f172.google.com ([209.85.192.172]:62987 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935433Ab3DRAJW (ORCPT ); Wed, 17 Apr 2013 20:09:22 -0400 Received: by mail-pd0-f172.google.com with SMTP id 5so1120802pdd.17 for ; Wed, 17 Apr 2013 17:09:21 -0700 (PDT) In-Reply-To: <516F37FF.8040703@infradead.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap , Yang Zhang Cc: Marcelo Tosatti , Gleb Natapov , Stephen Rothwell , x86@kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, KVM On Wed, 17 Apr 2013, Randy Dunlap wrote: > On 04/17/13 16:12, David Rientjes wrote: > > The build fails when CONFIG_SMP is disabled: > > > > arch/x86/kvm/vmx.c: In function 'vmx_deliver_posted_interrupt': > > arch/x86/kvm/vmx.c:3950:3: error: 'apic' undeclared (first use in this function) > > > > Fix it by including the necessary header. > > Sorry, i386 build still fails with the same error message plus this one: > > ERROR: "apic" [arch/x86/kvm/kvm-intel.ko] undefined! > Ahh, that's because you don't have CONFIG_X86_LOCAL_APIC as you already mentioned. So it looks like this error can manifest in two different ways and we got different reports. This failure came from "KVM: VMX: Add the deliver posted interrupt algorithm", so adding Yang to the cc to specify the dependency this has on apic and how it can be protected without CONFIG_X86_LOCAL_APIC on i386.