linux-next: Fixes tags need some work in the tip tree

linux-next: Fixes tags need some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

In commit

  fe6f85ca121e ("x86/apic/32: Avoid bogus LDR warnings")

Fixes tag

  Fixes: bae3a8d3308 ("x86/apic: Do not initialize LDR and DFR for bigsmp")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  41d49e7939de ("clocksource/drivers/mediatek: Fix error handling")

Fixes tag

  Fixes: a0858f937960 ("mediatek: Convert the driver to timer-of")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the tip tree

[Thomas Gleixner]

On Tue, 5 Nov 2019, Stephen Rothwell wrote:
> In commit
> 
>   fe6f85ca121e ("x86/apic/32: Avoid bogus LDR warnings")
> 
> Fixes tag
> 
>   Fixes: bae3a8d3308 ("x86/apic: Do not initialize LDR and DFR for bigsmp")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Yes. I missed that one when applying the patch which had the fixes tag
already inside. Will add a check for that to catch future ones.

Jan, please adjust your git settings.

Thanks,

	tglx

linux-next: Fixes tags need some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

In commit

  eca8f0c80a00 ("hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()")

Fixes tag

  Fixes: da70160462e ("hrtimer: Implement support for softirq based hrtimers")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 5da70160462e ("hrtimer: Implement support for softirq based hrtimers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the tip tree

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> In commit
> 
>   eca8f0c80a00 ("hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()")
> 
> Fixes tag
> 
>   Fixes: da70160462e ("hrtimer: Implement support for softirq based hrtimers")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 5da70160462e ("hrtimer: Implement support for softirq based hrtimers")

Thanks - fixed.

	Ingo

linux-next: Fixes tags need some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

Hi all,

In commit

  6c4798d3f08b ("tools lib: Fix builds when glibc contains strlcpy()")

Fixes tag

  Fixes: ce99091 ("perf tools: Move strlcpy() from perf to tools/lib/string.c")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Fixes tag

  Fixes: 0215d59 ("tools lib: Reinstate strlcpy() header guard with __UCLIBC__")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the tip tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Hi all,

n commit

  6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")

Fixes tag

  Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

In commit

  db633a4e0e6e ("x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL, for clang/llvm")

Fixes tag

  Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the tip tree

[Thomas Hellstrom]

On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> Hi all,
>
> n commit
>
>   6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
>
> Fixes tag
>
>   Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")

The cited subject is missing a leading "x86/vmware:". Ingo, please let
me know if you want me to respin those.

Thanks,

Thomas

Re: linux-next: Fixes tags need some work in the tip tree

[Ingo Molnar]

* Thomas Hellstrom <thellstrom@vmware.com> wrote:

> On 10/22/19 10:17 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > n commit
> >
> >   6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro")
> >
> > Fixes tag
> >
> >   Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")
> 
> The cited subject is missing a leading "x86/vmware:". Ingo, please let
> me know if you want me to respin those.

Those who are picking it up for a backport will go by the sha1, while 
humans reading it are fine without the prefix, I think this is OK as-is.

Thanks,

	Ingo