From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3C6C432C0 for ; Tue, 19 Nov 2019 18:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DB71223E4 for ; Tue, 19 Nov 2019 18:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfKSSjp (ORCPT ); Tue, 19 Nov 2019 13:39:45 -0500 Received: from utopia.booyaka.com ([74.50.51.50]:49451 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfKSSjp (ORCPT ); Tue, 19 Nov 2019 13:39:45 -0500 X-Greylist: delayed 401 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Nov 2019 13:39:45 EST Received: (qmail 16630 invoked by uid 1019); 19 Nov 2019 18:33:03 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 19 Nov 2019 18:33:03 -0000 Date: Tue, 19 Nov 2019 18:33:03 +0000 (UTC) From: Paul Walmsley To: Christoph Hellwig cc: Stephen Rothwell , Palmer Dabbelt , paul.walmsley@sifive.com, linux-riscv@lists.infradead.org, Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: manual merge of the generic-ioremap tree with the risc-v tree In-Reply-To: <20191118065149.GA4850@lst.de> Message-ID: References: <20191118174501.73050c78@canb.auug.org.au> <20191118065149.GA4850@lst.de> User-Agent: Alpine 2.21.999 (DEB 260 2018-02-26) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Christoph, On Mon, 18 Nov 2019, Christoph Hellwig wrote: > On Mon, Nov 18, 2019 at 05:45:01PM +1100, Stephen Rothwell wrote: > > 0c3ac28931d5 ("riscv: separate MMIO functions into their own header file") > > As already mentioned in reply to this patch when it was posted I think > this kinda of split is a very bad idea. Unless I missed a followup from you, you mentioned that you thought there might be a better way to implement it, but you didn't highlight any problems with it: https://lore.kernel.org/linux-riscv/20191031155608.GB7270@lst.de/ If you think there's something critically wrong with the patch that can be fixed in time for the merge window, I'm happy to take a look at a proposal. Otherwise I think we'll need to drop the nommu set from the v5.5 queue. - Paul