linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Stefan Achatz <erazor_de@users.sourceforge.net>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH -next] hid: roccat modules interdependencies
Date: Mon, 31 May 2010 13:58:02 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1005311357540.28092@pobox.suse.cz> (raw)
In-Reply-To: <20100527090706.6c2bc555.randy.dunlap@oracle.com>

On Thu, 27 May 2010, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> hid-roccat-kone calls the hid-roccat module interfaces,
> so the former should depend on or select the latter to prevent
> build errors, like:
> 
> hid-roccat-kone.c:(.text+0x133ed2): undefined reference to `roccat_report_event'
> hid-roccat-kone.c:(.text+0x133fa8): undefined reference to `roccat_disconnect'
> hid-roccat-kone.c:(.text+0x1353be): undefined reference to `roccat_connect'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/hid/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100527.orig/drivers/hid/Kconfig
> +++ linux-next-20100527/drivers/hid/Kconfig
> @@ -358,6 +358,7 @@ config HID_ROCCAT
>  config HID_ROCCAT_KONE
>  	tristate "Roccat Kone Mouse support"
>  	depends on USB_HID
> +	select HID_ROCCAT
>  	---help---
>  	Support for Roccat Kone mouse.

Applied, thanks Randy.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

      reply	other threads:[~2010-05-31 11:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  5:26 linux-next: Tree for May 27 Stephen Rothwell
2010-05-27 16:05 ` linux-next: Tree for May 27 (infiniband: qib) Randy Dunlap
2010-05-27 21:45   ` Roland Dreier
2010-05-27 22:06     ` Randy Dunlap
2010-05-27 22:22       ` Ralph Campbell
2010-05-27 16:07 ` [PATCH -next] hid: roccat modules interdependencies Randy Dunlap
2010-05-31 11:58   ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1005311357540.28092@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=erazor_de@users.sourceforge.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).