From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0FCC433F5 for ; Mon, 23 May 2022 12:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235540AbiEWMbd (ORCPT ); Mon, 23 May 2022 08:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235546AbiEWMbb (ORCPT ); Mon, 23 May 2022 08:31:31 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CFD72B267 for ; Mon, 23 May 2022 05:31:29 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id f21so1202822pfa.3 for ; Mon, 23 May 2022 05:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=drc5LnU//nothzoPqQ8d1G4VXl7oy7LH+bWASwffyS0=; b=cUjzWmvkn1g+Ctnqb9MUltJvIF5FuQsDRBOLVuQ/2DACJACoScCPORIK0YNVEvtYJW 7mnjzKll6XZsFk9zw0VVRjk+GagEMU1q1FQvFN/qMWvY9SQ2+58l9+WcPpN5ix29NgGi u4Xo4WZXPKpkd5RcyH7ClkcGPRfSEYtuskl+1oSh6sezlpOlByJQ/Aypi7bUJO2mhgLv bYMaAOyvdXmmHNNgMOnY7f9Wi/bvXJZKBPJ3S6Xs/5mMvjwOF21UH7F6qGOHwpt2c9N1 EK5FTv6xjaUIz9dNJRsle5vJmw3rwCWHp4zT2F48v9wMPTqHpoDaYiQseopL6Xq4PswJ ZqYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=drc5LnU//nothzoPqQ8d1G4VXl7oy7LH+bWASwffyS0=; b=2L0ivx4/2/GdohvsxQ9OEkRDRwq6MOnz79hPAl6RsS82u+VzVUhB8V+3400P1EsMHh 0NZHDFQdaE/GOBq4ScpYTJXZYNpKO/7FvVO3EdNZD10q8asNe6qvX8d5196y0NnW7bbH PDIGOa9dd7QnQTs11bJYvMybZzAyLh1OSaDjyZCEjRNondj+mwmM7pWsaPAuVIGZZca9 KRg4NLvtbeZHArtMABuyg7tLrI6FQ1iQIMMGcc7zdRZu0XxvKAru7pSo1nThUs2u1CD7 OU+kl7h/SGwja7oMlrkVRjlfUqpE/+amNTzNqTYtt19J/K28pZxOfduqux13ma84BICk ekzQ== X-Gm-Message-State: AOAM531jgh/1tEx8vsHw4qBFGPHMY8lm+X8c/c5KFraOt59/ELD8lekp LvwBpoZM5Pc806BWWxBEng1RYkKdRpvKqA== X-Google-Smtp-Source: ABdhPJwgWclUcyvYUV+ZStu0nHJ4/FYeTiOk1bWWebykY/Rdx+WsX/KSJ4QAglqBV2Jfvlj9RLHc4Q== X-Received: by 2002:a63:3194:0:b0:3f6:a28:77cf with SMTP id x142-20020a633194000000b003f60a2877cfmr19688940pgx.264.1653309089024; Mon, 23 May 2022 05:31:29 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id b16-20020a170902b61000b0015ec71f72d6sm4995468pls.253.2022.05.23.05.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 05:31:28 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 06:31:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: linux-next: build failure after merge of the block tree Content-Language: en-US To: Coly Li Cc: Linux Kernel Mailing List , Linux Next Mailing List , Stephen Rothwell References: <20220523124921.7d6bbf34@canb.auug.org.au> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 5/23/22 12:05 AM, Coly Li wrote: > On 5/23/22 10:52 AM, Jens Axboe wrote: >> On 5/22/22 8:49 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> After merging the block tree, today's linux-next build (x86_64 >>> allmodconfig) failed like this: >>> >>> drivers/md/bcache/btree.c: In function 'bch_btree_check': >>> drivers/md/bcache/btree.c:2073:1: error: the frame size of 2184 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> 2073 | } >>> | ^ >>> >>> Caused by commit >>> >>> c766acd3d78e ("bcache: improve multithreaded bch_btree_check()") >>> >>> struct btree_check_state is very large to put on the stack :-( >>> >>> I have reverted that commit for today. > > Hi Jens, > >> Thanks, I'll drop it. It's not part of the initial request sent to >> Linus, exactly because it arrived late. >> >> Coly, I'm dropping this series. > > Yes please. Should I re-submit the fixed series to you in later -RC > round, or wait for 5.20 merge window? Just resubmit it when it's been fixed, then we'll figure it out at that point. As mentioned in the original email, at the very least it needs a linux-next soak for a weeks time. If the patches are simple enough and don't cause odd build errors/warnings, then we can still make this release if need be. -- Jens Axboe