archive mirror
 help / color / mirror / Atom feed
From: Fabrice Gasnier <>
To: Jonathan Cameron <>,
	Randy Dunlap <>
Cc: Stephen Rothwell <>,
	Linux Next Mailing List <>,
	Linux Kernel Mailing List <>,
Subject: Re: linux-next: Tree for Apr 8 (iio/adc/)
Date: Mon, 15 Apr 2019 15:13:44 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190414133059.4e25a574@archlinux>

On 4/14/19 2:30 PM, Jonathan Cameron wrote:
> On Mon, 8 Apr 2019 09:09:37 -0700
> Randy Dunlap <> wrote:
>> On 4/7/19 10:41 PM, Stephen Rothwell wrote:
>>> Hi all,
>>> Changes since 20190405:
>> on i386 or x86_64:
>> modular:
>> ERROR: "is_stm32_timer_trigger" [drivers/iio/adc/stm32-dfsdm-adc.ko] undefined!
>> or builtin:
>> ld: drivers/iio/adc/stm32-dfsdm-adc.o: in function `stm32_dfsdm_postenable':
>> stm32-dfsdm-adc.c:(.text+0x878): undefined reference to `is_stm32_timer_trigger'
>> Full i386 randconfig file is attached.
> Thanks Randy.
> So two possible fixes for this one.  We can do what is done for the
> stm32-adc driver and select IIO_STM_TIMER_TRIGGER or we can add a stub
> for this function in the header to make it return false if that
> driver isn't built.
> I personally favour the stub option but would like Fabrice to say what
> makes more sense.
> So Fabrice, which of the above? If you are busy and don't get back
> in the next day or two, I'll add the stub.

Hi Jonathan, Randy,

I've posted 3 patches:
- One to fix the current issue, with the stub option [1]. This makes
sense as the STM32 DFSDM can use timer and/or lptimer. I think I'll post
another patch later to remove the select in STM32_ADC config (no longer
needed then... But it's not the subject here, right ?).
- Two other patches to fix other warning/build issues I've seen while
working on the stub option. See [2]:


Sorry for the inconvenience, I should have seen this earlier.

Best Regards,

> Thanks,
> Jonathan

      reply	other threads:[~2019-04-15 13:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08  5:41 linux-next: Tree for Apr 8 Stephen Rothwell
2019-04-08 16:09 ` linux-next: Tree for Apr 8 (iio/adc/) Randy Dunlap
2019-04-14 12:30   ` Jonathan Cameron
2019-04-15 13:13     ` Fabrice Gasnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).