From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yishai Hadas <yishaih@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org
Subject: Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)
Date: Mon, 8 Jan 2024 21:57:52 -0800 [thread overview]
Message-ID: <c3a7b43a-820e-4da7-96a6-633bd4f35f26@infradead.org> (raw)
In-Reply-To: <20240108160935.4962f846@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
On 1/7/24 21:09, Stephen Rothwell wrote:
> Hi all,
>
> News: the merge window has opened, so please do not add any material
> intended for v6.9 to your linux-next included branches until asfter
> v6.8-rc1 has been released.
>
> Changes since 20240105:
>
on powerpc 64-bit:
when
CONFIG_VIRTIO_PCI=m
CONFIG_VIRTIO_PCI_ADMIN_LEGACY=y
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_probe':
main.c:(.text+0x17c): undefined reference to `virtio_pci_admin_has_legacy_io'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_init_device':
main.c:(.text+0x82c): undefined reference to `virtio_pci_admin_legacy_io_notify_info'
powerpc64-linux-ld: drivers/vfio/pci/virtio/main.o: in function `virtiovf_pci_bar0_rw':
main.c:(.text+0xe98): undefined reference to `virtio_pci_admin_legacy_common_io_read'
powerpc64-linux-ld: main.c:(.text+0xecc): undefined reference to `virtio_pci_admin_legacy_device_io_read'
powerpc64-linux-ld: main.c:(.text+0x10d8): undefined reference to `virtio_pci_admin_legacy_common_io_write'
powerpc64-linux-ld: main.c:(.text+0x1108): undefined reference to `virtio_pci_admin_legacy_device_io_write'
Also, it is not a good idea to have a driver depend on a hidden (not visible) Kconfig symbol,
like this:
config VIRTIO_VFIO_PCI
tristate "VFIO support for VIRTIO NET PCI devices"
depends on VIRTIO_PCI_ADMIN_LEGACY
Full randconfig file is attached.
--
#Randy
[-- Attachment #2: config-r4841.gz --]
[-- Type: application/gzip, Size: 54792 bytes --]
prev parent reply other threads:[~2024-01-09 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 5:09 linux-next: Tree for Jan 8 Stephen Rothwell
2024-01-09 5:57 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3a7b43a-820e-4da7-96a6-633bd4f35f26@infradead.org \
--to=rdunlap@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).