From: Randy Dunlap <rdunlap@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Oct 28 (objtool)
Date: Mon, 28 Oct 2019 12:35:52 -0700 [thread overview]
Message-ID: <cc9c0f83-ce06-19a3-eb07-5fe19e5ca2f2@infradead.org> (raw)
In-Reply-To: <20191028160215.ruzhvlwqaumw4krm@treble>
On 10/28/19 9:02 AM, Josh Poimboeuf wrote:
> On Mon, Oct 28, 2019 at 08:31:28AM -0700, Randy Dunlap wrote:
>> On 10/28/19 1:51 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20191025:
>>>
>>
>>
>> on x86_64:
>>
>> kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x14: unreachable instruction
>>
>> .o file is attached.
>
> Silly GCC. Does this fix it?
Yes, thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
> index 4b1c3b664f51..d58587391b96 100644
> --- a/include/linux/sched/task.h
> +++ b/include/linux/sched/task.h
> @@ -83,7 +83,7 @@ static inline void exit_thread(struct task_struct *tsk)
> {
> }
> #endif
> -extern void do_group_exit(int);
> +extern void __noreturn do_group_exit(int);
>
> extern void exit_files(struct task_struct *);
> extern void exit_itimers(struct signal_struct *);
> diff --git a/kernel/exit.c b/kernel/exit.c
> index f2d20ab74422..bdc4122d904d 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -894,7 +894,7 @@ SYSCALL_DEFINE1(exit, int, error_code)
> * Take down every thread in the group. This is called by fatal signals
> * as well as by sys_exit_group (below).
> */
> -void
> +void __noreturn
> do_group_exit(int exit_code)
> {
> struct signal_struct *sig = current->signal;
> @@ -931,7 +931,6 @@ SYSCALL_DEFINE1(exit_group, int, error_code)
> {
> do_group_exit((error_code & 0xff) << 8);
> /* NOTREACHED */
> - return 0;
> }
>
> struct waitid_info {
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 543c068096b1..97919469c787 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -135,6 +135,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
> "__stack_chk_fail",
> "panic",
> "do_exit",
> + "do_group_exit",
> "do_task_dead",
> "__module_put_and_exit",
> "complete_and_exit",
>
--
~Randy
prev parent reply other threads:[~2019-10-28 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 8:51 linux-next: Tree for Oct 28 Stephen Rothwell
2019-10-28 15:31 ` linux-next: Tree for Oct 28 (objtool) Randy Dunlap
2019-10-28 16:02 ` Josh Poimboeuf
2019-10-28 19:35 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc9c0f83-ce06-19a3-eb07-5fe19e5ca2f2@infradead.org \
--to=rdunlap@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).