linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the block tree
Date: Wed, 4 Mar 2020 15:50:54 +0300	[thread overview]
Message-ID: <d19697ab-8cb0-fad2-3dd8-dab296f61c69@gmail.com> (raw)
In-Reply-To: <cd8154ef-bb6f-aa7c-2553-582f0b497516@kernel.dk>

On 04/03/2020 06:01, Jens Axboe wrote:
> On 3/3/20 7:17 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/io_uring.c: In function 'io_close':
>> fs/io_uring.c:3415:3: warning: ignoring return value of 'refcount_inc_not_zero', declared with attribute warn_unused_result [-Wunused-result]
>>  3415 |   refcount_inc_not_zero(&req->refs);
>>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>>   62e0c6b73a2c ("io_uring: make submission ref putting consistent")
> 
> That should just be a refcount_inc() and also looks like it should happen
> before the async queue. I'll fix it up.

Yes, it's better to. Thanks!


-- 
Pavel Begunkov

  reply	other threads:[~2020-03-04 12:51 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  2:17 linux-next: build warning after merge of the block tree Stephen Rothwell
2020-03-04  3:01 ` Jens Axboe
2020-03-04 12:50   ` Pavel Begunkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-15  1:48 Stephen Rothwell
2023-03-15  1:54 ` Jens Axboe
2023-02-09  3:00 Stephen Rothwell
2023-01-18  3:10 Stephen Rothwell
2022-10-05  7:17 Stephen Rothwell
2022-10-05 12:19 ` Jens Axboe
2022-07-20  3:33 Stephen Rothwell
2022-07-20 12:10 ` Stephen Rothwell
2022-07-20 12:43 ` Jens Axboe
2022-07-15 12:06 Stephen Rothwell
2022-07-15  3:52 Stephen Rothwell
2022-07-15 12:33 ` Stephen Rothwell
2022-07-15 13:08   ` Dylan Yudaken
2022-04-21  2:02 Stephen Rothwell
2022-04-21  2:03 ` Jens Axboe
2022-04-21  5:43 ` Stephen Rothwell
2021-10-19  5:39 Stephen Rothwell
2021-08-13  9:41 Stephen Rothwell
2021-08-13 13:54 ` Jens Axboe
2021-09-03  6:49   ` Stephen Rothwell
2021-09-03 13:41     ` Jens Axboe
2021-06-15  2:13 Stephen Rothwell
2021-06-15 12:22 ` Pavel Begunkov
2021-06-09  3:52 Stephen Rothwell
2021-06-09  4:28 ` Dan Williams
2021-02-24  2:31 Stephen Rothwell
2021-02-24  2:40 ` Chaitanya Kulkarni
2021-02-24  5:25 ` Chaitanya Kulkarni
2021-02-24  5:33   ` Stephen Rothwell
2021-02-24  5:38     ` Chaitanya Kulkarni
2021-02-24 10:42       ` Stephen Rothwell
2021-02-24 21:41         ` Chaitanya Kulkarni
2021-02-24 21:45           ` Randy Dunlap
2021-02-24 21:51             ` Chaitanya Kulkarni
2021-02-24  7:16     ` Chaitanya Kulkarni
2020-12-22 23:47 Stephen Rothwell
2020-12-23  0:13 ` Jens Axboe
2020-12-07  7:48 Stephen Rothwell
2020-12-03  7:39 Stephen Rothwell
2020-12-14 20:14 ` Stephen Rothwell
2020-12-21  1:30   ` Stephen Rothwell
2020-12-03  7:37 Stephen Rothwell
2020-12-14 20:13 ` Stephen Rothwell
2020-12-21  1:29   ` Stephen Rothwell
2020-11-12  4:32 Stephen Rothwell
2020-10-22 23:48 Stephen Rothwell
2020-10-23  0:30 ` Jens Axboe
2020-07-02  1:21 Stephen Rothwell
2020-07-02  4:07 ` Jens Axboe
2020-01-31  0:16 Stephen Rothwell
2020-01-31  0:25 ` Jens Axboe
2020-01-16  0:54 Stephen Rothwell
2020-01-16  4:50 ` Jens Axboe
2019-10-18  0:51 Stephen Rothwell
2019-10-18  0:56 ` Jens Axboe
2019-10-18  0:59   ` Jens Axboe
2019-10-18  3:58   ` Stephen Rothwell
2019-08-29  3:51 Stephen Rothwell
2019-08-29  4:08 ` Stephen Rothwell
2019-08-29 15:41   ` Tejun Heo
2019-08-29 15:44     ` Jens Axboe
2019-08-09  4:00 Stephen Rothwell
2019-08-09  4:13 ` Jens Axboe
2019-08-09  6:15 ` Yuehaibing
2019-04-17  2:31 Stephen Rothwell
2019-04-17 10:05 ` Chao Yu
2019-04-17 14:03   ` Jaegeuk Kim
2019-04-18  0:57     ` Chao Yu
2019-04-18 14:01       ` Jaegeuk Kim
2019-04-19  1:14         ` Chao Yu
2018-11-08  3:31 Stephen Rothwell
2018-11-08  4:19 ` Jens Axboe
2018-09-28  1:11 Stephen Rothwell
2018-09-28  6:43 ` Omar Sandoval
2018-09-28 14:26   ` Jens Axboe
2018-05-31  3:49 Stephen Rothwell
2018-05-14  2:51 Stephen Rothwell
2018-05-14  8:29 ` Christoph Hellwig
2018-05-14 14:31   ` Jens Axboe
2017-05-10  1:24 Stephen Rothwell
2017-05-10  2:20 ` Markus Trippelsdorf
2017-05-10  3:00   ` Jens Axboe
2017-05-10  6:19     ` Markus Trippelsdorf
2017-05-10  3:26   ` Stephen Rothwell
2014-10-23  1:28 Stephen Rothwell
2014-10-23  2:14 ` Jens Axboe
2013-09-23  4:29 Stephen Rothwell
2011-05-09  3:49 Stephen Rothwell
2011-05-09  5:55 ` Tao Ma
2011-05-09  6:34   ` Jens Axboe
2010-12-20  4:31 Stephen Rothwell
2010-12-20  4:42 ` Stephen Rothwell
2010-12-20  8:12   ` Jens Axboe
2010-09-16  3:30 Stephen Rothwell
2010-04-29  6:14 Stephen Rothwell
2010-04-29  7:28 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d19697ab-8cb0-fad2-3dd8-dab296f61c69@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).