From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the kvm tree
Date: Fri, 16 Apr 2021 17:02:01 +0200 [thread overview]
Message-ID: <d4928233-670a-8930-f581-8e7b765b3c00@de.ibm.com> (raw)
In-Reply-To: <20210417005831.3785688b@canb.auug.org.au>
On 16.04.21 16:58, Stephen Rothwell wrote:
> Hi all,
>
> On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 16/04/21 14:38, Christian Borntraeger wrote:
>>> On 16.04.21 14:27, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>> c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
>>>>
>>>> Fixes tag
>>>>
>>>> Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
>>>>
>>>> has these problem(s):
>>>>
>>>> - Subject does not match target commit subject
>>>> Just use
>>>> git log -1 --format='Fixes: %h ("%s")'
>>>
>>> Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
>>>
>>
>> Maybe you just missed it when it was reported for kvms390?
>>
>> https://www.spinics.net/lists/linux-next/msg59652.html
>
> It was a different commit SHA then and was reported because the Fixes
> SHA did not exist. It was fixed the next day, so I guess either I
> missed reporting this different problem, or I thought at least it had
> been fixed to use the correct SHA. I am not completely consistent,
> sometimes :-)
Yeah, seems that my fix was only half-way correct then but it managed to get past your review.
next prev parent reply other threads:[~2021-04-16 15:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 12:27 linux-next: Fixes tag needs some work in the kvm tree Stephen Rothwell
2021-04-16 12:38 ` Christian Borntraeger
2021-04-16 14:02 ` Paolo Bonzini
2021-04-16 14:58 ` Stephen Rothwell
2021-04-16 15:02 ` Christian Borntraeger [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-09 21:31 Stephen Rothwell
2022-07-20 22:05 Stephen Rothwell
2022-05-22 0:49 Stephen Rothwell
2022-01-19 11:49 Stephen Rothwell
2021-09-06 21:48 Stephen Rothwell
2021-08-19 22:20 Stephen Rothwell
2021-06-21 22:18 Stephen Rothwell
2021-06-21 23:37 ` Paolo Bonzini
2021-02-04 20:16 Stephen Rothwell
2020-03-16 20:36 Stephen Rothwell
2020-01-24 3:13 Stephen Rothwell
2019-12-04 12:50 Stephen Rothwell
2019-02-16 7:34 Stephen Rothwell
2019-02-20 7:02 ` Yu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4928233-670a-8930-f581-8e7b765b3c00@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).