From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3F0C77B73 for ; Sat, 15 Apr 2023 20:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjDOUhO (ORCPT ); Sat, 15 Apr 2023 16:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjDOUhN (ORCPT ); Sat, 15 Apr 2023 16:37:13 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 857D519BC for ; Sat, 15 Apr 2023 13:37:10 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3e699254ac4so8628071cf.1 for ; Sat, 15 Apr 2023 13:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1681591029; x=1684183029; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t2a9ohFUrTNKxbAMdXdxcEvmxB5N2rxQmTBw9UNOtCw=; b=N9BWcPtn2YDusrc9wxcfjb90DrieYzrKXTKGMRv15mpl293f5w3NMDvIhOY09dRWJl 3f2nNBE2E/KOId5ijJXTwcS/yeyB03IdkxjsspesfnOamFjAhCaCuvEpkCyab2qkJFjv t2QP3VDKAhk0frjCuNaS1S7mPobmKo4SbL6nbuzX2hg9TdDmHaqFxhIZdERKIFKIyWby 7yZsztuvlBVJEumRGeR+GuH4HDqdh62kP0en6fOuz2vsuJAFMnNWdKqBi/y7xX4J7hnJ jII+CXiBGOhhyW3Ikr1KngF/4MQcSytBh9AOKpZZURwS8KM+O+pBaq9yBiYTbqV9VfHq AlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681591029; x=1684183029; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t2a9ohFUrTNKxbAMdXdxcEvmxB5N2rxQmTBw9UNOtCw=; b=HfuErgRtieFMHh841M3FgbfXXmBqM2CmTh6M9VC33gFzQJhk95hL1Bgybj+leaT+lb HYknJ+TYGtNXl4fjVPtLOS3buQ5UCklJwbXXp26yuRXAI3K/bBd6QjGBqi+SUVPFQV+E NRY0v86/IBJl2wpg4yBCM2yuFhZkTkmfqZTDMFTXszjqbDOqVK8eorttSf6MeuJ7pi9y ZfuNyByYio8Hvg8V4xcErKdhCenB7yaRgGGGeEIATAQjwKJfXsaq9rS5OwbpY6RHwUXF Bm+dbAIisaMjKDjBjZKuxg9vwCmnNqfO9ft5B6lAIL3GQtgVtX4EVeTCYjfqqoY8djGI AecQ== X-Gm-Message-State: AAQBX9cMxXmNH6h+TJT315DjEyXN+Gv8iD4St+y+dij7Cv5v44698NP+ I177OuQqP6QCreycl+JuftG1rmVRcEHHNlOtfMA= X-Google-Smtp-Source: AKy350ZS+YdnXW5h4FYvEi92oULU6xuIAcEuSpQwjjuQzlpQIpCyHzGWnUDv+vgZN6xJ8flOyLzEpQ== X-Received: by 2002:a05:6214:3011:b0:5ef:5132:7ad7 with SMTP id ke17-20020a056214301100b005ef51327ad7mr9923443qvb.2.1681591029430; Sat, 15 Apr 2023 13:37:09 -0700 (PDT) Received: from [172.19.131.144] ([216.250.210.6]) by smtp.gmail.com with ESMTPSA id l15-20020a05620a0c0f00b0074c658aadf1sm701544qki.41.2023.04.15.13.37.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Apr 2023 13:37:09 -0700 (PDT) Message-ID: Date: Sat, 15 Apr 2023 14:37:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: linux-next: Tree for Apr 13 Content-Language: en-US To: Ayush Jain , broonie@kernel.org, Linux Next Mailing List Cc: Linux Kernel Mailing List , Santosh.Shukla@amd.com, Kalpana.Shetty@amd.com, Narasimhan V , sfr@canb.auug.org.au, David Howells References: <20230413182542.1133335-1-broonie@kernel.org> <0c6b661c-f7ff-cf12-b7f0-00b6b2f1317b@amd.com> <3c4b9025-2667-ca8c-7427-502068b8168e@amd.com> From: Jens Axboe In-Reply-To: <3c4b9025-2667-ca8c-7427-502068b8168e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Adding David, who did the splice changes. Always a good idea to CC the person(s) involved. On 4/14/23 1:25 AM, Ayush Jain wrote: > Hello, > > On 4/14/2023 10:41 AM, Jain, Ayush wrote: >> Hello Broonie, >> >> When Running fio-test on latest linux-next tree, I noticed that test hung indefinitely, Going back I see that this problem exists since >> next-20230316 release, After bisecting I landed on the following merge commit by Jens. >> >> Commit   097d3ca138f9 ("Merge branch 'for-6.4/splice' into for-next") >> >> Running perf I see following trace and call-stack for fio: >> >>   Overhead  Command  Shared Object     Symbol >>     25.08%  fio      [kernel.vmlinux]  [k] copy_user_generic_string >>        copy_user_generic_string >>        __do_splice >>        __x64_sys_splice >>        do_syscall_64 >>        entry_SYSCALL_64_after_hwframe >>        splice >>        0x1c44be0 >>    ... >> >> On a good kernel I see the following perf trace: >> >>    Overhead  Command  Shared Object     Symbol >>      49.93%  fio      fio               [.] fio_crc32 >>       7.23%  fio      fio               [.] clock_thread_fn >>       2.10%  fio      [kernel.vmlinux]  [k] clear_page_rep >>       1.55%  fio      fio               [.] __fill_random_buf >>       1.35%  fio      [kernel.vmlinux]  [k] loop_queue_rq >>       1.05%  fio      [kernel.vmlinux]  [k] copy_user_generic_string >>       ... >> >> I see some splice changes being added as the part of merge >> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/?h=for-6.4/splice >> >> I observe this problem on 3 EPYC system(Zen1,3,4), with the following disk architecture >> >> Zen1: nvme0n1   931.5G Samsung SSD 970 EVO Plus 1TB >> Zen4: nvme0n1   232.9G Samsung SSD 960 EVO 250GB >> >> I am running fio as follows: >> >>     $fio fio-simple.job --filename=/dev/test_vg/test_lv >> >> where test_lv is mounted as follows: >> >> NAME                           MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINTS >> loop0                            7:0    0  12.2G  0 loop >> └─md127                          9:127  0  12.2G  0 raid0 >>     └─test_vg-test_lv            253:3    0   5.5G  0 lvm >> >> You can find fio-simple.job at >> https://github.com/avocado-framework-tests/avocado-misc-tests/blob/master/io/disk/fiotest.py.data/fio-simple.job >> >> Fio Version: fio-3.34-25-g07ed >> > Also adding to these observations > > -If we create a filesystem on the raw disk -- Test completes with a Pass > > -If there is no Filesystem on the raw disk(loop, nvme) -- Test hangs with the provided trace > >> >> Regards >> Ayush Jain >> > On 4/13/2023 11:55 PM, broonie@kernel.org wrote: >>> Hi all, >>> >>> Changes since 20230411: >>> >>> The sh tree gained a conflict with the mm-unstable tree. >>> >>> The erofs tree gained a conflict with the vfs-idmapping tree. >>> >>> The ext4 tree gained multiple conflicts with the mm-stable tree. >>> >>> The net-next tree gained a conflict with the origin tree. >>> >>> The bpf-next tree gained a conflict with the net-net tree. >>> >>> Non-merge commits (relative to Linus' tree): 10382 >>>   11028 files changed, 580165 insertions(+), 249563 deletions(-) >>> >>> ---------------------------------------------------------------------------- >>> >>> I have created today's linux-next tree at >>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you >>> are tracking the linux-next tree using git, you should not use "git pull" >>> to do so as that will try to merge the new linux-next release with the >>> old one.  You should use "git fetch" and checkout or reset to the new >>> master. >>> >>> You can see which trees have been included by looking in the Next/Trees >>> file in the source.  There is also the merge.log file in the Next >>> directory.  Between each merge, the tree was built with a ppc64_defconfig >>> for powerpc, an allmodconfig for x86_64, a multi_v7_defconfig for arm >>> and a native build of tools/perf. After the final fixups (if any), I do >>> an x86_64 modules_install followed by builds for x86_64 allnoconfig, >>> powerpc allnoconfig (32 and 64 bit), ppc44x_defconfig, allyesconfig >>> and pseries_le_defconfig and i386, arm64, s390, sparc and sparc64 >>> defconfig and htmldocs. And finally, a simple boot test of the powerpc >>> pseries_le_defconfig kernel in qemu (with and without kvm enabled). >>> >>> Below is a summary of the state of the merge. >>> >>> I am currently merging 357 trees (counting Linus' and 102 trees of bug >>> fix patches pending for the current merge release). >>> >>> Stats about the size of the tree over time can be seen at >>> http://neuling.org/linux-next-size.html . >>> >>> Status of my local build tests will be at >>> http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give >>> advice about cross compilers/configs that work, we are always open to add >>> more builds. >>> >>> Thanks to Randy Dunlap for doing many randconfig builds.  And to Paul >>> Gortmaker for triage and bug fixes. >> > > Regards, > Ayush Jain -- Jens Axboe